On Mon, 17 Apr 2023 17:37:46 +0100 Ferruh Yigit <ferruh.yi...@amd.com> wrote:
> From: Ferruh Yigit <ferruh.yi...@amd.com> > To: fengchengwen <fengcheng...@huawei.com>, tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 00/44] fix segment fault when parse args > Date: Mon, 17 Apr 2023 17:37:46 +0100 > User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 > Thunderbird/102.10.0 > > On 4/15/2023 2:38 AM, fengchengwen wrote: > > Hi Thomas, Ferruh, > > > > This patch-set get almost 30% ack by PMD's maintainer. > > Could it be applied? and squeeze the patch-set is okay. > > > > Hi Chengwen, > > The patch is trivial and safe on its own, so for me having enough ack or > not is not what blocks the set. > > As we discussed before, instead of adding NULL checks to the callbacks, > it is better to handle this in the kvargs API level, that discussion is > holding this patchset back. > > According result of discussion we may prefer to not merge this patch at all. Agree. Hitting so many places, and not sure that all of them are covered, is an indicator it should be solved at higher level.
