[PATCH] doc: update feature list for idpf and cpfl

2023-10-11 Thread beilei . xing
From: Beilei Xing Add RSS support in idpf.ini and cpfl.ini. Signed-off-by: Beilei Xing --- doc/guides/nics/features/cpfl.ini | 3 +++ doc/guides/nics/features/idpf.ini | 3 +++ 2 files changed, 6 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini

RE: [PATCH] net/cpfl: reset devargs during the first probe

2023-10-11 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, October 12, 2023 12:47 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] net/cpfl: reset devargs during the first probe > > From: Beilei Xing > Reset devargs during the first probe. Otherwise, probe

Re: DTS roadmap for 23.11

2023-10-11 Thread Juraj Linkeš
A minor correction On Thu, Oct 12, 2023 at 2:50 AM Honnappa Nagarahalli wrote: > > Hello, > Following is the roadmap for DTS for 23.11 release. > > 1) DTS API document auto generation > https://patches.dpdk.org/project/dpdk/cover/20230831100407.59865-1-juraj.lin...@pantheon.tech/ > > 2) S

[PATCH v4 3/3] net/octeon_ep: add new fastpath routines

2023-10-11 Thread Vamsi Attunuru
Adds new fastpath routines for cn10k & cn9k endpoint devices and assigns the fastpath routines based on the offload flags. Patch also adds misc changes to improve performance and code-readability. Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/cnxk_ep_rx.c| 310

[PATCH v4 2/3] net/octeon_ep: clean up receive routine

2023-10-11 Thread Vamsi Attunuru
Patch improves Rx routine and pkt count update routines, packet count update routines need to drain inflight ISM memory updates while decrementing the packet count register. Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/otx_ep_rxtx.c | 164 1 file changed,

[PATCH v4 1/3] net/octeon_ep: support 32B IQ descriptor size

2023-10-11 Thread Vamsi Attunuru
From: Shijith Thotton Update input queue setup to consider descriptor size in driver conf. The default instruction size for otx2 and cnxk devices has been updated to 32 bytes. Signed-off-by: Shijith Thotton --- drivers/net/octeon_ep/cnxk_ep_vf.c| 10 +- drivers/net/octeon_ep/otx2_e

[PATCH v4 0/3] rewrite fastpath routines

2023-10-11 Thread Vamsi Attunuru
This series adds new fastpath routines for cn10k & cn9k endpoint devices and supports 32B Tx desciptor format which improves the performance. v4 changes: - Use rte_atomic_xxx instead of __atomic_xxx built-ins v2 & v3 changes: - Fixed CI Shijith Thotton (1): net/octeon_ep: support 32B IQ descri

RE: [PATCH] clarify purpose of empty cache lines

2023-10-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 12 October 2023 01.44 > > 04/09/2023 10:43, Morten Brørup: > > /** Force minimum cache line alignment. */ > > #define __rte_cache_min_aligned __rte_aligned(RTE_CACHE_LINE_MIN_SIZE) > > > > +#define _RTE_CACHE_GUARD_HELPER2(un

Recall: [PATCH] clarify purpose of empty cache lines

2023-10-11 Thread Morten Brørup
Morten Brørup would like to recall the message, "[PATCH] clarify purpose of empty cache lines".

RE: [PATCH] clarify purpose of empty cache lines

2023-10-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 12 October 2023 01.44 > > 04/09/2023 10:43, Morten Brørup: > > /** Force minimum cache line alignment. */ > > #define __rte_cache_min_aligned __rte_aligned(RTE_CACHE_LINE_MIN_SIZE) > > > > +#define _RTE_CACHE_GUARD_HELPER2(un

Re: [PATCH v5 36/40] net/hns3: support setting and querying RSS hash function

2023-10-11 Thread fengchengwen
On 2023/10/12 11:05, Jie Hai wrote: > On 2023/10/12 10:23, fengchengwen wrote: >> The new algorithm (RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT) should >> treat as Not Support. >> >> With above fix >> Acked-by: Chengwen Feng >> > Actually, the new algorithm is not supported. > see hns3_update_

Re: [PATCH v5 39/40] app/proc-info: support querying RSS hash algorithm

2023-10-11 Thread Jie Hai
On 2023/10/12 10:05, fengchengwen wrote: Suggest add one new API for get hash_algo_name. e.g. rte_eth_get_rss_algo_name() Thanks, that's better for reuse, will change it in next version. On 2023/10/11 17:28, Jie Hai wrote: Display RSS hash algorithm with command show-port as below. - RSS i

Re: [PATCH v5 38/40] app/proc-info: adjust the display format of RSS info

2023-10-11 Thread Jie Hai
On 2023/10/12 10:01, fengchengwen wrote: Hi HaiJie, On 2023/10/11 17:28, Jie Hai wrote: This patch splits the length and value of RSS key into two parts, removes spaces between RSS keys, and adds line breaks between RSS key and RSS hf. Before the adjustment, RSS info is shown as: - RSS

Re: [PATCH v5 36/40] net/hns3: support setting and querying RSS hash function

2023-10-11 Thread Jie Hai
On 2023/10/12 10:23, fengchengwen wrote: The new algorithm (RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT) should treat as Not Support. With above fix Acked-by: Chengwen Feng Actually, the new algorithm is not supported. see hns3_update_rss_algo_key(). if (modify_algo && hash_func >

Re: [PATCH v5 40/40] app/testpmd: add RSS hash algorithms display

2023-10-11 Thread fengchengwen
Hi HaiJie, On 2023/10/11 17:28, Jie Hai wrote: > Add the command "show port X rss-hash algorithm" to display > the RSS hash algorithms of port X. An example is shown: > > testpmd> show port 0 rss-hash algorithm > RSS algorithms: > toeplitz > > Signed-off-by: Jie Hai > --- > app/test-pmd/cmdl

Re: [PATCH v5 36/40] net/hns3: support setting and querying RSS hash function

2023-10-11 Thread Jie Hai
On 2023/10/12 10:23, fengchengwen wrote: The new algorithm (RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT) should treat as Not Support. With above fix Acked-by: Chengwen Feng Thanks, will check it. On 2023/10/11 17:28, Jie Hai wrote: From: Huisong Li Support setting and querying RSS hash

Re: [PATCH v5 01/40] ethdev: overwrite some comment related to RSS

2023-10-11 Thread fengchengwen
On 2023/10/11 17:27, Jie Hai wrote: > 1. overwrite the comments of fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 29 ++--- > lib/ethdev/rte_flow.h | 3 +++ > 2 files ch

Re: [PATCH v5 13/40] net/ena: check RSS hash algorithms

2023-10-11 Thread Jie Hai
On 2023/10/12 1:27, Ferruh Yigit wrote: On 10/11/2023 10:27 AM, Jie Hai wrote: A new field 'algorithm' has been added to rss_conf, check it in case of ignoring unsupported values. Signed-off-by: Jie Hai --- drivers/net/ena/ena_rss.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dri

RE: [PATCH v5 09/40] net/cpfl: check RSS hash algorithms

2023-10-11 Thread Xing, Beilei
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 12, 2023 1:21 AM > To: Jie Hai ; dev@dpdk.org; Zhang, Yuying > ; Xing, Beilei ; Zhang, Qi Z > > Cc: lihuis...@huawei.com; fengcheng...@huawei.com; > liudongdo...@huawei.com > Subject: Re: [PATCH v5 09/40] net/cpfl: chec

Re: [PATCH v5 08/40] net/cnxk: check RSS hash algorithms

2023-10-11 Thread Jie Hai
On 2023/10/12 1:04, Ferruh Yigit wrote: On 10/11/2023 10:27 AM, Jie Hai wrote: A new field 'algorithm' has been added to rss_conf, check it in case of ignoring unsupported values. Signed-off-by: Jie Hai --- drivers/net/cnxk/cnxk_ethdev.c | 5 + drivers/net/cnxk/cnxk_ethdev_ops.c | 3

Re: [PATCH v5 36/40] net/hns3: support setting and querying RSS hash function

2023-10-11 Thread fengchengwen
The new algorithm (RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT) should treat as Not Support. With above fix Acked-by: Chengwen Feng On 2023/10/11 17:28, Jie Hai wrote: > From: Huisong Li > > Support setting and querying RSS hash function by ethdev ops. > > Signed-off-by: Huisong Li > Sign

Re: [PATCH v5 02/40] ethdev: support setting and querying RSS algorithm

2023-10-11 Thread fengchengwen
On 2023/10/12 1:39, Stephen Hemminger wrote: > On Wed, 11 Oct 2023 17:27:27 +0800 > Jie Hai wrote: > >> Currently, rte_eth_rss_conf supports configuring and querying >> RSS hash functions, rss key and it's length, but not RSS hash >> algorithm. >> >> The structure ``rte_eth_rss_conf`` is exten

Re: [PATCH v5 26/40] net/mvpp2: check RSS hash algorithms

2023-10-11 Thread Jie Hai
On 2023/10/12 2:00, Ferruh Yigit wrote: On 10/11/2023 10:27 AM, Jie Hai wrote: A new field 'algorithm' has been added to rss_conf, check it in case of ignoring unsupported values. Signed-off-by: Jie Hai --- drivers/net/mvpp2/mrvl_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH v5 39/40] app/proc-info: support querying RSS hash algorithm

2023-10-11 Thread fengchengwen
Suggest add one new API for get hash_algo_name. e.g. rte_eth_get_rss_algo_name() On 2023/10/11 17:28, Jie Hai wrote: > Display RSS hash algorithm with command show-port as below. > - RSS info > -- hash algorithm : toeplitz > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu > Ack

Re: [PATCH v5 01/40] ethdev: overwrite some comment related to RSS

2023-10-11 Thread Jie Hai
On 2023/10/12 0:31, Ferruh Yigit wrote: On 10/11/2023 10:27 AM, Jie Hai wrote: 1. overwrite the comments of fields of 'rte_eth_rss_conf'. 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.h | 29 ++--- lib/ethdev/rte_

Re: [PATCH v5 38/40] app/proc-info: adjust the display format of RSS info

2023-10-11 Thread fengchengwen
Hi HaiJie, On 2023/10/11 17:28, Jie Hai wrote: > This patch splits the length and value of RSS key into two parts, > removes spaces between RSS keys, and adds line breaks between RSS > key and RSS hf. > > Before the adjustment, RSS info is shown as: > - RSS > -- RSS len 40 key (hex): 6d

Re: [PATCH v5 37/40] app/proc-info: fix never show RSS info

2023-10-11 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/10/11 17:28, Jie Hai wrote: > Command show-port should show RSS info (rss_key, len and rss_hf), > However, the information is shown only when rss_conf.rss_key is not > NULL. Since no memory is allocated for rss_conf.rss_key, rss_key > will always be NULL and the rs

RE: [PATCH v2 05/11] net/nfp: adjust the log statement

2023-10-11 Thread Chaoyong He
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 12, 2023 9:39 AM > To: Chaoyong He > Cc: dev@dpdk.org; oss-drivers ; Long Wu > ; Nole Zhang > Subject: Re: [PATCH v2 05/11] net/nfp: adjust the log statement > > On Thu, 12 Oct 2023 09:26:58 +0800 > Chaoyong He

Re: [PATCH v2 05/11] net/nfp: adjust the log statement

2023-10-11 Thread Stephen Hemminger
On Thu, 12 Oct 2023 09:26:58 +0800 Chaoyong He wrote: > + PMD_RX_LOG(ERR, "mbuf overflow likely due to the RX > offset.\n" > + "\t\tYour mbuf size should have extra > space for" > + " RX offset=%u bytes.

Re: [PATCH v4] app/testpmd: enable cli for programmable action

2023-10-11 Thread Stephen Hemminger
On Thu, 12 Oct 2023 00:04:00 + "Zhang, Qi Z" wrote: > > > >> Is there an existing driver implementation, checking it helps to > > > >> understand feature implementation? > > > > > > > > This work is still ongoing, currently we target to upstream on DPDK > > > > 24.03 Then the testpmd chang

[PATCH v2 11/11] net/nfp: refact the meson build file

2023-10-11 Thread Chaoyong He
Make the source files follow the alphabeta sequence. Also update the copyright header line. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/driv

[PATCH v2 10/11] net/nfp: adjust logic to make it more readable

2023-10-11 Thread Chaoyong He
Adjust some logic to make it easier to understand. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_common.c | 87 +--- drivers/net/nfp/nfp_cpp_bridge.c | 5 +- drivers/net/nfp/nfp_ctrl.h | 2 - drivers/net/

[PATCH v2 09/11] net/nfp: rename some parameter and variable

2023-10-11 Thread Chaoyong He
Rename some parameter and variable to make the logic easier to understand. Also avoid the mix use of lowercase and uppercase in macro name. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_common.h| 20 ++-- drivers/net/nfp/nfp

[PATCH v2 08/11] net/nfp: unify the guide line of header file

2023-10-11 Thread Chaoyong He
Unify the guide line of header file, we choose '__FOO_BAR_H__' style. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.h | 6 +++--- drivers/net/nfp/flower/nfp_flower_cmsg.h| 6 +++--- drivers/net/nfp/flower/nfp_f

[PATCH v2 06/11] net/nfp: standard the comment style

2023-10-11 Thread Chaoyong He
Follow the DPDK coding style, use the kdoc comment style. Also delete some comment which are not valid anymore and add some comment to help understand logic. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_conntrack.c| 4 +- driv

[PATCH v2 07/11] net/nfp: standard the blank character

2023-10-11 Thread Chaoyong He
Use space character to align instead of TAB character. There should one blank line to split the block of logic, no more no less. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_common.c | 39 + drivers/net/nfp/nfp_common

[PATCH v2 05/11] net/nfp: adjust the log statement

2023-10-11 Thread Chaoyong He
Add log statement to the important control logic, and remove verbose info log statement. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 17 +++--- .../net/nfp/flower/nfp_flower_representor.c | 4 +- drivers/net/nfp

[PATCH v2 04/11] net/nfp: standard the local variable coding style

2023-10-11 Thread Chaoyong He
There should only declare one local variable in each line, and the local variable should obey the unify sequence. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 6 +- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 4 +- drivers/net/nf

[PATCH v2 03/11] net/nfp: unify the type of integer variable

2023-10-11 Thread Chaoyong He
Unify the type of integer variable to the DPDK prefer style. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 2 +- drivers/net/nfp/flower/nfp_flower_cmsg.c | 16 +- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 6 ++-

[PATCH v2 02/11] net/nfp: unify the indent coding style

2023-10-11 Thread Chaoyong He
Each parameter of function should occupy one line, and indent two TAB character. All the statement which span multi line should indent two TAB character. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 5 +- drivers/

[PATCH v2 01/11] net/nfp: explicitly compare to null and 0

2023-10-11 Thread Chaoyong He
To compliance with the coding standard, make the pointer variable explicitly comparing to 'NULL' and the integer variable explicitly comparing to '0'. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 6 +- drivers/net/nfp/

[PATCH v2 00/11] Unify the PMD coding style

2023-10-11 Thread Chaoyong He
This patch series aims to unify the coding style of NFP PMD, make the logics following the same rules, to make it easier to understand and extend. Also prepare for the upcoming vDPA PMD patch series. --- v2: * Add some missing modification. --- Chaoyong He (11): net/nfp: explicitly compare to n

RE: [PATCH] net/cpfl: reset devargs during the first probe

2023-10-11 Thread Zhang, Qi Z
> -Original Message- > From: beilei.x...@intel.com > Sent: Thursday, October 12, 2023 12:47 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] net/cpfl: reset devargs during the first probe > > From: Beilei Xing > > Reset devargs during the first probe. Other

Minutes of Technical Board Meeting, 2023-August-23

2023-10-11 Thread Honnappa Nagarahalli
Minutes of Technical Board Meeting, 2023-August-23 Members Attending - -Aaron -Bruce -Hemant -Honnappa (Chair) -Jerin -Kevin -Maxime -Stephen NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK communit

DTS roadmap for 23.11

2023-10-11 Thread Honnappa Nagarahalli
Hello, Following is the roadmap for DTS for 23.11 release. 1) DTS API document auto generation https://patches.dpdk.org/project/dpdk/cover/20230831100407.59865-1-juraj.lin...@pantheon.tech/ 2) Scatter test suite along with TG packet manipulation and verification https://patches.dpdk.org/p

RE: [PATCH v4] app/testpmd: enable cli for programmable action

2023-10-11 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, October 11, 2023 9:20 PM > To: Ferruh Yigit ; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > or...@nvidia.com > Subject: RE: [PATCH v4] app/testpmd: enable cli for programmable action > > > >

Re: [PATCH] clarify purpose of empty cache lines

2023-10-11 Thread Thomas Monjalon
04/09/2023 10:43, Morten Brørup: > /** Force minimum cache line alignment. */ > #define __rte_cache_min_aligned __rte_aligned(RTE_CACHE_LINE_MIN_SIZE) > > +#define _RTE_CACHE_GUARD_HELPER2(unique) \ > + char cache_guard_ ## unique[RTE_CACHE_LINE_SIZE * > RTE_CACHE_GUARD_LINES] \ >

Re: [PATCH] eal: add cache guard to per-lcore PRNG state

2023-10-11 Thread Thomas Monjalon
11/10/2023 18:55, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 11 October 2023 18.08 > > > > TLS is an alternative solution proposed by Stephen. > > What do you think? > > I think we went down a rabbit hole - which I admit to enjoy. :-) There is no r

Re: [PATCH] mempool: add cache guard to per-lcore debug statistics

2023-10-11 Thread Thomas Monjalon
30/09/2023 08:24, Andrew Rybchenko: > On 9/4/23 12:10, Morten Brørup wrote: > > The per-lcore debug statistics, if enabled, are frequently written by > > their individual lcores, so add a cache guard to prevent CPU cache > > thrashing. > > > > Depends-on: series-29415 ("clarify purpose of empty ca

Re: [PATCH v5 1/3] lib: introduce dispatcher library

2023-10-11 Thread Mattias Rönnblom
On 2023-10-11 16:57, David Marchand wrote: On Mon, Oct 9, 2023 at 6:50 PM Mattias Rönnblom wrote: [snip] +static int +evd_set_service_runstate(struct rte_dispatcher *dispatcher, int state) +{ + int rc; + + rc = rte_service_component_runstate_set(dispatcher->service_id, +

Re: [PATCH] eal: add cache guard to per-lcore PRNG state

2023-10-11 Thread Mattias Rönnblom
On 2023-10-11 18:07, Thomas Monjalon wrote: TLS is an alternative solution proposed by Stephen. What do you think? I've expressed my views on this topic in two threads already. I'm happy to continue that discussion, but I would suggest it would be under the banner of "what should the standar

memif thread race condition on memif.disconnect()

2023-10-11 Thread Bly, Mike
Hello, We have run into a timing issue between threads when using the memif interface type and need some guidance. Our application has a DPDK based process operating (among other things) a memif server interface. The problem is exposed when this memif interface receives a memif.disconnect mess

Re: [PATCH 0/6] docs: Unify Getting Started Guides

2023-10-11 Thread Dave Young
Thank you for reviewing the patches and for your feedback. 1. Regarding the toctree, I've added the new Getting Started Guide so that it's accessible via the links in the left column. I've tested this on my local version, and the warning should disappear once the patch is submitted. 2. As for the

Re: [PATCH 1/6] Section 1: Introduction

2023-10-11 Thread Dave Young
Thank you for the feedback. I agree with the suggested changes to remove "unified" and the last paragraph. These changes have been made locally. I plan to send updated versions of all patches in this series at the same time, so you can expect to see these adjustments in the next version. Thanks! D

Re: [PATCH v5 00/40] support setting and querying RSS algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > This patchset is to support setting and querying RSS algorithms. > > -- > v5: > 1. rewrite some comments. > 2. check RSS algorithm for drivers supporting RSS. > 3. change field "func" of rss_conf to "algorithm". > 4. fix commit log for [PATCH v4 4/7]. > 5.

Re: [PATCH v5 33/40] net/tap: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/tap/rte_eth_tap.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/tap/rte_e

Re: [PATCH v5 30/40] net/null: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/null/rte_eth_null.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/null/rt

Re: [PATCH v5 26/40] net/mvpp2: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/mvpp2/mrvl_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/mvpp2/mrvl_e

Re: [PATCH v5 21/40] net/igc: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/igc/igc_ethdev.c | 4 > drivers/net/igc/igc_txrx.c | 5 + > 2 files changed, 9 insertions(+) >

Re: [PATCH v5 02/40] ethdev: support setting and querying RSS algorithm

2023-10-11 Thread Stephen Hemminger
On Wed, 11 Oct 2023 17:27:27 +0800 Jie Hai wrote: > Currently, rte_eth_rss_conf supports configuring and querying > RSS hash functions, rss key and it's length, but not RSS hash > algorithm. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "algorithm". This represents t

Re: [PATCH v5 14/40] net/enic: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/enic/enic_ethdev.c | 1 + > drivers/net/enic/enic_main.c | 3 +++ > 2 files changed, 4 insertions(+) >

Re: [PATCH v5 13/40] net/ena: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/ena/ena_rss.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ena/ena_rss.c b/dr

Re: [PATCH v5 09/40] net/cpfl: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/cpfl/cpfl_ethdev.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/cpfl/cpfl_

Re: [PATCH v5 08/40] net/cnxk: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/cnxk/cnxk_ethdev.c | 5 + > drivers/net/cnxk/cnxk_ethdev_ops.c | 3 +++ > 2 files changed, 8 inse

Re: [PATCH v5 05/40] net/bnx2x: check RSS hash algorithms

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/bnx2x/bnx2

RE: [PATCH] eal: add cache guard to per-lcore PRNG state

2023-10-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 11 October 2023 18.08 > > TLS is an alternative solution proposed by Stephen. > What do you think? I think we went down a rabbit hole - which I admit to enjoy. :-) My simple patch should be applied, with the description impr

[Bug 1273] eth_memif_rx segfault when burst size is greater than 32

2023-10-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1273 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED St

Re: [PATCH v2 25/29] regexdev: remove experimental tag

2023-10-11 Thread Jerin Jacob
On Wed, Oct 11, 2023 at 6:14 PM Ori Kam wrote: > > Hi Stephen, > > I know that Nvidia, is going to remove the support for regex in the future. > The only other HW that implements this is Marvel. > > I don't know about other manufacturers plan to support it. I suggest keeping > it as is for now, a

Re: [RFC 1/2] eal: add pointer compression functions

2023-10-11 Thread Paul Szczepanek
On 11/10/2023 14:36, Honnappa Nagarahalli wrote: -Original Message- From: Thomas Monjalon Sent: Monday, October 9, 2023 10:54 AM To: Paul Szczepanek Cc: dev@dpdk.org; Honnappa Nagarahalli ; Kamalakshitha Aligeri Subject: Re: [RFC 1/2] eal: add pointer compression functions [...] I se

Re: [PATCH v5 01/40] ethdev: overwrite some comment related to RSS

2023-10-11 Thread Ferruh Yigit
On 10/11/2023 10:27 AM, Jie Hai wrote: > 1. overwrite the comments of fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 29 ++--- > lib/ethdev/rte_flow.h | 3 +++ > 2 files ch

Re: [PATCH v2] ethdev: add calculate hash function

2023-10-11 Thread Ferruh Yigit
On 10/10/2023 3:24 PM, Ori Kam wrote: > rte_flow supports insert by index table[1]. > > Using the above table, the application can create rules > that are based on hash. > For example application can create the following logic in order > to create load balancing: > 1. Create insert by index table

Re: [PATCH] eal: add cache guard to per-lcore PRNG state

2023-10-11 Thread Thomas Monjalon
TLS is an alternative solution proposed by Stephen. What do you think? 06/09/2023 18:25, Stephen Hemminger: > On Mon, 4 Sep 2023 13:57:19 +0200 > Mattias Rönnblom wrote: > > > On 2023-09-04 11:26, Morten Brørup wrote: > > > The per-lcore random state is frequently updated by their individual >

Re: [PATCH] doc: remove confusing command to send patch

2023-10-11 Thread Thomas Monjalon
11/10/2023 12:22, Ferruh Yigit: > On 10/11/2023 11:20 AM, Thomas Monjalon wrote: > > 11/10/2023 10:41, Ferruh Yigit: > >> On 10/11/2023 9:30 AM, Bruce Richardson wrote: > >>> On Wed, Oct 11, 2023 at 10:03:07AM +0200, Thomas Monjalon wrote: > 11/10/2023 09:30, David Marchand: > > On Tue, Oc

Re: [PATCH] doc: remove confusing command to send patch

2023-10-11 Thread Thomas Monjalon
11/10/2023 17:52, Stephen Hemminger: > On Wed, 11 Oct 2023 09:30:23 +0100 > Bruce Richardson wrote: > > > > Or we can send to dev@dpdk.org, Cc maintainers. > > > This is what I do: > > > git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh > > > > > +1 for this, mainly on the b

Re: [PATCH] clarify purpose of empty cache lines

2023-10-11 Thread Thomas Monjalon
04/09/2023 11:12, Bruce Richardson: > On Mon, Sep 04, 2023 at 10:43:49AM +0200, Morten Brørup wrote: > > This patch introduces the generic RTE_CACHE_GUARD macro into the EAL, and > > replaces vaguely described empty cache lines in the rte_ring structure > > with this macro. > > > > Although the im

Re: [PATCH] doc: remove confusing command to send patch

2023-10-11 Thread Stephen Hemminger
On Wed, 11 Oct 2023 09:30:23 +0100 Bruce Richardson wrote: > > Or we can send to dev@dpdk.org, Cc maintainers. > > This is what I do: > > git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh > > > +1 for this, mainly on the basis of it being what I do too! :-) Ditto. Maybe wou

Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2

2023-10-11 Thread Bruce Richardson
On Wed, Oct 11, 2023 at 05:27:22PM +0200, Thomas Monjalon wrote: > 20/09/2023 16:18, Ric Li: > > When running 'meson setup' on Windows with MSYS2, > > "list-dir-globs.py * failed with status 1". > > We don't know why it is failing? > What about other usages of list_dir_globs in drivers and lib? >

Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2

2023-10-11 Thread Thomas Monjalon
20/09/2023 16:18, Ric Li: > When running 'meson setup' on Windows with MSYS2, > "list-dir-globs.py * failed with status 1". We don't know why it is failing? What about other usages of list_dir_globs in drivers and lib? > Avoid using globbing to get components for app build > since they are alread

Re: [PATCH] bus/pci: fix device ID print

2023-10-11 Thread Thomas Monjalon
13/09/2023 10:23, Qiming Yang: > This patch fixes the issue where device id first 0 does not print. > > Fixes: e4f27af0f448 ("bus/pci: reduce boot-up logs to absolute minimum") > Cc: sta...@dpdk.org > > Signed-off-by: Qiming Yang Applied, thanks.

Re: [PATCH v5 1/3] lib: introduce dispatcher library

2023-10-11 Thread David Marchand
On Mon, Oct 9, 2023 at 6:50 PM Mattias Rönnblom wrote: [snip] > +static int > +evd_set_service_runstate(struct rte_dispatcher *dispatcher, int state) > +{ > + int rc; > + > + rc = rte_service_component_runstate_set(dispatcher->service_id, > +

Re: [PATCH v4 0/3] Spec changes to support multi I/O models

2023-10-11 Thread Thomas Monjalon
02/10/2023 11:58, Srikanth Yalavarthi: > This series implements changes to mldev spec to extend support > for ML models with multiple inputs and outputs. Changes include > introduction of I/O layout to support packed and split buffers > for model input and output. Extended the rte_ml_model_info > s

Re: [PATCH v3 4/4] net/tap: use rte_ether_unformat_address

2023-10-11 Thread Ferruh Yigit
On 10/3/2023 9:29 PM, Stephen Hemminger wrote: > From: David Christensen > > Building DPDK with gcc 12 on a ppc64le system generates a > stringop-overflow warning. Replace the local MAC address > validation function parse_user_mac() with a call to > rte_ether_unformat_addr() instead. > > Bugzill

RE: [RFC 1/2] eal: add pointer compression functions

2023-10-11 Thread Honnappa Nagarahalli
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 9, 2023 10:54 AM > To: Paul Szczepanek > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Kamalakshitha Aligeri > Subject: Re: [RFC 1/2] eal: add pointer compression functions > > 27/09/2023 17:08, Paul Szczepanek: > > Ad

[PATCH v3 5/5] examples/bond: auto-generate cmdline boilerplate

2023-10-11 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- Note: the original help text on some of the commands in this example were not useful "this command do not handle any arguments". Ther

[PATCH v3 4/5] examples/hotplug_mp: auto-generate cmdline boilerplate

2023-10-11 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/hotplug_mp/Makefile| 12 +- examples/multi_process/hotplug_mp/commands.c | 147 ++ example

[PATCH v3 3/5] examples/simple_mp: auto-generate cmdline boilerplate

2023-10-11 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/simple_mp/Makefile | 12 +- examples/multi_process/simple_mp/meson.build | 9 ++ .../multi_process/simpl

[PATCH v3 2/5] buildtools: script to generate cmdline boilerplate

2023-10-11 Thread Bruce Richardson
Provide a "dpdk-cmdline-gen.py" script for application developers to quickly generate the boilerplate code necessary for using the cmdline library. Example of use: The script takes an input file with a list of commands the user wants in the app, where the parameter variables are tagged with the ty

[PATCH v3 1/5] doc/prog_guide: new chapter on cmdline library

2023-10-11 Thread Bruce Richardson
The cmdline library was not documented in our programmers guide, so add a new chapter on it. This chapter covers step-by-step how to use the library, rather than focusing on the library internals. This complements the existing cmdline example app document, providing more details on the process of u

[PATCH v3 0/5] document and simplify use of cmdline

2023-10-11 Thread Bruce Richardson
The DPDK commandline library is widely used by apps and examples within DPDK, but it is not documented in our programmers guide and it requires a lot of boilerplate code definitions in order to used. We can improve this situation by creating a simple python script to automatically generate the boil

RE: [PATCH v4] app/testpmd: enable cli for programmable action

2023-10-11 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 11, 2023 6:21 PM > To: Zhang, Qi Z ; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > or...@nvidia.com > Subject: Re: [PATCH v4] app/testpmd: enable cli for programmable action > > On 10

[PATCH v3 3/3] net/octeon_ep: add new fastpath routines

2023-10-11 Thread Vamsi Attunuru
Adds new fastpath routines for cn10k & cn9k endpoint devices and assigns the fastpath routines based on the offload flags. Patch also adds misc changes to improve performance and code-readability. Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/cnxk_ep_rx.c| 309

[PATCH v3 2/3] net/octeon_ep: clean up receive routine

2023-10-11 Thread Vamsi Attunuru
Patch improves Rx routine and pkt count update routines, packet count update routines need to drain inflight ISM memory updates while decrementing the packet count register. Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/otx_ep_rxtx.c | 162 1 file changed,

[PATCH v3 1/3] net/octeon_ep: support 32B IQ descriptor size

2023-10-11 Thread Vamsi Attunuru
From: Shijith Thotton Update input queue setup to consider descriptor size in driver conf. The default instruction size for otx2 and cnxk devices has been updated to 32 bytes. Signed-off-by: Shijith Thotton --- drivers/net/octeon_ep/cnxk_ep_vf.c| 10 +- drivers/net/octeon_ep/otx2_e

[PATCH v3 0/3] rewrite fastpath routines

2023-10-11 Thread Vamsi Attunuru
This series adds new fastpath routines for cn10k & cn9k endpoint devices and supports 32B Tx desciptor format which improves the performance. v2 & v3 changes: - Fixed CI Shijith Thotton (1): net/octeon_ep: support 32B IQ descriptor size Vamsi Attunuru (2): net/octeon_ep: clean up receive rou

Re: [PATCH v4 0/3] Release ethdev shared memory on port cleanup

2023-10-11 Thread Thomas Monjalon
27/09/2023 13:45, David Marchand: > This series was triggered after investigating why the > eal_flags_file_prefix_autotest unit test was failing in the case of > statically built binaries [1]). > > For now, I went with a simple (naive) approach and put all accesses to the > shared data under a sin

[RFC v2 2/2] test: add pointer compress tests to ring perf test

2023-10-11 Thread Paul Szczepanek
Add a test that runs a zero copy burst enqueue and dequeue on a ring of raw pointers and compressed pointers at different burst sizes to showcase performance benefits of newly added pointer compression APIs. Refactored threading code to pass more parameters to threads to reuse existing code. Added

[RFC v2 1/2] eal: add pointer compression functions

2023-10-11 Thread Paul Szczepanek
Add a new utility header for compressing pointers. The provided functions can store pointers in 32-bit offsets. The compression takes advantage of the fact that pointers are usually located in a limited memory region (like a mempool). We can compress them by converting them to offsets from a base

[RFC v2 0/2] add pointer compression API

2023-10-11 Thread Paul Szczepanek
This patchset is proposing adding a new EAL header with utility functions that allow compression of arrays of pointers. When passing caches full of pointers between threads, memory containing the pointers is copied multiple times which is especially costly between cores. A compression method will

RE: [PATCH v2 25/29] regexdev: remove experimental tag

2023-10-11 Thread Ori Kam
Hi Stephen, I know that Nvidia, is going to remove the support for regex in the future. The only other HW that implements this is Marvel. I don't know about other manufacturers plan to support it. I suggest keeping it as is for now, and maybe we will need to remove this lib. Anyone from Marvel

Re: [PATCH] doc: sort build and EAL features in the release notes

2023-10-11 Thread David Marchand
On Wed, Oct 11, 2023 at 9:54 AM Thomas Monjalon wrote: > > When adding build and EAL features in 23.11, > the format and sorting order was unusual. Indeed, my bad. > This change is making these features similar as others. > > Signed-off-by: Thomas Monjalon Acked-by: David Marchand Applied, t

  1   2   >