RE: [PATCH v2 05/11] net/nfp: adjust the log statement

[Chaoyong He]

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Thursday, October 12, 2023 9:39 AM
> To: Chaoyong He <chaoyong...@corigine.com>
> Cc: dev@dpdk.org; oss-drivers <oss-driv...@corigine.com>; Long Wu
> <long...@nephogine.com>; Nole Zhang <peng.zh...@corigine.com>
> Subject: Re: [PATCH v2 05/11] net/nfp: adjust the log statement
> 
> On Thu, 12 Oct 2023 09:26:58 +0800
> Chaoyong He <chaoyong...@corigine.com> wrote:
> 
> > +                   PMD_RX_LOG(ERR, "mbuf overflow likely due to the
> RX offset.\n"
> > +                                   "\t\tYour mbuf size should have extra
> space for"
> > +                                   " RX offset=%u bytes.\n"
> > +                                   "\t\tCurrently you just have %u bytes
> available"
> > +                                   " but the received packet is %u bytes
> long",
> > +                                   hw->rx_offset,
> > +                                   rxq->mbuf_size - hw->rx_offset,
> > +                                   mb->data_len);
> 
> Multi-line log messages with tabs look good on command line (developer) but
> don't work well when application is run as a service and logging is going to
> syslog.
> Syslog doesn't like messages with newlines in them.
> The message is way to long. Make it shorter, and put any other notes in a
> comment please..

Thanks, got it.
I will revise as you said in the next version.