> -----Original Message-----
> From: Ferruh Yigit <ferruh.yi...@amd.com>
> Sent: Thursday, October 12, 2023 1:21 AM
> To: Jie Hai <haij...@huawei.com>; dev@dpdk.org; Zhang, Yuying
> <yuying.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>
> Cc: lihuis...@huawei.com; fengcheng...@huawei.com;
> liudongdo...@huawei.com
> Subject: Re: [PATCH v5 09/40] net/cpfl: check RSS hash algorithms
>
> On 10/11/2023 10:27 AM, Jie Hai wrote:
> > A new field 'algorithm' has been added to rss_conf, check it in case
> > of ignoring unsupported values.
> >
> > Signed-off-by: Jie Hai <haij...@huawei.com>
> > ---
> > drivers/net/cpfl/cpfl_ethdev.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/cpfl/cpfl_ethdev.c
> > b/drivers/net/cpfl/cpfl_ethdev.c index c4ca9343c3e0..6acb6ce9fd22
> > 100644
> > --- a/drivers/net/cpfl/cpfl_ethdev.c
> > +++ b/drivers/net/cpfl/cpfl_ethdev.c
> > @@ -450,6 +450,9 @@ cpfl_init_rss(struct idpf_vport *vport)
> > rss_conf = &dev_data->dev_conf.rx_adv_conf.rss_conf;
> > nb_q = dev_data->nb_rx_queues;
> >
> > + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)
> > + return -EINVAL;
> > +
> > if (rss_conf->rss_key == NULL) {
> > for (i = 0; i < vport->rss_key_size; i++)
> > vport->rss_key[i] = (uint8_t)rte_rand(); @@ -568,6
> +571,9 @@
> > cpfl_rss_hash_update(struct rte_eth_dev *dev,
> > return -ENOTSUP;
> > }
> >
> > + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)
> > + return -EINVAL;
> > +
> > if (!rss_conf->rss_key || rss_conf->rss_key_len == 0) {
> > PMD_DRV_LOG(DEBUG, "No key to be configured");
> > goto skip_rss_key;
>
>
> cpfl also doesn't report RSS capability
> (doc/guides/nics/features/cpfl.ini), but it is clear that driver supports RSS.
>
> @Yuying, @Beilei, can you please update .ini file in a separate file?
Thanks for the reminder, will update .ini file later.
