On Wed, Oct 11, 2023 at 05:27:22PM +0200, Thomas Monjalon wrote:
> 20/09/2023 16:18, Ric Li:
> > When running 'meson setup' on Windows with MSYS2,
> > "list-dir-globs.py * failed with status 1".
>
> We don't know why it is failing?
> What about other usages of list_dir_globs in drivers and lib?
>
> > Avoid using globbing to get components for app build
> > since they are already listed in the meson file.
>
> I don't understand the logic.
>
> > +disable_apps = ',' + get_option('disable_apps')
> > +disable_apps = run_command(list_dir_globs, disable_apps, check:
> > true).stdout().split()
>
> This could fail.
>
> > +
> > +enable_apps = ',' + get_option('enable_apps')
> > +enable_apps = run_command(list_dir_globs, enable_apps, check:
> > true).stdout().split()
> > +if enable_apps.length() == 0
> > + enable_apps = apps
> > +endif
>
> If nothing is enabled, we enable all?
>
Yes, if the enable_apps list is empty we should enable everything.
However, on reviewing the v2, I missed the fact that this patch is
removing the expansion of the disable_apps value.
Given your comment, this check can probably also be improved by checking
the get_option('enable_apps') length, rather than the expanded version.
/Bruce
