Re: [PATCH v2 2/2] eal: remove NUMFLAGS enumeration

2023-08-14 Thread Stanisław Kardach
On Fri, Aug 11, 2023, 08:08 Sivaprasad Tummala wrote: > This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU > features without breaking ABI each time. > > Signed-off-by: Sivaprasad Tummala > --- > lib/eal/arm/include/rte_cpuflags_32.h| 1 - > lib/eal/arm/include/rte_cpuflags_64.h|

RE: [RFC] ring: further performance improvements with C11

2023-08-14 Thread Honnappa Nagarahalli
> -Original Message- > From: Konstantin Ananyev > Sent: Wednesday, August 9, 2023 1:19 PM > To: Wathsala Wathawana Vithanage ; > Honnappa Nagarahalli ; > konstantin.v.anan...@yandex.ru; tho...@monjalon.net; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Justin He ; nd > > Subject: RE: [RFC]

[PATCH v3 7/7] eal: initialize worker threads once

2023-08-14 Thread okaya
From: Sinan Kaya Initialize worker threads once and keep a flag for other init calls. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal.c | 60 - 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c

[PATCH v3 6/7] eal_interrupts: don't reinitialize threads

2023-08-14 Thread okaya
From: Sinan Kaya Initialize interrupt thread once and keep a flag for further init. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_interrupts.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c index c9881143be..6a35b4ae

[PATCH v3 5/7] eal_memory: skip initialization

2023-08-14 Thread okaya
From: Sinan Kaya Initialize heap area just once. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memory.c | 5 + lib/eal/common/malloc_heap.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c

[PATCH v3 4/7] memseg: init once

2023-08-14 Thread okaya
From: Sinan Kaya Initialize memory segments just once and bail out if called multiple times. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_memory.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 9

[PATCH v3 3/7] eal_memzone: bail out on initialized

2023-08-14 Thread okaya
From: Sinan Kaya Initialize memzone once and bail out if someone calls init multiple times. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c in

[PATCH v3 2/7] tailq: skip init if already initialized

2023-08-14 Thread okaya
From: Sinan Kaya Allows tailq to be reinitialied multiple times by looking up previously registered tailqs Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_tailqs.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/eal/common/eal_common_tailqs

[PATCH v3 1/7] eal: fixes for re-initialization issues

2023-08-14 Thread okaya
From: Graham Whyte reinitialize the solib link list and clean the globals holding state for parsing. Signed-off-by: Sinan Kaya Signed-off-by: Graham Whyte --- lib/eal/common/eal_common_options.c | 7 +++ lib/eal/linux/eal.c | 4 +++- 2 files changed, 10 insertions(+), 1 de

[PATCH v3 0/7] support reinit flow

2023-08-14 Thread okaya
From: Sinan Kaya We want to be able to call rte_eal_init() and rte_eal_cleanup() APIs back to back for maintanance reasons. Here is a summary of the code we have seen so far: 1. some code support getting called multiple times by keeping a static variable. 2. some code initializes once but never

[PATCH v2 7/7] eal: initialize worker threads once

2023-08-14 Thread okaya
From: Sinan Kaya Initialize worker threads once and keep a flag for other init calls. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal.c | 68 - 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c

[PATCH v2 6/7] eal_interrupts: don't reinitialize threads

2023-08-14 Thread okaya
From: Sinan Kaya Initialize interrupt thread once and keep a flag for further init. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_interrupts.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c index d52ec8eb4c..f141711f

[PATCH v2 4/7] memseg: init once

2023-08-14 Thread okaya
From: Sinan Kaya Initialize memory segments just once and bail out if called multiple times. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_memory.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 6

[PATCH v2 5/7] eal_memory: skip initialization

2023-08-14 Thread okaya
From: Sinan Kaya Initialize heap area just once. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memory.c | 5 + lib/eal/common/malloc_heap.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c

[PATCH v2 3/7] eal_memzone: bail out on initialized

2023-08-14 Thread okaya
From: Sinan Kaya Initialize memzone once and bail out if someone calls init multiple times. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c in

[PATCH v2 2/7] tailq: skip init if already initialized

2023-08-14 Thread okaya
From: Sinan Kaya Allows tailq to be reinitialied multiple times by looking up previously registered tailqs Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_tailqs.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/eal/common/eal_common_tailqs

[PATCH v2 1/7] eal: fixes for re-initialization issues

2023-08-14 Thread okaya
From: Graham Whyte reinitialize the solib link list and clean the globals holding state for parsing. Signed-off-by: Sinan Kaya Signed-off-by: Graham Whyte --- lib/eal/common/eal_common_options.c | 7 +++ lib/eal/linux/eal.c | 4 +++- 2 files changed, 10 insertions(+), 1 de

[PATCH v2 0/7] support reinit flow

2023-08-14 Thread okaya
From: Sinan Kaya We want to be able to call rte_eal_init() and rte_eal_cleanup() APIs back to back for maintanance reasons. Here is a summary of the code we have seen so far: 1. some code support getting called multiple times by keeping a static variable. 2. some code initializes once but never

Re: [PATCH v1 0/7] support reinit flow

2023-08-14 Thread Sinan Kaya
On Mon, 2023-08-14 at 19:12 -0700, Stephen Hemminger wrote: > On Mon, 14 Aug 2023 21:38:19 -0400 > > ok...@kernel.org wrote: > > > > > From: Sinan Kaya > > We want to be able to call rte_eal_init() and rte_eal_cleanup() > > APIs back to back for maintanance reasons. > > > Why? > > This chan

Re: [PATCH v1 3/7] eal_memzone: bail out on initialized

2023-08-14 Thread Stephen Hemminger
On Mon, 14 Aug 2023 21:38:22 -0400 ok...@kernel.org wrote: > + static int initialized = 0; > int ret = 0; > > + if (initialized) > + return 0; > + > /* get pointer to global configuration */ > mcfg = rte_eal_get_configuration()->mem_config; > > @@ -415,6 +

Re: [PATCH v1 1/7] eal: fixes for re-initialization issues

2023-08-14 Thread Stephen Hemminger
On Mon, 14 Aug 2023 21:38:20 -0400 ok...@kernel.org wrote: > From: Graham Whyte > > reinitialize the solib link list and clean the globals holding > state for parsing. > > Signed-off-by: Sinan Kaya > Signed-off by: Graham Whyte Please fix all the checkpatch issues.

Re: [PATCH v1 0/7] support reinit flow

2023-08-14 Thread Stephen Hemminger
On Mon, 14 Aug 2023 21:38:19 -0400 ok...@kernel.org wrote: > From: Sinan Kaya > > We want to be able to call rte_eal_init() and rte_eal_cleanup() > APIs back to back for maintanance reasons. Why? This change exposes lots of drivers, API's and other things to untested code paths. If you just wa

RE: [PATCH] graph: mark API's as stable

2023-08-14 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, August 14, 2023 9:07 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Kiran Kumar K ; Nithin > Dabilpuram ; Yan, Zhirun > Subject: Re: [PATCH] graph: mark API's as stable > > On Thu, Aug 10, 2023

[PATCH v1 7/7] eal: initialize worker threads once

2023-08-14 Thread okaya
From: Sinan Kaya Signed-off-by: Sinan Kaya --- lib/eal/linux/eal.c | 68 - 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 5fd81d71cb..63190a4e70 100644 --- a/lib/eal/linux/eal.c +++ b/li

[PATCH v1 6/7] eal_interrupts: don't reinitialize threads

2023-08-14 Thread okaya
From: Sinan Kaya Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_interrupts.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c index d52ec8eb4c..aa296f153b 100644 --- a/lib/eal/linux/eal_interrupts.c +++ b/lib/eal/linux/eal

[PATCH v1 5/7] eal_memory: skip initialization

2023-08-14 Thread okaya
From: Sinan Kaya Initialize heap area just once. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memory.c | 5 + lib/eal/common/malloc_heap.c | 6 ++ 2 files changed, 11 insertions(+) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c i

[PATCH v1 4/7] memseg: init once

2023-08-14 Thread okaya
From: Sinan Kaya Initialize memory segments just once and bail out if called multiple times. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_memory.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 60

[PATCH v1 3/7] eal_memzone: bail out on initialized

2023-08-14 Thread okaya
From: Sinan Kaya Initialize memzone once and bail out if someone calls init multiple times. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c ind

[PATCH v1 2/7] tailq: skip init if already initialized

2023-08-14 Thread okaya
From: Sinan Kaya Allows tailq to be reinitialied multiple times by looking up previously registered tailqs Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_tailqs.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/lib/eal/common/eal_common_tailq

[PATCH v1 1/7] eal: fixes for re-initialization issues

2023-08-14 Thread okaya
From: Graham Whyte reinitialize the solib link list and clean the globals holding state for parsing. Signed-off-by: Sinan Kaya Signed-off by: Graham Whyte --- lib/eal/common/eal_common_options.c | 7 +++ lib/eal/linux/eal.c | 4 +++- 2 files changed, 10 insertions(+), 1 de

[PATCH v1 0/7] support reinit flow

2023-08-14 Thread okaya
From: Sinan Kaya We want to be able to call rte_eal_init() and rte_eal_cleanup() APIs back to back for maintanance reasons. Here is a summary of the code we have seen so far: 1. some code support getting called multiple times by keeping a static variable. 2. some code initializes once but never

Reminder - Registration - DPDK Dublin Summit Next Month

2023-08-14 Thread Nathan Southern
Dear DPDK Community, This is a reminder that if you plan to attend our Dublin, Ireland Summit at the Gibson Hotel, from Sep. 12-14 of this year, to please go ahead and take the time to register. Once again, registration is completely and totally free. You can find a link to the final schedule he

RE: [PATCH v3 0/8] expand list of optional libraries

2023-08-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 14 August 2023 20.21 > > This patchset contains changes to DPDK to make the build more > configurable > overall. The changes can be grouped into two areas: > > * Firstly, there are changes to make the build of the unit t

RE: [PATCH v4 4/4] build: enable MSVC specific compiler options

2023-08-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 14 August 2023 18.47 > > On Mon, Aug 14, 2023 at 09:10:53AM -0700, Tyler Retzlaff wrote: > > On Mon, Aug 14, 2023 at 09:30:20AM +0100, Bruce Richardson wrote: > > > On Fri, Aug 11, 2023 at 11:24:47AM -0700, Tyler Retzlaff

[PATCH v3 8/8] build: expand list of optional libraries

2023-08-14 Thread Bruce Richardson
With the unit test build now with individual per-file dependencies, we can more easily expand the list of optional libraries. Add 8 new libraries to the optional list. Signed-off-by: Bruce Richardson --- lib/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/meson.build

[PATCH v3 7/8] build: make most device classes optional

2023-08-14 Thread Bruce Richardson
Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH v3 6/8] examples/l3fwd: make eventdev an optional dependency

2023-08-14 Thread Bruce Richardson
With l3fwd being a very commonly used example app, and built as part of our CI tests, we need to ensure it's buildable with just about all supported DPDK configurations. To enable l3fwd application to be built when the eventdev library is disabled, we need to compile in the eventdev support condit

[PATCH v3 5/8] app/test: define unit tests suites based on test macros

2023-08-14 Thread Bruce Richardson
Rather than having the test suites listed out in the meson.build files and having to have them enabled/disabled selectively based on what libs are being built, pull the tests to run from the source files which were added to the build. Most test suites require no additional info other than the list

[PATCH v3 4/8] app/test: build using per-file dependency matrix

2023-08-14 Thread Bruce Richardson
Rather than using if-else constructs to selectively add or remove files from the UT build, switch to a table-based approach where each file lists out what libs or drivers it depends upon. Initial version of this table was generated via analysis of the header files included in each C file. The basi

[PATCH v3 3/8] app/test: make telemetry data test buildable on windows

2023-08-14 Thread Bruce Richardson
To enable the building of the telemetry data tests file when building on windows, we need to provide a stub implementation. That way, the test file is buildable any time the library itself is built. Signed-off-by: Bruce Richardson --- app/test/test_telemetry_data.c | 14 -- 1 file ch

[PATCH v3 2/8] app/test: tag tests with the test type

2023-08-14 Thread Bruce Richardson
Rather than having the test types called out in the meson.build file, we can use macros to identify the test type in the C file itself and then dynamically build up the tests lists at config time. Signed-off-by: Bruce Richardson --- app/test/test_acl.c | 2 +- app/test/test

[PATCH v3 1/8] app/test: add new macros for various test types

2023-08-14 Thread Bruce Richardson
Rather than just registering all tests using a single generic macro, add macros which identify the test as being of a particular type. Signed-off-by: Bruce Richardson --- app/test/test.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/test/test.h b/app/test/test.h

[PATCH v3 0/8] expand list of optional libraries

2023-08-14 Thread Bruce Richardson
This patchset contains changes to DPDK to make the build more configurable overall. The changes can be grouped into two areas: * Firstly, there are changes to make the build of the unit tests more flexible and maintainable. These 5 patches switch the unit tests from having separate hard-coded

Re: [PATCH v2 2/6] eal: adapt EAL to present rte optional atomics API

2023-08-14 Thread Tyler Retzlaff
On Mon, Aug 14, 2023 at 10:00:49AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Friday, 11 August 2023 19.32 > > > > Adapt the EAL public headers to use rte optional atomics API instead of > > directly using and exposing toolchain specific at

RE: [PATCH v8 0/6] Convert use of RTE_LOGTYPE_USER1 in libraries

2023-08-14 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 14 August 2023 18.31 > > Libraries in DPDK should be using dynamic logtype instead > of overloading the static logtype RTE_LOGTYPE_USER1 > > v8 - rebase and add power library > > Stephen Hemminger (6): > ip_frag: use

Re: [PATCH] net/bonding: Fix header for C++

2023-08-14 Thread Ferruh Yigit
On 8/9/2023 6:49 PM, Tyler Retzlaff wrote: > On Wed, Aug 09, 2023 at 03:52:41PM +, Visa Hankala wrote: >> Apply C linkage to the whole header to allow use with C++. >> >> Fixes: dc40f17a36b ("net/bonding: allow external state machine in mode 4") >> >> Signed-off-by: Visa Hankala >> > > Acked-

Re: [PATCH v4 4/4] build: enable MSVC specific compiler options

2023-08-14 Thread Bruce Richardson
On Mon, Aug 14, 2023 at 09:10:53AM -0700, Tyler Retzlaff wrote: > On Mon, Aug 14, 2023 at 09:30:20AM +0100, Bruce Richardson wrote: > > On Fri, Aug 11, 2023 at 11:24:47AM -0700, Tyler Retzlaff wrote: > > > * Enable optional use of C11 atomics support. * Enable use of C23 > > > typeof operator. *

[PATCH v8 6/6] power: use a dynamic logtype for guest channel

2023-08-14 Thread Stephen Hemminger
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Fixes: cd0d5547e873 ("power: vm communication channels in guest") Signed-off-by: Stephen Hemminger --- lib/power/guest_channel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[PATCH v8 5/6] ipsec: fix usage of RTE_LOGTYPE_USER1

2023-08-14 Thread Stephen Hemminger
There already is a logtype in this driver, use it! Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v8 4/6] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-08-14 Thread Stephen Hemminger
Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Reviewed-by: Maxime Coquelin Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 4 ++-- lib/vhost/vhost_crypto.c | 22 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff

[PATCH v8 3/6] latencystats: use dynamic logtype

2023-08-14 Thread Stephen Hemminger
Libraries should not reuse RTE_LOGTYPE_USER1 for their logging. Instead they should register their own type. Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: reshma.pat...@intel.com Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 3 ++- 1 file c

[PATCH v8 2/6] reorder: use a dynamic logtype

2023-08-14 Thread Stephen Hemminger
Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH v8 1/6] ip_frag: use a dynamic logtype

2023-08-14 Thread Stephen Hemminger
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Acked-by: Konstantin Ananyev Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h | 5 - lib/

[PATCH v8 0/6] Convert use of RTE_LOGTYPE_USER1 in libraries

2023-08-14 Thread Stephen Hemminger
Libraries in DPDK should be using dynamic logtype instead of overloading the static logtype RTE_LOGTYPE_USER1 v8 - rebase and add power library Stephen Hemminger (6): ip_frag: use a dynamic logtype reorder: use a dynamic logtype latencystats: use dynamic logtype vhost: use logtype instead

Re: [PATCH] dma/skeleton: fix pthread set affinity

2023-08-14 Thread Tyler Retzlaff
On Sat, Aug 12, 2023 at 07:27:38AM +0530, Vipin Varghese wrote: > In skeleton dma driver, the user can pin the dma thread to desired > cpu core. The previous commit changed the api from set-affinity to > get-affinity leading to thread to be pinned to first available lcore. > > Bugzilla ID: 1270 >

Re: [PATCH v4 4/4] build: enable MSVC specific compiler options

2023-08-14 Thread Tyler Retzlaff
On Mon, Aug 14, 2023 at 09:30:20AM +0100, Bruce Richardson wrote: > On Fri, Aug 11, 2023 at 11:24:47AM -0700, Tyler Retzlaff wrote: > > * Enable optional use of C11 atomics support. > > * Enable use of C23 typeof operator. > > * Explicitly force intrinsics when building with MSVC. > > * Disable MSV

Re: [PATCH] dma/idxd: add reset in the init routine

2023-08-14 Thread Bruce Richardson
On Fri, Aug 11, 2023 at 10:10:54AM +0800, Frank Du wrote: > Fix for windows, no one reset the dev to a clear status. In Linux, > kernel driver will reset during the prob. > > Signed-off-by: Frank Du > --- > drivers/dma/idxd/idxd_pci.c | 8 > 1 file changed, 8 insertions(+) > Ran some s

[dpdk-dev] [PATCH] maintainers: update tree for marvell drivers

2023-08-14 Thread jerinj
From: Jerin Jacob Marvell's cnxk dmadev driver, cn9k regexdev driver, cnxk mldev driver, cnxk bphy rawdev driver and cnxk gpio rawdev driver are merging through main tree now. Offering to help by merging it through next-net-mrvl tree to save cycles for main tree maintainers. Signed-off-by: Jerin

Re: Drivers, architectures, processor families, etc.

2023-08-14 Thread Ferruh Yigit
On 8/2/2023 10:49 PM, Philip Prindeville wrote: > Hi, > > I'm trying to come up with some Kconfig logic for OpenWRT packaging to help > users select the right build options for their hardware. > > Most OpenWRT developers typically cross-compile, so we obviously can't rely > on detection on the

[Bug 1273] eth_memif_rx segfault when burst size is greater than 32

2023-08-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1273 Bug ID: 1273 Summary: eth_memif_rx segfault when burst size is greater than 32 Product: DPDK Version: 23.03 Hardware: All OS: Linux Status: UNCONFIRMED

Re: [PATCH v2 0/8] expand list of optional libraries

2023-08-14 Thread Bruce Richardson
On Mon, Aug 14, 2023 at 04:16:01PM +0100, Bruce Richardson wrote: > This patchset contains changes to DPDK to make the build more configurable > overall. The changes can be grouped into two areas: > > * Firstly, there are changes to make the build of the unit tests more > flexible and maintainab

[PATCH v2 8/8] build: expand list of optional libraries

2023-08-14 Thread Bruce Richardson
With the unit test build now with individual per-file dependencies, we can more easily expand the list of optional libraries. Add 8 new libraries to the optional list. Signed-off-by: Bruce Richardson --- lib/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/meson.build

[PATCH v2 7/8] build: make most device classes optional

2023-08-14 Thread Bruce Richardson
Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH v2 6/8] examples/l3fwd: make eventdev an optional dependency

2023-08-14 Thread Bruce Richardson
With l3fwd being a very commonly used example app, and built as part of our CI tests, we need to ensure it's buildable with just about all supported DPDK configurations. To enable l3fwd application to be built when the eventdev library is disabled, we need to compile in the eventdev support condit

[PATCH v2 5/8] app/test: define unit tests suites based on test macros

2023-08-14 Thread Bruce Richardson
Rather than having the test suites listed out in the meson.build files and having to have them enabled/disabled selectively based on what libs are being built, pull the tests to run from the source files which were added to the build. Most test suites require no additional info other than the list

[PATCH v2 4/8] app/test: build using per-file dependency matrix

2023-08-14 Thread Bruce Richardson
Rather than using if-else constructs to selectively add or remove files from the UT build, switch to a table-based approach where each file lists out what libs or drivers it depends upon. Initial version of this table was generated via analysis of the header files included in each C file. The basi

[PATCH v2 3/8] app/test: make telemetry data test buildable on windows

2023-08-14 Thread Bruce Richardson
To enable the building of the telemetry data tests file when building on windows, we need to provide a stub implementation. That way, the test file is buildable any time the library itself is built. Signed-off-by: Bruce Richardson --- app/test/test_telemetry_data.c | 14 -- 1 file ch

[PATCH v2 2/8] app/test: tag tests with the test type

2023-08-14 Thread Bruce Richardson
Rather than having the test types called out in the meson.build file, we can use macros to identify the test type in the C file itself and then dynamically build up the tests lists at config time. Signed-off-by: Bruce Richardson --- app/test/test_acl.c | 2 +- app/test/test

[PATCH v2 1/8] app/test: add new macros for various test types

2023-08-14 Thread Bruce Richardson
Rather than just registering all tests using a single generic macro, add macros which identify the test as being of a particular type. Signed-off-by: Bruce Richardson --- app/test/test.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/test/test.h b/app/test/test.h

[PATCH v2 0/8] expand list of optional libraries

2023-08-14 Thread Bruce Richardson
This patchset contains changes to DPDK to make the build more configurable overall. The changes can be grouped into two areas: * Firstly, there are changes to make the build of the unit tests more flexible and maintainable. These 5 patches switch the unit tests from having separate hard-coded

RE: C11 atomics adoption blocked

2023-08-14 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 14 August 2023 15.46 > > mercredi 9 août 2023, Morten Brørup: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Tuesday, 8 August 2023 22.50 > > > > > > On Tue, Aug 08, 2023 at 10:22:09PM +0200, Morten

Re: [PATCH v4 0/9] expand list of optional libraries

2023-08-14 Thread Bruce Richardson
On Fri, Jun 23, 2023 at 04:06:59PM +0100, Bruce Richardson wrote: > DPDK still has many libraries which cannot be disabled as part of a > build. With the ongoing work to make it easier to only build a subset > of the libraries in DPDK, we can also work to expand the list of > libraries which can be

RE: [EXT] atlantic macsec API's

2023-08-14 Thread Igor Russkikh
Hi Stephen, > The DPDK Atlantic driver has 6 API's marked as experimental. > These API's were added back in 19.05 release. > These API's should either be marked as stable or removed in 23.11 release. > What do you want to do? Unfortunately to my knowledge, this project is no more supported by Ma

Re: [PATCH v4] dmadev: add tracepoints

2023-08-14 Thread Thomas Monjalon
jeudi 3 août 2023, fengchengwen: > Hi Thomas, > > On 2023/7/31 20:48, Thomas Monjalon wrote: > > 10/07/2023 09:50, fengchengwen: > >> Hi Thomas, > >> > >> On 2023/7/10 14:49, Thomas Monjalon wrote: > >>> 09/07/2023 05:23, fengchengwen: > Hi Thomas, > > On 2023/7/7 18:40, Thomas Monj

RE: [PATCH v3] Add support for IBM Z s390x

2023-08-14 Thread Mathew S Thoennes
David, I will connect with David Christensen in regards to what they are doing for CI. I have talked to him in the past but now that things are rolling I will reconnect with him. I do have hardware that the CI could run on to verify the build. I think testing of the hardware part would end u

[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter

2023-08-14 Thread jhascoet
From: Julien Hascoet In case of ring full state, we retry the enqueue operation in order to avoid mbuf loss. Fixes: af75078fece ("first public release") Signed-off-by: Julien Hascoet --- app/test/test_mbuf.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/

[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter

2023-08-14 Thread jhascoet
From: Julien Hascoet In case of ring full state, we retry the enqueue operation in order to avoid mbuf loss. Fixes: af75078fece ("first public release") Signed-off-by: Julien Hascoet --- app/test/test_mbuf.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/t

Re: C11 atomics adoption blocked

2023-08-14 Thread Thomas Monjalon
mercredi 9 août 2023, Morten Brørup: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Tuesday, 8 August 2023 22.50 > > > > On Tue, Aug 08, 2023 at 10:22:09PM +0200, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > > Sent: Tuesday

Re: 3SNIC roadmap for v23.11

2023-08-14 Thread Ferruh Yigit
On 8/4/2023 5:55 PM, Steven Song wrote: > Hi Ferruh, > > Please find below 3SNIC roadmap for v23.11 release: > > * Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters. > > Features of sssnic PMD are: > > - Link status > - Link status event > - Queue start/stop > - Rx interrupt > - Sc

Re: [PATCH] graph: mark API's as stable

2023-08-14 Thread Jerin Jacob
On Thu, Aug 10, 2023 at 11:35 PM Stephen Hemminger wrote: > > The graph library has been marked experimental since initial > release in 2020. Time to take the training wheels off. > > Signed-off-by: Stephen Hemminger Acked-by: Jerin Jacob

Re: [PATCH 31/31] net/cnxk: fixes for IPv6 header in reassembly

2023-08-14 Thread Jerin Jacob
On Fri, Aug 11, 2023 at 2:31 PM Nithin Dabilpuram wrote: > > From: Rahul Bhansali > > In reassembly path, next header field in IPv6 header is not > updated correctly, hence reassembled packet is corrupted. > This fix will consider IPv6 fragment header presence at start/mid/end in > extension list

[PATCH 2/2] net/ice: map group to pipeline stage

2023-08-14 Thread Qi Zhang
Mapping rte_flow_attr->group to a specific hardware stage. Group 0 -> switch filter Group 1 -> acl filter Group 2 -> fdir filter For RSS, it will only be selected if there is a RTE_FLOW_ACTION_RSS action target no queue group and the group ID is ignored. Since each flow parser will be selected b

[PATCH 1/2] net/ice: remove pipeline mode

2023-08-14 Thread Qi Zhang
This marks the initial phase of refactoring the ice rte_flow implementation. The combination of switch and fdir rules within the same syntax has led to inconvenient user experiences. Naturally, the switch filter and fdir filter represent distinct pipeline stages with differing hardware capabilitie

[PATCH 0/2] refactor rte_flow

2023-08-14 Thread Qi Zhang
1. apply group to hardware pipeline stage static mapping 2. remove pipeline mode Qi Zhang (2): net/ice: remove pipeline mode net/ice: map group to pipeline stage doc/guides/nics/ice.rst | 19 --- drivers/net/ice/ice_acl_filter.c| 13 +- drivers/net/ice/ice_ethdev.c

RE: [PATCH v2] net/iavf: refactor part of watchdog

2023-08-14 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Monday, August 14, 2023 5:10 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Jiale, SongX ; > Zeng, ZhichaoX ; Wu, Jingjing > ; Xing, Beilei > Subject: [PATCH v2] net/iavf: refactor part of watchdog > > This commit refactors two parts of th

Re: 20.11.9 patches review and test

2023-08-14 Thread Luca Boccassi
On Mon, 14 Aug 2023 at 12:52, Ali Alnubani wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Saturday, July 29, 2023 2:08 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; benjamin.wal...@intel.com; David > > Christensen ; Hem

[PATCH] doc: add note about VMXNET3 on AMD with ESXI.

2023-08-14 Thread Igor de Paula
This patch notes the requirements for ESXI version 7.0.1 or higher when using IOVA as VA. Signed-off-by: Igor de Paula --- .mailmap| 1 + doc/guides/nics/vmxnet3.rst | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.mailmap b/.mailmap index 864d33ee46..cbcc1153a6 100644

RE: 20.11.9 patches review and test

2023-08-14 Thread Ali Alnubani
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Saturday, July 29, 2023 2:08 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Ian Stokes ; Jerin Jacob > ; John McNamara ; Ju- >

[PATCH] doc: add note about VMXNET3 on AMD with ESXI.

2023-08-14 Thread Igor de Paula
This patch notes the requirements for ESXI version 7.0.1 or higher when usin IOVA as VA. --- .mailmap| 1 + doc/guides/nics/vmxnet3.rst | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.mailmap b/.mailmap index 864d33ee46..cbcc1153a6 100644 --- a/.mailmap +++ b/.mailmap @

[PATCH] doc: add note about VMXNET3 on AMD with ESXI

2023-08-14 Thread Igor de Paula
--- ...-note-about-VMXNET3-on-AMD-with-ESXI.patch | 38 +++ 1 file changed, 38 insertions(+) create mode 100644 0001-doc-add-note-about-VMXNET3-on-AMD-with-ESXI.patch diff --git a/0001-doc-add-note-about-VMXNET3-on-AMD-with-ESXI.patch b/0001-doc-add-note-about-VMXNET3-on-AMD-wit

RE: [EXT] Re: [RFC 0/3] Introduce event link profiles

2023-08-14 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Mattias Rönnblom > Sent: Saturday, August 12, 2023 11:23 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; Shijith Thotton > ; timothy.mcdan...@intel.com; > hemant.agra...@nxp.com; sachin.sax...@nxp.com; > mattias.ronnb...@ericsson.com; lia

[PATCH] doc: add note about VMXNET3 on AMD with ESXI

2023-08-14 Thread Igor de Paula
This patch notes the requirement for ESXI version 7.0.1 or higher when using IOVA as VA. Signed-off-by: Igor de Paula igord...@gmail.com --- .mailmap| 1 + doc/guides/nics/vmxnet3.rst | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.mailmap b/.mailmap index 864d33ee46..

Re: [PATCH v1 3/3] dma/idxd: add API to create and attach to window

2023-08-14 Thread Burakov, Anatoly
On 8/14/2023 5:39 AM, Jerin Jacob wrote: On Fri, Aug 11, 2023 at 9:45 PM Anatoly Burakov wrote: This commit implements functions necessary to use inter-domain operations with idxd driver. The process is as follows: 1. Process A that wishes to share its memory with others, shall call `rte

Re: [PATCH] devtools: list symbols by version

2023-08-14 Thread Thomas Monjalon
vendredi 11 août 2023, David Marchand: > Make it easier to list experimental symbols added in a certain version. > While at it, add a check on map symbol files content to avoid breaking > this listing tool. Is there a relation between the new check and the new -V option? I feel it would be clearer

RE: [PATCH] usertools: suggest use of hwloc for new cpu

2023-08-14 Thread Konstantin Ananyev
> On Sun, Aug 13, 2023 at 08:52:01AM -0700, Stephen Hemminger wrote: > > On Sun, 13 Aug 2023 02:12:03 + > > "Varghese, Vipin" wrote: > > > > > > > > > > On Sat, 12 Aug 2023 06:27:20 +0530 > > > > Vipin Varghese wrote: > > > > > > > > > Most modern processor now supports numa by partitioning

RE: [PATCH] usertools: suggest use of hwloc for new cpu

2023-08-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 14 August 2023 10.52 > > On Sun, Aug 13, 2023 at 08:52:01AM -0700, Stephen Hemminger wrote: > > On Sun, 13 Aug 2023 02:12:03 + > > "Varghese, Vipin" wrote: > > > > > > > > > > On Sat, 12 Aug 2023 06:27:20 +0530 > > >

Re: [PATCH v4 1/4] build: unblock the use of the MSVC compiler

2023-08-14 Thread Bruce Richardson
On Mon, Aug 14, 2023 at 12:07:34PM +0300, Dmitry Kozlyuk wrote: > 2023-08-14 09:27 (UTC+0100), Bruce Richardson: > > On Fri, Aug 11, 2023 at 11:24:44AM -0700, Tyler Retzlaff wrote: > > > Detect when MSVC toolset is available and tweak toolchain arguments > > > where the meson build system offers no

Re: [PATCH v4 1/4] build: unblock the use of the MSVC compiler

2023-08-14 Thread Dmitry Kozlyuk
2023-08-14 09:27 (UTC+0100), Bruce Richardson: > On Fri, Aug 11, 2023 at 11:24:44AM -0700, Tyler Retzlaff wrote: > > Detect when MSVC toolset is available and tweak toolchain arguments > > where the meson build system offers no abstraction. > > > > Signed-off-by: Tyler Retzlaff > > Acked-by: Bruc

RE: [PATCH 1/6] eal: provide rte stdatomics optional atomics API

2023-08-14 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 11 August 2023 17.55 > > On Fri, Aug 11, 2023 at 11:42:12AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Friday, 11 August 2023 03.32 > > > > > > Provide API for

[PATCH v2] net/iavf: refactor part of watchdog

2023-08-14 Thread Zhichao Zeng
This commit refactors two parts of the watchdog: 1. Cancel the rte_eal_alarm when closing the watchdog to avoid ASAN heap-use-after-free error in some conditions. 2. Modify the logs when enabling and disabling the watchdog to be more detailed. Fixes: af801b0374e3 ("net/iavf: add devargs to c

  1   2   >