Re: ixgbe rxq interrupt not working

2023-03-08 Thread Rajasekhar Pulluru
Hi Stephen, ixgbe interfaces works correctly when not used with dpdk. # cat /proc/interrupts | grep enp2s0f1 109:436 0 0 0 IR-PCI-MSI 1050624-edge enp2s0f1-TxRx-0 110: 0167 0 0 IR-PCI-MSI 1050625-edge enp2s0f1-TxRx-1 11

Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf

2023-03-08 Thread Thomas Monjalon
09/03/2023 02:43, fengchengwen: > On 2023/3/7 0:13, Thomas Monjalon wrote: > > --- a/doc/guides/rel_notes/release_22_11.rst > > +++ b/doc/guides/rel_notes/release_22_11.rst > > @@ -504,7 +504,7 @@ ABI Changes > >``rte-worker-`` so that DPDK can accommodate lcores higher > > than 99. > > > >

Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq

2023-03-08 Thread Dongdong Liu
Hi Jie On 2023/1/31 10:58, Jie Hai wrote: Currently the l3fwd-power only supports ACPI cpufreq and Pstate cpufreq, This patch adds CPPC cpufreq. Signed-off-by: Jie Hai Looks good, so Acked-by: Dongdong Liu Thanks, Dongdong --- examples/l3fwd-power/main.c | 9 ++--- 1 file changed, 6

[dpdk-dev] [PATCH] doc: deprecation notice to remove LiquidIO ethdev driver

2023-03-08 Thread jerinj
From: Jerin Jacob The LiquidIO product line(drivers/net/liquidio) has been substituted with CN9K/CN10K OCTEON product line smart NICs located in drivers/net/octeon_ep/. DPDK v20.08 has categorized the LiquidIO driver as UNMAINTAINED because of the absence of updates in the driver. Due to the abov

RE: [PATCH v2 2/2] vhost: refactor to follow new naming convention

2023-03-08 Thread Xia, Chenbo
> -Original Message- > From: Nobuhiro MIKI > Sent: Thursday, March 9, 2023 1:17 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; step...@networkplumber.org; Nobuhiro MIKI corp.jp> > Subject: [PATCH v2 2/2] vhost: refactor to follow new naming convention > > Simply re

RE: [PATCH v2 1/2] vhost: fix constants to follow new naming convention

2023-03-08 Thread Xia, Chenbo
> -Original Message- > From: Nobuhiro MIKI > Sent: Thursday, March 9, 2023 1:17 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; step...@networkplumber.org; Nobuhiro MIKI corp.jp> > Subject: [PATCH v2 1/2] vhost: fix constants to follow new naming > convention > > DP

[PATCH v2 2/2] vhost: refactor to follow new naming convention

2023-03-08 Thread Nobuhiro MIKI
Simply replace 'master' with 'frontend' and 'slave' with 'backend'. Signed-off-by: Nobuhiro MIKI Acked-by: Stephen Hemminger --- drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- lib/vhost/rte_vhost.h | 8 ++-- lib/vhost/version.map | 2 +- lib/vhost/vhost.c | 4 +- lib/vhos

[PATCH v2 0/2] vhost: fix names to follow new naming convention

2023-03-08 Thread Nobuhiro MIKI
In this series, we simply replace 'master' with 'frontend' and 'slave' with 'backend' so that vhost user protocol message, protocol names follow the new naming conventions. v2: - Update .mailmap in patch 1 - Replace 'master' with 'frontend' in patch 2 Nobuhiro MIKI (2): vhost: fix constants to

[PATCH v2 1/2] vhost: fix constants to follow new naming convention

2023-03-08 Thread Nobuhiro MIKI
DPDK apps (e.g. dpdk-skeleton) output this name during negotiation. But, it is not consistent when debugging using QEMU as a front-end, for example. This is because QEMU already follows new naming convention [1]. Some type names and variable names, such as VhostUserSlaveRequest, are still in old n

[PATCH 4/4] mempool: use lcore API to check if lcore ID is valid

2023-03-08 Thread Honnappa Nagarahalli
Use lcore API to check if the lcore ID is valid. The runtime check does not add much value. Hence use assert to validate the lcore ID. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Wathsala Vithanage Reviewed-by: Ruifeng Wang --- lib/mempool/rte_mempool.h | 5 ++--- 1 file changed, 2 insert

[PATCH 3/4] eal: add API to check if lcore id is valid

2023-03-08 Thread Honnappa Nagarahalli
Simple API to check if the lcore ID does not exceed the maximum number of lcores configured. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- lib/eal/include/rte_lcore.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/in

[PATCH 2/4] mempool: clarify comments for mempool cache implementation

2023-03-08 Thread Honnappa Nagarahalli
Clarify that the mempool cache create and free API implementations work on user owned mempool caches. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang --- lib/mempool/rte_mempool.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

[PATCH 1/4] mempool: clarify mempool cache flush API behavior

2023-03-08 Thread Honnappa Nagarahalli
Clarify that mempool cache flush API works with default mempool cache. It is applications responsibility to validate that the cache belongs to the specified mempool. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang --- lib/mempool/rte_mempool.h |

[PATCH 0/4] Small corrections in mempool

2023-03-08 Thread Honnappa Nagarahalli
1) Patches 1/4, 2/4 - Few small corrections in mempool API documentation. 2) Patch 3/4 - The API for checking 'lcore ID is valid' is trivial, but it is the right thing to do. 3) Patch 4/4 - IMO, the 'lcore ID is valid' check is not necessary to be done during run time. If it is not valid, the

Re: [PATCH 2/2] vhost: refactor to follow new naming convention

2023-03-08 Thread Nobuhiro MIKI
On 2023/03/09 12:03, Xia, Chenbo wrote: > Hi Nobuhiro, > > Thanks for the work, check comments inline. > >> -Original Message- >> From: Nobuhiro MIKI >> Sent: Thursday, March 9, 2023 10:07 AM >> To: maxime.coque...@redhat.com; Xia, Chenbo >> Cc: dev@dpdk.org; Nobuhiro MIKI >> Subject:

[PATCH 2/2] net/sfc: fix resetting mark in tunnel offload switch rules

2023-03-08 Thread Ivan Malov
The currently used API is unfit for the purpose as it checks the order in which the action is being added. Use a dedicated API to request the reset. Fixes: 012bf708c20f ("net/sfc: support group flows in tunnel offload") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton ---

[PATCH 1/2] common/sfc_efx/base: allow to request MAE mark reset action

2023-03-08 Thread Ivan Malov
Previously, DPDK sfc driver received support for tunnel offload. In it, MAE needs to set intermediate mark from an outer rule (OR) recirculation ID in order to help the driver identify packets that hit the OR but miss on action rule (AR) lookup. But, for packets that do hit an AR, the driver wants

[PATCH 1/1] net/sfc: stop misuse of Rx ingress m-port metadata on EF100

2023-03-08 Thread Ivan Malov
The driver supports representor functionality. In it, packets coming from VFs to the dedicated back-end Rx queue get demultiplexed into front-end Rx queues of representor ethdevs as per the per-packet metadata indicating logical HW ingress ports. On transmit, packets are provided with symmetrical m

[PATCH] net/idpf: fix a compiler issue about virtchnl opcode

2023-03-08 Thread Mingxia Liu
Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed with virtchnl2 or VIRTCHNL2. Fixes: 78049b3dc7e6 ("net/idpf: add alarm to handle virtual channel me

[PATCH v1 2/2] test/bbdev: fix unchecked ret value issue

2023-03-08 Thread Hernan Vargas
Add check for return value from get_bbdev_queue_stats. Coverity issue: 383155 Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) di

[PATCH v1 0/2] test-bbdev coverity fixes

2023-03-08 Thread Hernan Vargas
Fixes for coverity issues 383647, 383155. Hernan Vargas (2): test/bbdev: fix possible div by zero issue test/bbdev: fix unchecked ret value issue app/test-bbdev/test_bbdev_perf.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.37.1

[PATCH v1 1/2] test/bbdev: fix possible div by zero issue

2023-03-08 Thread Hernan Vargas
Add extra check at function level to ensure num_ops cannot be 0. Coverity issue: 383647 Fixes: f0d288bca467 ("test/bbdev: add support for BLER for 4G") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app

RE: [PATCH 1/2] vhost: fix constants to follow new naming convension

2023-03-08 Thread Xia, Chenbo
> -Original Message- > From: Nobuhiro MIKI > Sent: Thursday, March 9, 2023 10:07 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Nobuhiro MIKI > Subject: [PATCH 1/2] vhost: fix constants to follow new naming convension > > DPDK apps (e.g. dpdk-skeleton) output this

RE: [PATCH 2/2] vhost: refactor to follow new naming convention

2023-03-08 Thread Xia, Chenbo
Hi Nobuhiro, Thanks for the work, check comments inline. > -Original Message- > From: Nobuhiro MIKI > Sent: Thursday, March 9, 2023 10:07 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Nobuhiro MIKI > Subject: [PATCH 2/2] vhost: refactor to follow new naming conve

RE: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode

2023-03-08 Thread Liu, Mingxia
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, March 9, 2023 10:42 AM > To: Liu, Mingxia > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Yuying > > Subject: Re: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode > > On Thu, 9 Mar 2023 10:31:42 + > Mingxia L

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-08 Thread Honnappa Nagarahalli
> -Original Message- > From: fengchengwen > Sent: Wednesday, March 8, 2023 7:00 PM > To: Honnappa Nagarahalli ; Konstantin > Ananyev ; dev@dpdk.org; > tho...@monjalon.net; Ferruh Yigit ; Andrew > Rybchenko ; Kalesh AP anakkur.pura...@broadcom.com>; Ajit Khaparde > (ajit.khapa...@broadco

RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms

2023-03-08 Thread Honnappa Nagarahalli
> -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, March 7, 2023 10:08 AM > To: Honnappa Nagarahalli ; dev@dpdk.org; > Ruifeng Wang ; Matan Azrad ; > Shahaf Shuler > Cc: nd ; Matan Azrad ; sta...@dpdk.org; > nd > Subject: RE: [PATCH v2] net/mlx5: use just sufficient barrier

Re: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode

2023-03-08 Thread Stephen Hemminger
On Thu, 9 Mar 2023 10:31:42 + Mingxia Liu wrote: > iff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c > index db58157ba3..59883af8a8 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -1058,8 +1058,8 @@ idpf_handle_virtchnl_msg(

Re: [PATCH 0/2] vhost: fix names to follow new naming convention

2023-03-08 Thread Stephen Hemminger
On Thu, 9 Mar 2023 11:07:19 +0900 Nobuhiro MIKI wrote: > In this series, we simply replace '_slave_' with '_backend_' so that > vhost user protocol message, protocol names follow the new naming > conventions. > > Nobuhiro Miki (2): > vhost: fix constants to follow new naming convension > vh

[PATCH v3] net/mlx5: use just sufficient barrier for ARM platforms

2023-03-08 Thread Honnappa Nagarahalli
cqe->op_own indicates if the CQE is owned by the NIC. The rest of the fields in CQE should be read only after op_own is read. On Arm platforms using "dmb ishld" is sufficient to enforce this. Fixes: 88c0733535d6 ("net/mlx5: extend Rx completion with error handling") Cc: ma...@mellanox.com Cc: sta.

[PATCH v2] net/cpfl: fix a compiler issue about virtchnl opcode

2023-03-08 Thread Mingxia Liu
Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed with virtchnl2 or VIRTCHNL2. Fixes: 20618563b81b ("net/cpfl: support device initialization") Signe

[PATCH] net/cpfl: fix a compiler issue about virtchnl opcode

2023-03-08 Thread Mingxia Liu
Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed with virtchnl2 or VIRTCHNL2. Fixes: 20618563b81b ("net/cpfl: support device initialization") Signe

[PATCH 1/2] vhost: fix constants to follow new naming convension

2023-03-08 Thread Nobuhiro MIKI
DPDK apps (e.g. dpdk-skeleton) output this name during negotiation. But, it is not consistent when debugging using QEMU as a front-end, for example. This is because QEMU already follows new naming convention [1]. Some type names and variable names, such as VhostUserSlaveRequest, are still in old n

[PATCH 0/2] vhost: fix names to follow new naming convention

2023-03-08 Thread Nobuhiro MIKI
In this series, we simply replace '_slave_' with '_backend_' so that vhost user protocol message, protocol names follow the new naming conventions. Nobuhiro Miki (2): vhost: fix constants to follow new naming convension vhost: refactor to follow new naming convention drivers/vdpa/ifc/ifcvf_v

[PATCH 2/2] vhost: refactor to follow new naming convention

2023-03-08 Thread Nobuhiro MIKI
Simply replace '_slave_' with '_backend_'. Signed-off-by: Nobuhiro MIKI --- drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- lib/vhost/rte_vhost.h | 2 +- lib/vhost/version.map | 2 +- lib/vhost/vhost.c | 4 +-- lib/vhost/vhost.h | 4 +-- lib/vhost/vhost_user.c

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-08 Thread Ajit Khaparde
On Tue, Mar 7, 2023 at 4:40 AM Konstantin Ananyev wrote: > > > > > >>> In the proactive error handling mode, the PMD will set the data > > >>> path > > >>> pointers to dummy functions and then try recovery, in this > > >>> period the > > >>> application ma

RE: [PATCH v5] enhance NUMA affinity heuristic

2023-03-08 Thread You, KaisenX
> -Original Message- > From: Thomas Monjalon > Sent: 2023年3月3日 22:07 > To: Burakov, Anatoly ; You, KaisenX > > Cc: dev@dpdk.org; Zhou, YidingX ; > david.march...@redhat.com; Matz, Olivier ; > ferruh.yi...@amd.com; zhou...@loongson.cn; sta...@dpdk.org; > Richardson, Bruce ; jer...@marve

Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf

2023-03-08 Thread fengchengwen
On 2023/3/7 0:13, Thomas Monjalon wrote: > The impact of the option "enable_iova_as_pa" is explained for users. > > Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF" > in order to be more accurate (IOVA mode is decided at runtime), > and more readable in the code. > > Similarly

RE: [PATCH v9 01/21] net/cpfl: support device initialization

2023-03-08 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, March 7, 2023 11:03 PM > To: Liu, Mingxia ; Xing, Beilei > ; > Zhang, Yuying ; Raslan Darawsheh > > Cc: dev@dpdk.org; Stephen Hemminger ; > Richardson, Bruce ; Zhang, Qi Z > > Subject: Re: [PATCH v9 01/21] net/cpfl: support de

RE: [PATCH v9 01/21] net/cpfl: support device initialization

2023-03-08 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 9, 2023 1:04 AM > To: Liu, Mingxia ; Xing, Beilei > ; > Zhang, Yuying ; Zhang, Qi Z > Cc: dev@dpdk.org; Stephen Hemminger ; > Richardson, Bruce ; Raslan Darawsheh > > Subject: Re: [PATCH v9 01/21] net/cpfl: support devi

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-08 Thread fengchengwen
On 2023/3/8 9:09, Honnappa Nagarahalli wrote: > > >>> > > Is there any reason not to design this in the same way as 'rte_eth_dev_reset'? Why does the PMD have to recover by itself? I suppose it is a question for the authors of original patch... >>> Appreciate if the

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-08 Thread fengchengwen
On 2023/3/8 10:03, Stephen Hemminger wrote: > On Wed, 8 Mar 2023 08:36:48 +0800 > fengchengwen wrote: > >> On 2023/3/8 0:06, Stephen Hemminger wrote: >>> On Tue, 7 Mar 2023 17:35:32 +0800 >>> fengchengwen wrote: >>> The syslog will add timestamp, but the syslog backend will re-write >>>

Re: release candidate 23.03-rc1

2023-03-08 Thread Thinh Tran
Hi IBM - Power Systems DPDK v23.03-rc1-11 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. Systems tested: - IBM Power9 PowerNV 9006-22P OS: RHEL 8.3 GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) NICs: - Mellanox Technologies MT28800 F

RE: [PATCH v2] test: add cryptodev crosscheck suite

2023-03-08 Thread Power, Ciara
> -Original Message- > From: Power, Ciara > Sent: Wednesday 8 March 2023 17:31 > To: Volodymyr Fialko ; dev@dpdk.org; Akhil Goyal > ; Fan Zhang > Cc: jer...@marvell.com; ano...@marvell.com; hemant.agra...@nxp.com; Ji, > Kai > Subject: RE: [PATCH v2] test: add cryptodev crosscheck suite

Re: ixgbe rxq interrupt not working

2023-03-08 Thread Stephen Hemminger
On Wed, 8 Mar 2023 22:54:12 +0530 Rajasekhar Pulluru wrote: > No Honnappa. > > Thanks & Regards, > Rajasekhar > > On Wed, Mar 8, 2023 at 5:49 AM Honnappa Nagarahalli < > honnappa.nagaraha...@arm.com> wrote: > > > > > > > From: Rajasekhar Pulluru > > Sent: Tuesday, March 7, 2023 12:52 PM > >

RE: [PATCH v2] test: add cryptodev crosscheck suite

2023-03-08 Thread Power, Ciara
Hi Volodymyr, > -Original Message- > From: Volodymyr Fialko > Sent: Thursday 9 February 2023 12:34 > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: jer...@marvell.com; ano...@marvell.com; hemant.agra...@nxp.com; Ji, > Kai ; Power, Ciara ; Volodymyr > Fialko > Subject: [PATCH v2] tes

Re: ixgbe rxq interrupt not working

2023-03-08 Thread Rajasekhar Pulluru
No Honnappa. Thanks & Regards, Rajasekhar On Wed, Mar 8, 2023 at 5:49 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > From: Rajasekhar Pulluru > Sent: Tuesday, March 7, 2023 12:52 PM > To: dev@dpdk.org > Subject: ixgbe rxq interrupt not working > > Hi Team, > > Bringing-up

Re: ixgbe rxq interrupt not working

2023-03-08 Thread Rajasekhar Pulluru
Hi Stephen, Downloaded https://fast.dpdk.org/rel/dpdk-22.11.1.tar.xz, built and linked with the application. Still don't get rxq interrupt of ixgbe ports. EAL: Detected CPU lcores: 4 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_so

Re: [PATCH v9 01/21] net/cpfl: support device initialization

2023-03-08 Thread Ferruh Yigit
On 3/7/2023 3:03 PM, Ferruh Yigit wrote: > On 3/7/2023 2:11 PM, Ferruh Yigit wrote: >> On 3/2/2023 9:20 PM, Mingxia Liu wrote: >>> Support device init and add the following dev ops: >>> - dev_configure >>> - dev_close >>> - dev_infos_get >>> - link_update >>> - dev_supported_ptypes_get >>> >>>

[PATCH v2 5/5] mlx5dr: Definer, translate RTE quota item

2023-03-08 Thread Gregory Etelson
MLX5 PMD implements QUOTA with Meter object. PMD Quota action translation implicitly increments Meter register value after HW assigns it. Meter register values are: HW QUOTA(HW+1) QUOTA state RED01 (01b) BLOCK YELLOW 12 (10b) PASS GREEN 2

[PATCH v2 4/5] net/mlx5: add indirect QUOTA create/query/modify

2023-03-08 Thread Gregory Etelson
Implement HWS functions for indirect QUOTA creation, modification and query. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5.h | 72 +++ drivers/net/mlx5/mlx5_flow.c | 62 ++ drivers/net/mlx5/mlx5_flow.h | 20 +- driv

[PATCH v2 2/5] net/mlx5: remove code duplication

2023-03-08 Thread Gregory Etelson
Replace duplicated code with dedicated functions Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5.h | 6 +- drivers/net/mlx5/mlx5_flow_hw.c | 182 2 files changed, 95 insertions(+), 93 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers

[PATCH v2 1/5] net/mlx5: update query fields in async job structure

2023-03-08 Thread Gregory Etelson
Query fields defined in `mlx5_hw_q_job` target CT type only. The patch updates `mlx5_hw_q_job` for other query types as well. Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5.h | 10 +- drivers/net/mlx5/mlx5_flow_aso.c | 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 +++--

[PATCH v2 3/5] common/mlx5: update MTR ASO definitions

2023-03-08 Thread Gregory Etelson
Update MTR ASO definitions for QUOTA flow action. Quota flow action requires WQE READ capability and access to token fields. Signed-off-by: Gregory Etelson --- drivers/common/mlx5/mlx5_prm.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/m

[PATCH v2 0/5] net/mlx5: add indirect QUOTA create/query/modify

2023-03-08 Thread Gregory Etelson
Add indirect quota flow action. Add match on quota flow item. v2: rebase to the latest main branch. Gregory Etelson (5): net/mlx5: update query fields in async job structure net/mlx5: remove code duplication common/mlx5: update MTR ASO definitions net/mlx5: add indirect QUOTA create/query

Re: [PATCH] net/nfp: fix MTU configuration order

2023-03-08 Thread Ferruh Yigit
On 3/8/2023 2:33 AM, Chaoyong He wrote: > From: Peng Zhang > > If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the > NFP driver setup fails. This is because the default values evaluated > when setting the MTU are initialized in the rte_eth_rx_queue_setup() > code path. Fix this

[dpdk-dev v1] crypto/openssl: fix of ASAN heap-use-after-free

2023-03-08 Thread Kai Ji
fix of ASAN report on heap-use-after-free error on tmp buffer. Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Cc: kai...@intel.com Signed-off-by: Kai Ji --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

RE: [PATCH] examples/qos_sched: fix buffer overflow on mbuf free

2023-03-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, March 8, 2023 2:09 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Ajmera, Megha > ; Dumitrescu, Cristian > > Subject: [PATCH] examples/qos_sched: fix buffer overflow on mbuf free > > When running the qos_sched app with

[PATCH] examples/qos_sched: fix buffer overflow on mbuf free

2023-03-08 Thread Bruce Richardson
When running the qos_sched app with separated worker and Tx threads, the app would seg-fault after a short time of handling packets. The root cause of this turns out to be an incorrect array index when freeing unsent packets post-Tx. Rather than freeing packets using the "nb_tx" value i.e. where tr

RE: [PATCH v3 0/2] net/mlx5: support MPLSoUDP for HWS

2023-03-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Thursday, February 23, 2023 9:48 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v3 0/2] net/mlx5: support MPLSoUDP for HWS > > Add support for matching/encap/decap MPLSoUDP including

[PATCH 2/2] crypto/qat: added cipher-crc cap check

2023-03-08 Thread Kevin O'Sullivan
A configuration item called qat_sym_cipher_crc_enable has been added. When set, an LA bulk req message with combined cipher-crc will be sent on startup to the QAT device. The response is checked to see if the data returned matches the cipher text. If a match is determined the cipher-crc capability

[PATCH 1/2] crypto/qat: added cipher-crc offload support

2023-03-08 Thread Kevin O'Sullivan
Functionality has been added to the QAT PMD to use the combined cipher-crc offload feature on the gen1/gen2/gen3 QAT devices by setting the CRC content descriptor accordingly. Signed-off-by: Kevin O'Sullivan Signed-off-by: David Coyle --- drivers/common/qat/qat_adf/icp_qat_fw.h| 1 - driv

[PATCH 0/2] crypto/qat: added cipher-crc offload feature

2023-03-08 Thread Kevin O'Sullivan
This patchset adds support to the QAT PMD for combined cipher-crc processing on the QAT device. The current QAT PMD implementation of cipher-crc calculates CRC in software and uses QAT for encryption/decryption offload. Note: The code-path is still retained for QAT versions without support for com

Re: [PATCH 2/2] net/mana: enable driver by default

2023-03-08 Thread Thomas Monjalon
20/01/2023 03:19, lon...@linuxonhyperv.com: > From: Long Li > > The dependencies of mana have been released in rdma-core v44 and Linux > kernel 6.2. > > Signed-off-by: Long Li I'm squashing this patch with the previous one, including the backport request. I consider it is allowed to enable a d

RE: [PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12

2023-03-08 Thread Tal Shnaiderman
> Subject: Re: [PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12 > > External email: Use caution opening links or attachments > > > On Thu, Mar 02, 2023 at 02:21:50PM +0100, Thomas Monjalon wrote: > > With recent changes in Meson and MinGW toolchain, the driver mlx5 was > > not able t

RE: [PATCH v3 2/3] net/mlx5: remove weak stub functions

2023-03-08 Thread Tal Shnaiderman
> Subject: Re: [PATCH v3 2/3] net/mlx5: remove weak stub functions > > External email: Use caution opening links or attachments > > > On Thu, Mar 02, 2023 at 02:21:49PM +0100, Thomas Monjalon wrote: > > The vector Rx functions are conditionally compiled. > > Some stub functions were also always

RE: [PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-08 Thread Tal Shnaiderman
> Subject: [PATCH v3 1/3] common/mlx5: get Windows dependency from > standard variables > > External email: Use caution opening links or attachments > > > The DevX library path had to be provided through the variables > DEVX_INC_PATH and DEVX_LIB_PATH. > It was non-standard and triggers some iss

Re: [PATCH v4] app/testpmd: fix secondary process not forwarding

2023-03-08 Thread Ferruh Yigit
On 3/8/2023 4:19 PM, Shiyang He wrote: > Under multi-process scenario, the secondary process gets queue state > from the wrong location (the global variable 'ports'). Therefore, the > secondary process can not forward since "stream_init" is not called. > > This commit fixes the issue by calling 'r

Re: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-08 Thread Ferruh Yigit
On 3/8/2023 2:54 AM, lihuisong (C) wrote: > > 在 2023/3/8 10:05, He, ShiyangX 写道: >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Tuesday, March 7, 2023 7:41 PM >>> To: He, ShiyangX ; dev@dpdk.org >>> Cc: Zhou, YidingX ; sta...@dpdk.org; Zhang, >>> Yuying >>> ; Singh, Aman Deep

Re: [PATCH v2 1/1] drivers: remove implementation of Rx metadata negotiation

2023-03-08 Thread Jerin Jacob
On Tue, Mar 7, 2023 at 4:16 PM Hanumanth Pothula wrote: > > Presently, Rx metadata is sent to PMD by default, leading > to a performance drop as processing for the same in Rx path > takes extra cycles. > > Hence, removing driver implementation of Rx metadata negotiation > and falling back to old i

[PATCH v4] app/testpmd: fix secondary process not forwarding

2023-03-08 Thread Shiyang He
Under multi-process scenario, the secondary process gets queue state from the wrong location (the global variable 'ports'). Therefore, the secondary process can not forward since "stream_init" is not called. This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get' to get queue state f

Re: [PATCH] net/nfp: fix MTU configuration order

2023-03-08 Thread Niklas Söderlund
Hi Stephen, Thanks for your feedback. On 2023-03-07 18:44:09 -0800, Stephen Hemminger wrote: > On Wed, 8 Mar 2023 10:33:18 +0800 > Chaoyong He wrote: > > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > > index 5922bfea8e..5d92b476e2 100644 > > --- a/drivers/net/nfp