On 2023/03/09 12:03, Xia, Chenbo wrote:
> Hi Nobuhiro,
>
> Thanks for the work, check comments inline.
>
>> -----Original Message-----
>> From: Nobuhiro MIKI <nm...@yahoo-corp.jp>
>> Sent: Thursday, March 9, 2023 10:07 AM
>> To: maxime.coque...@redhat.com; Xia, Chenbo <chenbo....@intel.com>
>> Cc: dev@dpdk.org; Nobuhiro MIKI <nm...@yahoo-corp.jp>
>> Subject: [PATCH 2/2] vhost: refactor to follow new naming convention
>>
>> Simply replace '_slave_' with '_backend_'.
>>
>> Signed-off-by: Nobuhiro MIKI <nm...@yahoo-corp.jp>
>> ---
>> drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
>> lib/vhost/rte_vhost.h | 2 +-
>> lib/vhost/version.map | 2 +-
>> lib/vhost/vhost.c | 4 +--
>> lib/vhost/vhost.h | 4 +--
>> lib/vhost/vhost_user.c | 62 +++++++++++++++++------------------
>> lib/vhost/vhost_user.h | 6 ++--
>> 7 files changed, 41 insertions(+), 41 deletions(-)
>>
>> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
>> index fe4d278c5380..e4133568c1aa 100644
>> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
>> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
>> @@ -605,7 +605,7 @@ virtio_interrupt_handler(struct ifcvf_internal
>> *internal)
>
> ...
>
>>
>> typedef struct VhostUserMemoryRegion {
>> uint64_t guest_phys_addr;
>> @@ -137,7 +137,7 @@ struct vhost_user_config {
>> typedef struct VhostUserMsg {
>> union {
>> uint32_t master; /* a VhostUserRequest value */
>> - uint32_t slave; /* a VhostUserSlaveRequest value*/
>> + uint32_t backend; /* a VhostUserBackendRequest value*/
>
> I think we should rename the master to front-end too (as QEMU spec says)
>
> If you can also replace all the 'masters' with front-end too, we will
> appreciate
> that much..
>
> BTW, I guess this is your first patch, you need to update .mailmap file with
> your
> name and email address.
Hi Chenbo,
Thanks for your review.
I will fix them in v2.
Best Regards,
Nobuhiro MIKI
