> Subject: Re: [PATCH v3 2/3] net/mlx5: remove weak stub functions > > External email: Use caution opening links or attachments > > > On Thu, Mar 02, 2023 at 02:21:49PM +0100, Thomas Monjalon wrote: > > The vector Rx functions are conditionally compiled. > > Some stub functions were also always compiled with weak attribute. > > If there is no vector support, the weak functions were linked. > > > > These weak functions are moved in a specific file which is compiled > > only if there is no vector support. > > This way it is simpler to understand, > > and the weak attributes can be removed. > > > > This change helps to compile with MinGW GCC which has no support for > > weak functions. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > --- > > Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
Acked-by: Tal Shnaiderman <tal...@nvidia.com>