Re: [PATCH v1 1/1] drivers: remove implementation of Rx metadata negotiation

2023-03-06 Thread Jerin Jacob
On Mon, Mar 6, 2023 at 5:39 PM Hanumanth Pothula wrote: > > Presently, Rx metadata is sent to PMD by default, leading > to a performance drop as processing for the same in Rx path > takes extra cycles. > > Hence, removing driver implementation of Rx metadata negotiation > and falling back to old i

RE: [PATCH v3 0/2] Add option to timestamp console log

2023-03-06 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 6 March 2023 20.28 > > This is a reprise of earlier patch to add timestamp to console > messages. > > Example: > # dpdk-testpmd -l 1-4 -n 4 --vdev net_null0 --log-timestamp -- -i > EAL: Detected CPU lcores: 16 > EAL: De

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-06 Thread Honnappa Nagarahalli
> > On 3/6/2023 1:26 PM, Morten Brørup wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > >> Sent: Monday, 6 March 2023 13.49 > >> > >> On 1/4/2023 8:21 AM, Morten Brørup wrote: > From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Wednesday, 4 January 2023 08.31 >

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Honnappa Nagarahalli
> -Original Message- > From: Konstantin Ananyev > Sent: Sunday, March 5, 2023 9:24 AM > To: Honnappa Nagarahalli ; > dev@dpdk.org; Chengwen Feng ; > tho...@monjalon.net; Ferruh Yigit ; Andrew > Rybchenko ; Kalesh AP anakkur.pura...@broadcom.com>; Ajit Khaparde > (ajit.khapa...@broadcom.

[PATCH v2] net/iavf: fix iavf query stats in intr thread

2023-03-06 Thread Kaiwen Deng
When iavf send query-stats command in eal-intr-thread through virtual channel, there will be no response received from iavf_dev_virtchnl_handler for this command during block and wait. Because iavf_dev_virtchnl_handler is also registered in eal-intr-thread. When vf device is bonded as BONDING_MODE

RE: [PATCH] net/iavf: fix iavf query stats in intr thread

2023-03-06 Thread Deng, KaiwenX
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, February 27, 2023 8:56 AM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Wu, Jingjing ; Xing, > Beilei > Subject: RE: [PATCH] net/iavf: fix iavf query stats in intr thread > > > > >

RE: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-06 Thread He, ShiyangX
>-Original Message- >From: Ferruh Yigit >Sent: Monday, March 6, 2023 11:06 PM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; sta...@dpdk.org; Zhang, Yuying >; Singh, Aman Deep >; Burakov, Anatoly >; Matan Azrad ; Dmitry >Kozlyuk >Subject: Re: [PATCH v3] app/testpmd: fix secondary

RE: [PATCH v7] net/i40e: fix max frame size configuration

2023-03-06 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, March 6, 2023 8:19 PM > To: Xing, Beilei ; Zhang, Yuying > ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; > david.march...@redhat.com; Su, Simei ; > sta...@dpdk.org > Subject: [PATCH v7] net/i40e: fix max frame size configuration

RE: [PATCH v2 2/3] examples/l3fwd: removed hash entry number

2023-03-06 Thread Ruifeng Wang
> -Original Message- > From: Kamalakshitha Aligeri > Sent: Tuesday, March 7, 2023 12:25 AM > To: jer...@marvell.com; tho...@monjalon.net; david.march...@redhat.com; > sean.morris...@intel.com; konstantin.anan...@huawei.com; Ruifeng Wang > ; Honnappa Nagarahalli > Cc: dev@dpdk.org; nd > S

Re: [PATCH v3] log: add timestamp for log

2023-03-06 Thread Stephen Hemminger
On Mon, 6 Mar 2023 13:00:17 -0800 Tyler Retzlaff wrote: > On Sat, Mar 04, 2023 at 08:04:41AM -0800, Stephen Hemminger wrote: > > On Sat, 4 Mar 2023 16:14:21 +0800 > > luzhipeng wrote: > > > > > From: Zhipeng Lu > > > > > > add timestamp for log > > > > > > Signed-off-by: Zhipeng Lu > >

Re: [PATCH v4 9/9] table: enable build on Windows

2023-03-06 Thread Tyler Retzlaff
On Sun, Feb 19, 2023 at 03:14:16PM -0800, Stephen Hemminger wrote: > There doesn't seem to be anything keeping this from building on Windows. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff this series looks good to me, i see no barrier to having it merged?

Re: [PATCH v3] log: add timestamp for log

2023-03-06 Thread Tyler Retzlaff
On Sat, Mar 04, 2023 at 08:04:41AM -0800, Stephen Hemminger wrote: > On Sat, 4 Mar 2023 16:14:21 +0800 > luzhipeng wrote: > > > From: Zhipeng Lu > > > > add timestamp for log > > > > Signed-off-by: Zhipeng Lu > > Good idea but: > - it needs to be optional > - timestamp only makes sense

Re: [PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-06 Thread Tyler Retzlaff
On Mon, Mar 06, 2023 at 09:30:00AM +0100, Thomas Monjalon wrote: > 03/03/2023 22:09, Tyler Retzlaff: > > On Fri, Mar 03, 2023 at 03:12:19PM +0100, Thomas Monjalon wrote: > > > 02/03/2023 18:17, Tyler Retzlaff: > > > > On Thu, Mar 02, 2023 at 02:21:48PM +0100, Thomas Monjalon wrote: > > > > > The De

Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf

2023-03-06 Thread Thomas Monjalon
06/03/2023 17:39, Bruce Richardson: > On Mon, Mar 06, 2023 at 05:13:27PM +0100, Thomas Monjalon wrote: > > -if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not > > pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path) > > +if not get_option('enable_iova_as_pa

Re: [PATCH v2 1/2] doc: make the Linux drivers doc more generic

2023-03-06 Thread Thomas Monjalon
06/03/2023 18:41, Chautru, Nicolas: > Hi Thomas, > > Any update with regards to that series? Unsure how much more you want it to > become generic. Ie. replacing most of "network port" by "PCIe device" Devices are not always PCI based. The doc should reviewed entirely to make sure it is not rest

[PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-06 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. The timestamp format is chosen to look like the default Linux dmesg timestamp. Example: [ 0.00

[PATCH v3 1/2] eal: unify logging code for FreeBsd and Linux

2023-03-06 Thread Stephen Hemminger
FreeBSD logging code was not using syslog and did not have the same options as Linux. Move the log writing code to common tree. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 7 +++ lib/eal/linux/meson.build | 1 - lib/eal/{linux => unix}/eal_log.c | 0 lib/

[PATCH v3 0/2] Add option to timestamp console log

2023-03-06 Thread Stephen Hemminger
This is a reprise of earlier patch to add timestamp to console messages. Example: # dpdk-testpmd -l 1-4 -n 4 --vdev net_null0 --log-timestamp -- -i EAL: Detected CPU lcores: 16 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EA

[PATCH v2 2/2] eal: add option to put timestamp on console output

2023-03-06 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. The timestamp format was chosen to be the same as the default Linux dmesg timestamp. The messages ar

[PATCH v2 1/2] eal: unify logging code for FreeBsd and Linux

2023-03-06 Thread Stephen Hemminger
FreeBSD logging code was not using syslog and did not have the same options as Linux. Move the log writing code to common tree. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 6 ++ lib/eal/linux/meson.build | 1 - lib/eal/{linux => unix}/eal_log.c | 0 lib/e

[PATCH v2 0/2] Add option to timestamp console log

2023-03-06 Thread Stephen Hemminger
This is a reprise of earlier patch to add timestamp to console messages. Example: # dpdk-testpmd -l 1-4 -n 4 --vdev net_null0 --log-timestamp -- -i EAL: Detected CPU lcores: 16 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EA

RE: [PATCH v2 1/2] doc: make the Linux drivers doc more generic

2023-03-06 Thread Chautru, Nicolas
Hi Thomas, Any update with regards to that series? Unsure how much more you want it to become generic. Ie. replacing most of "network port" by "PCIe device" Thanks Nic > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 22, 2022 6:59 AM > To: Chautru, Nicolas > Cc:

Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf

2023-03-06 Thread Bruce Richardson
On Mon, Mar 06, 2023 at 05:13:27PM +0100, Thomas Monjalon wrote: > The impact of the option "enable_iova_as_pa" is explained for users. > > Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF" > in order to be more accurate (IOVA mode is decided at runtime), > and more readable in

RE: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf

2023-03-06 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 6 March 2023 17.13 > > The impact of the option "enable_iova_as_pa" is explained for users. > > Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF" > in order to be more accurate (IOVA mode is decided at runtime

[PATCH v2 3/3] doc/l3fwd: lpm supports IPv4 and IPv6 forwarding

2023-03-06 Thread Kamalakshitha Aligeri
LPM based lookup supports both IPv4 and IPv6 forwarding. Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") Cc: sta...@dpdk.org Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- doc/guides/sample_app_ug/l3_forward.rst | 3 +--

[PATCH v2 2/3] examples/l3fwd: removed hash entry number

2023-03-06 Thread Kamalakshitha Aligeri
hash_entry_number in l3fwd is not being used by both lpm and em lookup method. Removed the global variable hash_entry_number and the function that parses the hash-entry-number flag. Fixes: e7e6dd643092 ("examples/l3fwd: support config file for EM") Cc: sta...@dpdk.org Signed-off-by: Kamalakshitha

[PATCH v2 1/3] examples/l3fwd: validate ptype only for type of traffic sent

2023-03-06 Thread Kamalakshitha Aligeri
The check_ptype function is not considering the ptype of the incoming traffic. --parse-ptype flag must be provided only when the NIC does not support parsing the ptype of the incoming traffic Suggested-by: Nathan Brown Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by:

Re: [PATCH] doc: add gpudev to the Doxygen index

2023-03-06 Thread Thomas Monjalon
01/03/2023 17:54, Ferruh Yigit: > On 3/1/2023 4:27 PM, Thomas Monjalon wrote: > > When introducing the library gpudev, > > it has been forgotten to add a link in the API index. > > > > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library") > > Cc: sta...@dpdk.org > > > > Signed-off-by

[PATCH v2 2/2] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-06 Thread Thomas Monjalon
If IOVA as PA is disabled and the driver requires the IOVA field, the build of the driver was disabled. Unfortunately some drivers were building some sub-libraries (with specific options for vector paths) which were not disabled. The build parsing of those drivers need to be skipped earlier to avo

[PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf

2023-03-06 Thread Thomas Monjalon
The impact of the option "enable_iova_as_pa" is explained for users. Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF" in order to be more accurate (IOVA mode is decided at runtime), and more readable in the code. Similarly the drivers are using the variable "require_iova_in_mb

[PATCH v2 0/2] refactor diasbling IOVA as PA

2023-03-06 Thread Thomas Monjalon
As discussed recently in some email threads, it looks simpler to reword the feature "enabling IOVA as PA" to "requiring IOVA in mbuf". The Meson option name is not changed (compatibility is kept) but the variables are renamed. The second patch (which can be applied alone) is fixing the build when

[PATCH v3] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-06 Thread Martzki
The library libpcap has their function 'bpf_validate' either so there would be a multiple definition issue when linking with librte_bpf.a and libpcap.a statically (Same as http://dpdk.org/patch/52631). So just rename the function names to avoid such issue. Signed-off-by: Martzki --- v3: * Rewrit

[PATCH v2] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-06 Thread Martzki
Thanks for your review. In this v2 patch I renamed all functions in bpf_impl.h. Signed-off-by: Martzki --- v2: * Rename all functions in bpf_impl.h. * Adjust the commit message. --- lib/bpf/bpf.c | 6 +++--- lib/bpf/bpf_convert.c | 3 --- lib/bpf/bpf_impl.h | 10 -- l

RE: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2023-03-06 Thread Slava Ovsiienko
Hi, Martin Is this issue resolved by: http://git.dpdk.org/dpdk/commit/?id=f66323717e ? Should we archive the patch? With best regards, Slava > -Original Message- > From: Martin Havlik > Sent: среда, 21 июля 2021 г. 18:59 > To: xhavl...@stud.fit.vutbr.cz; Xiaoyun Li ; Ferruh > Yigi

RE: [PATCH 4/4] net/mlx5: define index register for linear tables

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: пятница, 27 января 2023 г. 01:41 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Ori > Kam ; Raslan Darawsheh ; Matan > Azrad ; Slava Ovsiienko > Subject: [PATCH 4/4] net/mlx5: define index register for linear tables

RE: [PATCH 3/4] net/mlx5: add hash result metadata to modify field

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: пятница, 27 января 2023 г. 01:41 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Ori > Kam ; Raslan Darawsheh ; Matan > Azrad ; Slava Ovsiienko > Subject: [PATCH 3/4] net/mlx5: add hash result metadata to modify fiel

RE: [PATCH 2/4] net/mlx5: add flow rule insertion by index

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: пятница, 27 января 2023 г. 01:41 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Ori > Kam ; Raslan Darawsheh ; Matan > Azrad ; Slava Ovsiienko > Subject: [PATCH 2/4] net/mlx5: add flow rule insertion by index > > N

Re: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-06 Thread Ferruh Yigit
On 2/23/2023 8:08 AM, lihuisong (C) wrote: > > 在 2023/2/23 22:41, Shiyang He 写道: >> Under multi-process scenario, the secondary process gets queue state >> from the wrong location (the global variable 'ports'). Therefore, the >> secondary process can not forward since "stream_init" is not called.

RE: [PATCH 1/4] net/mlx5: add table insertion type and hash function

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: пятница, 27 января 2023 г. 01:41 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Ori > Kam ; Raslan Darawsheh ; Matan > Azrad ; Slava Ovsiienko > Subject: [PATCH 1/4] net/mlx5: add table insertion type and hash funct

Re: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-06 Thread Ferruh Yigit
On 2/23/2023 2:41 PM, Shiyang He wrote: > Under multi-process scenario, the secondary process gets queue state > from the wrong location (the global variable 'ports'). Therefore, the > secondary process can not forward since "stream_init" is not called. > > This commit fixes the issue by calling '

Re: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 1:26 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Monday, 6 March 2023 13.49 >> >> On 1/4/2023 8:21 AM, Morten Brørup wrote: From: Feifei Wang [mailto:feifei.wa...@arm.com] Sent: Wednesday, 4 January 2023 08.31 Add 'tx_fill_sw

回复: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-06 Thread Feifei Wang
Hi, Morten, Ferruh Thanks very much for your reviewing. Whatever the worries about direct rearm or comments to improve direct rearm, these urge us to learn more and think more. I think it is beneficial and a good achievement for this exploration. I will update the latest version for techboard

Re: [PATCH] vhost: fix slot index in async split virtqueue Tx

2023-03-06 Thread Maxime Coquelin
On 2/23/23 03:30, Cheng Jiang wrote: The slot_idx in the asynchronous Vhost split virtqueue dequeue data path is supposed to be decreased by 1 when desc_to_mbuf() fails. Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring") Cc: sta...@dpdk.org Signed-off-by: Cheng Jiang ---

Re: [PATCH] vhost: fix OOB access for invalid vid

2023-03-06 Thread Maxime Coquelin
On 2/27/23 11:59, David Marchand wrote: The net/vhost pmd currently provides a -1 vid when disabling interrupt after a virtio port got disconnected. This can be caught when running with ASan. First, start dpdk-l3fwd-power in interrupt mode with a net/vhost port. $ ./build-clang/examples/dpd

Re: [PATCH v3] vhost: fix madvise arguments alignment

2023-03-06 Thread Maxime Coquelin
On 3/1/23 21:02, Mike Pattrick wrote: The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new member was added to rte_vhost_mem_region. A new

Re: [PATCH] vhost: fix vring enable with VDPA

2023-03-06 Thread Maxime Coquelin
On 3/2/23 10:48, David Marchand wrote: For VDPA devices, vq are not locked once the device has been configured. But we need to hold the vq lock to check if vhost async is enabled. Combining VDPA and vhost async does not seem to make much sense, so prevent this combination, and only assert the

Re: [PATCH v2] net/virtio: deduce IP length for Virtio TSO checksum

2023-03-06 Thread Maxime Coquelin
On 3/3/23 12:19, Boleslav Stankevich wrote: The length of TSO payload could not fit into 16 bits provided by the IPv4 total length and IPv6 payload length fields. Thus, deduce it from the length of the packet. Fixes: 696573046e9 ("net/virtio: support TSO") Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH v2] net/virtio: deduce IP length for Virtio TSO checksum

2023-03-06 Thread Maxime Coquelin
On 3/3/23 12:19, Boleslav Stankevich wrote: The length of TSO payload could not fit into 16 bits provided by the IPv4 total length and IPv6 payload length fields. Thus, deduce it from the length of the packet. Fixes: 696573046e9 ("net/virtio: support TSO") Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH] vhost: fix OOB access for invalid vid

2023-03-06 Thread Maxime Coquelin
On 2/27/23 11:59, David Marchand wrote: The net/vhost pmd currently provides a -1 vid when disabling interrupt after a virtio port got disconnected. This can be caught when running with ASan. First, start dpdk-l3fwd-power in interrupt mode with a net/vhost port. $ ./build-clang/examples/dpd

RE: [PATCH 4/7] mlx5: replace zero length array with flex array

2023-03-06 Thread Slava Ovsiienko
Hi, Stephen IIUC - for now all of the compilers claimed for DPDK compilation support the zero-length-array and we do not have an issue ? We could eliminate this GNU extension and have workaround, like this: /* Verbs headers do not support -pedantic. */ #ifdef PEDANTIC #pragma GCC diagnostic igno

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-06 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, 6 March 2023 13.49 > > On 1/4/2023 8:21 AM, Morten Brørup wrote: > >> From: Feifei Wang [mailto:feifei.wa...@arm.com] > >> Sent: Wednesday, 4 January 2023 08.31 > >> > >> Add 'tx_fill_sw_ring' and 'rx_flush_descriptor' API into dir

Re: [PATCH v1 1/1] doc: update to Intel vRAN Boost PMD

2023-03-06 Thread Maxime Coquelin
On 2/27/23 10:04, Maxime Coquelin wrote: On 2/24/23 19:20, Nicolas Chautru wrote: Cosmetic change to refer explictly to the full name of the PMD Fixed explictly -> explicitly Intel vRAN Boost v1. VRB1 acronym is only used as a prefix within the code. Signed-off-by: Nicolas Chautru ---

Re: [PATCH v3 00/17] test/bbdev: changes for 23.03

2023-03-06 Thread Maxime Coquelin
On 3/2/23 21:21, Hernan Vargas wrote: v3: Added new commit with enq/deq timeout implementaion. v2: Made changes requested during review. Added 3 commits. v1: Upstreaming bbdev-test changes for 23.03. Hernan Vargas (17): test/bbdev: fix seg fault for non supported HARQ len test/bbdev: ex

RE: [PATCH] common/mlx5: replace use of PMD logtype

2023-03-06 Thread Slava Ovsiienko
Hi, Stephen We have another place of using RTE_LOG in mlx5_glue_path(). Should we update this one as well ? With best regards, Slava > -Original Message- > From: Stephen Hemminger > Sent: четверг, 23 февраля 2023 г. 19:41 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Slava Ovsiienko > ;

Re: [PATCH v3 01/17] test/bbdev: fix seg fault for non supported HARQ len

2023-03-06 Thread Maxime Coquelin
On 3/2/23 21:21, Hernan Vargas wrote: Fix segmentation fault happening in corner case in test-bbdev. This fault could happen when running some specific vectors which size are not supported by the PMD. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") The Fixes tag is still wrong, th

RE: [PATCH 5/5] net/mlx5: enable enhanced CQE compression

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: вторник, 28 февраля 2023 г. 18:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH 5/5] net/mlx5: enable enhanced CQE compression > > Extend rxq_cqe_comp_en devarg to allow the Enhanced CQ

RE: [PATCH 4/5] net/mlx5: support enhanced CQE zipping in vector Rx burst

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: вторник, 28 февраля 2023 г. 18:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH 4/5] net/mlx5: support enhanced CQE zipping in vector Rx > burst > > Add Enhanced CQE compression support

RE: [PATCH 3/5] net/mlx5: support enhanced CQE compression in Rx burst

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: вторник, 28 февраля 2023 г. 18:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH 3/5] net/mlx5: support enhanced CQE compression in Rx burst > > net/mlx5: support enhanced CQE compressio

[PATCH v2] crypto/ccp: bug fixes for ccp device probe flow

2023-03-06 Thread Sunil Uttarwar
- Rebasing patch([v1] crypto/ccp: bug fixes for ccp device probe flow) Signed-off-by: Sunil Uttarwar --- drivers/crypto/ccp/rte_ccp_pmd.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index a5271d7227..5d1a4445de 10

Re: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-06 Thread Ferruh Yigit
On 1/4/2023 8:21 AM, Morten Brørup wrote: >> From: Feifei Wang [mailto:feifei.wa...@arm.com] >> Sent: Wednesday, 4 January 2023 08.31 >> >> Add 'tx_fill_sw_ring' and 'rx_flush_descriptor' API into direct rearm >> mode for separate Rx and Tx Operation. And this can support different >> multiple sour

[Bug 1173] RTE flow: non-ip packets are not delivered when RSS hash type ESP is used

2023-03-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1173 Bug ID: 1173 Summary: RTE flow: non-ip packets are not delivered when RSS hash type ESP is used Product: DPDK Version: 22.11 Hardware: x86 OS: Linux Sta

RE: [PATCH 2/5] common/mlx5: add CQE validity iteration count

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: вторник, 28 февраля 2023 г. 18:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH 2/5] common/mlx5: add CQE validity iteration count > > The validity iteration count replaces the function

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Konstantin Ananyev
> On 3/6/2023 10:32 AM, Konstantin Ananyev wrote: > > > > > >>> -Original Message- > >>> From: Ferruh Yigit > >>> Sent: Saturday, March 4, 2023 1:19 AM > >>> To: Konstantin Ananyev ; dev@dpdk.org; > >>> fengchengwen > >>> ; Konstantin Ananyev > >>> ; Honnappa > >>> Nagarahalli ; Stephe

RE: [PATCH 1/5] common/mlx5: detect enhanced CQE compression capability

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: вторник, 28 февраля 2023 г. 18:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH 1/5] common/mlx5: detect enhanced CQE compression > capability > > Enhanced CQE Compression is designed f

[PATCH v7] net/i40e: fix max frame size configuration

2023-03-06 Thread Simei Su
This patch sets max frame size at port level rather than queue level to avoid unexpected packets received by port. Fixes: 34fe803c051f ("net/i40e: don't check link status on device start") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- v7: * Split v6 patch into two parts: - David Marchand's r

[PATCH v1 1/1] drivers: remove implementation of Rx metadata negotiation

2023-03-06 Thread Hanumanth Pothula
Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in Rx path takes extra cycles. Hence, removing driver implementation of Rx metadata negotiation and falling back to old implementation where mark actions are tracked as part of the flow rule.

Re: [PATCH] app/testpmd:add vxlan txonly

2023-03-06 Thread Ferruh Yigit
On 2/18/2023 11:47 PM, Ferruh Yigit wrote: > On 2/18/2023 11:06 AM, wushaohua wrote: >> >> 在 2023/2/18 4:43, Ferruh Yigit 写道: >>> On 1/3/2023 2:30 AM, wushao...@chinatelecom.cn wrote: From: Shaohua Wu Add the vxlan packet sending module to actively send vxlan packets using a co

RE: [PATCH v2] crypto/ccp: fix PCI probing

2023-03-06 Thread Uttarwar, Sunil Prakashrao
[Public] Acked-by: Sunil Uttarwar -Original Message- From: David Marchand Sent: Thursday, March 2, 2023 5:14 PM To: dev@dpdk.org Cc: sta...@dpdk.org; Uttarwar, Sunil Prakashrao ; Somalapuram, Amaranath Subject: [PATCH v2] crypto/ccp: fix PCI probing Caution: This message originated

RE: [PATCH v2] net/mlx5: enable hint in async table

2023-03-06 Thread Slava Ovsiienko
> -Original Message- > From: Rongwei Liu > Sent: понедельник, 6 марта 2023 г. 13:37 > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH v2] net/mlx5: enable hint in async table > > Driver gets the hint value from rte_table_attr for async flow. > Parse the value and

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 10:32 AM, Konstantin Ananyev wrote: > > >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Saturday, March 4, 2023 1:19 AM >>> To: Konstantin Ananyev ; dev@dpdk.org; >>> fengchengwen >>> ; Konstantin Ananyev >>> ; Honnappa >>> Nagarahalli ; Stephen Hemminger >>> ; >>>

[PATCH v2] net/mlx5: enable hint in async table

2023-03-06 Thread Rongwei Liu
Driver gets the hint value from rte_table_attr for async flow. Parse the value and pass the supported value to hardware accordingly. Signed-off-by: Rongwei Liu --- drivers/net/mlx5/mlx5_flow_hw.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/dr

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Ajit Khaparde
On Mon, Mar 6, 2023 at 2:33 AM Konstantin Ananyev wrote: > > > > > > -Original Message- > > > From: Ferruh Yigit > > > Sent: Saturday, March 4, 2023 1:19 AM > > > To: Konstantin Ananyev ; dev@dpdk.org; > > > fengchengwen > > > ; Konstantin Ananyev > > > ; Honnappa > > > Nagarahalli ; St

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Konstantin Ananyev
> > >> In the proactive error handling mode, the PMD will set the data path > > >> pointers to dummy functions and then try recovery, in this period the > > >> application may still invoking data path API. This will introduce a > > >> race-condition with data path which may lead t

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ajit Khaparde
On Mon, Mar 6, 2023 at 3:00 AM Ferruh Yigit wrote: > > On 3/6/2023 10:22 AM, Konstantin Ananyev wrote: > > > > > >> In the proactive error handling mode, the PMD will set the data path > >> pointers to dummy functions and then try recovery, in this period the > >> application may still

RE: [PATCH v2] net/i40e: don't check link status on device start

2023-03-06 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, March 6, 2023 2:54 PM > To: David Marchand ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Yuying ; Xing, Beilei > ; Zhang, Qi Z > Subject: RE: [PATCH v2] net/i40e: don't check link status on device start > > > > > -Original Me

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 10:22 AM, Konstantin Ananyev wrote: > > >> In the proactive error handling mode, the PMD will set the data path >> pointers to dummy functions and then try recovery, in this period the >> application may still invoking data path API. This will introduce a >> race-condi

Re: [PATCH v2] net/virtio: deduce IP length for Virtio TSO checksum

2023-03-06 Thread Maxime Coquelin
On 3/6/23 07:17, Xia, Chenbo wrote: Hi Boleslav, The change seems good, but patchwork is complaining about lack of .mailmap change. http://mails.dpdk.org/archives/test-report/2023-March/363061.html Guess this is your first patch? So you need to add name and email in mailmap file. Thank

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Konstantin Ananyev
> > -Original Message- > > From: Ferruh Yigit > > Sent: Saturday, March 4, 2023 1:19 AM > > To: Konstantin Ananyev ; dev@dpdk.org; > > fengchengwen > > ; Konstantin Ananyev > > ; Honnappa > > Nagarahalli ; Stephen Hemminger > > ; > > Ruifeng Wang ; Ajit Khaparde > > (ajit.khapa...@br

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Konstantin Ananyev
> In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a > race-condition with data path which may lead to crash [1]. > >

RE: [PATCH v3 1/1] app/test-flow-perf: fix division or module by zero

2023-03-06 Thread Wisam Monther
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 20, 2023 2:52 PM > To: Mohammad Iqbal Ahmad ; dev@dpdk.org; Jack > Min ; Wisam Monther > Cc: jer...@marvell.com; sk...@marvell.com; skotesh...@marvell.com; > pbhagavat...@marvell.com; kirankum...@marvell.com; > psathe

Re: [PATCH 15/15] common/cnxk: enable SDP channel backpressure to TL4

2023-03-06 Thread Jerin Jacob
On Fri, Mar 3, 2023 at 1:42 PM Nithin Dabilpuram wrote: > > From: Veerasenareddy Burru > > Configure TL4 to respond to SDP channel backpressure. > > Signed-off-by: Veerasenareddy Burru Changed git commit logs and added Fixes: as needed. Series applied to dpdk-next-net-mrvl/for-next-net. Thanks

RE: [PATCH v2 0/5] test/crypto: add ZUC256 chained tests

2023-03-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: Power, Ciara > Sent: Friday, March 3, 2023 10:38 AM > Cc: dev@dpdk.org; Ji, Kai ; De Lara Guarch, Pablo > ; Power, Ciara > Subject: [PATCH v2 0/5] test/crypto: add ZUC256 chained tests > > This patchset adds chained testcases for each ZUC256 digest size: >

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 1:41 AM, fengchengwen wrote: >> What if application is not interested in recovery modes at all and not >> registered any callback for the recover> > There's probably race-condition which may lead to crash, because DPDK worker > threads runs busyloop and located on isolated core, and als

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/6/2023 1:41 AM, fengchengwen wrote: > On 2023/3/4 0:51, Ferruh Yigit wrote: >> On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: >>> In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the applicati

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-06 Thread Ferruh Yigit
On 3/5/2023 2:53 PM, Konstantin Ananyev wrote: > 03/03/2023 16:51, Ferruh Yigit пишет: >> On 3/2/2023 12:08 PM, Konstantin Ananyev wrote: >>> In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the app

Re: [PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-06 Thread Thomas Monjalon
03/03/2023 22:09, Tyler Retzlaff: > On Fri, Mar 03, 2023 at 03:12:19PM +0100, Thomas Monjalon wrote: > > 02/03/2023 18:17, Tyler Retzlaff: > > > On Thu, Mar 02, 2023 at 02:21:48PM +0100, Thomas Monjalon wrote: > > > > The DevX library path had to be provided through the variables > > > > DEVX_INC_P

RE: [PATCH v1] net/mlx5: enable hint in async table

2023-03-06 Thread Rongwei Liu
@Slava Ovsiienko Can you help review and ACK? BR Rongwei > -Original Message- > From: Rongwei Liu > Sent: Thursday, February 16, 2023 13:49 > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: Raslan Darawsheh > Subject: [PATCH