Re: [PATCH] eventdev/eth_rx: fix return of rx adapter instance get

On Tue, Jan 3, 2023 at 6:39 PM Shijith Thotton wrote: > > The API to get rx adapter instance is returning error for event devices > with internal port capability and eth_rx_adapter_instance_get op > undefined. But as the Rx adapter is internally maintaining the queue > information needed to find t

RE: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail

Hi, > -Original Message- > From: Chengwen Feng > Sent: Monday, February 6, 2023 6:53 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Xu, Rosen > ; Zhang, Tianfei ; Huang, > Wei > Cc: dev@dpdk.org > Subject: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail > > The MAP_FAILED s

[PATCH] net/i40e: remove avx512 specific Rx queue rearm code

'i40e_rxq_rearm' in avx512 path is optimized to improve the performance. But after the commit a2833ecc5ea4 ("mempool: fix get objects from mempool with cache"), this avx512 specific optimization is not necessary. This patch remove the unnecessary PMD specific optimization to make the code easier to

[PATCH] net/ice: remove avx512 specific Rx queue rearm code

'ice_rxq_rearm' in avx512 path is optimized to improve the performance. But after the commit a2833ecc5ea4 ("mempool: fix get objects from mempool with cache"), this avx512 specific optimization is not necessary. This patch remove the unnecessary PMD specific optimization to make the code easier to

[PATCH] net/i40e: remove avx512 specific Rx queue rearm code

'i40e_rxq_rearm' in avx512 path is optimized to improve the performance. But after the commit a2833ecc5ea4 ("mempool: fix get objects from mempool with cache"), this avx512 specific optimization is not necessary. This patch remove the unnecessary PMD specific optimization to make the code easier to

[PATCH] net/iavf: remove avx512 specific Rx queue rearm code

'iavf_rxq_rearm' in avx512 path is optimized to improve the performance. But after the commit a2833ecc5ea4 ("mempool: fix get objects from mempool with cache"), this avx512 specific optimization is not necessary. This patch remove the unnecessary PMD specific optimization to make the code easier to

RE: [PATCH] net/ice: fix get link status timeout

Hi, Minjin > -Original Message- > From: Ye, MingjinX > Sent: Monday, February 6, 2023 6:52 PM > To: 韩爽 ; Thomas Monjalon > > Cc: dev@dpdk.org; sta...@dpdk.org; Zhou, YidingX > ; Yang, Qiming ; Zhang, > Qi Z ; david.march...@redhat.com; > ferruh.yi...@amd.com > Subject: RE: [PATCH] net/ic

Re: [PATCH] test/graph: initialize graph param variable

On Fri, Feb 3, 2023 at 2:19 PM Amit Prakash Shukla wrote: > > Initializing rte_graph_param variable with 0 to avoid any > garbage value in structure elements which are not populated > as part of this function. > > Signed-off-by: Amit Prakash Shukla Acked-by: Jerin Jacob > --- > app/test/test

RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API

Hi, > -Original Message- > From: Deng, KaiwenX > Sent: Thursday, February 2, 2023 2:53 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Wu, > Wenjun1 ; Zhao1, Wei ; > Xing, Beilei ; Lu, Wenzhuo ; > Dai, Wei > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for

[PATCH v9 6/6] ethdev: add trace points for tm

Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 332 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 ++--- 3 files changed,

[PATCH v9 5/6] ethdev: add trace points for mtr

Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 223 +++ lib/ethdev/ethdev_trace_points.c | 63 + lib/ethdev/rte_mtr.c | 156 ++

[PATCH v9 4/6] ethdev: add trace points for flow

Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 502 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +- 3 files changed

[PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 893 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 486 ++--- lib/e

[PATCH v9 2/6] ethdev: add trace points for ethdev (part one)

Adds trace points for ethdev functions. The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as an internal header. ethdev_trace.h contains internal slow path and fast path tracepoints. The public fast path tracepoints are present in rte_ethdev_trace_fp.h header. Signed-off-by: Ank

[PATCH v9 1/6] eal: trace: add trace point emit for blob

Adds a trace point emit function for capturing a blob. The blob captures the length passed by the application followed by the array. The maximum blob bytes which can be captured is bounded by RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob length macro is 64 bytes. If the length is less than

[PATCH v9 0/6] add trace points in ethdev library

This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v9: - Added __rte_eal_trace_generic_blob in lib/eal/version.map file. v8: - Resolved review comments on ethdev patch. - The file rte_ethdev_trace.h and rte_ethdev

[PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport

Big structures like bitmap, pipes and queues in subport are addressed using offset of 'memory' field in subport structures. This means no other variable should be added after 'memory' variable or else addressing of such structs like bitmap etc. become incorrect. Realigned tc_ov_enabled variable in

Re: [PATCH v2] eventdev/timer: fix overflow issue

On Wed, Jan 25, 2023 at 2:16 AM Erik Gabriel Carrillo wrote: > > The software timer adapter converts event timer timeout ticks to a > number of CPU cycles at which an rte_timer should expire. The > computation uses integer operations that can result in overflow. > > Use floating point operations i

Re: [PATCH] bnxt: fix unwanted interrupt config on link state change

On Mon, Feb 6, 2023 at 10:44 PM wrote: > > From: Edwin Brossette > > When getting the device's info via bnxt_dev_info_get_op(), the device > enables interrupts on link state changes because of the following line: > > > eth_dev->data->dev_conf.intr_conf.lsc = 1; > > Enabling this mode might not

RE: [PATCH v2 2/2] vhost: fix possible FD leaks on truncation

> -Original Message- > From: Maxime Coquelin > Sent: Saturday, January 28, 2023 12:56 AM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Coquelin, Maxime ; sta...@dpdk.org > Subject: [PATCH v2 2/2] vhost: fix possible FD leaks on truncation > > This patch fixes possibl

RE: [PATCH v2 1/2] vhost: fix possible FDs leak

> -Original Message- > From: Maxime Coquelin > Sent: Saturday, January 28, 2023 12:56 AM > To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo > > Cc: Coquelin, Maxime ; sta...@dpdk.org > Subject: [PATCH v2 1/2] vhost: fix possible FDs leak > > On failure, read_vhost_message() onl

Re: [dpdk-dev] [PATCH v2 02/12] mldev: support PMD functions for ML device

On Tue, Feb 7, 2023 at 2:34 AM Stephen Hemminger wrote: > > On Tue, 7 Feb 2023 01:54:43 +0530 > wrote: > > > +static struct rte_ml_dev ml_devices[RTE_MLDEV_MAX_DEVS]; > > > > This will reserve space for 64 devices, but almost all users > will only have one. Maybe a level of indirection and alloca

RE: [EXT] Re: [PATCH v8 1/6] eal: trace: add trace point emit for blob

>On Mon, Feb 6, 2023 at 12:59 PM Ankur Dwivedi >wrote: >> >> Adds a trace point emit function for capturing a blob. The blob >> captures the length passed by the application followed by the array. >> >> The maximum blob bytes which can be captured is bounded by >> RTE_TRACE_BLOB_LEN_MAX macro. Th

RE: [PATCH v3 2/6] common/idpf: add RSS set/get ops

> > +static int idpf_config_rss_hf(struct idpf_vport *vport, uint64_t > > +rss_hf) { > > + uint64_t hena = 0, valid_rss_hf = 0; > According to the coding style, only the last variable on a line should be > initialized. > [Liu, Mingxia] Ok, thank, I'll check if the same issue exist otherwhere.

RE: [PATCH v10 1/1] common/idpf: add AVX512 data path for split queue model

> -Original Message- > From: Wenjun Wu > Sent: Tuesday, February 7, 2023 10:11 AM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Liu, Mingxia ; Lu, Wenzhuo > ; Wu, Wenjun1 ; Qiao, > Wenjing > Subject: [PATCH v10 1/1] common/idpf: add AVX512 data path for split > queue model >

[PATCH v5] ethdev: add flow rule group description

Add more sentences to describe the group concepts and define group 0 as root group for traffic to search a hit rule. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- lib/ethdev/rte_flow.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.h b/l

RE: [PATCH v2] vhost: decrease log level for unimplemented requests

> -Original Message- > From: Maxime Coquelin > Sent: Monday, February 6, 2023 11:08 PM > To: dev@dpdk.org; Xia, Chenbo ; ktray...@redhat.com; > david.march...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH v2] vhost: decrease log level for unimplemented requests > >

RE: [PATCH 0/3] cleanup the PMD

> On Mon, 6 Feb 2023 15:05:46 +0800 > Chaoyong He wrote: > > > This patch series aims to better align the PMD with the preferred DPDK > > coding style. > > - Remove the usage of 'printf()' > > - Remove the unneeded header file includes > > - Explicitly compare pointer with NULL > > - Explicitly

RE: Testpmd/l3fwd port shutdown failure on Arm Altra systems

Hi Qiming, Could you please help on this? Thanks. BR, Beilei > -Original Message- > From: Juraj Linkeš > Sent: Monday, February 6, 2023 4:53 PM > To: Singh, Aman Deep ; Zhang, Yuying > ; Xing, Beilei > Cc: dev@dpdk.org; Ruifeng Wang ; Zhang, Lijian > ; Honnappa Nagarahalli > > Subject

Re: net/bnxt: wrong link status when lsc_intr is used

On Mon, 6 Feb, 2023, 2:15 pm Edwin Brossette, wrote: > Hello, > > Thank you for your quick answer. > > This was added long back in the driver code by this commit (as you can >> see 6+ yrs old :)) , so I believe at the time the intent was to get >> this link notification asynchronous >> and 'lsc'

[PATCH v10 1/1] common/idpf: add AVX512 data path for split queue model

Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Reviewed-by: Wenjing Qiao Acked-by: Wenzhuo Lu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 21 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 799

[PATCH v10 0/1] Add support AVX512 split queue datapath

This patchset enables AVX512 data path for split queue model. It is based on the below pathset 1. https://patches.dpdk.org/project/dpdk/list/?series=26809&state=* v3: fix logical error. v4: rebase to the new baseline. v5: fix compilation error. v6: remove unexpected changes. v7: rebase to the ne

RE: [PATCH v2] net/i40e: support enabling/disabling source pruning

> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 1, 2023 7:11 PM > To: David Marchand ; > m...@smartsharesystems.com; ferruh.yi...@amd.com; Zhang, Ke1X > > Cc: dev@dpdk.org; Matz, Olivier ; Zhang, Yuying > ; Xing, Beilei > Subject: Re: [PATCH v2] net/i40e: supp

RE: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail

It looks good. > -Original Message- > From: Chengwen Feng > Sent: Monday, February 6, 2023 18:53 > To: tho...@monjalon.net; ferruh.yi...@amd.com; Xu, Rosen > ; Zhang, Tianfei ; Huang, > Wei > Cc: dev@dpdk.org > Subject: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail > > The MAP

Re: [PATCH v3] app/procinfo: display eventdev xstats for PMD data

On Mon, 6 Feb 2023 17:05:05 -0600 Abdullah Sevincer wrote: > + > + size = (unsigned int)ret; /* number of names */ > + > + /* Get memory to hold stat names, IDs, and values */ > + > + xstats_names = malloc(sizeof(struct rte_event_dev_xstats_name) * size); > + ids = malloc(sizeof(

[PATCH v2 8/8] pcapng: windows compatibility

Allow building on Windows, need to provide some comparability wrappers for writev() and if_nametoindex. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/pcapng/meson.build | 6 - lib/pcapng/rte_pcapng.c | 59 +++-- 2 files changed, 57 i

[PATCH v2 7/8] fib: enable on Windows

The FIB library builds on Windows as long as sys/queue.h is defined. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/test_fib.c | 22 +- app/test/test_fib6.c | 24 ++-- app/test/test_fib6_perf.c | 15 +-- app/

[PATCH v2 5/8] ip_frag: enable build on Windows

This build works on Windows if sys/queue.h is included. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/test_ipfrag.c | 12 lib/ip_frag/ip_frag_common.h | 2 ++ lib/ip_frag/meson.build | 6 -- 3 files changed, 2 insertions(+), 18 deletions(-)

[PATCH v2 6/8] rib: enable on Windows

The RIB library builds on Windows as long as sys/queue.h is included Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/test_rib.c | 19 --- app/test/test_rib6.c | 24 ++-- lib/rib/meson.build | 6 -- lib/rib/rte_rib.c| 1 + li

[PATCH v2 3/8] lpm: enable on Windows

This builds on Windows without changes. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/test_lpm.c | 15 +-- app/test/test_lpm6.c | 12 app/test/test_lpm6_data.h | 3 ++- app/test/test_lpm6_perf.c | 14 +- app/test/test_lpm

[PATCH v2 4/8] reorder: build on Windows

This builds on Windows if sys/queue.h is included. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- app/test/test_reorder.c | 11 --- lib/reorder/meson.build | 6 -- lib/reorder/rte_reorder.c | 1 + 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/ap

[PATCH v2 2/8] net/ring: build on Windows

The command line arguments are stored in node_action_pair and the name[] was sized to PATH_MAX which does not exist on Windows. Since the name is either "CREATE" or "ATTACH" it is not related to PATH_MAX (4096). With this fix driver builds ok on windows, but need to modify the test meson build to

[PATCH v2 1/8] net/null: build null PMD on Windows

Builds fine with current code, no changes needed. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- drivers/net/null/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/null/meson.build b/drivers/net/null/meson.build index 4a483955a7a9..a51f8f5211b0 1006

[PATCH v2 0/8] Enable building more libraries on Windows

While diagnosing some Windows cross build errors; noticed that lots of important DPDK libraries are not being built on Windows. Stephen Hemminger (8): net/null: build null PMD on Windows net/ring: build on Windows lpm: enable on Windows reorder: build on Windows ip_frag: enable build on

[PATCH v4] app/procinfo: display eventdev xstats for PMD data

This commit extends proc-info application to display xstats and PMD dump data for the eventdev devices. New command line arguments are introduced to display stats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): dpdk-proc-info -- --edev-stats-

[PATCH v3] app/procinfo: display eventdev xstats for PMD data

This commit extends proc-info application to display xstats and PMD dump data for the eventdev devices. New command line arguments are introduced to display stats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): dpdk-proc-info -- --edev-stats-

Re: [dpdk-dev] [PATCH v2 02/12] mldev: support PMD functions for ML device

06/02/2023 22:04, Stephen Hemminger: > On Tue, 7 Feb 2023 01:54:43 +0530 > wrote: > > > +static struct rte_ml_dev ml_devices[RTE_MLDEV_MAX_DEVS]; > > > > This will reserve space for 64 devices, but almost all users > will only have one. Maybe a level of indirection and allocate as needed? > > Y

Re: [dpdk-dev] [PATCH v2 02/12] mldev: support PMD functions for ML device

On Tue, 7 Feb 2023 01:54:43 +0530 wrote: > +static struct rte_ml_dev ml_devices[RTE_MLDEV_MAX_DEVS]; > This will reserve space for 64 devices, but almost all users will only have one. Maybe a level of indirection and allocate as needed? You could even use a single allocation for the pmd and dev

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

Konstantin Ananyev, Feb 06, 2023 at 21:44: > > Ok I see. But what should we do to prevent this? Simply ignore the > > request and log a warning? > > That's seems like simplest choice to me... Or if you still prefer to > allow it - put a special comment that it is user responsibility to > handle suc

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

> Konstantin Ananyev, Feb 06, 2023 at 21:34: > > Yes, app knows what resources it wants to free. > > But it has no way to know *when* it is safe to free them. > > Just a bit more explanation: > > App invokes your function which resets global value of CB. > > How would it know that after return fr

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

Konstantin Ananyev, Feb 06, 2023 at 21:34: > Yes, app knows what resources it wants to free. > But it has no way to know *when* it is safe to free them. > Just a bit more explanation: > App invokes your function which resets global value of CB. > How would it know that after return from this functi

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

> -Original Message- > From: Robin Jarry > Sent: Monday, February 6, 2023 8:29 PM > To: Konstantin Ananyev ; dev@dpdk.org > Cc: Tyler Retzlaff ; Kevin Laatz > ; Morten Brørup > > Subject: Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage > > Konstantin Ananyev, Feb

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

Konstantin Ananyev, Feb 06, 2023 at 21:07: > Problem is not in resetting cb function itself. > > Usually with CB user needs some sort of data structure (to accumulate > stats, track states, etc.). If we allow to reset the CB, then it > arises the question when/how should we allow user to free assoc

[dpdk-dev] [PATCH v2 11/12] mldev: support to retrieve error information

From: Srikanth Yalavarthi Added functions to get error information for an ML op. This information can include both drive specific error message and error code. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c | 31 +++ li

[dpdk-dev] [PATCH v2 12/12] mldev: support to get debug info and test device

From: Srikanth Yalavarthi Added functions for ML device debug APIs. The APIs are used to dump ML device debug information and to run selftest. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c | 39 ++ lib/mldev/rt

[dpdk-dev] [PATCH v2 10/12] mldev: support device extended statistics

From: Srikanth Yalavarthi Added functions to handle device extended stats. xstats supported are driver specific and can include stats specific to ML device or ML model and I/O. Added prototypes for functions to be called by the device drivers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: J

[dpdk-dev] [PATCH v2 09/12] mldev: support device statistics

From: Srikanth Yalavarthi Added functions to get and reset device stats. Device stats include number of requests enqueued, dequeued and errors. Added function prototypes to used by driver implementations. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c

[dpdk-dev] [PATCH v2 08/12] mldev: support inference enqueue and dequeue

From: Srikanth Yalavarthi Added implementations of fast-path functions to enqueue and dequeue ML requests from an ML device queue-pair. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c | 76 ++ lib/mldev/rte_mldev

[dpdk-dev] [PATCH v2 07/12] mldev: support ML op pool and ops

From: Srikanth Yalavarthi Added library functions to create and free ML op pool. Create function allocates new ML op pool and initializes ML ops to their defaults. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c | 69

[dpdk-dev] [PATCH v2 06/12] mldev: support input and output data handling

From: Srikanth Yalavarthi Added library functions to handle model input and output data. The APIs can be used to get the size of I/O buffers, quantize input data and dequantize output data. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c | 94

[dpdk-dev] [PATCH v2 05/12] mldev: support handling ML models

From: Srikanth Yalavarthi Added RTE functions to handle ML models. These APIs can load, unload, start, and stop an ML model. Additional APIs to update model parameters and get model information are added. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/rte_mldev.c

[dpdk-dev] [PATCH v2 04/12] mldev: support ML device queue-pair setup

From: Srikanth Yalavarthi Added APIs to create a queue-pair attached to ML device. Queue pairs are created with a user specified ID. Added function prototypes to be used by ML drivers for queue pair create and destroy. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mlde

[dpdk-dev] [PATCH v2 03/12] mldev: support ML device handling functions

From: Srikanth Yalavarthi Added ML device handling APIs. These APIs are used to get device information, configure, start, stop and close ML devices. Added function prototypes to PMD layer which are used by the ML driver implementations in the poll mode driver. Signed-off-by: Srikanth Yalavarthi

[dpdk-dev] [PATCH v2 02/12] mldev: support PMD functions for ML device

From: Srikanth Yalavarthi Added PMD functions to handle ML devices. The rte_mldev_pmd.* files are for drivers only and should be private to DPDK, and are not installed for application use. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mldev/meson.build | 9 +++

[dpdk-dev] [PATCH v2 01/12] mldev: introduce machine learning device library

From: Jerin Jacob Add mldev API specification to standardize and use the machine learning device and inference operations in vendor neutral way. Following operations are abstracted through APIs - ML device capability probe - ML device configuration - ML device queue pair configuration - ML devi

[dpdk-dev] [PATCH v2 00/12] mldev: introduce machine learning device library

From: Jerin Jacob Machine learning inference library == Definition of machine learning inference Inference in machine learning is the process of making an output prediction based on new input data using a pre-trained machin

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

> > Konstantin Ananyev, Jan 04, 2023 at 11:53: > > Probably we can even print warning or so if some-one tries to overwrite > > it once again. > > I'm not sure that is necessary. If an application wants to reset the > callback to NULL at any point in time, I don't see why DPDK should tell > them

Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name

06/02/2023 17:01, Sinan Kaya: > On Sun, 2023-01-22 at 21:51 +0100, Thomas Monjalon wrote: > > 20/01/2023 17:47, Stephen Hemminger: > > > On Thu, 19 Jan 2023 23:41:40 -0500 > > > ok...@kernel.org wrote: > > > > > > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h > > > > index 364

[PATCH v2] app/procinfo: display eventdev xstats for PMD data

This commit extends proc-info application to display xstats and PMD dump data for the eventdev devices. New command line arguments are introduced to display stats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): dpdk-proc-info -- --edev-stats-

[PATCH] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/mbuf/mbuf_log.h | 10 ++ lib/mbuf/rte_mbuf.c | 20 lib/mbuf/rte_mbuf_dyn.c | 14

Re: [PATCH] doc: fix an alignment issue in bnxt NIC documentation

On Thu, Feb 2, 2023 at 10:13 AM Ajit Khaparde wrote: > > The supported firmware version information was not aligned correctly. > This patch fixes it. > > Fixes: b845c295cd13 ("doc: update Broadcom bnxt guide") > Signed-off-by: Ajit Khaparde Patch applied dpdk-next-net-brcm. Thanks > --- > doc/g

Re: [dpdk-dev] [PATCH 0/3] bnxt PMD fixes

On Tue, Jan 31, 2023 at 8:23 PM Kalesh A P wrote: > > From: Kalesh AP > > This patchset contains bnxt PMD bug fixes. Please apply. Patchset applied dpdk-next-net-brcm. Thanks > > Kalesh AP (1): > net/bnxt: fix Tx queue stats after queue stop and start > > Mike Baucom (1): > net/bnxt: fix Rx

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

On Mon, Feb 06, 2023 at 05:49:18PM +0100, Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Monday, 6 February 2023 17.11 > > > > On Wed, Feb 1, 2023 at 2:16 PM Thomas Monjalon > > wrote: > > > > > I tend to prefer this kind of namespace as well. > > > > >

[PATCH] bnxt: fix unwanted interrupt config on link state change

From: Edwin Brossette When getting the device's info via bnxt_dev_info_get_op(), the device enables interrupts on link state changes because of the following line: > eth_dev->data->dev_conf.intr_conf.lsc = 1; Enabling this mode might not be wanted by the user. The flag RTE_ETH_DEV_INTR_LSC c

[PATCH] efd: replace RTE_LOGTYPE_EFD with local type

Replace all uses of global logtype with a local log type. Do not break message formats across source lines. Signed-off-by: Stephen Hemminger --- lib/efd/rte_efd.c | 106 ++ 1 file changed, 51 insertions(+), 55 deletions(-) diff --git a/lib/efd/rte_efd

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 6 February 2023 17.11 > > On Wed, Feb 1, 2023 at 2:16 PM Thomas Monjalon > wrote: > > > > I tend to prefer this kind of namespace as well. > > > > Let's compare different naming proposals, > > > > taking into account what w

Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

On Mon, Feb 6, 2023 at 11:52 AM Naga Harish K, S V wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, February 3, 2023 3:15 PM > > To: Naga Harish K, S V > > Cc: jer...@marvell.com; Carrillo, Erik G ; > > Gujjar, > > Abhinandan S ; dev@dpdk.org; > > Ja

Re: [PATCH 0/3] cleanup the PMD

On Mon, 6 Feb 2023 15:05:46 +0800 Chaoyong He wrote: > This patch series aims to better align the PMD with > the preferred DPDK coding style. > - Remove the usage of 'printf()' > - Remove the unneeded header file includes > - Explicitly compare pointer with NULL > - Explicitly compare integer wi

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

On Wed, Feb 1, 2023 at 2:16 PM Thomas Monjalon wrote: > > > I tend to prefer this kind of namespace as well. > > > Let's compare different naming proposals, > > > taking into account what we already have for some annotations, > > > and what is proposed to be added in this patch and David's patch >

Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name

On Sun, 2023-01-22 at 21:51 +0100, Thomas Monjalon wrote: > 20/01/2023 17:47, Stephen Hemminger: > > On Thu, 19 Jan 2023 23:41:40 -0500 > > ok...@kernel.org wrote: > > > > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h > > > index 364f140f91..6d94a65d97 100644 > > > --- a/lib/e

Re: [PATCH v3 00/10] codeql fixes for various subsystems

On Thu, 2023-01-19 at 23:41 -0500, ok...@kernel.org wrote: > From: Sinan Kaya > > Following up the codeql reported problems first submitted > by Stephen Hemminger here: > > https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ > > Posting a series of fixes about potential null poi

Re: Sign changes through function signatures

I'm a fan of "just rip the bandaid off" (especially when it's convenient for me, however it's very possible I will also be the person to bring up backwards compatibility). Speaking of backwards compatibility, API/ABI breakage was semi-recently discussed at the techboard [1]. From the notes it was

[PATCH] app/testpmd: fix crash on cleanup

If allocating the ports[] array fails, a crash will occur when shutting down testpmd since ethdev emits RTE_ETH_EVENT_DESTROY events. Move init_port() before registering ethdev event handler. Fixes: 85c6571c9103 ("app/testpmd: reset port status on close notification") Cc: sta...@dpdk.org Signed-o

RE: [PATCH 0/2] lib/reorder: fix drain/free issues

Hi All, Kind reminder to all maintainers, please review and ack/comment. > This patch address issues with reorder drain/free, discovered with enabled > `RTE_LIBRTE_MEMPOOL_DEBUG`.

RE: [PATCH v4 1/2] ethdev: introduce the PHY affinity field in Tx queue API

Hi, @Andrew, @Thomas, @Ori, Could you lease help to review the patch? Thanks. > -Original Message- > From: Jiawei Wang > Sent: Friday, February 3, 2023 9:34 PM > To: Slava Ovsiienko ; Ori Kam ; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > andrew.rybche...@oktetlabs.ru; Aman Singh ; >

Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

On 1/20/23 21:55, Hernan Vargas wrote: Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Please Cc stable, since it fixes a

[PATCH v2] vhost: decrease log level for unimplemented requests

This patch changes VHOST_USER_SET_VRING_ERR and VHOST_USER_SET_LOG_FD "not implemented" log levels from INFO to DEBUG, as implementing these requests is not mandatory. Having them being displayed at INFO level may induce some confusion to the end-user. Fixes: fd29c33b651a ("vhost: handle unsupport

RE: [v2 00/16] net/mlx5/hws: support range and partial hash matching

From: Alex Vesker > ConnectX and BlueField devices which support HWS are capable of > performing advanced match, range-match and hashing operations on packet > headers. This patch-set introduces support for (1) range matching - allows > combining range and exact match over provided item fields us

Re: [PATCH v8 4/5] app/testpmd: report lcore usage

On Mon, Feb 6, 2023 at 10:08 AM Robin Jarry wrote: > > David Marchand, Feb 06, 2023 at 09:58: > > I have been playing a bit with this series with two lcores, each one > > polling a net/null port. > > At first it looked good, but then I started to have one idle lcore, by > > asking net/null not to

RE: [PATCH] net/mlx5: check compressed CQE opcode for an error

From: Alexander Kozyrev > The CQE opcode is never checked for a compressed CQE in the vectorized Rx > burst routines. It is assumed that compressed CQEs are always valid and > skipped error checking. > > This is obviously not the case and error CQEs may be compressed together as > well. Need to

RE: [PATCH] net/mlx5: ignore non-critical syndromes for Rx queue

From: Alexander Kozyrev > For non-fatal syndromes like LOCAL_LENGTH_ERR, the Rx queue reset > shouldn't be triggered. Rx queue could continue with the next packets > without any recovery. Only three syndromes warrant Rx queue reset: > LOCAL_QP_OP_ERR, LOCAL_PROT_ERR and WR_FLUSH_ERR. > Do not ini

RE: [PATCH] net/mlx5: fix error CQE dumping for vectorized Rx burst

From: Alexander Kozyrev > There is a dump file with debug information created for an error CQE to help > with troubleshooting later. > It starts with the last CQE, which, presumably is the error CQE. > But this is only true for the scalar Rx burst routing since we handle CQEs > there > one by on

[PATCH] crypto/cnxk: fix order of ECFPM params

Fix the order of ECFPM parameters according to target board. Fixes: 8e39b133235 ("crypto/cnxk: support fixed point multiplication") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h | 48 --- 1 file changed, 28 insertions(+), 20 deletion

[PATCH] common/cnxk: fix incorrect auth key length

Auth key length is stored as 8 bit value in SE context. It should be larger enough to accommodate supported auth key length of 1024 bytes maximum, as in HMAC. Fixes: a45859312ff ("common/cnxk: add SE definitions for symmetric crypto") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common

Re: [PATCH v8 1/6] eal: trace: add trace point emit for blob

On Mon, Feb 6, 2023 at 12:59 PM Ankur Dwivedi wrote: > > Adds a trace point emit function for capturing a blob. The blob > captures the length passed by the application followed by the array. > > The maximum blob bytes which can be captured is bounded by > RTE_TRACE_BLOB_LEN_MAX macro. The value f

[v1, 10/10] examples/fips_validation: add extra space in JSON buffer

Current test buffer to copy input data of maximum possible length did not account NULL character, due to which a last input character is always ignored and it causes tests like RSA SIGVER for modulo of 4096 bits to fail. This patch fixes it. Fixes: 0b65d54f3a4 ("examples/fips_validation: fix JSON

[v1, 08/10] examples/fips_validation: fix AES GCM validation tests

AES GCM validation tests fail in FIPS validation due to incorrect fields populated in response file. This patch fixes them. Fixes: 5b540bebac8e ("examples/fips_validation: fix GMAC decryption output") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c |

[v1, 09/10] examples/fips_validation: fix AES XTS to read seq number

Fix AES XTS test to read sequence number correctly. Fixes: f8e431ed8f6 ("examples/fips_validation: add parsing for AES-XTS") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_xts.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --g

[v1, 07/10] examples/fips_validation: add SHA3 algorithms in ECDSA test

Add SHA3 algorithms in ECDSA as supported. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_ecdsa.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/fips_validation_ecdsa.c b/examples/fips_validation/fips_validation_ecdsa.c i

[v1, 06/10] examples/fips_validation: add ECDSA keygen support

Add support to validate ECDSA keygen mode tests. Signed-off-by: Gowrishankar Muthukrishnan --- .../fips_validation/fips_validation_ecdsa.c | 52 +++ examples/fips_validation/main.c | 13 + 2 files changed, 65 insertions(+) diff --git a/examples/fips_validatio

  1   2   >