[dpdk-dev] [PATCH v2 11/12] mldev: support to retrieve error information

[jerinj]

From: Srikanth Yalavarthi <syalavar...@marvell.com>

Added functions to get error information for an ML op.
This information can include both drive specific error
message and error code.

Signed-off-by: Srikanth Yalavarthi <syalavar...@marvell.com>
Signed-off-by: Jerin Jacob <jer...@marvell.com>
---
 lib/mldev/rte_mldev.c      | 31 +++++++++++++++++++++++++++++++
 lib/mldev/rte_mldev_core.h | 22 ++++++++++++++++++++++
 lib/mldev/version.map      |  1 +
 3 files changed, 54 insertions(+)

diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
index da4c272d57..1a8d8d4987 100644
--- a/lib/mldev/rte_mldev.c
+++ b/lib/mldev/rte_mldev.c
@@ -832,4 +832,35 @@ rte_ml_dequeue_burst(int16_t dev_id, uint16_t qp_id, 
struct rte_ml_op **ops, uin
        return (*dev->dequeue_burst)(dev, qp_id, ops, nb_ops);
 }
 
+int
+rte_ml_op_error_get(int16_t dev_id, struct rte_ml_op *op, struct 
rte_ml_op_error *error)
+{
+       struct rte_ml_dev *dev;
+
+#ifdef RTE_LIBRTE_ML_DEV_DEBUG
+       if (!rte_ml_dev_is_valid_dev(dev_id)) {
+               RTE_MLDEV_LOG(ERR, "Invalid dev_id = %d\n", dev_id);
+               return -EINVAL;
+       }
+
+       dev = rte_ml_dev_pmd_get_dev(dev_id);
+       if (*dev->op_error_get == NULL)
+               return -ENOTSUP;
+
+       if (op == NULL) {
+               RTE_MLDEV_LOG(ERR, "Dev %d, op cannot be NULL\n", dev_id);
+               return -EINVAL;
+       }
+
+       if (error == NULL) {
+               RTE_MLDEV_LOG(ERR, "Dev %d, error cannot be NULL\n", dev_id);
+               return -EINVAL;
+       }
+#else
+       dev = rte_ml_dev_pmd_get_dev(dev_id);
+#endif
+
+       return (*dev->op_error_get)(dev, op, error);
+}
+
 RTE_LOG_REGISTER_DEFAULT(rte_ml_dev_logtype, INFO);
diff --git a/lib/mldev/rte_mldev_core.h b/lib/mldev/rte_mldev_core.h
index b2ddf8fb5e..29bec93c5f 100644
--- a/lib/mldev/rte_mldev_core.h
+++ b/lib/mldev/rte_mldev_core.h
@@ -73,6 +73,25 @@ typedef uint16_t (*mldev_enqueue_t)(struct rte_ml_dev *dev, 
uint16_t qp_id, stru
 typedef uint16_t (*mldev_dequeue_t)(struct rte_ml_dev *dev, uint16_t qp_id, 
struct rte_ml_op **ops,
                                    uint16_t nb_ops);
 
+/**
+ * @internal
+ *
+ * Get error information for an Op.
+ *
+ * @param dev
+ *     ML device pointer.
+ * @param op
+ *     ML Op handle.
+ * @param error
+ *     Pointer to error structure.
+ *
+ * @return
+ *     - 0 on success.
+ *     - <0, error on failure.
+ */
+typedef int (*mldev_op_error_get_t)(struct rte_ml_dev *dev, struct rte_ml_op 
*op,
+                                   struct rte_ml_op_error *error);
+
 /**
  * Definitions of all functions exported by a driver through the generic 
structure of type
  * *ml_dev_ops* supplied in the *rte_ml_dev* structure associated with a 
device.
@@ -622,6 +641,9 @@ struct rte_ml_dev {
        /** Pointer to PMD dequeue function. */
        mldev_dequeue_t dequeue_burst;
 
+       /** Pointer to PMD Op error get function. */
+       mldev_op_error_get_t op_error_get;
+
        /** Pointer to device data. */
        struct rte_ml_dev_data *data;
 
diff --git a/lib/mldev/version.map b/lib/mldev/version.map
index ddf340ef8e..ebe69765e6 100644
--- a/lib/mldev/version.map
+++ b/lib/mldev/version.map
@@ -29,6 +29,7 @@ EXPERIMENTAL {
        rte_ml_model_start;
        rte_ml_model_stop;
        rte_ml_model_unload;
+       rte_ml_op_error_get;
        rte_ml_op_pool_create;
        rte_ml_op_pool_free;
 
-- 
2.39.1