> -----Original Message-----
> From: Maxime Coquelin <maxime.coque...@redhat.com>
> Sent: Monday, February 6, 2023 11:08 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo....@intel.com>; ktray...@redhat.com;
> david.march...@redhat.com
> Cc: Maxime Coquelin <maxime.coque...@redhat.com>; sta...@dpdk.org
> Subject: [PATCH v2] vhost: decrease log level for unimplemented requests
> 
> This patch changes VHOST_USER_SET_VRING_ERR and
> VHOST_USER_SET_LOG_FD "not implemented" log levels from
> INFO to DEBUG, as implementing these requests is not
> mandatory. Having them being displayed at INFO level
> may induce some confusion to the end-user.
> 
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in
> functions")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
> ---
>  lib/vhost/vhost_user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 8f33d5f4d9..551908df8e 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct
> virtio_net **pdev,
> 
>       if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
>               close(ctx->fds[0]);
> -     VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> +     VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
> 
>       return RTE_VHOST_MSG_RESULT_OK;
>  }
> @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net
> **pdev,
>               return RTE_VHOST_MSG_RESULT_ERR;
> 
>       close(ctx->fds[0]);
> -     VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
> +     VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
> 
>       return RTE_VHOST_MSG_RESULT_OK;
>  }
> --
> 2.39.1

Reviewed-by: Chenbo Xia <chenbo....@intel.com> 

Reply via email to