RE: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-13 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, December 14, 2022 12:35 PM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic > > When rt

RE: [PATCH V4 7/9] telemetry: support adding integer value as hexadecimal

2022-12-13 Thread Morten Brørup
> From: lihuisong (C) [mailto:lihuis...@huawei.com] > Sent: Wednesday, 14 December 2022 03.44 > > 在 2022/12/14 1:09, Bruce Richardson 写道: > > On Tue, Dec 13, 2022 at 06:15:10PM +0800, Huisong Li wrote: > >> Sometimes displaying a unsigned integer value as hexadecimal encoded > style > >> is more e

Re: Question about add ethdev loopback set API

2022-12-13 Thread fengchengwen
On 2022/12/13 19:25, Ferruh Yigit wrote: > On 12/13/2022 10:04 AM, fengchengwen wrote: >> Hi Ferruh, >> >> During the test, we need to delineate where go wrong when encountered >> e.g. CRC error. In this scenario, loopback is useful. >> >> I think we can add a loopback set API which could s

[PATCH v2 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

[PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v2 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_conf

[PATCH v2 1/1] common/idpf: add AVX512 data path for split queue model

2022-12-13 Thread Wenjun Wu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 19 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 797 +- drivers/common/idpf/version.

[PATCH v2 0/1] Add support AVX512 split queue datapath

2022-12-13 Thread Wenjun Wu
This patchset enables AVX512 data path for split queue model. It is based on the below two pathsets 1. https://patches.dpdk.org/project/dpdk/cover/20221208072725.32434-1-beilei.x...@intel.com/ 2. https://patches.dpdk.org/project/dpdk/cover/20221208075309.37852-1-beilei.x...@intel.com/ Wenjun W

Re: [PATCH 1/2] net/bonding: support private dump ops

2022-12-13 Thread fengchengwen
Hi Min, V2 has been solved. Please review. Thanks. On 2022/12/6 10:01, humin (Q) wrote: > Hi, > > 在 2022/12/5 16:10, Chengwen Feng 写道: >> This patch implements eth_dev_priv_dump ops which could enhance the >> debug capability. >> >> The dump output is similar to testpmd command >> "show bondin

[PATCH v2 1/3] net/bonding: support private dump ops

2022-12-13 Thread Chengwen Feng
This patch implements eth_dev_priv_dump ops which could enhance the debug capability. The dump output is similar to testpmd command "show bonding config [port]". Signed-off-by: Chengwen Feng --- drivers/net/bonding/rte_eth_bond_pmd.c | 105 - 1 file changed, 104 insertio

[PATCH v2 3/3] net/bonding: use dump API to impl show bonding cmd

2022-12-13 Thread Chengwen Feng
The bonding PMD's eth_dev_priv_dump ops contain the following testpmd commands output: "show bonding config [port]" and "show bonding lacp info [port]". To reduce duplicate code maintenance, this patch uses rte_eth_dev_priv_dump to implement the command "show bonding config [port]", and remove the

[PATCH v2 2/3] net/bonding: support dump LACP info

2022-12-13 Thread Chengwen Feng
This patch adds dump lacp info in eth_dev_priv_dump ops. The extra dump output is similar to testpmd command "show bonding lacp info [port]". Signed-off-by: Chengwen Feng --- drivers/net/bonding/rte_eth_bond_pmd.c | 143 - 1 file changed, 141 insertions(+), 2 deletions(-

[PATCH v2 0/3] net/bonding: support device private dump

2022-12-13 Thread Chengwen Feng
This patchset adds device private dump for bonding PMD, and use rte_eth_dev_priv_dump API to implement testpmd show bonding command. Chengwen Feng (3): net/bonding: support private dump ops net/bonding: support dump LACP info net/bonding: use dump API to impl show bonding cmd --- v2: * ad

[PATCH v1] common/idpf: add AVX512 data path for split queue model

2022-12-13 Thread Wenjun Wu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 19 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 797 +- drivers/common/idpf/version.

[PATCH 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

[PATCH 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-13 Thread Naga Harish K S V
When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_conf

Re: [PATCH V4 6/9] telemetry: refactor mapping between value and array type

2022-12-13 Thread lihuisong (C)
在 2022/12/14 0:57, Bruce Richardson 写道: On Tue, Dec 13, 2022 at 06:15:09PM +0800, Huisong Li wrote: Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions fo

Re: [PATCH V4 1/9] telemetry: move to header to controllable range

2022-12-13 Thread lihuisong (C)
在 2022/12/14 1:10, Bruce Richardson 写道: On Tue, Dec 13, 2022 at 06:15:04PM +0800, Huisong Li wrote: The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. s/uncontrollable/unconditio

Re: [PATCH V4 7/9] telemetry: support adding integer value as hexadecimal

2022-12-13 Thread lihuisong (C)
在 2022/12/14 1:09, Bruce Richardson 写道: On Tue, Dec 13, 2022 at 06:15:10PM +0800, Huisong Li wrote: Sometimes displaying a unsigned integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces two APIs to

[RFC] ethdev: add template table insertion and matching types

2022-12-13 Thread Alexander Kozyrev
Bring more flexibility and control over both flow rule insertion and packet matching mechanisms. Introduce 2 new flow table types: 1. Allow a user to specify the insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted fl

RE: [PATCH] net/iavf: fix mbuf VLAN offload flags in the L2TAG2 path with AVX2

2022-12-13 Thread Lu, Wenzhuo
> -Original Message- > From: Michal Schmidt > Sent: Thursday, December 8, 2022 8:19 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; Xing, Beilei ; Wang, Haiyue > > Subject: [PATCH] net/iavf: fix mbuf VLAN offload flags in the L2TAG2 path with > AVX2 > > It has been ob

RE: [PATCH v2] net/iavf: fix outer udp checksum offload

2022-12-13 Thread Xu, Ke1
> -Original Message- > From: Zeng, ZhichaoX > Sent: Tuesday, December 13, 2022 9:45 AM > To: dev@dpdk.org > Cc: Zhou, YidingX ; Xu, Ke1 ; > Zhang, Qi Z ; Zeng, ZhichaoX > ; Wu, Jingjing ; Xing, > Beilei ; Nicolau, Radu > Subject: [PATCH v2] net/iavf: fix outer udp checksum offload > >

Re: help with pthread_t deprecation / api changes

2022-12-13 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 09:39:24PM +0100, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Tuesday, 13 December 2022 20.34 > > > > 13/12/2022 18:38, Tyler Retzlaff: > > > Okay, just one final confirmation. This is what we would like? > > > > > > * completely re

RE: help with pthread_t deprecation / api changes

2022-12-13 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 13 December 2022 20.34 > > 13/12/2022 18:38, Tyler Retzlaff: > > Okay, just one final confirmation. This is what we would like? > > > > * completely remove the existing rte_thread_getname api. > > - by implication this means

RE: [RFC PATCH 7/7] telemetry: change public API to use 64-bit signed values

2022-12-13 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, 13 December 2022 19.28 > > While the unsigned values added to telemetry dicts/arrays were up to > 64-bits in size, the sized values were only up to 32-bits. We can > standardize the API by having both int and uint functi

Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-13 Thread Ferruh Yigit
On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: Hi Ankur, Jerin, I have some major questions, I can see some already queried by Andrew as well: 1) How flexible are we on changing trace log output? Should we take trace log as kind of user interface and don't break it (as much as possible)? Or is it OK

RE: 19.11.14 patches review and test

2022-12-13 Thread Ali Alnubani
> -Original Message- > From: Christian Ehrhardt > Sent: Tuesday, December 13, 2022 1:41 PM > To: Ali Alnubani > Cc: sta...@dpdk.org; dev@dpdk.org; Abhishek Marathe > ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Ian Stokes ; Jerin > Jacob ; John McNamara ; > Ju-Hyo

Re: help with pthread_t deprecation / api changes

2022-12-13 Thread Thomas Monjalon
13/12/2022 18:38, Tyler Retzlaff: > On Tue, Dec 13, 2022 at 09:32:06AM +0100, Thomas Monjalon wrote: > > 12/12/2022 18:45, Tyler Retzlaff: > > > On Sun, Dec 11, 2022 at 08:50:48AM +0100, Thomas Monjalon wrote: > > > > 10/12/2022 00:49, Tyler Retzlaff: > > > > > On Fri, Dec 09, 2022 at 10:13:44PM +0

[RFC PATCH 7/7] telemetry: change public API to use 64-bit signed values

2022-12-13 Thread Bruce Richardson
While the unsigned values added to telemetry dicts/arrays were up to 64-bits in size, the sized values were only up to 32-bits. We can standardize the API by having both int and uint functions take 64-bit values. For ABI compatibility, we use function versioning to ensure older binaries can still u

[RFC PATCH 6/7] telemetry: make internal int representation 64-bits

2022-12-13 Thread Bruce Richardson
The internal storage for int values can be expanded from 32-bit to 64-bit without affecting the external ABI. Suggested-by: Morten Brørup Signed-off-by: Bruce Richardson --- lib/telemetry/telemetry_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetr

[RFC PATCH 5/7] telemetry: update json functions to use int/uint in names

2022-12-13 Thread Bruce Richardson
Since we are standardizing on using uint in place of u64, and expanding the int values to 64-bit, we can update the internal json functions to use the new names and expanded signed type. Suggested-by: Morten Brørup Signed-off-by: Bruce Richardson --- app/test/test_telemetry_json.c | 9

[RFC PATCH 4/7] telemetry: make array initialization more robust

2022-12-13 Thread Bruce Richardson
Rather than relying on a specific ordering of elements in the array matching that of elements in the enum definition, we can explicitly mark each array entry using the equivalent enum value as an index. Signed-off-by: Bruce Richardson --- lib/telemetry/telemetry_data.c | 8 1 file chang

[RFC PATCH 3/7] telemetry: remove RTE prefix from internal enum values

2022-12-13 Thread Bruce Richardson
To better distinguish which values are public and which are internal remove the "RTE_" prefix off the internal enum defining the container types. Signed-off-by: Bruce Richardson --- lib/ethdev/sff_telemetry.c | 2 +- lib/telemetry/telemetry.c | 36 +++--- lib/te

[RFC PATCH 2/7] telemetry: add uint type as alias for u64

2022-12-13 Thread Bruce Richardson
For future standardization on the "uint" name for unsigned values rather than the existing "u64" one, we can for now: * rename all internal values to use uint rather than u64 * add new function names to alias the existing u64 ones Suggested-by: Morten Brørup Signed-off-by: Bruce Richardson ---

[RFC PATCH 1/7] telemetry: rename unsigned 64-bit enum value to uint

2022-12-13 Thread Bruce Richardson
For telemetry data, rather than having unsigned 64-bit values and signed 32-bit values, we want to just have unsigned and signed values, each stored with the max bit-width i.e. 64-bits. To that end, we rename the U64 enum entry to "UINT" to have a more generic name For backward API-level compatibi

[RFC PATCH 0/7] Standardize telemetry int types

2022-12-13 Thread Bruce Richardson
Rather than having 64-bit unsigned types and 32-bit signed types supported by the telemetry lib, we should support 64-bit values for both types. On the naming side, since both are 64-bit, we should no longer call the unsigned value u64 - "uint" is better. This patchset implements these changes as

Re: [PATCH 2/4] eal: allow applications to report their cpu usage

2022-12-13 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 04:49:31PM +0100, Robin Jarry wrote: > Robin Jarry, Dec 07, 2022 at 17:21: > > Allow applications to register a callback that will be invoked in > > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > > > The callback is expected to return the number of

Re: help with pthread_t deprecation / api changes

2022-12-13 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 09:32:06AM +0100, Thomas Monjalon wrote: > 12/12/2022 18:45, Tyler Retzlaff: > > On Sun, Dec 11, 2022 at 08:50:48AM +0100, Thomas Monjalon wrote: > > > 10/12/2022 00:49, Tyler Retzlaff: > > > > On Fri, Dec 09, 2022 at 10:13:44PM +0100, Thomas Monjalon wrote: > > > > > 09/12/

Re: [PATCH V3 00/11] telemetry: add u32 value type and hex integer string API

2022-12-13 Thread Bruce Richardson
On Mon, Dec 12, 2022 at 12:16:07PM +, Bruce Richardson wrote: > On Mon, Dec 12, 2022 at 01:03:52PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Monday, 12 December 2022 12.21 > > > > > > On Mon, Dec 12, 2022 at 12:02:32PM +0100, Morte

Re: [PATCH V4 1/9] telemetry: move to header to controllable range

2022-12-13 Thread Bruce Richardson
On Tue, Dec 13, 2022 at 06:15:04PM +0800, Huisong Li wrote: > The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause > this header is uncontrollable. So this patch moves this header to inside > '_RTE_TELEMETRY_H_'. s/uncontrollable/unconditional/ ?? > > Fixes: 99a2dd955fba ("lib

Re: [PATCH V4 7/9] telemetry: support adding integer value as hexadecimal

2022-12-13 Thread Bruce Richardson
On Tue, Dec 13, 2022 at 06:15:10PM +0800, Huisong Li wrote: > Sometimes displaying a unsigned integer value as hexadecimal encoded style > is more expected for human consumption, such as, offload capability and > device flag. This patch introduces two APIs to add unsigned integer (can be > one of u

Re: [PATCH RESEND v2 00/11] codeql fixes for various subsystems

2022-12-13 Thread Sinan Kaya
On Tue, 2022-12-13 at 19:59 +0300, Dmitry Kozlyuk wrote: > 2022-12-13 11:43 (UTC-0500), Sinan Kaya: > > Checking to see if I need to cover any feedback. > > There was some feedback to pre-resend v2 that is not visible on > patchwork: > > http://inbox.dpdk.org/dev/cajfav8yee9awya3ovluqavfw0mzonsqj

Re: [PATCH RESEND v2 00/11] codeql fixes for various subsystems

2022-12-13 Thread Dmitry Kozlyuk
2022-12-13 11:43 (UTC-0500), Sinan Kaya: > Checking to see if I need to cover any feedback. There was some feedback to pre-resend v2 that is not visible on patchwork: http://inbox.dpdk.org/dev/cajfav8yee9awya3ovluqavfw0mzonsqjq-k+2q4wampmyrj...@mail.gmail.com/

Re: [PATCH V4 6/9] telemetry: refactor mapping between value and array type

2022-12-13 Thread Bruce Richardson
On Tue, Dec 13, 2022 at 06:15:09PM +0800, Huisong Li wrote: > Currently, use rte_tel_value_type as index of array to find the > tel_container_types in rte_tel_data_start_array. It's not good > for maintenance. > > Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") > Cc: s

Re: [PATCH RESEND v2 00/11] codeql fixes for various subsystems

2022-12-13 Thread Sinan Kaya
On Tue, 2022-11-22 at 10:30 -0500, ok...@kernel.org wrote: > From: Sinan Kaya > Following up the codeql reported problems first submittedby Stephen > Hemminger here: > https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ > > Posting a series of fixes about potential null pointer ac

RE: [PATCH 2/4] eal: allow applications to report their cpu usage

2022-12-13 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 13 December 2022 16.50 > > Robin Jarry, Dec 07, 2022 at 17:21: > > Allow applications to register a callback that will be invoked in > > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > > > The callback is exp

[PATCH v3 1/3] test/bbdev: fix build issue with optional build flag

2022-12-13 Thread Nicolas Chautru
Incorrect bbdev member name used in test code under RTE_BBDEV_OFFLOAD_COST build flag. Fixes: 4f08028c5e24 ("bbdev: expose queue related warning and status") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH v3 3/3] test/bbdev: explicit check for allocation failure

2022-12-13 Thread Nicolas Chautru
Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[PATCH v3 2/3] test/bbdev: fix build issue with optional build flag

2022-12-13 Thread Nicolas Chautru
Missing implementation for offload test with FFT. Only build when the optional build flag RTE_BBDEV_OFFLOAD_COST is set. Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 82

[PATCH v3 0/3] test/bbdev: fix build issues with optional build flag

2022-12-13 Thread Nicolas Chautru
v3: add more Fixes tag for missing error check commit v2: add check in offload test function for error during allocation suggested by Maxime. Fixing compilation errors in bbdev-test application on rc4 when the optional flag RTE_BBDEV_OFFLOAD_COST is set manually. This was raised by Vipin. Nicolas

Re: [PATCH 2/4] eal: allow applications to report their cpu usage

2022-12-13 Thread Robin Jarry
Robin Jarry, Dec 07, 2022 at 17:21: > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application start and the number o

RE: [PATCH] examples/l2fwd-event: fix function args of worker cleanup

2022-12-13 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Shijith Thotton > Sent: Monday, December 12, 2022 9:19 PM > To: Jerin Jacob Kollanukkaran > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > Nikhilesh Bhagavatula > Subject: [PATCH] examples/l2fwd-event: fix function args of worker cleanup > > Fixed function ca

[PATCH] event/cnxk: arm early to account for software delays

2022-12-13 Thread Shijith Thotton
Arm a bucket early to account for software delays in timer arm routine. Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_worker.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/event/cnxk/cnxk_tim_worker.h b/drivers/event/cnxk/cnxk_tim_worker.h

[PATCH] ci: drop Travis configuration

2022-12-13 Thread David Marchand
We stopped using Travis in the main branch and in the public CI in favor of GHA more than a year ago. The UNH community lab now covers testing native compilation and unit tests for ARM platforms. We decided to stop maintaining the configuration in our repository with the argument that "if it is no

DPDK 20.11.7 released

2022-12-13 Thread luca . boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-20.11.7.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=20.11 Luca Boccassi --- .github/workflows/build.yml| 19 +- VERSION

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-13 Thread Ferruh Yigit
On 12/13/2022 9:35 AM, Ferruh Yigit wrote: > On 12/13/2022 7:52 AM, You, KaisenX wrote: >> >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: 2022年12月8日 23:04 >>> To: You, KaisenX ; dev@dpdk.org; Burakov, >>> Anatoly ; David Marchand >>> >>> Cc: sta...@dpdk.org; Yang, Qiming ; Zho

RE: [PATCH v4 1/4] eal: add generic support for reading PMU events

2022-12-13 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Tuesday, 13 December 2022 11.44 > > Add support for programming PMU counters and reading their values > in runtime bypassing kernel completely. > > This is especially useful in cases where CPU cores are isolated > (nohz_full) i.e ru

Re: 21.11.3 patches review and test

2022-12-13 Thread Christian Ehrhardt
On Tue, Dec 6, 2022 at 12:30 PM Kevin Traynor wrote: > > Hi all, > > Here is a list of patches targeted for stable release 21.11.3. > > The planned date for the final release is 19th December. > > Please help with testing and validation of your use cases and report > any issues/results with reply-

Re: 19.11.14 patches review and test

2022-12-13 Thread Christian Ehrhardt
On Sun, Dec 11, 2022 at 3:40 PM Ali Alnubani wrote: > > > -Original Message- > > From: christian.ehrha...@canonical.com > > > > Sent: Monday, November 28, 2022 3:17 PM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; benjamin.wal...@intel.com; David > >

Re: 19.11.14 patches review and test

2022-12-13 Thread Christian Ehrhardt
On Wed, Dec 7, 2022 at 11:26 AM Jiang, YuX wrote: > > Hi All, > > Update the test status for Intel part. DPDK19.11.14-rc1 validation test is > almost finished, no critical issue is found, but find some new bugs for build > and power management. > New defects for build: No fix yet. > http

Re: 19.11.14 patches review and test

2022-12-13 Thread Christian Ehrhardt
Thank you all so much - @ Jiang YuX, YangHang Liu, Ali Alnubani ! To add my own that just completed last night: Same tests as usual, no regressions found: 19.11.14~rc1-0ubuntu0.20.04.1~focalppa1 1.0.0 (14:11:38): phys (BM) tests 1.1.0 (14:11:38): initialize environment 1.1.1 (14:14:57): t

Re: Question about add ethdev loopback set API

2022-12-13 Thread Ferruh Yigit
On 12/13/2022 10:04 AM, fengchengwen wrote: > Hi Ferruh, > > During the test, we need to delineate where go wrong when encountered > e.g. CRC error. In this scenario, loopback is useful. > > I think we can add a loopback set API which could set inner or outer loop, > and user can use tele

RE: [PATCH V3 00/11] telemetry: add u32 value type and hex integer string API

2022-12-13 Thread Morten Brørup
Med venlig hilsen / Kind regards, -Morten Brørup > -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 12 December 2022 13.16 > To: Morten Brørup > Cc: Huisong Li; dev@dpdk.org; ciara.po...@intel.com; > liudongdo...@huawei.com; huangda...@hua

[PATCH] net/af_xdp: AF_XDP PMD CNI Integration

2022-12-13 Thread Koikkara Reeny, Shibin
From: Shibin Koikkara Reeny Integrate support for the AF_XDP CNI and device plugin so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privilege

[PATCH v4 2/4] eal/arm: support reading ARM PMU events in runtime

2022-12-13 Thread Tomasz Duszynski
Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/eal/arm/include/meson.build | 1 + lib/eal/arm/include/rte_pmu_pmc.h | 39 +++ lib/eal/arm/meson.build | 4 ++ lib/eal/arm/rte_pmu.c

[PATCH v4 3/4] eal/x86: support reading Intel PMU events in runtime

2022-12-13 Thread Tomasz Duszynski
Add support for reading Intel PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 2 ++ lib/eal/include/rte_pmu.h | 2 +- lib/eal/x86/include/meson.build | 1 + lib/eal/x86/include/rte_pmu_pmc.h | 33 +++ 4 files

[PATCH v4 4/4] eal: add PMU support to tracing library

2022-12-13 Thread Tomasz Duszynski
In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[PATCH v4 1/4] eal: add generic support for reading PMU events

2022-12-13 Thread Tomasz Duszynski
Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performa

[PATCH v4 0/4] add support for self monitoring

2022-12-13 Thread Tomasz Duszynski
This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain adventages when application runs on isolated cores with nohz_full kernel parameter. Events can be read directly using rte_pm

[PATCH V4 8/9] test: add test cases for adding hex integer value API

2022-12-13 Thread Huisong Li
Add test cases for adding hexadecimal unsigned integer value API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 158 + 1 file changed, 158 insertions(+) diff --git a/app/test/test_telemetry_data.c

[PATCH V4 9/9] ethdev: display capability values in hexadecimal format

2022-12-13 Thread Huisong Li
The 'dev_flags', 'rx_offloads', 'tx_offloads' and 'rss_hf' are better displayed in hexadecimal format. Like: -->old display by input /ethdev/info,0 "dev_flags": 3, "rx_offloads": 524288, "tx_offloads": 65536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3",

[PATCH V4 7/9] telemetry: support adding integer value as hexadecimal

2022-12-13 Thread Huisong Li
Sometimes displaying a unsigned integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces two APIs to add unsigned integer (can be one of uint8_t, uint16_t, uint32_t and uint64_t type) value as hexadecimal e

[PATCH V4 6/9] telemetry: refactor mapping between value and array type

2022-12-13 Thread Huisong Li
Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acke

[PATCH V4 5/9] mem: possible data truncation and conversion error

2022-12-13 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' and 'u64' datas need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/eal/common/eal_

[PATCH V4 1/9] telemetry: move to header to controllable range

2022-12-13 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Mo

[PATCH V4 3/9] mempool: fix possible data truncation and conversion error

2022-12-13 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' and 'u64' datas need to use the 'u64' APIs to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/mempool/

[PATCH V4 4/9] cryptodev: fix possible data conversion error

2022-12-13 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data needs to use the 'u64' APIs to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/cryptodev/rte_cryptodev.c | 2 +

[PATCH V4 2/9] ethdev: fix possible data truncation and conversion error

2022-12-13 Thread Huisong Li
The 'u32' and 'u64' datas can not assigned to 'int' type variable. The 'u32' and 'u64' datas need to use the 'u64' APIs to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng -

[PATCH V4 0/9] telemetry: fix data truncation and conversion error and add hex integer API

2022-12-13 Thread Huisong Li
Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. This patch series uses 'u64' functions to do this. In addition, this patch series introduces two APIs to store unsigned integer values as

Re: 20.11.7 patches review and test

2022-12-13 Thread Luca Boccassi
Thank you, I'll apply the fix for the last build issue and release then On Tue, 13 Dec 2022 at 09:05, Jiang, YuX wrote: > > Hi Luca, > > 1, Compilation error compiling dpdk with vm_power_manager sample app > - Not fixed yet, but also not too bad and thereby does not block release. > 2, vf_interru

Question about add ethdev loopback set API

2022-12-13 Thread fengchengwen
Hi Ferruh, During the test, we need to delineate where go wrong when encountered e.g. CRC error. In this scenario, loopback is useful. I think we can add a loopback set API which could set inner or outer loop, and user can use telemetry to set the loopback in the above scenario. I'd

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-13 Thread Ferruh Yigit
On 12/13/2022 7:52 AM, You, KaisenX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: 2022年12月8日 23:04 >> To: You, KaisenX ; dev@dpdk.org; Burakov, >> Anatoly ; David Marchand >> >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX >> ; Wu, Jingjing ; Xing, >> Beilei ; Zha

[PATCH] net/mlx5: add debug support for dumping all rte ports

2022-12-13 Thread Alex Vesker
Add a special value max_uint16 to request dump of all rte ethernet ports. This is useful for collecting the full info from all the ports in a single dump. Signed-off-by: Alex Vesker Reviewed-by: Ori Kam --- drivers/net/mlx5/linux/mlx5_socket.c | 39 ++-- 1 file changed,

[PATCH v11 3/6] memarea: support alloc/free/refcnt-update API

2022-12-13 Thread Chengwen Feng
This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_refcnt_update() API. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 10 ++ lib/memarea/memarea_private.h | 3 + lib/memarea/rte_memarea.c | 157 ++ lib

[PATCH v11 1/6] memarea: introduce memarea library

2022-12-13 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. This patch provides rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/api/doxy-api-index.md | 3 +- d

[PATCH v11 4/6] test/memarea: support alloc/free/refcnt-update test

2022-12-13 Thread Chengwen Feng
This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_refcnt_update() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 145 +++- 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/app/test/test_memarea.c b/app/test

[PATCH v11 6/6] test/memarea: support dump test

2022-12-13 Thread Chengwen Feng
This patch supports rte_memarea_dump() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c index 00f9d07ed4..da712a14e8 100644 --- a/app/test/test

[PATCH v11 5/6] memarea: support dump API

2022-12-13 Thread Chengwen Feng
This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 3 + lib/memarea/rte_memarea.c | 98 +++ lib/memarea/rte_memarea.h | 21 ++ lib/memarea/version.

[PATCH v11 0/6] introduce memarea library

2022-12-13 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The memory region can be initialized from the following memory sources: 1. HEAP: e.g. invoke rte_malloc_socket. 2. LIBC: e.g. invoke posix_memalign. 3. Another me

[PATCH v11 2/6] test/memarea: support memarea test

2022-12-13 Thread Chengwen Feng
This patch supports memarea test of rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng --- MAINTAINERS | 1 + app/test/meson.build| 2 + app/test/test_memarea.c | 130 3 files changed, 133 insertions(+) c

[PATCH v2] net/i40e: don't check link status on device start

2022-12-13 Thread David Marchand
The mentioned changes broke existing applications when the link status of i40e ports is down at the time the port is started. Revert those changes, the original issue will need a different fix. Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") Fixes: 2184f7cdeeaa ("net/i40e

RE: 20.11.7 patches review and test

2022-12-13 Thread Jiang, YuX
Hi Luca, 1, Compilation error compiling dpdk with vm_power_manager sample app - Not fixed yet, but also not too bad and thereby does not block release. 2, vf_interrupt_pmd/nic_interrupt_VF_vfio_pci: l3fwd-power Wake up failed on X722 37d0 - Find on DPDK22.11, it has fix patch: https://patchwor

RE: [PATCH v2 4/4] common/ml: add Arm NEON type conversion routines

2022-12-13 Thread Ruifeng Wang
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, December 13, 2022 1:21 AM > To: Srikanth Yalavarthi ; Ruifeng Wang > > Cc: dev@dpdk.org; sshankarn...@marvell.com; jer...@marvell.com; > apra...@marvell.com > Subject: [PATCH v2 4/4] common/ml: add Arm NEON type conversio

Re: [External] Re: [PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach

2022-12-13 Thread David Marchand
On Tue, Dec 13, 2022 at 9:54 AM Fengnan Chang wrote: > > Thomas Monjalon 于2022年12月13日周二 16:34写道: > > > > 13/12/2022 08:59, Fengnan Chang: > > > Alarm and multiprocess hotplug still need access hugepage memory, > > > if alarm event processed after memory detach, it may cause SEGV. > > > So cleanup

Re: [PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach

2022-12-13 Thread Thomas Monjalon
13/12/2022 08:59, Fengnan Chang: > Alarm and multiprocess hotplug still need access hugepage memory, > if alarm event processed after memory detach, it may cause SEGV. > So cleanup alarm and multiprocess hotplug before memory detach. > > Signed-off-by: Fengnan Chang > --- > lib/eal/linux/eal.c |

Re: help with pthread_t deprecation / api changes

2022-12-13 Thread Thomas Monjalon
12/12/2022 18:45, Tyler Retzlaff: > On Sun, Dec 11, 2022 at 08:50:48AM +0100, Thomas Monjalon wrote: > > 10/12/2022 00:49, Tyler Retzlaff: > > > On Fri, Dec 09, 2022 at 10:13:44PM +0100, Thomas Monjalon wrote: > > > > 09/12/2022 21:06, Tyler Retzlaff: > > > > > On Fri, Dec 09, 2022 at 08:48:14AM -0

[PATCH] vdpa/ifc: improve device stop logic for block device

2022-12-13 Thread Andy Pei
For block device, we make sure no IO is inflight before we stop device. We terminate the notify relay process and wait for all inflight IOs to be completed. So in this period, we wait for hardware to update used index, there is no need to relay new kick. Signed-off-by: Andy Pei --- drivers/vdpa/

  1   2   >