> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 13 December 2022 20.34 > > 13/12/2022 18:38, Tyler Retzlaff: > > Okay, just one final confirmation. This is what we would like? > > > > * completely remove the existing rte_thread_getname api. > > - by implication this means remove the 1 use of it in eal in > > logging. > > > > * introduce a new void rte_thread_set_name(rte_thread_t, const char > *name) > > that: > > - returns void (does not fail), but in cases it can be detected > will > > log a DEBUG level log message. > > - quietly truncates the name (if longer) to > RTE_MAX_THREAD_NAME_LEN on > > all platforms.
Consider also DEBUG logging if truncating the name. Your choice - do or don't is fine with me. > > - document that it is best effort and only works if the stars > align > > for the target platform. > > > > * there will be no unit test, since the set doesn't fail and there is > no > > get to validate the set. > > > > once i get confirmation i'll update the series. > > Just my opinion: this proposal is my preference, yes. > What others think? LGTM.
