xstats id type

2022-10-12 Thread Morten Brørup
+TO: rawdev maintainers, regexdev maintainers > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 12 October 2022 22.44 > > 12/10/2022 18:47, Jerin Jacob: > > On Wed, Oct 12, 2022 at 9:58 PM Thomas Monjalon > wrote: > > > > > > 12/10/2022 18:16, Jerin Jacob: > > > > On Wed, O

Re: [PATCH v2 4/4] event/dlb2: fix port cos override calculation

2022-10-12 Thread Jerin Jacob
On Thu, Oct 13, 2022 at 5:21 AM Abdullah Sevincer wrote: > > This commit fixes a calculation error > of total number of ldb ports during port cos > override from dlb2 event structure. > > Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS") > Cc: sta...@dpdk.org > > Signed-off-by: Abd

[PATCH v4 2/2] examples/vhost: unconfigure DMA vchannel

2022-10-12 Thread xuan . ding
From: Xuan Ding This patch applies rte_vhost_async_dma_unconfigure() to manually free DMA vchannels. Before unconfiguration, need make sure the specified DMA device is no longer used by any vhost ports. Signed-off-by: Xuan Ding --- examples/vhost/main.c | 38 +--

[PATCH v4 1/2] vhost: introduce DMA vchannel unconfiguration

2022-10-12 Thread xuan . ding
From: Xuan Ding Add a new API rte_vhost_async_dma_unconfigure() to unconfigure DMA vchannels in vhost async data path. Lock protection are also added to protect DMA vchannels configuration and unconfiguration from concurrent calls. Signed-off-by: Xuan Ding --- doc/guides/prog_guide/vhost_lib.r

[PATCH v4 0/2] vhost: introduce DMA vchannel unconfiguration

2022-10-12 Thread xuan . ding
From: Xuan Ding This patchset introduces a new API rte_vhost_async_dma_unconfigure() to help user to manually free DMA vchannels finished to use. Note: this API should be called after async channel unregister. v4: * Rebase to 22.11 rc1. * Fix the usage of 'dma_ref_count' to make sure the specif

[PATCH] net/ice/base: fix duplicate flow rules

2022-10-12 Thread Yiding Zhou
When a vsi that already exists in the created vsi_list subscribes to the same filter again, the return value ICE_SUCCESS results in duplicate flow rules to be stored, which will cause 'flush' and 'destroy' errors. Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe") Cc: st

[PATCH v4] net/iavf: fix error of virtchnl command

2022-10-12 Thread Yiding Zhou
When the device is bonded, bond pmd will register callback for LSC event. This callback will execute some virtchnl commands in eal-intr-thread to reinitialize the device with interrupts disabled. In this case, responses to all commands not be received. This commit starts a thread to handle all eve

RE: [PATCH] net/iavf: fix default state for Rx timestamp enabling

2022-10-12 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, October 13, 2022 9:48 AM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix default state for Rx timestamp enabling > > This patch adds per queue o

RE: [PATCH] net/iavf: support raw packet for flow subscription

2022-10-12 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Jie1X > Sent: Sunday, October 9, 2022 5:01 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; Zhang, Qi Z > ; Yang, Qiming ; Wu, > Jingjing ; Xing, Beilei ; Wang, > Jie1X > Subject: [PATCH] net/iavf: support raw packet for flow subscription > > Add Protocol

RE: release candidate 22.11-rc1

2022-10-12 Thread Jiang, YuX
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 11, 2022 9:50 AM > To: annou...@dpdk.org > Subject: release candidate 22.11-rc1 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v22.11-rc1 > > There are 737 new patches

[PATCH] test/cryptodev: fix PDCP vectors

2022-10-12 Thread Anoob Joseph
The existing PDCP vectors have a deviation from the PDCP header specification. The reserved fields are set to 0 in the PDCP headers and D/C bits are updated as per the use case. The MAC-I for the corresponding vectors are also updated. Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap case

RE: [PATCH] net/iavf: fix IPsec flow create error check

2022-10-12 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, October 11, 2022 5:44 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; Nicolau, Radu > ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix IPsec flow create error check > > Fix an error check where the re

RE: [PATCH] net/ice: null field checks in ice_{r,t}x_queue_release

2022-10-12 Thread Zhang, Qi Z
> -Original Message- > From: Markus Theil > Sent: Wednesday, October 12, 2022 8:28 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Tomasz Jonak > Subject: [PATCH] net/ice: null field checks in ice_{r,t}x_queue_release > > From: Tomasz Jonak > > In case rte_eth_dma_zone_re

Re: [PATCH v3] app/testpmd: fix incorrect queues state of secondary process

2022-10-12 Thread Stephen Hemminger
On Tue, 6 Sep 2022 22:53:10 +0800 Peng Zhang wrote: > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { > + struct fwd_stream *fs = fwd_streams[i]; > + struct rte_eth_dev_data *dev_rx_data, > *dev_tx_data; > + > +

RE: [PATCH v1] net/iavf: fix taninted scalar

2022-10-12 Thread Zhang, Qi Z
> -Original Message- > From: Steve Yang > Sent: Tuesday, October 11, 2022 4:34 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; Yang, SteveX > Subject: [PATCH v1] net/iavf: fix taninted scalar > > Passing tainted expression "rss_meta->proto_hdrs.count" to > "iavf_refine_pro

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, October 13, 2022 9:00 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 7/8] vhost: vDPA blk d

RE: [PATCH v3] app/testpmd: fix incorrect queues state of secondary process

2022-10-12 Thread Zhou, YidingX
Hi > -Original Message- > From: Zhou, YidingX > Sent: Thursday, September 29, 2022 9:58 AM > To: Zhang, Peng1X ; lihuisong (C) > ; dev@dpdk.org; andrew.rybche...@oktetlabs.ru > Cc: Singh, Aman Deep ; Zhang, Yuying > > Subject: RE: [PATCH v3] app/testpmd: fix incorrect queues state of sec

[PATCH] net/iavf: fix default state for Rx timestamp enabling

2022-10-12 Thread Simei Su
This patch adds per queue offload check to turn off Rx timestamp offload by default. Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor") Cc: sta...@dpdk.org Signed-off-by: Simei Su v2: * Refine commit log. --- drivers/net/iavf/iavf_vchnl.c | 3 ++- 1 file changed, 2 insert

RE: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately report idle

2022-10-12 Thread Naga Harish K, S V
> -Original Message- > From: Jayatheerthan, Jay > Sent: Tuesday, October 11, 2022 12:40 PM > To: mattias.ronnblom ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; Jerin Jacob ; Naga > Harish K, S V > Cc: dev@dpdk.org; Van Haaren, Harry ; > hof...@lysator.liu.se; mattias.ronnblom > Subje

RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-12 Thread Chautru, Nicolas
Hi Maxime, Akhil, (replying to myself) > > Hi Maxime, Akhil, > > <...> > > > This is same comment as for ACC100 vs. ACC101. > > > Having a single API would be the way to go, given the prototype > > > of the functions are identical. > > > > > > Keep acc200 function, but inte

RE: [PATCH 3/4] eventdev: have ethernet Tx adapter appropriately report idle

2022-10-12 Thread Naga Harish K, S V
> -Original Message- > From: Jayatheerthan, Jay > Sent: Tuesday, October 11, 2022 12:41 PM > To: mattias.ronnblom ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; Jerin Jacob ; Naga > Harish K, S V > Cc: dev@dpdk.org; Van Haaren, Harry ; > hof...@lysator.liu.se; mattias.ronnblom > Subje

RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-12 Thread Chautru, Nicolas
Hi Maxime, Akhil, <...> > > This is same comment as for ACC100 vs. ACC101. > > Having a single API would be the way to go, given the prototype of > > the functions are identical. > > > > Keep acc200 function, but internal only, rte_acc_configure() would > > call the acc100

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, October 12, 2022 8:13 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao, > Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any > queue is ready > > Hi Chen

[PATCH v2 4/4] event/dlb2: fix port cos override calculation

2022-10-12 Thread Abdullah Sevincer
This commit fixes a calculation error of total number of ldb ports during port cos override from dlb2 event structure. Fixes: bec8901bfe9f ("event/dlb2: support ldb port specific COS") Cc: sta...@dpdk.org Signed-off-by: Abdullah Sevincer --- drivers/event/dlb2/dlb2.c | 3 ++- 1 file changed, 2

[PATCH v2 3/4] event/dlb2: remove cos from devargs

2022-10-12 Thread Abdullah Sevincer
This commit removes the cos argument from devargs struct. Since cos is now per port specific only and supported through port_cos in dev_args, there is no need to to have a cos argument in dev_args struct. Signed-off-by: Abdullah Sevincer --- drivers/event/dlb2/dlb2.c | 1 - drivers/event/dl

[PATCH v2 2/4] event/dlb2: add check valid producer coremask

2022-10-12 Thread Abdullah Sevincer
This commit add checks during port probing for validating producer core masks if they are a subset of eal coremask. Error is returned if producer coremask is not a subset of eal coremask. Signed-off-by: Abdullah Sevincer --- drivers/event/dlb2/pf/base/dlb2_resource.c | 21 +

[PATCH v2 1/4] event/dlb2: remove cos from port probing

2022-10-12 Thread Abdullah Sevincer
This commit removes cos (class of service) from port probing criteria and applies enhancements for selection of ports from best cos when default cos (255) is used. Signed-off-by: Abdullah Sevincer --- drivers/event/dlb2/dlb2.c | 5 +- drivers/event/dlb2/dlb2_priv.h

RE: [EXT] [PATCH v12 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Chautru, Nicolas
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 12, 2022 1:13 PM > To: Chautru, Nicolas ; dev@dpdk.org; > maxime.coque...@redhat.com > Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; hemant.agra...@nxp.com; > david.march...@redhat.com; step...@net

Re: rte_event_dev_xstats_reset id type

2022-10-12 Thread Thomas Monjalon
12/10/2022 18:47, Jerin Jacob: > On Wed, Oct 12, 2022 at 9:58 PM Thomas Monjalon wrote: > > > > 12/10/2022 18:16, Jerin Jacob: > > > On Wed, Oct 12, 2022 at 9:05 PM Morten Brørup > > > wrote: > > > > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > Sent: Wednesday, 12 Octob

Re: [PATCH v7] usertools: rewrite pmdinfo

2022-10-12 Thread Thomas Monjalon
12/10/2022 18:48, Robin Jarry: > Thomas Monjalon, Oct 12, 2022 at 18:44: > > OK for executable, > > but can we expect .so to be always executable? > > I think this is the default when linking. Whether dynamic libraries or > executable programs. > > Also, the "must be executable" limitation only a

RE: [EXT] [PATCH v12 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Akhil Goyal
> From: Nic Chautru > > Added support for info_get to allow to query the device. > Null capability exposed. > > Signed-off-by: Nic Chautru Please use same signoffs in all your patches. Previously you were using Nicolas. Modified Nic Chautru -> Nicolas Chautru in all your patches. > Reviewed-by

RE: [EXT] [PATCH v12 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Akhil Goyal
> diff --git a/drivers/baseband/acc/acc200_pmd.h > b/drivers/baseband/acc/acc200_pmd.h > index acead1d17c..587b6f6d5b 100644 > --- a/drivers/baseband/acc/acc200_pmd.h > +++ b/drivers/baseband/acc/acc200_pmd.h > @@ -8,6 +8,7 @@ > #include "acc_common.h" > #include "acc200_pf_enum.h" > #include "a

RE: [PATCH v2 2/2] crypto/cnxk: fix failure from session rework

2022-10-12 Thread Akhil Goyal
> Subject: [PATCH v2 2/2] crypto/cnxk: fix failure from session rework > > Post security session rework, CPTR got changed affecting cn9k IPsec > functionality. Address the same. Also, move all s/w accessible > fast path fields to rte_security_session cacheline for better perf. > > Fixes: 3f3fc3

RE: [v3] crypto/cnxk: support exponent type private key

2022-10-12 Thread Akhil Goyal
> Subject: [v3] crypto/cnxk: support exponent type private key > > This patch adds support for RTE_RSA_KEY_TYPE_EXP in cnxk crypto > driver. > > Signed-off-by: Gowrishankar Muthukrishnan > -- Applied to dpdk-next-crypto Thanks.

RE: [v7 0/3] FIPS asymmetric validation

2022-10-12 Thread Akhil Goyal
> Subject: [v7 0/3] FIPS asymmetric validation > > This patch series adds support in fips_validation app to perform > asymmetric validation. To start with, RSA algorithm is used in > the evaluation. For the key value pairs which is multiprecision > in arithmetic, openssl library is used. > > Chan

RE: [EXT] [PATCH v5 0/4] add remaining SGL support to AESNI_MB

2022-10-12 Thread Akhil Goyal
> Currently, the intel-ipsec-mb library only supports SGL for > GCM and ChaCha20-Poly1305 algorithms through the JOB API. > > To add SGL support for other algorithms, a workaround approach is > added in the AESNI_MB PMD. SGL feature flags can now be added to > the PMD. > > Some additional Snow3G

[PATCH v2 0/1] doc: update to include bbdev snippet using literalinclude

2022-10-12 Thread Nicolas Chautru
v2: Rebased to latest to avoid git am failure when applying. v1: Update to include bbdev snippet using literalinclude. Nicolas Chautru (1): doc: update to include bbdev snippet using literalinclude doc/guides/prog_guide/bbdev.rst | 105 +++- lib/bbdev/rte_bbdev_op.h

[PATCH v2 1/1] doc: update to include bbdev snippet using literalinclude

2022-10-12 Thread Nicolas Chautru
Adding code snippet using literalinclude so that to keep automatically these structures in doc in sync with the bbdev source code. Signed-off-by: Nicolas Chautru --- doc/guides/prog_guide/bbdev.rst | 105 +++- lib/bbdev/rte_bbdev_op.h| 15 + 2 files chang

[PATCH v12 16/16] test-bbdev: unit test capability extension

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added support for bbdev level unit test for the FFT operations and for Soft-Output options. Also added 2 small test vectors for the FFT operation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c| 540 +++- app/test-bbdev/test_bbdev_

[PATCH v12 15/16] baseband/acc: add helper function for descriptor index

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added set of helper functions used through the code to track descriptor indexes in a queue ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/acc_common.h | 41 - drivers/baseband/acc/rte_acc100_pmd.c | 124 ++ drivers/baseband/acc/

[PATCH v12 14/16] baseband/acc: simplify meson dependency

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Removed some of libraries from the external dependency captured in meson build file which are not required. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v12 13/16] baseband/acc: add PF configure companion function

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). That function is kept common to all ACC devices. Signed-off-by: Nic Chautru Acked-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c

[PATCH v12 12/16] baseband/acc: add device status and vf2pf comms

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a

[PATCH v12 11/16] baseband/acc: support interrupt

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 302 +- 1 file changed, 299 insertions(+), 3 deleti

[PATCH v12 10/16] baseband/acc: add support for FFT operations

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for FFT processing Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 235 +- 1 file changed, 233 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc2

[PATCH v12 09/16] baseband/acc: add LTE processing functions

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for 4G FEC Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 818 +- 1 file changed, 813 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c

[PATCH v12 08/16] baseband/acc: add LDPC processing functions

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added LDPC encode and decode processing functions. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 84 ++ drivers/baseband/acc/rte_acc200_pmd.c | 1269 - 2 files changed, 1348 insertions(+), 5 dele

[PATCH v12 07/16] baseband/acc: add queue configuration for ACC200

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added function to create and configure queues for the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 391 +- 2 files changed, 391 insertions(+)

[PATCH v12 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pmd.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 231 ++ 2 files change

[PATCH v12 05/16] baseband/acc: add HW register definitions for ACC200

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Added registers list and structure to access the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pf_enum.h | 108 + drivers/baseband/acc/acc200_pmd.h | 163 ++ drivers/baseband/acc/ac

[PATCH v12 04/16] baseband/acc: introduce PMD for ACC200

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Introduced stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS| 3 + doc/guides/bbdevs/acc200.rst | 257 + doc/gu

[PATCH v12 03/16] baseband/acc: rename directory from acc100 to acc

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Used a common directory for the ACC PMDs Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS | 2 +- app/test-bbdev/meson.build| 4 ++-- app/test-bbdev/test_bbdev_perf.c

[PATCH v12 01/16] baseband/acc100: remove unused registers

2022-10-12 Thread Nicolas Chautru
From: Nic Chautru Cleanep up the enum files to remove un-used registers definitions. No functionality change. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/acc100_pf_enum.h | 939 --- 1 file changed, 939 deletions(-) diff --git a/driv

[PATCH v12 00/16] bbdev ACC200 PMD

2022-10-12 Thread Nicolas Chautru
v12: Rebase between commits notably to avoid interim build issue and test vector format issue raised by Akhil. Thanks. v11: Fixed clang compilation error introduced in v10 16/16. Thanks v10: Update of patch 13 to expose a single configuration API for the ACC devices. New commit 15 to ref

RE: [EXT] [PATCH v11 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Chautru, Nicolas
Hi Akhil, OK. Fixing this this morning + test_vector extra line. Thanks Nic > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 12, 2022 5:31 AM > To: Chautru, Nicolas ; dev@dpdk.org; > maxime.coque...@redhat.com > Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce

Re: [PATCH 2/2] ci: update to new API for step outputs in GHA

2022-10-12 Thread David Marchand
On Wed, Oct 12, 2022 at 6:30 PM David Marchand wrote: > > GitHub actions deprecated use of set-output, replaced with > GITHUB_OUTPUT. > > Note: we still have some warnings, as of today, because of > actions/cache@v3 which did not migrate yet. For the record, the changes in actions/cache@v3 are pu

Re: [PATCH v7] usertools: rewrite pmdinfo

2022-10-12 Thread Robin Jarry
Thomas Monjalon, Oct 12, 2022 at 18:44: > OK for executable, > but can we expect .so to be always executable? I think this is the default when linking. Whether dynamic libraries or executable programs. Also, the "must be executable" limitation only applies on the files specified on the command li

Re: rte_event_dev_xstats_reset id type

2022-10-12 Thread Jerin Jacob
On Wed, Oct 12, 2022 at 9:58 PM Thomas Monjalon wrote: > > 12/10/2022 18:16, Jerin Jacob: > > On Wed, Oct 12, 2022 at 9:05 PM Morten Brørup > > wrote: > > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Sent: Wednesday, 12 October 2022 17.13 > > > > > > > > 12/10/2022 14:14,

Re: [PATCH v7] usertools: rewrite pmdinfo

2022-10-12 Thread Thomas Monjalon
12/10/2022 18:30, Robin Jarry: > Thomas Monjalon, Oct 12, 2022 at 18:16: > > What about implementing both? > > If ldd is available, use it, > > otherwise use LD_TRACE_LOADED_OBJECTS variable. > > This is a bit overkill in my opinion. Also it would make the behaviour > somewhat different whether ld

Re: [PATCH v7] usertools: rewrite pmdinfo

2022-10-12 Thread Robin Jarry
Thomas Monjalon, Oct 12, 2022 at 18:16: > What about implementing both? > If ldd is available, use it, > otherwise use LD_TRACE_LOADED_OBJECTS variable. This is a bit overkill in my opinion. Also it would make the behaviour somewhat different whether ldd is available and/or the analyzed binaries a

[PATCH 2/2] ci: update to new API for step outputs in GHA

2022-10-12 Thread David Marchand
GitHub actions deprecated use of set-output, replaced with GITHUB_OUTPUT. Note: we still have some warnings, as of today, because of actions/cache@v3 which did not migrate yet. Signed-off-by: David Marchand --- .github/workflows/build.yml | 21 +++-- 1 file changed, 7 insertions

[PATCH 1/2] ci: bump versions of actions in GHA

2022-10-12 Thread David Marchand
GitHub started deprecating GHA actions based on Node 12 [1]. For now, only warnings are raised, but we might as well switch to v3 versions of the common actions, now. 1: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ Signed-off

[PATCH 0/2] GitHub Actions configuration fixes

2022-10-12 Thread David Marchand
GitHub Actions started to deprecated some part of the workflow syntax and dependencies of some core actions. This series (mostly) fix those warnings. For reviewers/testers, this is still moving: I got new warnings while I was testing the first patch... -- David Marchand David Marchand (2): c

Re: rte_event_dev_xstats_reset id type

2022-10-12 Thread Thomas Monjalon
12/10/2022 18:16, Jerin Jacob: > On Wed, Oct 12, 2022 at 9:05 PM Morten Brørup > wrote: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Wednesday, 12 October 2022 17.13 > > > > > > 12/10/2022 14:14, Van Haaren, Harry: > > > > From: Morten Brørup > > > > > From: Van Haare

Re: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch

2022-10-12 Thread Thomas Monjalon
12/10/2022 17:16, Ankur Dwivedi: > > >-Original Message- > >From: Thomas Monjalon > >Sent: Wednesday, October 12, 2022 6:39 PM > >To: Ankur Dwivedi > >Cc: dev@dpdk.org; Akhil Goyal ; > >royzhang1...@gmail.com; Amit Prakash Shukla ; > >Jerin Jacob Kollanukkaran ; Ankur Dwivedi > >; david.

Re: [PATCH v7] usertools: rewrite pmdinfo

2022-10-12 Thread Thomas Monjalon
12/10/2022 17:16, Olivier Matz: > On Tue, Oct 11, 2022 at 12:44:56AM +0200, Thomas Monjalon wrote: > As discussed off-list with Robin, it appears that "ldd" is not available > on buildroot-based images. See: > http://lists.busybox.net/pipermail/buildroot/2013-July/074927.html > > The link is quite

Re: rte_event_dev_xstats_reset id type

2022-10-12 Thread Jerin Jacob
On Wed, Oct 12, 2022 at 9:05 PM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 12 October 2022 17.13 > > > > 12/10/2022 14:14, Van Haaren, Harry: > > > From: Morten Brørup > > > > From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com] > >

RE: rte_event_dev_xstats_reset id type

2022-10-12 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 12 October 2022 17.13 > > 12/10/2022 14:14, Van Haaren, Harry: > > From: Morten Brørup > > > From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com] > > > > From: Jerin Jacob > > > > > On Wed, Oct 12, 2022 at 1:40 PM Mor

Re: [PATCH] doc: fix support table for ETH and VLAN flow items

2022-10-12 Thread Thomas Monjalon
07/10/2022 13:55, Ilya Maximets: > On 10/7/22 13:50, Ilya Maximets wrote: > > On 9/12/22 12:09, Thomas Monjalon wrote: > >> 16/03/2022 13:01, Ilya Maximets: > >>> 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk. > >>> Other drivers doesn't support it. Most of them (like i40e) just > >

Re: [PATCH 2/2] build: export dpdk_includes for subproject usage.

2022-10-12 Thread Bruce Richardson
On Wed, Oct 12, 2022 at 04:47:04PM +0200, Markus Theil wrote: > From: Thorben Roemer > > In order to perform things like LTO more easily in > our DPDK applications, we use DPDK as a meson subproject. > Also export includes in order to be usable in this context. > > Signed-off-by: Thorben Roemer

Re: [PATCH 1/2] build: allow to conditionally build apps

2022-10-12 Thread Bruce Richardson
On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote: > Makes apps configureable from meson, like already > possible for drivers. > > Signed-off-by: Markus Theil > --- > app/meson.build | 17 - > meson_options.txt | 4 > 2 files changed, 16 insertions(+), 5 deleti

Re: [PATCH v7] usertools: rewrite pmdinfo

2022-10-12 Thread Olivier Matz
Hi, On Tue, Oct 11, 2022 at 12:44:56AM +0200, Thomas Monjalon wrote: > 04/10/2022 21:29, Robin Jarry: > > dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag > > merely prints multiple independent JSON lines which cannot be fed > > directly to any JSON parser. Moreover, the sc

RE: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch

2022-10-12 Thread Ankur Dwivedi
>-Original Message- >From: Thomas Monjalon >Sent: Wednesday, October 12, 2022 6:39 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Akhil Goyal ; >royzhang1...@gmail.com; Amit Prakash Shukla ; >Jerin Jacob Kollanukkaran ; Ankur Dwivedi >; david.march...@redhat.com >Subject: [EXT] Re: [PATCH v2

Re: DPDK PDUMP pcapng usage

2022-10-12 Thread Stephen Hemminger
On Tue, 11 Oct 2022 15:11:02 + Sylvia Grundwürmer wrote: > Hi, > > i am running DPDK 22.03 on a NXP platform, using 2 eth ports (dpmac, dpni, > dprc config should be OK, as i get bursts of packets with testpmd and in a > little customized app > which is just checking if packets are bursted

Re: [PATCH v4] pci: read amd iommu virtual address width

2022-10-12 Thread Stephen Hemminger
On Tue, 11 Oct 2022 16:08:53 +0200 Michael Piszczek wrote: > + mgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + > 1; > } > + else { Minor nit, the kernel style used by DPDK uses "cuddle else" } else {

Re: [PATCH] net/bonding: fix socket_id type

2022-10-12 Thread Ferruh Yigit
On 10/12/2022 3:20 PM, Markus Theil wrote: On 10/12/22 14:23, Ferruh Yigit wrote: On 10/12/2022 12:45 PM, Markus Theil wrote: From: Thorben Roemer DPDK uses int or u32 in most other places for socket IDs. Fix compilation warnings by also using int in the bonding code. Hi Markus, 'rte_eth_

Re: rte_event_dev_xstats_reset id type

2022-10-12 Thread Thomas Monjalon
12/10/2022 14:14, Van Haaren, Harry: > From: Morten Brørup > > From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com] > > > From: Jerin Jacob > > > > On Wed, Oct 12, 2022 at 1:40 PM Morten Brørup wrote: > > > > > > > > > > Hi Jerin (eventdev maintainer), > > > > > > > > + harry.van.haa...@in

Re: [PATCH v1] event/dlb2: add port probing enhancements

2022-10-12 Thread Jerin Jacob
On Wed, Oct 12, 2022 at 8:02 PM Abdullah Sevincer wrote: > > This commit is an enhancement for previously > implemented port probing optimizations. Changes > are below: > > 1-Since cos is now per port, remove the device and > domain specific cos from dev_args struct. > > 2-Changes for using best c

Re: [PATCH] event/sw: fix selftest xstats reset API usage

2022-10-12 Thread Thomas Monjalon
12/10/2022 15:08, Van Haaren, Harry: > From: Thomas Monjalon > > 12/10/2022 14:34, Harry van Haaren: > > > The eventdev xstats reset API takes an ID of "uint32_t", while > > > the rest of the xstats APIs require an "unsigned int". On some > > > platforms these might not be the same bitwidth, howev

[PATCH 2/2] build: export dpdk_includes for subproject usage.

2022-10-12 Thread Markus Theil
From: Thorben Roemer In order to perform things like LTO more easily in our DPDK applications, we use DPDK as a meson subproject. Also export includes in order to be usable in this context. Signed-off-by: Thorben Roemer --- drivers/meson.build | 1 + lib/meson.build | 1 + meson.build

[PATCH 1/2] build: allow to conditionally build apps

2022-10-12 Thread Markus Theil
Makes apps configureable from meson, like already possible for drivers. Signed-off-by: Markus Theil --- app/meson.build | 17 - meson_options.txt | 4 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/app/meson.build b/app/meson.build index 93d8c15032..4d9c8

[PATCH v1] event/dlb2: add port probing enhancements

2022-10-12 Thread Abdullah Sevincer
This commit is an enhancement for previously implemented port probing optimizations. Changes are below: 1-Since cos is now per port, remove the device and domain specific cos from dev_args struct. 2-Changes for using best cos as default cos during LDB port selection. 3-Changed LDB_COS_DEFAULT to

Re: [PATCH] ethdev: add include for vtune

2022-10-12 Thread Markus Theil
On 10/12/22 14:26, Ferruh Yigit wrote: On 10/12/2022 1:02 PM, Markus Theil wrote: From: Michael Pfeiffer Adding this include allowed us to use vtune with DPDK. Signed-off-by: Michael Pfeiffer ---   lib/ethdev/ethdev_profile.c | 1 +   1 file changed, 1 insertion(+) diff --git a/lib/ethdev/et

Re: [PATCH] net/bonding: fix socket_id type

2022-10-12 Thread Markus Theil
On 10/12/22 14:23, Ferruh Yigit wrote: On 10/12/2022 12:45 PM, Markus Theil wrote: From: Thorben Roemer DPDK uses int or u32 in most other places for socket IDs. Fix compilation warnings by also using int in the bonding code. Hi Markus, 'rte_eth_bond_create()' is part of API, so changing i

回复: 回复: [PATCH v2 1/3] ethdev: add API for direct rearm mode

2022-10-12 Thread Feifei Wang
> -邮件原件- > 发件人: Konstantin Ananyev > 发送时间: Wednesday, October 12, 2022 6:21 AM > 收件人: Feifei Wang ; tho...@monjalon.net; > Ferruh Yigit ; Andrew Rybchenko > ; Ray Kinsella > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > > 主题: Re: 回复: [PATCH v2 1/3] ethdev: add API for

Re: [PATCH v2] devtools: add tracepoint check in checkpatch

2022-10-12 Thread Thomas Monjalon
12/10/2022 13:45, Ankur Dwivedi: > devtools/check-symbol-change.sh | 76 +--- > devtools/check-tracepoint.py| 52 ++ > devtools/check-tracepoint.sh| 66 > devtools/checkpatches.sh| 9 > devtools/comm

RE: [PATCH] event/sw: fix selftest xstats reset API usage

2022-10-12 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 12, 2022 2:06 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; jer...@marvell.com; Li, WeiyuanX ; > ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru; Morten Brørup > > Subject: Re: [PATCH] event/sw: fix selftest xst

Re: [PATCH] event/sw: fix selftest xstats reset API usage

2022-10-12 Thread Thomas Monjalon
12/10/2022 14:34, Harry van Haaren: > The eventdev xstats reset API takes an ID of "uint32_t", while > the rest of the xstats APIs require an "unsigned int". On some > platforms these might not be the same bitwidth, however this was > assumed in the code. > > Fix by providing a uint32_t to the xst

[PATCH] build: make headroom and max memzones configurable

2022-10-12 Thread Markus Theil
We often set headroom and memzones to a different value in our builds. This should also be useful in other projects. Signed-off-by: Markus Theil --- config/meson.build | 2 ++ config/rte_config.h | 2 -- meson_options.txt | 4 3 files changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v4] usertools: add check for IOMMU support in dpdk-devbind

2022-10-12 Thread Fidaullah Noonari
binding with vfio driver, when IOMMU is disabled, causes program to crash. this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is disabled, it changes vfio into unsafe noiommu mode and prints warning message. Signed-off-by: Fidaullah Noonari --- usertools/dpdk-devbind.py | 45 ++

RE: [EXT] [PATCH v11 16/16] test-bbdev: unit test capability extension

2022-10-12 Thread Akhil Goyal
> +in_sequence_size = > +24 > + > +in_leading_padding = > +0 > + > +out_sequence_size = > +3 > + > +out_leading_depadding = > +0 > + > +window_index = > +0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 > + > +cs_bitmap = > +255 > + > +num_antennas_log2 = > +3 > + > +ifft_log2 = > +5 > + > +fft_log2 = > +2 > + >

[PATCH v2] power: fix pstate number parsing

2022-10-12 Thread Markus Theil
From: Markus Theil When converting atoi to strtol in a revision of introducing sysfs support for turbo percentage, a necessary check against '\n' returned by sysfs was not introduced. Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs") Reviewed-by: Reshma Pattan Acked-by: Re

[PATCH] event/sw: fix selftest xstats reset API usage

2022-10-12 Thread Harry van Haaren
The eventdev xstats reset API takes an ID of "uint32_t", while the rest of the xstats APIs require an "unsigned int". On some platforms these might not be the same bitwidth, however this was assumed in the code. Fix by providing a uint32_t to the xstats_reset() function. Fixes: e21df4b062b5 ("test

RE: [EXT] [PATCH v11 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Akhil Goyal
> From: Nic Chautru > > Added support for info_get to allow to query the device. > Null capability exposed. > > Signed-off-by: Nic Chautru > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/acc200_pmd.h | 1 + > drivers/baseband/acc/rte_acc200_pmd.c | 231 ++

[PATCH v3 8/9] trace: remove limitation on trace point name

2022-10-12 Thread David Marchand
The name of a trace point is provided as a constant string via the RTE_TRACE_POINT_REGISTER macro. We can rely on an explicit constant string in the binary and simply point at it. There is then no need for a (fixed size) copy. Signed-off-by: David Marchand --- Changes since v2: - stored trace poi

[PATCH v3 9/9] trace: remove limitation on directory

2022-10-12 Thread David Marchand
Remove arbitrary limit on 12 characters of the file prefix used for the directory where to store the traces. Simplify the code by relying on dynamic allocations. Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/common/eal_common_trace_utils.c | 68

[PATCH v3 7/9] trace: fix metadata dump

2022-10-12 Thread David Marchand
The API does not describe that metadata dump is conditioned to enabling any trace points. While at it, merge dump unit tests into the generic trace_autotest to enhance coverage. Fixes: f6b2d65dcd5d ("trace: implement debug dump") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Sunil

[PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-12 Thread David Marchand
Enabling trace points at runtime was not working if no trace point had been enabled first at rte_eal_init() time. The reason was that trace.args reflected the arguments passed to --trace= EAL option. To fix this: - the trace subsystem initialisation is updated: trace directory creation is deferr

[PATCH v3 6/9] trace: fix race in debug dump

2022-10-12 Thread David Marchand
trace->nb_trace_mem_list access must be under trace->lock to avoid races with threads allocating/freeing their trace buffers. Fixes: f6b2d65dcd5d ("trace: implement debug dump") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/comm

[PATCH v3 4/9] trace: rework loop on trace points

2022-10-12 Thread David Marchand
Directly skip the block when a trace point does not match the user criteria. Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/common/eal_common_trace.c | 34 +-- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git

  1   2   >