> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Wednesday, October 12, 2022 2:06 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dev@dpdk.org; jer...@marvell.com; Li, WeiyuanX <weiyuanx...@intel.com>; > ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru; Morten Brørup > <m...@smartsharesystems.com> > Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage > > 12/10/2022 14:34, Harry van Haaren: > > The eventdev xstats reset API takes an ID of "uint32_t", while > > the rest of the xstats APIs require an "unsigned int". On some > > platforms these might not be the same bitwidth, however this was > > assumed in the code. > > > > Fix by providing a uint32_t to the xstats_reset() function. > > Why adding a comment about the type in the code? > We are not adding /* using the right type */ in each line of code.
Correct; but as the SW PMD was the only selftest code that actually uses xstats_reset() I err-ed on the side of warning devs that there's some "funky" or inconsistent API requirements here. I can respin without if that seems better, but my intention was to help future readers..? <snip>
