12/10/2022 15:08, Van Haaren, Harry: > From: Thomas Monjalon <tho...@monjalon.net> > > 12/10/2022 14:34, Harry van Haaren: > > > The eventdev xstats reset API takes an ID of "uint32_t", while > > > the rest of the xstats APIs require an "unsigned int". On some > > > platforms these might not be the same bitwidth, however this was > > > assumed in the code. > > > > > > Fix by providing a uint32_t to the xstats_reset() function. > > > > Why adding a comment about the type in the code? > > We are not adding /* using the right type */ in each line of code. > > Correct; but as the SW PMD was the only selftest code that actually > uses xstats_reset() I err-ed on the side of warning devs that there's > some "funky" or inconsistent API requirements here. > > I can respin without if that seems better, but my intention was to > help future readers..?
It does not really help. If you want to help, and you think the API is wrong, then please send a patch to propose a change in the API.
