RE: [PATCH] net/i40e: restore disable double VLAN by default

2022-07-06 Thread Liu, KevinX
Ok, I'll tidy it up again. > -Original Message- > From: Yang, Qiming > Sent: 2022年7月7日 14:55 > To: Liu, KevinX ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, > KevinX > Subject: RE: [PATCH] net/i40e: restore disable double VLAN by default > > Hi, > > > -O

RE: [PATCH v2] net/iavf: fix gtpu extension flow error

2022-07-06 Thread Yang, Qiming
Hi, > -Original Message- > From: Wu, WenxuanX > Sent: Wednesday, July 6, 2022 10:56 > To: qiz.zh...@intel.com; Xing, Beilei ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Wu, WenxuanX ; Su, > Simei ; sta...@dpdk.com > Subject: [PATCH v2] net/iavf: fix gtpu extension flow error > >

[PATCH] ethdev: add protocol param to color table update

2022-07-06 Thread skori
From: Sunil Kumar Kori Using rte_mtr_color_in_protocol_set(), user can configure combination of protocol headers, like outer_vlan and outer_ip, can be enabled on given meter object. But rte_mtr_meter_vlan_table_update() and rte_mtr_meter_dscp_table_update() do not have information that which tab

Re: [RFC PATCH 00/29] cover letter for net/qdma PMD

2022-07-06 Thread Thomas Monjalon
06/07/2022 09:51, Aman Kumar: > This patch series provides net PMD for VVDN's NR(5G) Hi-PHY solution over > T1 telco card. These telco accelerator NIC cards are targeted for ORAN DU > systems to offload inline NR Hi-PHY (split 7.2) operations. For the DU host, > the cards typically appears as a bas

[PATCH] vhost: fix unnecessary dirty page logging

2022-07-06 Thread xuan . ding
From: Xuan Ding The dirty page logging is only required in vhost enqueue direction for live migration. This patch removes the unnecessary dirty page logging in vhost dequeue direction. Otherwise, it will result in a performance drop. Some if-else judgements are also optimized to improve performan

RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure

2022-07-06 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Peng1X > Sent: Wednesday, July 6, 2022 10:17 PM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Subject: [PATCH v6] net/ice: add retry mechanism for DCF after failure > > From: Peng Zhang > > The origin design is if error happen during the step

RE: [PATCH] net/i40e: restore disable double VLAN by default

2022-07-06 Thread Yang, Qiming
Hi, > -Original Message- > From: Kevin Liu > Sent: Thursday, July 7, 2022 18:48 > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH] net/i40e: restore disable double VLAN by default > > Restore disable double VLAN by default. Please

[Bug 1048] [dpdk-22.07rc3] i40e_rss_input/flow_query: RSS types is not displayed tests failed

2022-07-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1048 Bug ID: 1048 Summary: [dpdk-22.07rc3] i40e_rss_input/flow_query: RSS types is not displayed tests failed Product: DPDK Version: unspecified Hardware: All OS: All

RE: [PATCH] net/i40e: restore disable double VLAN by default

2022-07-06 Thread Han, YingyaX
> -Original Message- > From: Kevin Liu > Sent: Thursday, July 7, 2022 6:48 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH] net/i40e: restore disable double VLAN by default > > Restore disable double VLAN by default. > > Fixe

RE: [PATCH v2] net/iavf: fix gtpu extension flow error

2022-07-06 Thread Huang, ZhiminX
> -Original Message- > From: wenxuanx...@intel.com > Sent: Wednesday, July 6, 2022 10:56 AM > To: qiz.zh...@intel.com; Xing, Beilei ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Wu, WenxuanX ; Su, > Simei ; sta...@dpdk.com > Subject: [PATCH v2] net/iavf: fix gtpu extension flow err

RE: [PATCH] net/i40e: restore disable double VLAN by default

2022-07-06 Thread Jiang, YuX
> -Original Message- > From: Kevin Liu > Sent: Thursday, July 7, 2022 6:48 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, > KevinX > Subject: [PATCH] net/i40e: restore disable double VLAN by default > > Restore disable double VLAN by default. > > Fixes:

[PATCH] net/i40e: restore disable double VLAN by default

2022-07-06 Thread Kevin Liu
Restore disable double VLAN by default. Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN") Signed-off-by: Kevin Liu --- doc/guides/nics/i40e.rst | 6 +++--- drivers/net/i40e/i40e_ethdev.c | 12 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/doc/g

Re: [RFC PATCH 05/29] net/qdma: add device init and uninit functions

2022-07-06 Thread Aman Kumar
On 06/07/22 9:05 pm, Stephen Hemminger wrote: On Wed, 6 Jul 2022 13:21:55 +0530 Aman Kumar wrote: +/* parse a sysfs file containing one integer value */ +static int parse_sysfs_value(const char *filename, uint32_t *val) +{ + FILE *f; + char buf[BUFSIZ]; + char *end = NULL; +

Re: [RFC PATCH 04/29] net/qdma: add logging support

2022-07-06 Thread Aman Kumar
On 06/07/22 8:57 pm, Stephen Hemminger wrote: On Wed, 6 Jul 2022 13:21:54 +0530 Aman Kumar wrote: +extern int qdma_logtype_pmd; +#define PMD_DRV_LOG(level, fmt, args...) \ + rte_log(RTE_LOG_ ## level, qdma_logtype_pmd, "%s(): " \ + fmt "\n", __func__, ## args) Did you te

RE: i40e QinQ Offload w/ NVM 8.40 not working

2022-07-06 Thread Yang, Qiming
Hi, Ben Please use FW8.6 to have a try. FW 8.4 and 8.5 have some bugs in QinQ feature. Qiming From: Ben Magistro Sent: 2022年4月8日 1:05 To: dev@dpdk.org Cc: ben.magis...@trinitycyber.com; Stefan Baranoff Subject: Re: i40e QinQ Offload w/ NVM 8.40 not working Hello, We were able to narrow it dow

[PATCH v5 7/7] bbdev: remove unnecessary if-check

2022-07-06 Thread Nicolas Chautru
Code clean up due to if-check not required Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev_op.h | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index afa1a71..386eed8 100644 --- a/lib/bbdev/rte_bbdev_

[PATCH v5 5/7] bbdev: add new operation for FFT processing

2022-07-06 Thread Nicolas Chautru
Extension of bbdev operation to support FFT based operations. Signed-off-by: Nicolas Chautru Acked-by: Hemant Agrawal --- doc/guides/prog_guide/bbdev.rst | 130 +++ lib/bbdev/rte_bbdev.c | 10 ++- lib/bbdev/rte_bbdev.h | 76 +

[PATCH v5 6/7] bbdev: add queue related warning and status information

2022-07-06 Thread Nicolas Chautru
This allows to expose more information with regards to any queue related failure and warning which cannot be supported in existing API. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 2 ++ lib/bbdev/rte_bbdev.c| 19 +++ lib/bbdev/rte_bbdev.h

[PATCH v5 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-07-06 Thread Nicolas Chautru
Add support in existing bbdev PMDs for the explicit number of queue and priority for each operation type configured on the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 29 +- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c

[PATCH v5 3/7] bbdev: add device info on queue topology

2022-07-06 Thread Nicolas Chautru
Adding more options in the API to expose the number of queues exposed and related priority. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index 9b1ffa4..ac941d6 100644 --- a/lib/bbdev

[PATCH v5 2/7] bbdev: add device status info

2022-07-06 Thread Nicolas Chautru
Added device status information, so that the PMD can expose information related to the underlying accelerator device status. Minor order change in structure to fit into padding hole. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 1 + drivers/baseband/fp

[PATCH v5 1/7] bbdev: allow operation type enum for growth

2022-07-06 Thread Nicolas Chautru
Updating the enum for rte_bbdev_op_type to allow to keep ABI compatible for enum insertion while adding padded maximum value for array need. Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing RTE_BBDEV_OP_TYPE_PADDED_MAX. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev.c | 2

[PATCH v5 0/7] bbdev changes for 22.11

2022-07-06 Thread Nicolas Chautru
v5: update base on review from Tom Rix. Number of typos reported and resolved, removed the commit related to rw_lock for now, added a commit for code clean up from review, resolved one rebase issue between 2 commits, used size of array for some bound check implementation. Thanks. v4: update to th

[PATCH v2 2/2] event/dlb2: improve cq_weight error messages

2022-07-06 Thread Timothy McDaniel
This commit changes 2 error messages to better describe cq_weight related errors, should one occur. Fixes: ffa46fc4a2b5 ("event/dlb2: support CQ weight") Cc: sta...@dpdk.org Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 4 ++-- drivers/event/dlb2/pf/base/dlb2_

[PATCH v2 1/2] event/dlb2: fix cq_weight array overflow

2022-07-06 Thread Timothy McDaniel
The cq_weight array must be sized for the maximum number of eventdev ports, not the maximum number of DLB2 load balanced ports. This commit fixes the above array sizing bug and resultant coverity warning. Coverity issue: 379234 Fixes: ffa46fc4a2b5 ("event/dlb2: support CQ weight") Cc: sta...@dpdk

[PATCH v2 0/2] DLB2: cq_weight fixes

2022-07-06 Thread Timothy McDaniel
This patch series contains the following: - fix coverity issue 379234 - improve error reporting for cq_weight feature Changes since V1 - fixed a repeated word in the commit message of patch 1 Timothy McDaniel (2): event/dlb2: fix cq_weight array overflow event/dlb2: improve cq_weight error me

[PATCH 2/2] event/dlb2: improve cq_weight error messages

2022-07-06 Thread Timothy McDaniel
This commit changes 2 error messages to better describe cq_weight related errors, should one occur. Fixes: ffa46fc4a2b5 ("event/dlb2: support CQ weight") Cc: sta...@dpdk.org Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 4 ++-- drivers/event/dlb2/pf/base/dlb2_

[PATCH 1/2] event/dlb2: fix cq_weight array overflow

2022-07-06 Thread Timothy McDaniel
The cq_weight array must be sized for the maximum number of eventdev ports, not the the maximum number of DLB2 load balanced ports. This commit fixes the above array sizing bug and resultant coverity warning. Coverity issue: 379234 Fixes: ffa46fc4a2b5 ("event/dlb2: support CQ weight") Cc: sta...@

[PATCH 0/2] DLB2: cq_weight fixes

2022-07-06 Thread Timothy McDaniel
This patch series contains the following: - fix coverity issue 379234 - improve error reporting for cq_weight feature Timothy McDaniel (2): event/dlb2: fix cq_weight array overflow event/dlb2: improve cq_weight error messages drivers/event/dlb2/dlb2.c | 8 drivers/e

RE: [PATCH v4 1/7] bbdev: allow operation type enum for growth

2022-07-06 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Subject: Re: [PATCH v4 1/7] bbdev: allow operation type enum for growth > > > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > Updating the enum for rte_bbdev_op_type to allow to keep ABI > > compatible for enum insertion while adding padded

RE: [PATCH v4 2/7] bbdev: add device status info

2022-07-06 Thread Chautru, Nicolas
> -Original Message- > From: Tom Rix > Subject: Re: [PATCH v4 2/7] bbdev: add device status info > > > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > Added device status information, so that the PMD can expose > > information related to the underlying accelerator device status. > > Minor

RE: [PATCH v4 3/7] bbdev: add device info on queue topology

2022-07-06 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Subject: Re: [PATCH v4 3/7] bbdev: add device info on queue topology > > > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > Adding more options in the API to expose the number of queues exposed > > and related priority. > > > > Signed-off-by:

RE: [PATCH v4 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-07-06 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Sent: Wednesday, July 6, 2022 9:15 AM > To: Chautru, Nicolas ; dev@dpdk.org; > tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com > Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; david.march...@redhat.com;

RE: [PATCH v4 5/7] bbdev: add new operation for FFT processing

2022-07-06 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > > > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > Extension of bbdev operation to support FFT based operations. > > > > Signed-off-by: Nicolas Chautru > > Acked-by: Hemant Agrawal > > --- > > doc/guides/prog_guide/bbdev.rst | 130 >

RE: [PATCH v4 6/7] bbdev: add queue related warning and status information

2022-07-06 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > > > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > This allows to expose more information with regards to any queue > > related failure and warning which cannot be supported in existing API. > > > > Signed-off-by: Nicolas Chautru > > --- >

RE: [PATCH v4 7/7] bbdev: add a lock option for enqueue/dequeue operation

2022-07-06 Thread Chautru, Nicolas
Hi Stephen, Tom., > -Original Message- > From: Stephen Hemminger > > On Wed, 6 Jul 2022 12:01:19 -0700 > Tom Rix wrote: > > > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > > Locking is not explicitly required but can be valuable in case the > > > application cannot guarantee to be thr

Re: [PATCH v4 7/7] bbdev: add a lock option for enqueue/dequeue operation

2022-07-06 Thread Stephen Hemminger
On Wed, 6 Jul 2022 12:01:19 -0700 Tom Rix wrote: > On 7/5/22 5:23 PM, Nicolas Chautru wrote: > > Locking is not explicitly required but can be valuable > > in case the application cannot guarantee to be thread-safe, > > or specifically is at risk of using the same queue from multiple threads. > >

Re: [PATCH v4 7/7] bbdev: add a lock option for enqueue/dequeue operation

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: Locking is not explicitly required but can be valuable in case the application cannot guarantee to be thread-safe, or specifically is at risk of using the same queue from multiple threads. This is an option for PMD to use this. Signed-off-by: Nicolas C

Re: [PATCH v4 6/7] bbdev: add queue related warning and status information

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: This allows to expose more information with regards to any queue related failure and warning which cannot be supported in existing API. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 2 ++ lib/bbdev/rte_bbdev.c|

Re: [PATCH v4 5/7] bbdev: add new operation for FFT processing

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: Extension of bbdev operation to support FFT based operations. Signed-off-by: Nicolas Chautru Acked-by: Hemant Agrawal --- doc/guides/prog_guide/bbdev.rst | 130 +++ lib/bbdev/rte_bbdev.c | 11 ++- lib/bb

[Patch v2] net/mlx5: fix verbs fd leak in the secondary process

2022-07-06 Thread longli
From: Long Li FDs passed from rte_mp_msg are duplicated to the secondary process and need to be closed. Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API") Signed-off-by: Long Li --- Change in v2: handle error case where mlx5_proc_priv_init() might fail drivers/net/mlx5/linux/mlx5

[Patch v2] net/mlx4: fix verbs fd leak in the secondary process

2022-07-06 Thread longli
From: Long Li FDs passed from rte_mp_msg are duplicated to the secondary process and need to be closed. Fixes: 0203d33a10 ("net/mlx4: support secondary process") Signed-off-by: Long Li --- Change in v2: handle error case where mlx4_proc_priv_init() might fail drivers/net/mlx4/mlx4.c| 9 +

[PATCH] net/mlx5: fix verbs fd leak in the secondary process

2022-07-06 Thread longli
From: Long Li FDs passed from rte_mp_msg are duplicated to the secondary process and need to be closed. Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API") Signed-off-by: Long Li --- drivers/net/mlx5/mlx5_txq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/

[PATCH] net/mlx4: fix verbs cmd fd leak in the secondary process

2022-07-06 Thread longli
From: Long Li FDs passed from rte_mp_msg are duplicated to the secondary process and need to be closed. Fixes: 0203d33a10 ("net/mlx4: support secondary process") Signed-off-by: Long Li --- drivers/net/mlx4/mlx4_txq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx4/mlx4_t

RE: [Patch v2 01/17] net/mana: add basic driver, build environment and doc

2022-07-06 Thread Long Li
> Subject: Re: [Patch v2 01/17] net/mana: add basic driver, build environment > and > doc > > On Wed, Jul 6, 2022 at 6:12 PM Long Li wrote: > > > Is there a version dependency on rdma-core? Is that version > > > dependency listed somewhere? > > > > The rdma-core and kernel drivers are being subm

Re: [Patch v2 01/17] net/mana: add basic driver, build environment and doc

2022-07-06 Thread David Marchand
On Wed, Jul 6, 2022 at 6:12 PM Long Li wrote: > > Is there a version dependency on rdma-core? Is that version dependency > > listed > > somewhere? > > The rdma-core and kernel drivers are being submitted. The expected version > supporting MANA is with rdma-core v42 and Linux 5.19 (or 5.20). > >

Re: [PATCH v4 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: Add support in existing bbdev PMDs for the explicit number of queue and priority for each operation type configured on the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 29 +- dr

[PATCH v2] app/testpmd: fix GTP PSC raw processing

2022-07-06 Thread Gregory Etelson
Fix GTP PSP extension size initialization. Clear input buffer. Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Aman Singh Reviewed-by: Andrew Rybchenko --- v2: fix comment tags order. --- app/test-pmd/cmdline_flow.c

RE: [Patch v2 01/17] net/mana: add basic driver, build environment and doc

2022-07-06 Thread Long Li
> Subject: Re: [Patch v2 01/17] net/mana: add basic driver, build environment > and > doc > > On Tue, 5 Jul 2022 17:28:32 -0700 > lon...@linuxonhyperv.com wrote: > > > +Prerequisites > > +- > > + > > +This driver relies on external libraries and kernel drivers for > > +resources all

Re: [PATCH v4 3/7] bbdev: add device info on queue topology

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: Adding more options in the API to expose the number of queues exposed and related priority. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev

Re: [PATCH v4 2/7] bbdev: add device status info

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: Added device status information, so that the PMD can expose information related to the underlying accelerator device status. Minor order change in structure to fit into padding hole. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc

Re: [RFC PATCH 05/29] net/qdma: add device init and uninit functions

2022-07-06 Thread Stephen Hemminger
On Wed, 6 Jul 2022 13:21:55 +0530 Aman Kumar wrote: > +/* parse a sysfs file containing one integer value */ > +static int parse_sysfs_value(const char *filename, uint32_t *val) > +{ > + FILE *f; > + char buf[BUFSIZ]; > + char *end = NULL; > + > + f = fopen(filename, "r"); > +

Re: [RFC PATCH 04/29] net/qdma: add logging support

2022-07-06 Thread Stephen Hemminger
On Wed, 6 Jul 2022 13:21:54 +0530 Aman Kumar wrote: > +extern int qdma_logtype_pmd; > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, qdma_logtype_pmd, "%s(): " \ > + fmt "\n", __func__, ## args) Did you test this. Looks like your log messages are goi

Re: clarification on RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF flag

2022-07-06 Thread Stephen Hemminger
On Wed, 6 Jul 2022 19:07:54 +0530 venkatesh bs wrote: > Hi All, > > In multithreaded/Multicore environment can we use > RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF > independently, > or this flag should always be used with > RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD. > > We are trying to create and acc

Re: [Patch v2 01/17] net/mana: add basic driver, build environment and doc

2022-07-06 Thread Stephen Hemminger
On Tue, 5 Jul 2022 17:28:32 -0700 lon...@linuxonhyperv.com wrote: > +Prerequisites > +- > + > +This driver relies on external libraries and kernel drivers for resources > +allocations and initialization. The following dependencies are not part of > +DPDK and must be installed separate

Re: [PATCH v2 3/3] ethdev: add the check for the valitity of timestamp offload

2022-07-06 Thread Andrew Rybchenko
On 7/2/22 11:17, Dongdong Liu wrote: From: Huisong Li This patch adds the check for the valitity of timestamp offload. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- lib/ethdev/rte_ethdev.c | 65 - 1 file changed, 64 insertions(+), 1 dele

Re: [PATCH] app/testpmd: fix memory leak for dscp table

2022-07-06 Thread Andrew Rybchenko
In summary: dscp -> DSCP On 6/29/22 20:30, Singh, Aman Deep wrote: On 6/28/2022 6:59 PM, Jasvinder Singh wrote: This patch fixes memory leak reported by coverity. Coverity issue: 379220 Fixes: 9f5488e326d3 ("app/testpmd: support different input color method") Cc: sta...@dpdk.org Signed-off

Re: [PATCH] app/testpmd: fix GTP PSC raw processing

2022-07-06 Thread Andrew Rybchenko
On 7/4/22 12:08, Singh, Aman Deep wrote: On 6/30/2022 6:20 PM, Gregory Etelson wrote: Fix GTP PSP extension size initialization. Clear input buffer. cc: sta...@dpdk.org Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") Incorrect order: Fixes: ... Cc: ... Signed-off-by: Greg

Re: clarification on RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF flag

2022-07-06 Thread venkatesh bs
Hi All, In multithreaded/Multicore environment can we use RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF independently, or this flag should always be used with RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD. We are trying to create and access the hash table with RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF only. We ar

[PATCH v2] common/mlx5: update DevX error logging

2022-07-06 Thread Gregory Etelson
Current PMD logs all DevX errors at error level. DevX interface can fail queue counters allocation on some hardware types. That is a known issue. PMD fallback to VERB API to allocate queue counters when it detects the fault. That DevX failure should not be logged as PMD error. The patch provides

Re: [PATCH] app/testpmd: fix secondary process cannot dump packet

2022-07-06 Thread Andrew Rybchenko
On 7/6/22 05:00, lihuisong (C) wrote: 在 2022/7/5 18:12, Zhang, Peng1X 写道: Hi Song, Currently this patch is just fix the issue detected for rx queue on secondary process. Later patch for tx queue will be submit. Firstly, the Rx packet dump failure is not displayed in your commit log. In addi

Re: clarification on RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF flag

2022-07-06 Thread venkatesh bs
Hi All, In multithreaded/Multicore environment can we use RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF independently, or this flag should always be used with RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD. We are trying to create and access the hash table with RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF only. We ar

Re: [PATCH v4 1/7] bbdev: allow operation type enum for growth

2022-07-06 Thread Tom Rix
On 7/5/22 5:23 PM, Nicolas Chautru wrote: Updating the enum for rte_bbdev_op_type to allow to keep ABI compatible for enum insertion while adding padded maximum value for array need. Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing RTE_BBDEV_OP_TYPE_PADDED_MAX. Signed-off-by: Nicolas Chau

Re: [PATCH] vdpa/sfc: resolve race between libvhost and dev_conf

2022-07-06 Thread Maxime Coquelin
Hi Abhimanyu, On 7/6/22 11:24, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini libvhost calls dev_conf() before prosessing the VHOST_USER_SET_VRING_CALL message for the last VQ. So this message is processed after dev_conf() returns. However, the dev_conf() function spawns a thread to

DTS WG discussions

2022-07-06 Thread Honnappa Nagarahalli
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:Central Standard Time BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETFROM:-0500 TZOFFSETTO:-0600 RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=1SU;BYMONTH=11 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T02000

回复: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-07-06 Thread Feifei Wang
> -邮件原件- > 发件人: Feifei Wang > 发送时间: Wednesday, July 6, 2022 4:53 PM > 收件人: Konstantin Ananyev ; Yuying > Zhang ; Beilei Xing ; > Ruifeng Wang > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > 主题: 回复: [RFC PATCH v1] net/i40e: put mempool cache out of API > > > > > -邮件原件-

RE: [PATCH v5] net/i40e: fix error disable double VLAN

2022-07-06 Thread Han, YingyaX
-Original Message- From: Kevin Liu Sent: Wednesday, June 29, 2022 11:40 PM To: dev@dpdk.org Cc: Xing, Beilei ; Zhang, Yuying ; Yang, SteveX ; Liu, KevinX Subject: [PATCH v5] net/i40e: fix error disable double VLAN Enable double VLAN by default after firmware v8.3 and disable double

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-07-06 Thread Usman Tanveer
It has been there since the file was added (2015). I'm not able to find any purpose for this. Although, it's misleading the messages it shows upon calling rte_ethtool_net_open() as mentioned above. And when this function is called even when the port is already UP, it should print a message "device

RE: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

2022-07-06 Thread Zhang, Roy Fan
> -Original Message- > From: Vamsi Attunuru > Sent: Monday, June 27, 2022 6:30 AM > To: dev@dpdk.org > Cc: jer...@marvell.com; vattun...@marvell.com; gak...@marvell.com; > ferruh.yi...@intel.com; tho...@monjalon.net; ano...@marvell.com; > m...@ashroe.eu > Subject: [PATCH v2 1/1] doc: annou

Re: [PATCH v3] config/arm: add Phytium FT-2000+

2022-07-06 Thread luzhipeng
my name: zhipeng Lu thanks. 在 2022/7/5 22:31, Morten Brørup 写道: From: Morten Brørup Sent: Tuesday, 5 July 2022 16.25 From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, 5 July 2022 15.31 From: luzhipeng Here adds configs for Phytium server. Signed-off-by: luzhipeng Reviewed-

RE: [PATCH 1/2] common: add safe version of foreach-list to Linux

2022-07-06 Thread Khan, Hamza
> -Original Message- > From: Khan, Hamza > Sent: Wednesday 1 June 2022 11:55 > Cc: dev@dpdk.org; Khan, Hamza > Subject: [PATCH 1/2] common: add safe version of foreach-list to Linux > > Linux EAL does not have the LIST_FOREACH_SAFE version of the iterator > macros. Add it. > > Signed

[PATCH] vdpa/sfc: resolve race between libvhost and dev_conf

2022-07-06 Thread abhimanyu.saini
From: Abhimanyu Saini libvhost calls dev_conf() before prosessing the VHOST_USER_SET_VRING_CALL message for the last VQ. So this message is processed after dev_conf() returns. However, the dev_conf() function spawns a thread to set rte_vhost_host_notifier_ctrl() before returning control to libvh

RE: [PATCH] doc: announce change to cryptodev cb function prototype

2022-07-06 Thread Zhang, Roy Fan
> -Original Message- > From: Srujana Challa > Sent: Friday, June 24, 2022 2:45 PM > To: gak...@marvell.com; Zhang, Roy Fan > Cc: dev@dpdk.org; jer...@marvell.com; ndabilpu...@marvell.com; > ano...@marvell.com > Subject: [PATCH] doc: announce change to cryptodev cb function prototype > >

Re: [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc

2022-07-06 Thread Bruce Richardson
On Wed, Jul 06, 2022 at 02:55:48PM +0800, 835703...@qq.com wrote: > From: Shiqi Liu <835703...@qq.com> > > As the possible failure of the malloc(), the not_checked and > checked could be NULL pointer. > Therefore, it should be better to check it in order to avoid > the dereference of the NULL poin

Re: [PATCH] raw/ioat: Check for the NULL pointer after calling malloc

2022-07-06 Thread Bruce Richardson
On Tue, Jul 05, 2022 at 09:43:34PM +0200, Thomas Monjalon wrote: > 27/06/2022 19:52, 835703...@qq.com: > > From: Shiqi Liu <835703...@qq.com> > > > > As the possible failure of the malloc(), the not_checked and > > checked could be NULL pointer. > > Therefore, it should be better to check it in or

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-06 Thread Singh, Jasvinder
> -Original Message- > From: Danilewicz, MarcinX > Sent: Tuesday, July 5, 2022 6:06 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v8] sched: enable CMAN at runtime > > Added changes to enable CMAN (RED or PIE) at init from prof

回复: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-07-06 Thread Feifei Wang
> -邮件原件- > 发件人: Konstantin Ananyev > 发送时间: Sunday, July 3, 2022 8:20 PM > 收件人: Feifei Wang ; Yuying Zhang > ; Beilei Xing ; Ruifeng > Wang > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > > 主题: Re: [RFC PATCH v1] net/i40e: put mempool cache out of API > > > > Refer to "i40e_tx_free_bu

[RFC PATCH 29/29] net/qdma: add stats PMD ops for PF and VF

2022-07-06 Thread Aman Kumar
This patch implements PMD ops related to stats for both PF and VF functions. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma.h | 3 +- drivers/net/qdma/qdma_devops.c| 114 +++--- drivers/net/qdma/qdma_rxtx.c | 4 ++ drivers/net/qdma/qdma_vf_ethd

[RFC PATCH 28/29] net/qdma: add additional debug APIs

2022-07-06 Thread Aman Kumar
this patch implements function to debug and dump PMD/QDMA specific data. Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build |1 + drivers/net/qdma/qdma_xdebug.c | 1072 2 files changed, 1073 insertions(+) create mode 100644 drivers/net/qdma/qdma_xd

[RFC PATCH 27/29] net/qdma: add device specific APIs for export

2022-07-06 Thread Aman Kumar
this patch defines few PMD specific APIs to be directly used by the apps. such an example is to select queue modes between MM(memory mapped) or ST(streaming). Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build|1 + drivers/net/qdma/rte_pmd_qdma.c | 1728 ++

[RFC PATCH 26/29] net/qdma: add datapath burst API for VF

2022-07-06 Thread Aman Kumar
this patch implements routine for dev_start and dev_stop PMD ops and adds support for RX/TX datapath burst APIs for VF. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_vf_ethdev.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/drivers/net/qdma/qdma_vf_et

[RFC PATCH 25/29] net/qdma: add basic PMD ops for VF

2022-07-06 Thread Aman Kumar
this patch adds dev_configure, queue start/stop ops for VF devices. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_vf_ethdev.c | 641 ++ 1 file changed, 641 insertions(+) diff --git a/drivers/net/qdma/qdma_vf_ethdev.c b/drivers/net/qdma/qdma_vf_ethdev.c index 2

[RFC PATCH 24/29] net/qdma: add Rx/Tx queue setup routine for VF devices

2022-07-06 Thread Aman Kumar
Rx/Tx queue initialization routine for VFs is same as that of phys function. define separate ops structure for VF devices. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_vf_ethdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/qdma/qdma_vf_et

[RFC PATCH 23/29] net/qdma: add support for VF interfaces

2022-07-06 Thread Aman Kumar
This patch registers supported virtual function and initialization/deinit routines for the same. Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build | 1 + drivers/net/qdma/qdma.h | 9 + drivers/net/qdma/qdma_ethdev.c| 22 +++ drivers/net/qdma/qdma_vf_ethdev.c | 31

[RFC PATCH 22/29] net/qdma: mbox API adaptation in Rx/Tx init

2022-07-06 Thread Aman Kumar
add mbox initialization and handling to enable virtual functions queue setup. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma.h| 1 + drivers/net/qdma/qdma_devops.c | 196 ++--- drivers/net/qdma/qdma_ethdev.c | 47 3 files changed, 226 insertio

[RFC PATCH 21/29] net/qdma: add mailbox communication library

2022-07-06 Thread Aman Kumar
this patch implements mailbox communication mechanism to enable communication between virtual functions and physical function. Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build | 1 + drivers/net/qdma/qdma.h | 2 + drivers/net/qdma/qdma_mbox.c | 400

[RFC PATCH 20/29] net/qdma: add Rx burst API

2022-07-06 Thread Aman Kumar
add Rx data path burst API support for device. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_devops.c | 10 - drivers/net/qdma/qdma_rxtx.c | 709 + drivers/net/qdma/qdma_rxtx.h | 8 +- 3 files changed, 716 insertions(+), 11 deletions(-) diff --git a/

[RFC PATCH 19/29] net/qdma: add callback function for Tx desc status

2022-07-06 Thread Aman Kumar
This patch implements dev->tx_descriptor_status function for net_qdma PMD. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_devops.c | 1 + drivers/net/qdma/qdma_rxtx.c | 47 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/net/qdma/qdma_devops.c b

[RFC PATCH 18/29] net/qdma: add Tx queue reclaim routine

2022-07-06 Thread Aman Kumar
define function for dev->tx_done_cleanup for net_qdma PMD. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_devops.c | 8 drivers/net/qdma/qdma_rxtx.c | 28 2 files changed, 28 insertions(+), 8 deletions(-) diff --git a/drivers/net/qdma/qdma_devops.c

[RFC PATCH 17/29] net/qdma: add Tx burst API

2022-07-06 Thread Aman Kumar
add Tx data path burst API for the device. Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build | 2 + drivers/net/qdma/qdma_devops.c | 10 - drivers/net/qdma/qdma_rxtx.c | 422 + drivers/net/qdma/qdma_rxtx.h | 10 + drivers/net/qdma/qdma_user.c

[RFC PATCH 16/29] net/qdma: add start and stop apis

2022-07-06 Thread Aman Kumar
this patch implements definitions for dev_start and dev_stop apis. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_devops.c | 53 -- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/drivers/net/qdma/qdma_devops.c b/drivers/net/qdma/qdma_devops.c

[RFC PATCH 15/29] net/qdma: add queue cleanup PMD ops

2022-07-06 Thread Aman Kumar
defined routines for rx and tx queue cleanup functions. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_devops.c | 83 -- 1 file changed, 79 insertions(+), 4 deletions(-) diff --git a/drivers/net/qdma/qdma_devops.c b/drivers/net/qdma/qdma_devops.c index e411c

[RFC PATCH 14/29] net/qdma: add routine for Tx queue initialization

2022-07-06 Thread Aman Kumar
defined routines to handle tx queue related ops. this patch add support to rte_eth_dev_tx_queue* apis for this PMD. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma.h| 8 + drivers/net/qdma/qdma_common.c | 74 + drivers/net/qdma/qdma_devops.c | 270 +

[RFC PATCH 13/29] net/qdma: add callback support for Rx queue count

2022-07-06 Thread Aman Kumar
this patch implements callback support to read rx_desc and fetch rx_queue_count info. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_devops.c | 2 + drivers/net/qdma/qdma_devops.h | 6 +- drivers/net/qdma/qdma_rxtx.c | 120 + 3 files changed, 124 insert

[RFC PATCH 12/29] net/qdma: add routine for Rx queue initialization

2022-07-06 Thread Aman Kumar
defined routines to handle rx queue related ops. this patch add support to rte_eth_dev_rx_queue* apis for this PMD. Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build | 2 + drivers/net/qdma/qdma.h| 74 +++- drivers/net/qdma/qdma_common.c | 157 drivers/net/qdma/qdm

[RFC PATCH 11/29] net/qdma: add configure close and reset ethdev ops

2022-07-06 Thread Aman Kumar
add routines for below ethdev ops: 1. dev_configure 2. dev_reset 3. dev_close Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma.h| 11 +- drivers/net/qdma/qdma_devops.c | 292 - drivers/net/qdma/qdma_devops.h | 42 + drivers/net/qdma/qdma_ethdev

[RFC PATCH 10/29] net/qdma: add net PMD ops template

2022-07-06 Thread Aman Kumar
define dpdk pmd ops function for the device. routines are added as dummy calls. Signed-off-by: Aman Kumar --- drivers/net/qdma/meson.build| 5 +- drivers/net/qdma/qdma.h | 1 + drivers/net/qdma/qdma_devops.c | 464 ++ drivers/net/qdma/qdma_devops.h |

[RFC PATCH 09/29] net/qdma: define device modes and data structure

2022-07-06 Thread Aman Kumar
define enums and structure for supported device modes adapt macros into the routines. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma.h | 21 +++ drivers/net/qdma/qdma_common.c | 22 ++- drivers/net/qdma/qdma_ethdev.c | 17 ++- drivers/net/qdma/rte_pmd_qdma.h | 262 +

[RFC PATCH 08/29] net/qdma: qdma hardware initialization

2022-07-06 Thread Aman Kumar
add hardware initialization as per qdma_access lib. Fetch hardware version and other details and bind to proper qdma layer. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma.h| 13 +- drivers/net/qdma/qdma_common.c | 52 +++- drivers/net/qdma/qdma_ethdev.c | 225 +

[RFC PATCH 07/29] net/qdma: add supported qdma version

2022-07-06 Thread Aman Kumar
qdma-20.2 is supported for latest firmware. Signed-off-by: Aman Kumar --- drivers/net/qdma/qdma_version.h | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 drivers/net/qdma/qdma_version.h diff --git a/drivers/net/qdma/qdma_version.h b/drivers/net/qdma/qdma_versi

  1   2   >