Hi Tom,
> -----Original Message-----
> From: Tom Rix <t...@redhat.com>
> Subject: Re: [PATCH v4 3/7] bbdev: add device info on queue topology
>
>
> On 7/5/22 5:23 PM, Nicolas Chautru wrote:
> > Adding more options in the API to expose the number of queues exposed
> > and related priority.
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com>
> > ---
> > lib/bbdev/rte_bbdev.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index
> > 9b1ffa4..ac941d6 100644
> > --- a/lib/bbdev/rte_bbdev.h
> > +++ b/lib/bbdev/rte_bbdev.h
> > @@ -289,6 +289,10 @@ struct rte_bbdev_driver_info {
> >
> > /** Maximum number of queues supported by the device */
> > unsigned int max_num_queues;
> > + /** Maximum number of queues supported per operation type */
> > + unsigned int num_queues[RTE_BBDEV_OP_TYPE_PADDED_MAX];
> > + /** Priority level supported per operation type */
> > + unsigned int queue_priority[RTE_BBDEV_OP_TYPE_PADDED_MAX];
>
> It is better to add new elements to the end of a structure for better backward
> compatibility
All that serie is not ABI compatible (sizes change etc...). I don’t believe
there is such a recommendation, is there?
>
> Tom
>
> > /** Queue size limit (queue size must also be power of 2) */
> > uint32_t queue_size_lim;
> > /** Set if device off-loads operation to hardware */
