[PATCH v2 7/7] net/ngbe: support YT PHY SGMII to RGMII mode

2022-06-21 Thread Jiawen Wu
Add SGMII to RGMII mode for yt8521s and yt8531s PHY. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/ngbe/base/ngbe_phy_yt.c| 49 ++ 2 files changed, 50 insertions(+) diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/g

[PATCH v2 5/7] net/ngbe: fix YT PHY UTP mode to link up

2022-06-21 Thread Jiawen Wu
Fix to read and write the correct register fields for yt8521s and yt8531s PHY, since mode check was added. Fixes: 1c44384fce76 ("net/ngbe: support custom PHY interfaces") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_phy_yt.c | 42 ++--- 1 f

[PATCH v2 6/7] net/ngbe: support autoneg on/off for external PHY SFI mode

2022-06-21 Thread Jiawen Wu
Add support for external PHY to switch autoneg on/off on their SFI mode. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/ngbe/base/ngbe_phy_mvl.c | 16 +--- drivers/net/ngbe/base/ngbe_phy_yt.c| 20 +++- drivers/net/ngbe/ba

[PATCH v2 4/7] net/ngbe: add more packet statistics

2022-06-21 Thread Jiawen Wu
Add more hardware extended statistics. Fixes: 8b433d04adc9 ("net/ngbe: support device xstats") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethde

[PATCH v2 3/7] net/txgbe: fix register polling

2022-06-21 Thread Jiawen Wu
Fix to poll some specific registers, which expect bit value 0. 'w32w' is used in registers where the write command bit is set and waits for the bit clear to complete the write. Fixes: 24a4c76aff4d ("net/txgbe: add error types and registers") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- dri

[PATCH v2 1/7] net/txgbe: support OEM subsystem vendor ID

2022-06-21 Thread Jiawen Wu
Add support for OEM subsystem vendor ID. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_07.rst | 4 +++ drivers/net/txgbe/base/txgbe_hw.c | 39 ++ drivers/net/txgbe/base/txgbe_hw.h | 2 ++ drivers/net/txgbe/base/txgbe_type.h| 1 + drivers/ne

[PATCH v2 2/7] net/ngbe: support OEM subsystem vendor ID

2022-06-21 Thread Jiawen Wu
Add support for OEM subsystem vendor ID. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/ngbe/base/ngbe_hw.c| 13 +++-- drivers/net/ngbe/base/ngbe_type.h | 2 +- drivers/net/ngbe/ngbe_ethdev.c | 14 +- 4 files chan

[PATCH v2 0/7] Fixes and supports for Wangxun NICs

2022-06-21 Thread Jiawen Wu
Fix the remaining bugs, support more OEM devices. v2: - remove useless variable initializers - define macros for loop counts - supplement detailed commit log Jiawen Wu (7): net/txgbe: support OEM subsystem vendor ID net/ngbe: support OEM subsystem vendor ID net/txgbe: fix register polling

[PATCH v3] examples/vhost: fix retry logic on eth rx path

2022-06-21 Thread Yuan Wang
drain_eth_rx() uses rte_vhost_avail_entries() to calculate the available entries to determine if a retry is required. However, this function only works with split rings, and calculating packed rings will return the wrong value and cause unnecessary retries resulting in a significant performance pen

RE: ask for TXA_FLUSH_THRESHOLD change

2022-06-21 Thread Jaeeun Ham
Hi, Could you guide me on how to eliminate or reduce tx drop/retry? TXA_FLUSH_THRESHOLD helped somewhat but it was not cleared packet tx drop. [ TX adapter stats ] tx_retry: 17499893 tx_packets: 7501716 tx_dropped: 5132458 BR/Jaeeun From: Jayatheerthan, Jay Sent: Thursday, June

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-21 Thread Emil Berg
> -Original Message- > From: Morten Brørup > Sent: den 20 juni 2022 12:58 > To: Emil Berg > Cc: sta...@dpdk.org; bugzi...@dpdk.org; hof...@lysator.liu.se; > olivier.m...@6wind.com; dev@dpdk.org > Subject: RE: [PATCH] net: fix checksum with unaligned buffer > > > From: Emil Berg [mailto

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-21 Thread Emil Berg
> -Original Message- > From: Morten Brørup > Sent: den 17 juni 2022 11:07 > To: Emil Berg > Cc: sta...@dpdk.org; bugzi...@dpdk.org; hof...@lysator.liu.se; > olivier.m...@6wind.com; dev@dpdk.org > Subject: RE: [PATCH] net: fix checksum with unaligned buffer > > > From: Morten Brørup [mail

Re: [PATCH 1/2] config: Use G++ as C++ compiler

2022-06-21 Thread Stanisław Kardach
On Tue, Jun 21, 2022 at 9:53 PM Tyler Retzlaff wrote: > > > -cpp = ['ccache', 'arm-linux-gnueabihf-cpp'] > > +cpp = ['ccache', 'arm-linux-gnueabihf-g++'] > > suggest the variable should be 'cxx' not 'cpp' (to be consistent with > other build systems in the linux world) The variable name is mandat

[PATCH v1 3/3] net/ice: fix flow management in FDIR

2022-06-21 Thread Zhirun Yan
From: Xiao Wang The supported protocol fields e.g. outer tuples should be included in the key definition of rte_hash table. Besides, a protocol field should be used only when the corresponding mask is set. Signed-off-by: Xiao Wang --- drivers/net/ice/ice_ethdev.h | 8 ++ drivers/net/ice

[PATCH v1 2/3] net/ice: fix outer src mac as FDIR input field

2022-06-21 Thread Zhirun Yan
Add src mac in input set map. If not add this, the src mac can not be parsed and this field will be ignored. Add outer mac as extracted key input to avoid rule conflict for VXLAN rule when outer src mac change only. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_ethdev.h | 3 +++ drivers

[PATCH v1 1/3] net/ice/base: extend VXLAN type with inner pattern for FDIR

2022-06-21 Thread Zhirun Yan
When offload VXLAN rule only with inner IPv4 layer, we expect to hit a group flow include UDP/TCP/SCTP. The dummy packet of this flow type is specified with inner UDP type. This patch changed the inner IPv4 protocol type to a reserved value, then it could cover the inner UDP/TCP/SCTP. Signed-off-b

[PATCH v1 0/3] fix tunnel support for VXLAN in FDIR

2022-06-21 Thread Zhirun Yan
Extend to cover a group of inner UDP/TCP/SCTP when a VXLAN rule only with inner IP layer. Add outer mac as extracted key input to enable tunnel rule only with outer src mac changed. Fix flow management in FDIR to cover VXLAN inner/outer field. Xiao Wang (1): net/ice: fix flow management in FD

RE: [PATCH 3/7] net/txgbe: fix register polling

2022-06-21 Thread Jiawen Wu
On Tuesday, June 21, 2022 8:19 PM, Ferruh Yigit wrote: > On 6/20/2022 8:55 AM, Jiawen Wu wrote: > > Fix to poll some specific registers, which expect bit 0. > > > > Fixes: 24a4c76aff4d ("net/txgbe: add error types and registers") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Jiawen Wu > > --- > >

RE: [PATCH v2] examples/vhost: fix retry logic on eth rx path

2022-06-21 Thread Wang, YuanX
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, June 21, 2022 9:35 PM > To: Wang, YuanX ; maxime.coque...@redhat.com; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang > ; sta...@dpdk.org; Ling, WeiX > > Subject: RE: [PATCH v2] examples/vhost: fix retry logic on eth rx

[PATCH v3] doc: clean vhost async path doc

2022-06-21 Thread xuan . ding
From: Xuan Ding This patch moves the 'Recommended IOVA mode in async datapath' section under 'Vhost asynchronous data path' as a sub-section, which makes the doc cleaner. Signed-off-by: Xuan Ding Reviewed-by: Jiayu Hu --- v3: * add Reviewd-by v2: * fix a typo in commit log --- doc/guides/pro

[PATCH v2] doc: clean vhost async path doc

2022-06-21 Thread xuan . ding
From: Xuan Ding This patch moves the 'Recommended IOVA mode in async datapath' section under 'Vhost asynchronous data path' as a subsection, which makes the doc cleaner. Signed-off-by: Xuan Ding --- v2: * fix a typo in commit log --- doc/guides/prog_guide/vhost_lib.rst | 12 ++-- 1 fil

RE: [PATCH] doc: clean vhost async path doc

2022-06-21 Thread Hu, Jiayu
Reviewed-by: Jiayu Hu > -Original Message- > From: Ding, Xuan > Sent: Wednesday, June 22, 2022 9:36 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > Subject: [PATCH] doc: clean vhost async path doc > > From: Xuan Ding > > This patch mov

[PATCH] doc: clean vhost async path doc

2022-06-21 Thread xuan . ding
From: Xuan Ding This patch moves the 'Recommended IOVA mode in async datapath' section under 'Vhost asynchronous data path' as a subsection, which make the doc cleaner. Signed-off-by: Xuan Ding --- doc/guides/prog_guide/vhost_lib.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deleti

[PATCH v2] app/test: add event inline security tests

2022-06-21 Thread Volodymyr Fialko
Enable ability to run inline security tests using event API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst). New test command - event_inline_ipsec_autotest will run same list of test cases as inline_ipsec_autotest, but packets will go through eventdev. Signed-off-by: Volodymyr Fialko --

[dpdk-dev] [PATCH v5] examples/ipsec-secgw: support more flow patterns and actions

2022-06-21 Thread psatheesh
From: Satheesh Paul Added support to create flow rules with count, mark and security actions and mark pattern. Signed-off-by: Satheesh Paul --- v5: * Rebased the patch. v4: * Added more description in documenation for flow rule options. v3: * Fixed IPv4 and IPv6 dst addr setting in flow pattern

[PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-06-21 Thread Gaoxiang Liu
When copy_desc_to_mbuf function failed, i added 1. And last_avail_idx added i, other than i - 1. It may cause that the first mbuf in mbuf-list is dropped, the second mbuf in mbuf-list is received in the following rx procedure. And The pkt_len of the second mbuf is zero, resulting in segment fault w

RE: [PATCH v2] doc: update async enqueue API usage

2022-06-21 Thread Ding, Xuan
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, June 21, 2022 9:23 PM > To: Ding, Xuan ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu > Subject: RE: [PATCH v2] doc: update async enqueue API usage > > Hi Xuan, > > > -Original Message- > > From: D

[PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-06-21 Thread Gaoxiang Liu
When copy_desc_to_mbuf function failed, i added 1. And last_avail_idx added i, other than i - 1. It may cause that the first mbuf in mbuf-list is dropped, the second mbuf in mbuf-list is received in the following rx procedure. And The pkt_len of the second mbuf is zero, resulting in segment fault w

[PATCH] vhost: fix avail idx update error when desc copy failed

2022-06-21 Thread Gaoxiang Liu
When copy_desc_to_mbuf function failed, i added 1. And last_avail_idx added i, other than i - 1. It may cause that the first mbuf in mbuf-list is dropped, the second mbuf in mbuf-list is received in the following rx procedure. And The pkt_len of the second mbuf is zero, resulting in segment fault w

Re: [PATCH 08/12] net/qede/base: fix build with GCC 12

2022-06-21 Thread Stephen Hemminger
On Wed, 18 May 2022 12:16:53 +0200 David Marchand wrote: > GCC raises the following warning: > > In function ‘_mm256_storeu_si256’, > inlined from ‘rte_mov32’ at > ../lib/eal/x86/include/rte_memcpy.h:320:2, > inlined from ‘rte_mov128’ at > ../lib/eal/x86/include/rte_memcp

Re: [PATCH v2 2/6] eal: add thread lifetime management

2022-06-21 Thread Dmitry Kozlyuk
2022-06-21 14:28 (UTC-0700), Tyler Retzlaff: > On Tue, Jun 21, 2022 at 10:44:21PM +0300, Dmitry Kozlyuk wrote: > > 2022-06-21 11:51 (UTC-0700), Tyler Retzlaff: > > > > > +int > > > > > +rte_thread_join(rte_thread_t thread_id, unsigned long *value_ptr) > > > > > +{ > > > > > + int ret = 0; > >

Re: [PATCH v2 2/6] eal: add thread lifetime management

2022-06-21 Thread Tyler Retzlaff
On Tue, Jun 21, 2022 at 10:44:21PM +0300, Dmitry Kozlyuk wrote: > 2022-06-21 11:51 (UTC-0700), Tyler Retzlaff: > > > > +int > > > > +rte_thread_join(rte_thread_t thread_id, unsigned long *value_ptr) > > > > +{ > > > > + int ret = 0; > > > > + void *res = NULL; > > > > + void **pre

[PATCH] examples/distributor: update dynamic configuration

2022-06-21 Thread Abdullah Ömer Yamaç
In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without "-c" parameter, you can run RX and Distributor on the different core. * Sy

[PATCH] examples/distributor: update dynamic configuration

2022-06-21 Thread Abdullah Ömer Yamaç
In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without "-c" parameter, you can run RX and Distributor on the different core. * Sy

Re: [PATCH 1/2] config: Use G++ as C++ compiler

2022-06-21 Thread Tyler Retzlaff
On Tue, Jun 21, 2022 at 02:28:23PM +0200, Stanislaw Kardach wrote: > Through some mixup all cross-files for PowerPC and ARM platforms were > using C Preprocessor (cpp) instead of GCC (g++). > This caused meson to fail detecting the C++ compiler presence and > therefore disabling some targets (i.e.

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Tyler Retzlaff
On Tue, Jun 21, 2022 at 11:42:55AM +0200, Stanisław Kardach wrote: > On Tue, Jun 21, 2022 at 11:39 AM Bruce Richardson > wrote: > > > > Generally the "cpp" binary is not the c-plus-plus one, but the C > > preprocessor one. Perhaps the original files are incorrect here, and should > > all refer to

Re: [PATCH v2 2/6] eal: add thread lifetime management

2022-06-21 Thread Dmitry Kozlyuk
2022-06-21 11:51 (UTC-0700), Tyler Retzlaff: > > > +int > > > +rte_thread_join(rte_thread_t thread_id, unsigned long *value_ptr) > > > +{ > > > + int ret = 0; > > > + void *res = NULL; > > > + void **pres = NULL; > > > + > > > + if (value_ptr != NULL) > > > + pres = &res; > > > + > > > + re

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread David Marchand
On Tue, Jun 21, 2022 at 5:00 PM Thomas Monjalon wrote: > > >>> The name of the option should not include "huge". > > >>> What about "--worker-stack" ? > > >>> If disabled (equal zero), the workers should use the default stack > > >>> memory. > > >>> > > >>> > > >> Wouldn't that have the potential

Re: [PATCH v2 2/6] eal: add thread lifetime management

2022-06-21 Thread Tyler Retzlaff
On Sat, Jun 18, 2022 at 03:59:08PM +0300, Dmitry Kozlyuk wrote: > 2022-06-14 16:47 (UTC-0700), Tyler Retzlaff: > > On Windows, the function executed by a thread when the thread starts is > > represeneted by a function pointer of type DWORD (*func) (void*). > > On other platforms, the function point

RE: [PATCH] app/test: add event inline security tests

2022-06-21 Thread Akhil Goyal
> Enable ability to run inline security tests using event > API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst). > New test command - event_inline_ipsec_autotest will run same list of > test cases as inline_ipsec_autotest, but packets will go through eventdev. > > Signed-off-by: Volodymy

RE: [dpdk-dev v7] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-06-21 Thread Akhil Goyal
> Hi Kai, > > > Since openssl 3.0 now deprecates the low level API QAT required to perform > > partial hash & aes operation when creating the session. This patch add in > > qat_ipsec_mb_lib driver parameter to allow QAT PMD to switch APIs > > between openssl and intel ipsec-mb library. > > > > Sig

RE: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: support more flow patterns and actions

2022-06-21 Thread Akhil Goyal
> From: Satheesh Paul > > Added support to create flow rules with count, mark and > security actions and mark pattern. > > Signed-off-by: Satheesh Paul > --- > v4: > * Added more description in documenation for flow rule options. > v3: > * Fixed IPv4 and IPv6 dst addr setting in flow pattern sp

RE: [EXT] [PATCH v2] test/ipsec: fix performance test failure

2022-06-21 Thread Akhil Goyal
> This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct. > Before it was passed uninitialized to rte_ipsec_sa_init(), > which does not check whether prm->ipsec_xform.esn.value is greater > than sa->sqn_mask. > > Bugzilla ID: 1023 > Fixes: f7f3ac6dcbe2 ("test/ipsec: add performa

RE: [PATCH] test/crypto: fix cipher offset for ZUC tests

2022-06-21 Thread Akhil Goyal
> > The cipher offset in bits was not being used in ZUC encryption test > > functions > > when creating the operation, it was hardcoded to 0. > > This is fixed to use the offset from the test vector as intended. > > > > Fixes: fd01a9be38d5 ("test/crypto: move IV to crypto op private data") > > Cc:

RE: [EXT] [dpdk-dev v5 0/4] crypto/openssl: EVP api update for 3.0 lib

2022-06-21 Thread Akhil Goyal
> This patch set update openssl pmd deprecated APIs to EVP > APIs where supported in openssl 3.0 lib > > --- > v5: > - review comments fix and release notes update Acked-by: Akhil Goyal Added Fan's Ack from previous version, updated release notes. Applied to dpdk-next-crypto Thanks.

RE: [EXT] Re: [PATCH v2 1/2] examples/l3fwd: common packet group functionality

2022-06-21 Thread Rahul Bhansali
> -Original Message- > From: Konstantin Ananyev > Sent: Tuesday, June 21, 2022 4:43 AM > To: Rahul Bhansali ; dev@dpdk.org; Ruifeng Wang > > Cc: Jerin Jacob Kollanukkaran > Subject: [EXT] Re: [PATCH v2 1/2] examples/l3fwd: common packet group > functionality > > External Email > > --

Re: [PATCH] test: drop reference to removed tests

2022-06-21 Thread Thomas Monjalon
13/06/2022 09:37, David Marchand: > cycles_autotest and delay_us_sleep_autotest tests were removed in the > commit ee00af60170b ("test: remove strict timing requirements some tests") > and were wrongly reintroduced later. > > Bugzilla ID: 1021 > Fixes: 74822233bdc2 ("test: create a list of extra t

RE: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Honnappa Nagarahalli
> > 21/06/2022 16:52, Don Wallwork: > > On 6/21/2022 10:42 AM, Thomas Monjalon wrote: > > > 21/06/2022 14:31, Don Wallwork: > > >> On 6/21/2022 6:37 AM, Thomas Monjalon wrote: > > >>> 20/06/2022 10:35, David Marchand: > > On Tue, May 24, 2022 at 9:52 PM Don Wallwork > wrote: > > > Add s

Re: [PATCH v2 2/6] eal: add thread lifetime management

2022-06-21 Thread Tyler Retzlaff
On Sat, Jun 18, 2022 at 03:59:08PM +0300, Dmitry Kozlyuk wrote: > 2022-06-14 16:47 (UTC-0700), Tyler Retzlaff: > > > +int > > +rte_thread_create(rte_thread_t *thread_id, > > + const rte_thread_attr_t *thread_attr, > > + rte_thread_func thread_func, void *args) > > +{ > > [...]

Re: [PATCH] dma/idxd: fix AVX2 code in non-datapath functions

2022-06-21 Thread Thomas Monjalon
20/06/2022 11:20, Walsh, Conor: > > While all systems which will use the idxd driver for hardware will > > support AVX2, if the driver is present the initialization functions e.g. > > to register logs, will be called on all systems - irrespective of HW > > support. This can cause issues if the syst

Re: [PATCH v2 1/2] test/crypto: remove Windows conditional compilation

2022-06-21 Thread Tyler Retzlaff
On Tue, Jun 21, 2022 at 05:09:40PM +0200, Thomas Monjalon wrote: > 20/05/2022 12:12, Tyler Retzlaff: > > @@ -590,4 +588,3 @@ static int uplane_encap_no_integrity(uint32_t sn_size, > > uint8_t dir, > > return n - i; > > }; > > > > -#endif /* !RTE_EXEC_ENV_WINDOWS */ > > When removing the la

[dpdk-dev v5 4/4] crypto/openssl: update on DSA routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch updates asymmetric DSA routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Divide the single combined dsa sign test to two individual dsa sign and dsa verfiy tests. Signed-off-by: Kai Ji --- app/test/test_cryptodev_asym.c | 90 -- doc/guides/rel_notes/r

[dpdk-dev v5 3/4] crypto/openssl: update on DH routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch updates asymmetric DH routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Signed-off-by: Kai Ji --- drivers/crypto/openssl/openssl_pmd_private.h | 4 + drivers/crypto/openssl/rte_openssl_pmd.c | 185 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 47

[dpdk-dev v5 2/4] crypto/openssl: update on RSA routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch updates asymmetric RSA routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Signed-off-by: Kai Ji --- drivers/crypto/openssl/openssl_pmd_private.h | 7 + drivers/crypto/openssl/rte_openssl_pmd.c | 149 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 11

[dpdk-dev v5 1/4] crypto/openssl: update on HMAC routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch update the symmetric HMAC routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Signed-off-by: Kai Ji --- drivers/crypto/openssl/openssl_pmd_private.h | 4 + drivers/crypto/openssl/rte_openssl_pmd.c | 187 ++- 2 files changed, 181 insertions(+), 10 deletio

[dpdk-dev v5 0/4] crypto/openssl: EVP api update for 3.0 lib

2022-06-21 Thread Kai Ji
This patch set update openssl pmd deprecated APIs to EVP APIs where supported in openssl 3.0 lib --- v5: - review comments fix and release notes update v4: - compilation issue fix v3: - rebase to 22.07 rc1 v2: - addin DSA routine --- Kai Ji (4): crypto/openssl: update on HMAC routine with 3

Re: [PATCH] dma/idxd: fix missing default for workqueue options

2022-06-21 Thread Thomas Monjalon
20/06/2022 06:09, Pai G, Sunil: > > From: Richardson, Bruce > > Sent: Friday, June 17, 2022 4:48 PM > > To: dev@dpdk.org > > Cc: Laatz, Kevin ; Pai G, Sunil > > ; Richardson, Bruce > > Subject: [PATCH] dma/idxd: fix missing default for workqueue options > > > > When no --wq-option flag is passed

[PATCH v3 3/3] examples/vhost: update vhost usage message

2022-06-21 Thread Herakliusz Lipiec
updating vhost usage message to be aligned with the documentation. Signed-off-by: Herakliusz Lipiec Reviewed-by: Chenbo Xia --- examples/vhost/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index e7fee5aa1b..

[PATCH v3 2/3] doc: update vhost sample app docs

2022-06-21 Thread Herakliusz Lipiec
Vhost sample app documentation describes parameters that are not in the code and omits parameters that exist. Also switching the order of sections on running vhost and VM, since the --client parameter in the sample line requires a socket to be created by VM. Removing uio references and updating wit

[PATCH v3 1/3] examples/vhost: update makefile to match meson build system

2022-06-21 Thread Herakliusz Lipiec
Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson and the docs accordingly. Signed-off-by: Herakliusz Lipiec Acked-by: Bruce Richardson --- V2: * Moving relevant doc updates here from second patch as per Bruces su

Re: [PATCH v2 0/2] test: enable most driver tests on windows

2022-06-21 Thread Thomas Monjalon
20/05/2022 12:12, Tyler Retzlaff: > * remove conditional compilation for windows from crypto tests so they > are built and registered to be run with dpdk-test.exe. > * remaining driver tests require further investigation and will not be > addressed in this series. > > sorry for the delay in ad

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-21 Thread David Marchand
On Sat, Jun 18, 2022 at 4:10 PM Huichao Cai wrote: > > To resolve the compilation warning,replace the rte_memcpy with memcpy. > Modify in file test_ipfrag.c and rte_ipv4_fragmentation.c. > > Signed-off-by: Huichao Cai Fixed Konstantin mail address. > --- > app/test/test_ipfrag.c

Re: [PATCH v2 1/2] test/crypto: remove Windows conditional compilation

2022-06-21 Thread Thomas Monjalon
20/05/2022 12:12, Tyler Retzlaff: > @@ -590,4 +588,3 @@ static int uplane_encap_no_integrity(uint32_t sn_size, > uint8_t dir, > return n - i; > }; > > -#endif /* !RTE_EXEC_ENV_WINDOWS */ When removing the last line of a file, you should remove the blank line before. I'll fix when merging

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Thomas Monjalon
21/06/2022 16:52, Don Wallwork: > On 6/21/2022 10:42 AM, Thomas Monjalon wrote: > > 21/06/2022 14:31, Don Wallwork: > >> On 6/21/2022 6:37 AM, Thomas Monjalon wrote: > >>> 20/06/2022 10:35, David Marchand: > On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: > > Add support for using hug

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Don Wallwork
On 6/21/2022 10:42 AM, Thomas Monjalon wrote: 21/06/2022 14:31, Don Wallwork: On 6/21/2022 6:37 AM, Thomas Monjalon wrote: 20/06/2022 10:35, David Marchand: On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to im

Re: [PATCH v4 00/14] remove IWYU flagged headers

2022-06-21 Thread Thomas Monjalon
20/06/2022 12:40, Sean Morrissey: > This patchset removes unused header includes flagged > by the IWYU tool for the 22.07 release. > > V4: > * Fix arm build issues. > V3: > * Fix more linux build issues. > V2: > * Fix various build issues. Build looks fine now. Applied, thanks.

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Thomas Monjalon
21/06/2022 14:31, Don Wallwork: > On 6/21/2022 6:37 AM, Thomas Monjalon wrote: > > 20/06/2022 10:35, David Marchand: > >> On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: > >>> Add support for using hugepages for worker lcore stack memory. The > >>> intent is to improve performance by reducing

[PATCH] vdpa/ifc: fix vhost message size check issue

2022-06-21 Thread Andy Pei
For vhost message VHOST_USER_GET_CONFIG, we do not check payload size in vhost lib, we check payload size in driver specific ops. For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config). Fixes: 856d03bcdc54 ("vdpa/ifc: add block operations")

RE: [PATCH] eal/x86: don't export internal alignment macro

2022-06-21 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 21 June 2022 16.13 > > ALIGNMENT_MASK is only used internally. > Besides it lacks a DPDK-related prefix. > Hide it from external eyes. > > Reported-by: Morten Brørup > Signed-off-by: David Marchand > --- > lib/eal/x86/i

RE: [PATCH v2] app/test: add additional stream cipher tests

2022-06-21 Thread Power, Ciara
Hi Tejasree , Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday 21 June 2022 13:51 > To: Tejasree Kondoj ; Zhang, Roy Fan > ; Power, Ciara > Cc: Anoob Joseph ; Ankur Dwivedi > ; dev@dpdk.org > Subject: RE: [PATCH v2] app/test: add additional stream cipher tests > > > Addin

Re: [PATCH 1/2] config: Use G++ as C++ compiler

2022-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2022 at 02:28:23PM +0200, Stanislaw Kardach wrote: > Through some mixup all cross-files for PowerPC and ARM platforms were > using C Preprocessor (cpp) instead of GCC (g++). > This caused meson to fail detecting the C++ compiler presence and > therefore disabling some targets (i.e.

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2022 at 02:37:51PM +0200, Stanisław Kardach wrote: > On Tue, Jun 21, 2022 at 1:53 PM Thomas Monjalon wrote: > > > > If it is made intentionally hard, it is just a wrong design. > > A toolchain prefix is just a name. > > We can have 2 toolchains compiled with the same name and diff

[PATCH] eal/x86: don't export internal alignment macro

2022-06-21 Thread David Marchand
ALIGNMENT_MASK is only used internally. Besides it lacks a DPDK-related prefix. Hide it from external eyes. Reported-by: Morten Brørup Signed-off-by: David Marchand --- lib/eal/x86/include/rte_memcpy.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/x86/include/rte_memcpy.h b/lib/

RE: [PATCH] test/crypto: fix cipher offset for ZUC tests

2022-06-21 Thread Ji, Kai
> -Original Message- > From: Power, Ciara > Sent: Tuesday, June 21, 2022 12:42 PM > To: Akhil Goyal ; Zhang, Roy Fan > > Cc: dev@dpdk.org; Ji, Kai ; Power, Ciara > ; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [PATCH] test/crypto: fix cipher offset for ZUC tests > > The cipher o

[dpdk-dev v5 4/4] crypto/openssl: update on DSA routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch updates asymmetric DSA routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Divide the single combined dsa sign test to two individual dsa sign and dsa verfiy tests. Signed-off-by: Kai Ji --- app/test/test_cryptodev_asym.c | 90 -- doc/guides/rel_notes/r

[dpdk-dev v5 3/4] crypto/openssl: update on DH routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch updates asymmetric DH routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Signed-off-by: Kai Ji --- drivers/crypto/openssl/openssl_pmd_private.h | 4 + drivers/crypto/openssl/rte_openssl_pmd.c | 185 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 47

[dpdk-dev v5 2/4] crypto/openssl: update on RSA routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch updates asymmetric RSA routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Signed-off-by: Kai Ji --- drivers/crypto/openssl/openssl_pmd_private.h | 7 + drivers/crypto/openssl/rte_openssl_pmd.c | 149 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 11

[dpdk-dev v5 1/4] crypto/openssl: update on HMAC routine with 3.0 EVP API

2022-06-21 Thread Kai Ji
This patch update the symmetric HMAC routine in crypto openssl pmd to adopt openssl 3.0 EVP apis. Signed-off-by: Kai Ji --- drivers/crypto/openssl/openssl_pmd_private.h | 4 + drivers/crypto/openssl/rte_openssl_pmd.c | 187 ++- 2 files changed, 181 insertions(+), 10 deletio

[dpdk-dev v5 0/4] crypto/openssl: EVP api update for 3.0 lib

2022-06-21 Thread Kai Ji
This patch set update openssl pmd deprecated APIs to EVP APIs where supported in openssl 3.0 lib --- v5: - review comments fix and release notes update v4: - compilation issue fix v3: - rebase to 22.07 rc1 v2: - addin DSA routine --- Kai Ji (4): crypto/openssl: update on HMAC routine with 3

Re: [PATCH v2 1/2] net: fix GTP PSC headers

2022-06-21 Thread Singh, Aman Deep
On 6/16/2022 11:31 PM, Gregory Etelson wrote: Fix bitmap fields order in little endian section of GTP PSC headers. Fixes: e8ca1479cdc4 ("net: add extension header for GTP PSC") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav Ovsiienko Acked-by: Aman Singh

RE: [EXT] [dpdk-dev v4 2/4] crypto/openssl: 3.0 EVP update on RSA routine

2022-06-21 Thread Ji, Kai
> -Original Message- > > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > > @@ -2046,6 +2046,150 @@ process_openssl_modexp_op(struct > rte_crypto_op > > *cop, } > > > > /* process rsa operations */ > > +#if (OPENSSL_VERSION_NUMBER >= 0

RE: [PATCH v2] examples/vhost: fix retry logic on eth rx path

2022-06-21 Thread Xia, Chenbo
Hi Yuan, > -Original Message- > From: Wang, YuanX > Sent: Friday, June 17, 2022 3:02 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang ; > Wang, YuanX ; sta...@dpdk.org; Ling, WeiX > > Subject: [PATCH v2] examples/vhost: fix retry logic on

[PATCH v2] test/ipsec: fix performance test failure

2022-06-21 Thread Vladimir Medvedkin
This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct. Before it was passed uninitialized to rte_ipsec_sa_init(), which does not check whether prm->ipsec_xform.esn.value is greater than sa->sqn_mask. Bugzilla ID: 1023 Fixes: f7f3ac6dcbe2 ("test/ipsec: add performance cases") Cc

RE: [PATCH v6] sched: enable CMAN at runtime

2022-06-21 Thread Dumitrescu, Cristian
Hi Marcin, The code changes in the library (rte-sched.c) look good to me, but I do have some questions for the qos_sched app and the Soft NIC driver on how CMAN gets enabled/disabled. How do we control whether congestion management (CMAN) should be disabled on enabled (WRED/PIE)? It looks to

RE: [PATCH v2] doc: update async enqueue API usage

2022-06-21 Thread Xia, Chenbo
Hi Xuan, > -Original Message- > From: Ding, Xuan > Sent: Tuesday, June 21, 2022 3:22 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > Subject: [PATCH v2] doc: update async enqueue API usage > > From: Xuan Ding > > This patch updates the

RE: [EXT] [PATCH v1] doc/l2_forward_crypto: fixed grammar and parameters

2022-06-21 Thread Akhil Goyal
> Doc was updated with fixed grammar in most cases. These > include adding periods to ends of sentences and capitalizing > some words. Some instances of "a" were changed to "an". The > option "-n 4" has also been removed from the example of > running the application. > > Fixes: ba7b86b1419 ("doc:

RE: [PATCH v2 1/3] examples/vhost: update makefile to match meson build system

2022-06-21 Thread Xia, Chenbo
Hi Herakliusz, > -Original Message- > From: Lipiec, Herakliusz > Sent: Tuesday, June 21, 2022 8:13 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > Richardson, Bruce > Cc: dev@dpdk.org; Lipiec, Herakliusz > Subject: [PATCH v2 1/3] examples/vhost: update makefile to match meson > bui

RE: [EXT] [PATCH] test/ipsec: check for cryptodevs before testing

2022-06-21 Thread Akhil Goyal
> Make sure that ipsec_perf_autotest checks if there are any crypto > devices available before it starts performance testing. > Same test is performed in the ipsec_autotest so it seems prudent to do > it here too to not introduce false failures. > > Signed-off-by: Stanislaw Kardach > --- Acked-

RE: [PATCH] app/test: add event inline security tests

2022-06-21 Thread Akhil Goyal
> Enable ability to run inline security tests using event > API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst). > New test command - event_inline_ipsec_autotest will run same list of > test cases as inline_ipsec_autotest, but packets will go through eventdev. > > Signed-off-by: Volodymy

Re: [PATCH 2/2] net/hns3: support backplane media type

2022-06-21 Thread Ferruh Yigit
On 6/11/2022 8:42 AM, Dongdong Liu wrote: From: Chengwen Feng The 802.11 physical PMA sub-layer defines three media: copper, fiber and backplane. For PMD, the backplane is similar to the fiber, the main differences are that backplane doesn't have optical module. Because the interface of firmwar

RE: [EXT] [PATCH v2 1/2] examples/l3fwd: common packet group functionality

2022-06-21 Thread Akhil Goyal
> > > This will make the packet grouping function common, so > > that other examples can utilize as per need. > > > > Signed-off-by: Rahul Bhansali > > --- Acked-by: Akhil Goyal

RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode

2022-06-21 Thread Akhil Goyal
> This adds the support of NEON based lpm lookup along with > multi packet processing for burst send in packets routing. > > Performance impact: > On cn10k, with poll mode inline protocol, outbound performance > increased by upto ~8% and inbound performance increased by > upto ~6%. > > Signed-off

RE: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: support more flow patterns and actions

2022-06-21 Thread Akhil Goyal
> > From: Satheesh Paul > > Added support to create flow rules with count, mark and > security actions and mark pattern. > > Signed-off-by: Satheesh Paul > --- Acked-by: Akhil Goyal

RE: [PATCH v2] app/test: add additional stream cipher tests

2022-06-21 Thread Akhil Goyal
> Adding zuc, snow3g and aes-ctr-cmac auth-cipher > test vectors with same auth and cipher offsets > and total digest data encrypted. > Existing tests have different cipher and > auth offsets and partial or no digest encrypted. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal @Cia

RE: [PATCH] crypto/cnxk: add CPT hardware flow control checks

2022-06-21 Thread Akhil Goyal
> Add hardware supported flow control checks before enqueueing to CPT. > Since both poll mode and event mode can be used at the same time, add > hardware flow control checks to make sure s/w doesn't over submit to > hardware queues. For cn9k, queue depth usage is not high and so FC check > is omitt

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Stanisław Kardach
On Tue, Jun 21, 2022 at 1:53 PM Thomas Monjalon wrote: > > If it is made intentionally hard, it is just a wrong design. > A toolchain prefix is just a name. > We can have 2 toolchains compiled with the same name and different behaviours. > And we can have 2 similar toolchains with a different nam

RE: [PATCH v2 0/3] support stream cipher chained operations

2022-06-21 Thread Akhil Goyal
> This series adds support for zuc, snow3g and > aes-ctr-cmac chained operations in cn9k PMD. > > v2: > * Split autotest patch into separate series > > Tejasree Kondoj (3): > crypto/cnxk: fix CMAC IV > crypto/cnxk: support stream cipher chained operations > crypto/cnxk: support scatter gath

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Don Wallwork
On 6/21/2022 6:37 AM, Thomas Monjalon wrote: 20/06/2022 10:35, David Marchand: On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using

[PATCH] config/riscv: name the cross file properly

2022-06-21 Thread Stanislaw Kardach
Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file, rename it. Signed-off-by: Stanislaw Kardach --- .ci/linux-build.sh | 2 +- config/riscv/{riscv64_linux_gcc => riscv64_linux_gcc_ubuntu} | 0 devtools/test-meson-builds.sh

[PATCH 2/2] ci: use crossbuild-essential packages

2022-06-21 Thread Stanislaw Kardach
The crossbuild-essential- packages contain all necessary dependencies to cross-compile binaries for a given architecture including C and C++ compilers. Therefore use those instead of listing packages directly. This way C++ compiler is also installed and C++ include checks will be checked in CI for

  1   2   >