[PATCH] net/vhost: add flag to control wait queuing

2022-05-31 Thread Yuan Wang
update_queuing_status prevents PMD queue operations from affecting the data plane by waiting for rx/tx_pkt_burst to stops accessing the vhost device. In fact, it is only necessary to wait when destroy/stop the device, new/start device and vring_state_changed cases do not need. Since vring is locke

RE: [PATCH v9] eal: add seqlock

2022-05-31 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 1 June 2022 00.46 > > On Mon, 23 May 2022 16:23:46 +0200 > Mattias Rönnblom wrote: > > > +/** > > + * The RTE seqcount type. > > + */ > > +typedef struct { > > + uint32_t sn; /**< A sequence number for the protect

[PATCH v2] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Ke Zhang
The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable is done const intentionally to prevent using it directly, using the new helper functions : 'eth_hw_addr_set()' and 'eth_hw_addr_random()' Fixes: ea6b39b5b847 ("kni: remove ethtoo

[Bug 1022] [dpdk 22.07-rc0] meson build failed with doc args on Ubuntu22.04 with gcc11.2.0

2022-05-31 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1022 Bug ID: 1022 Summary: [dpdk 22.07-rc0] meson build failed with doc args on Ubuntu22.04 with gcc11.2.0 Product: DPDK Version: unspecified Hardware: All OS: All

RE: [PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread Zhang, Peng1X
Because under the following given situation, it still have some issue. To this given situation, it is sure that retry mechanism is necessary. While is it confirm that under other situation retry mechanism is always better than without retry? If modify 'ice_dcf_send_aq_cmd', it will affect the h

[Bug 1021] [dpdk-22.07][meson test] extra-tests/cycles_autotest & delay_us_sleep_autotest show Invalid DPDK_TEST value

2022-05-31 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1021 Bug ID: 1021 Summary: [dpdk-22.07][meson test] extra-tests/cycles_autotest & delay_us_sleep_autotest show Invalid DPDK_TEST value Product: DPDK Version: unspecified Hardware: All

[PATCH v3 7/7] app/testpmd: add meter color mark flow action

2022-05-31 Thread Alexander Kozyrev
Add testpmd command line to match for METER_MARK action: flow create ... actions meter_mark mtr_profile 20 / end Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 127 app/test-pmd/config.c | 26 app/test-p

[PATCH v3 6/7] app/testpmd: allow meter color marker modification

2022-05-31 Thread Alexander Kozyrev
Extend the list of available modify_field IDs to include recently added meter color marker item in testpmd CLI. Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdlin

[PATCH v3 5/7] app/testpmd: add meter color flow matching item

2022-05-31 Thread Alexander Kozyrev
Add testpmd command line to match on a meter color: flow create 0 ingress group 0 pattern meter color is green / end Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 83 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 + 2 files ch

[PATCH v3 4/7] ethdev: add meter color mark flow action

2022-05-31 Thread Alexander Kozyrev
Create a new Flow API action: METER_MARK. It Meters an IP packet stream and marks its packets with colors. Unlike the METER action, it performs no policing at all. A user has the flexibility to create any policies with the help of the METER_COLOR item later, only meter profile is mandatory here. S

[PATCH v3 3/7] ethdev: get meter profile/policy objects

2022-05-31 Thread Alexander Kozyrev
Introduce a new Meter API to retrieve a Meter profile and policy objects using the profile/policy ID previously created with meter_profile_add() and meter_policy_create() functions. That allows to save the pointer and avoid any lookups in the corresponding lists for quick access during a flow rule

[PATCH v3 2/7] ethdev: allow meter color marker modification

2022-05-31 Thread Alexander Kozyrev
Extend modify_field Flow API with support of Meter Color Marker modifications. It allows setting the packet's metadata to any color marker: green, yellow or red. A user is able to specify an initial packet color for Meter API or create simple Metering and Marking flow rules based on his own colorin

[PATCH v3 1/7] ethdev: add meter color flow matching item

2022-05-31 Thread Alexander Kozyrev
Provide an ability to use a Color Marker set by a Meter as a matching item in Flow API. The Color Marker reflects the metering result by setting the metadata for a packet to a particular codepoint: green, yellow or red. Signed-off-by: Alexander Kozyrev --- doc/guides/prog_guide/rte_flow.rst

[PATCH v3 0/7] ethdev: separate metering and marking from policing

2022-05-31 Thread Alexander Kozyrev
Extend Metering and Marking support in the Flow API: 1. Add METER_COLOR item to match Color Marker set by a Meter. 2. Add the ability to set Color Marker via modify_field Flow API. 3. Add Meter API to get profile/policy objects. 4. Add METER_MARK action to perform Meter color metering and marking.

RE: [PATCH v2 4/4] ethdev: add meter color mark flow action

2022-05-31 Thread Alexander Kozyrev
On Thursday, May 26, 2022 8:34 Ori Kam wrote: > I think required should be mandatory. Ok. > > +struct rte_flow_action_meter_mark { > > + > > + /**< Profile config retrieved with rte_mtr_profile_get(). */ > > + struct rte_flow_meter_profile *profile; > > + /**< Profile config retrieved with

RE: [PATCH v2 3/4] ethdev: get meter profile/policy objects

2022-05-31 Thread Alexander Kozyrev
On Thursday, May 26, 2022 8:28 Ori Kam wrote: > I think you should say also what happens to this pointer or values > in case of modification of the policy or destroy of the policy. Will mention this in the commit message in v3. Pointer is expected to be invalid and cannot be used once policy dest

[PATCH v2] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Ke Zhang
The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable is done const intentionally to prevent using it directly, using the new helper functions : 'eth_hw_addr_set()' and 'eth_hw_addr_random()' Fixes: ea6b39b5b847 ("kni: remove ethtoo

RE: [PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Peng1X > Sent: Wednesday, June 1, 2022 10:46 AM > To: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after failure > > Because currently just focus on the following gi

RE: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-31 Thread Alexander Kozyrev
> On Thursday, May 26, 2022 9:23 Jerin Jacob wrote: > > The overall approach looks good to me. > > > > Could you update > > doc/guides/prog_guide/traffic_metering_and_policing.rst for the new > > scheme. There is a documentation update in patch #3. > > I think, we need to add "struct rte_mtr_capa

RE: [PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread Zhang, Peng1X
Because currently just focus on the following given situation, and use 'hw->dcf_enabled' it should only affect on DCF. After having checked code 'ice_dcf_send_aq_cmd', it already have retry mechanism. > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, June 1, 2022 9:54 AM > To

Re: [PATCH v2] ethdev: fix dev close in secondary process

2022-05-31 Thread Ajit Khaparde
On Tue, May 31, 2022 at 6:32 PM Min Hu (Connor) wrote: > > From: Min Hu > > Secondary process need to close dev to release process private resources. > But secondary process should not be obliged to wait for device stop before > closing ethdev. > > This patch fixed it. > > Fixes: febc855b358e ("e

RE: [PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Peng1X > Sent: Wednesday, June 1, 2022 9:49 AM > To: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v4] net/ice: retry sending adminQ command after failure > > I see, so ice_aq_retry_send_cmd function will c

RE: [PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread Zhang, Peng1X
I see, so ice_aq_retry_send_cmd function will conduct whether DCF is enabled or not with 'hw->dcf_enabled'. > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, May 31, 2022 7:52 PM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v4

RE: [PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-05-31 Thread Honnappa Nagarahalli
> > > >> > >> [konstantin.v.anan...@yandex.ru appears similar to someone who > >> previously sent you email, but may not be that person. Learn why this > >> could be a risk at https://aka.ms/LearnAboutSenderIdentification.] > >> > >> 16/05/2022 07:10, Feifei Wang пишет: > >>> > > Currently, th

RE: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-31 Thread Kathleen Capella
Tested okay on N1SDP platform with testpmd (mac and io fwd) and l3fwd. Tested-by: Kathleen Capella > -Original Message- > From: Don Wallwork > Sent: Tuesday, May 24, 2022 2:52 PM > To: dev@dpdk.org > Cc: d...@xsightlabs.com; step...@networkplumber.org; > fengcheng...@huawei.com; m...@sm

RE: [PATCH v9] eal: add seqlock

2022-05-31 Thread Honnappa Nagarahalli
> > On Mon, 23 May 2022 16:23:46 +0200 > Mattias Rönnblom wrote: > > > + > > + /* make sure the data loads happens before the sn load */ > > + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); > > Why mix __atomic builtin with rte_atomic? > Instead: > __atomic_thread_fence(__ATOMIC_ACQUI

Re: [PATCH v9] eal: add seqlock

2022-05-31 Thread Stephen Hemminger
On Mon, 23 May 2022 16:23:46 +0200 Mattias Rönnblom wrote: > + > + /* make sure the data loads happens before the sn load */ > + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); Why mix __atomic builtin with rte_atomic? Instead: __atomic_thread_fence(__ATOMIC_ACQUIRE);

Re: [PATCH v9] eal: add seqlock

2022-05-31 Thread Stephen Hemminger
On Mon, 23 May 2022 16:23:46 +0200 Mattias Rönnblom wrote: > +/** > + * The RTE seqcount type. > + */ > +typedef struct { > + uint32_t sn; /**< A sequence number for the protected data. */ > +} rte_seqcount_t; Don't need structure for only one element. typedef uint32_t rte_seqcount_t; +

[PATCH v7 6/6] baseband/acc100: configuration of ACC101 from PF

2022-05-31 Thread Nicolas Chautru
Adding companion function common to ACC100/ACC101 which can be called from bbdev-test when running from PF. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 6 +- drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- drivers/baseband/acc100/rte_acc100_pmd.c | 314

[PATCH v7 5/6] baseband/acc100: modify validation code for ACC101

2022-05-31 Thread Nicolas Chautru
The validation requirement is different for the two devices. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 51 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/base

[PATCH v7 4/6] baseband/acc100: introduce PMD for ACC101

2022-05-31 Thread Nicolas Chautru
Support for ACC101 as a derivative of ACC100. Integrated in unified driver and reusing existing code when possible. Signed-off-by: Nicolas Chautru --- MAINTAINERS | 1 + doc/guides/bbdevs/acc100.rst | 37 +--- doc/guides/bbdevs/features/acc101.ini

[PATCH v7 2/6] baseband/acc100: add protection for some negative scenario

2022-05-31 Thread Nicolas Chautru
Catch exception in PMD in case of invalid input parameter. Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bas

[PATCH v7 3/6] baseband/acc100: remove RTE prefix for internal macro

2022-05-31 Thread Nicolas Chautru
Cosmetic update to remove RTE_ prefix for a define kept internal. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 4 ++-- drivers/baseband/acc100/rte_acc100_pmd.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc100/rte_

[PATCH v7 1/6] baseband/acc100: update companion PF configure function

2022-05-31 Thread Nicolas Chautru
Update of the device configuration function from PF used for bbdev-test to latest sequence for ACC199 PRQ device and matching version in pf_bb_config 22.03. Fixes: b17d70922d5d ("baseband/acc100: add configure function") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/ac

[PATCH v7 0/6] drivers/baseband: PMD to support ACC100/ACC101 devices

2022-05-31 Thread Nicolas Chautru
v7: updates suggested by Akhil and Maxime. Removed RTE prefix for internal #define, removed build-time single FEC engine configuration mode, documentation fix, coding guideline fix, renamed new file without rte prefix. v6: use formally an unified driver for AC100 and AC101. Exposing single unifi

Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-05-31 Thread Thomas Monjalon
15/04/2022 10:29, Ananyev, Konstantin: > > According to RFC791,the options may appear or not in datagrams. > > They must be implemented by all IP modules (host and gateways). > > What is optional is their transmission in any particular datagram, > > not their implementation.So we have to deal with

RE: [EXT] [PATCH v6 3/5] baseband/acc100: introduce PMD for ACC101

2022-05-31 Thread Chautru, Nicolas
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Monday, May 30, 2022 12:40 AM > To: Chautru, Nicolas ; dev@dpdk.org; > t...@redhat.com; maxime.coque...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > davi

RE: [PATCH v10] sched: enable traffic class oversubscription conditionally

2022-05-31 Thread Danilewicz, MarcinX
Thank you Thomas. BR, /Marcin > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 31, 2022 6:42 PM > To: Danilewicz, MarcinX > Cc: dev@dpdk.org; Singh, Jasvinder ; Ajmera, > Megha ; Dumitrescu, Cristian > > Subject: Re: [PATCH v10] sched: enable traffic class oversubscrip

RE: [EXT] [PATCH v2 0/2] test: enable most driver tests on windows

2022-05-31 Thread Akhil Goyal
Hi Thomas, Can you take this series directly on main as it is enabling crypto as well as other tests? Regards, Akhil > * remove conditional compilation for windows from crypto tests so they > are built and registered to be run with dpdk-test.exe. > * remaining driver tests require further i

RE: [PATCH] test/crypto-perf: allow auth generate followed by encryption

2022-05-31 Thread Akhil Goyal
> > Allowing auth generation followed by encryption mode. > > --optype auth-then-cipher can take cipher-op as encrypt > > and auth-op as generate now. > > > > Signed-off-by: Tejasree Kondoj > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD

2022-05-31 Thread Akhil Goyal
> > > Few PMD changes as part of maintenance of the driver. These are not > > > required on the stable variants. Aiming to upstream these in 22.07. > > > Updated with review suggestions. > > > > > > Reviewed-by: Nicolas Chautru Series Applied to dpdk-next-crypto Thanks.

RE: [PATCH v6 5/5] baseband/acc100: configuration of ACC101 from PF

2022-05-31 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 31, 2022 12:36 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > david.

RE: [PATCH v5 4/5] baseband/acc100: modify validation code for ACC101

2022-05-31 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 31, 2022 1:00 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > david.m

RE: [EXT] [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD

2022-05-31 Thread Akhil Goyal
> Hi Akhil, > I believe I did ack it here > https://patches.dpdk.org/project/dpdk/patch/20220520030556.3475133-6-hernan.var...@intel.com/ > That was only on the 5th patch not the entire series. While giving ack to a series, please mention it explicitly or Send ack on coverletter. > But doing i

RE: [PATCH v6 4/5] baseband/acc100: modify validation code for ACC101

2022-05-31 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 31, 2022 1:03 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > david.m

RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations

2022-05-31 Thread Akhil Goyal
> > > You should also set a default value of this flag. > > > > Default functionality is disable SDAP. Application is defining the cperf > > options > > with all values 0s in its main(): "struct cperf_options opts = {0};". Is > > n't it > > sufficient? > It would be good to initialize that with o

RE: [EXT] [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD

2022-05-31 Thread Chautru, Nicolas
Hi Akhil, I believe I did ack it here https://patches.dpdk.org/project/dpdk/patch/20220520030556.3475133-6-hernan.var...@intel.com/ But doing it formally here below > -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 11:07 AM > To: Vargas, Hernan ; dev@dpdk.org; > t.

RE: [EXT] [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD

2022-05-31 Thread Akhil Goyal
Hi Nicolas, Can you review the series and ack? Regards, Akhil > Few PMD changes as part of maintenance of the driver. These are not required > on the stable variants. Aiming to upstream these in 22.07. > Updated with review suggestions. > > Hernan (5): > baseband/fpga_5gnr_fec: remove FLR tim

Re: [PATCH] ethdev: fix dev close in secondary process

2022-05-31 Thread Stephen Hemminger
On Tue, 31 May 2022 20:08:55 +0300 Andrew Rybchenko wrote: > On 5/27/22 05:35, Min Hu (Connor) wrote: > > From: Min Hu > > > > Shared memory like port private resources should only be reserved > > by primary process. Secondary process should not start dev, and > > the state of 'dev_started' is

Re: [PATCH v7] eal/ppc: fix compilation for musl

2022-05-31 Thread David Christensen
On 5/14/22 12:14 AM, Duncan Bellamy wrote: musl lacks __ppc_get_timebase() but has __builtin_ppc_get_timebase() Signed-off-by: Duncan Bellamy --- lib/eal/ppc/include/rte_cycles.h | 7 ++ lib/eal/ppc/rte_cycles.c | 39 2 files changed, 46 inse

[PATCH] rte_ring: remove leftover comment about watermark

2022-05-31 Thread Stephen Hemminger
The watermark support was removed from rte_ring since version 17.02 but there is leftover in comments. Fixes: 77dd3064270c ("ring: remove watermark support") Cc: bruce.richard...@intel.com Signed-off-by: Stephen Hemminger --- lib/ring/rte_ring.h | 14 ++ 1 file changed, 6 insertions(

RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-05-31 Thread Honnappa Nagarahalli
> > 25/05/2022 01:24, Honnappa Nagarahalli пишет: > > From: Konstantin Ananyev > > > > 20/04/2022 09:16, Feifei Wang пишет: > >>> Enable direct rearm mode. The mapping is decided in the data plane > >>> based on the first packet received. > >>> > >>> Suggested-by: Honnappa Nagarahalli > >>

Re: [PATCH] ethdev: fix dev close in secondary process

2022-05-31 Thread Andrew Rybchenko
On 5/27/22 05:35, Min Hu (Connor) wrote: From: Min Hu Shared memory like port private resources should only be reserved by primary process. Secondary process should not start dev, and the state of 'dev_started' is only meaningful to primary process. While secondary process need to close dev to

Re: [PATCH 1/3] common/sfc_efx/base: convert EFX PCIe INTF to MCDI value

2022-05-31 Thread Andrew Rybchenko
On 5/26/22 11:45, Ivan Malov wrote: When the driver queries its PCIe interface type via MCDI, the value from the response is translated to an EFX enum. When the driver passes this enum value back to any other MCDI helper, the inverse translation has to be conducted. Fixes: 1bf9ff57ccb3 ("common

Re: [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni()

2022-05-31 Thread Andrew Rybchenko
On 5/11/22 14:23, mingli...@windriver.com wrote: From: Mingli Yu The netif_rx_ni is removed in below commit after kernel upgraded to 5.18, so change accordingly to fix the gap. 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni(). Signed-off-by: Mingli Yu --- kernel/linux/kni/k

Re: [PATCH] kni: fix compile error

2022-05-31 Thread Andrew Rybchenko
On 5/21/22 10:06, Min Hu (Connor) wrote: When kernel version change into 5.18 from 5.17, 'netif_rx_ni' is discard. It is replaced by 'netif_rx' and this API is also supported in the version below 5.18. This patch fixed it. Fixes: d89a58dfe90b ("kni: support chained mbufs") Cc: sta...@dpdk.org

Re: [PATCH v10] sched: enable traffic class oversubscription conditionally

2022-05-31 Thread Thomas Monjalon
> > Added new API for flag to enable or disable TC oversubscription > > for best effort traffic class at subport level. > > > > By default TC OV is enabled. > > > > Signed-off-by: Marcin Danilewicz > > Acked-by: Cristian Dumitrescu Applied, thanks.

Re: [PATCH 0/5] Fix IDXD PCI device close

2022-05-31 Thread Kevin Laatz
On 31/05/2022 17:17, Thomas Monjalon wrote: Kevin Laatz (5): dma/idxd: fix memory leak in pci close dma/idxd: fix memory leak due to free on incorrect pointer app/test: close dma devices during cleanup app/testpmd: stop and close dmadevs at exit examples/dma: fix missing dma close

Re: [PATCH 1/3] app/testpmd: fix displaying RSS info

2022-05-31 Thread Andrew Rybchenko
On 5/31/22 05:07, lihuisong (C) wrote: 在 2022/5/30 21:02, Ferruh Yigit 写道: On 5/30/2022 1:32 PM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.

Re: [PATCH 3/3] app/testpmd: compact RSS flow type output in port info

2022-05-31 Thread Andrew Rybchenko
On 5/25/22 20:37, Ferruh Yigit wrote: In port info command output, 'show port info all', supported RSS flow types printed one type per line, and although this information is not most important part of the command it takes big part of the command output. Compacting the supported RSS flow type out

Re: [PATCH] maintainers: update for nfp

2022-05-31 Thread Thomas Monjalon
17/05/2022 05:02, Chaoyong He: > Add Chaoyong as nfp maintainer. > > Signed-off-by: Chaoyong He > Signed-off-by: Niklas Soderlund Applied, thanks.

Re: [PATCH v2] kni: fix build with Linux 5.18

2022-05-31 Thread Ferruh Yigit
On 5/25/2022 11:26 AM, Jiri Slaby wrote: Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases and call the appropriate function in kni_n

Re: [PATCH 0/5] Fix IDXD PCI device close

2022-05-31 Thread Thomas Monjalon
> Kevin Laatz (5): > dma/idxd: fix memory leak in pci close > dma/idxd: fix memory leak due to free on incorrect pointer > app/test: close dma devices during cleanup > app/testpmd: stop and close dmadevs at exit > examples/dma: fix missing dma close Any news about the v2?

Re: [dpdk-dev] [RFC PATCH] ethdev: support congestion management

2022-05-31 Thread Stephen Hemminger
On Mon, 30 May 2022 18:45:26 +0530 wrote: > From: Jerin Jacob > > NIC HW controllers often come with congestion management support on > various HW objects such as Rx queue depth or mempool queue depth. > > Also, it can support various modes of operation such as RED > (Random early discard), WR

Re: [PATCH v2 1/1] app/testpmd: support different input color method

2022-05-31 Thread Andrew Rybchenko
On 5/25/22 17:41, Dumitrescu, Cristian wrote: -Original Message- From: sk...@marvell.com Sent: Wednesday, May 25, 2022 3:37 PM To: Li, Xiaoyun ; Singh, Aman Deep ; Zhang, Yuying ; Dumitrescu, Cristian Cc: dev@dpdk.org; Sunil Kumar Kori Subject: [PATCH v2 1/1] app/testpmd: support di

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 5:26 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves > > > > > -Original Message- > > From: Kusztal, Arkadiusz

Re: [PATCH v3] kni: fix device address set

2022-05-31 Thread Andrew Rybchenko
On 5/23/22 12:24, Min Hu (Connor) wrote: Currently, run KNI APP When Kernel version is 5.17. When quit the APP, dmesg buffer get calltrace, info like: [ 5965.847401] rte_kni: Creating kni... [ 6225.627205] vEth0 (unregistered): Current addr: 70 fd 45 d0 72 a7 00.. [ 6225.640113] vEth0 (unregiste

Re: [PATCH v3 0/6] move DPAA2 QDMA driver freom raw to dma

2022-05-31 Thread Thomas Monjalon
26/05/2022 08:00, Hemant Agrawal: > Acked-by: Hemant Agrawal > > On 5/5/2022 2:35 PM, nipun.gu...@nxp.com wrote: > > From: Nipun Gupta > > > > This change removes the DPAA2 QDMA raw driver and adds the > > QDMA driver in dma set of drivers. The underlying I/O > > framework remains intact, where

Re: [PATCH] testpmd: optimize forward stream statistics

2022-05-31 Thread Andrew Rybchenko
On 5/24/22 11:27, Junfeng Guo wrote: 1. add throughput statistics for forward stream 2. display forward statistics for every forward stream Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo Sorry, I don't understand why summary say "optimize", but description do not say what is optimized a

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Akhil Goyal
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 8:03 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves > > Hi Akhil, > > Sorry I have missed that, and I think we should

RE: [v9, 00/10] Add JSON vector set support to fips validation

2022-05-31 Thread Akhil Goyal
> > Subject: [v9, 00/10] Add JSON vector set support to fips validation > > > > Adds a very basic introduction to JSON vector sets in > > the fips validation example application. This patch set > > will only introduce the AES-GCM test using a JSON request > > file because the other algorithms need

Re: [PATCH V3 0/2] ethdev: fix MAC addrs list

2022-05-31 Thread Andrew Rybchenko
On 5/14/22 05:00, Min Hu (Connor) wrote: From: Huisong Li The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC index, and other indexes can't be the same as the address corresponding to index 0. If we break it, may cause following problems: 1) waste of MAC address spaces. 2

Re: [PATCH v2 0/2] Split driver specific commands out of testpmd

2022-05-31 Thread Andrew Rybchenko
On 5/24/22 23:06, David Marchand wrote: Hello, Following TB decision [1] and recent discussions on the driver specific commands in testpmd, here is a proposal on how the split could be done. For now, this series simply moves the testpmd code in the driver directory. The driver specific testpmd

Re: [PATCH v2 2/2] app/testpmd: register driver specific commands

2022-05-31 Thread David Marchand
On Tue, May 31, 2022 at 5:14 PM Andrew Rybchenko wrote: > > On 5/24/22 23:28, Thomas Monjalon wrote: > > 24/05/2022 22:06, David Marchand: > >> +count = 0; > >> +for (i = 0; builtin_ctx[i] != NULL; i++, count++) > >> +; > >> +TAILQ_FOREACH(c, &driver_commands_head, next) {

Re: [PATCH v2 1/2] app/testpmd: mark most cmdline symbols as static

2022-05-31 Thread Andrew Rybchenko
On 5/24/22 23:06, David Marchand wrote: All those symbols don't need to be global, plus it was hiding unused code such as: - cmd_set_conntrack_dir_set and cmd_set_conntrack_dir_conntrack in cmdline.c, - cmd_create_port_meter_g_action, cmd_create_port_meter_r_action, cmd_create_port_meter_y_

Re: [PATCH v2 2/2] app/testpmd: register driver specific commands

2022-05-31 Thread Andrew Rybchenko
On 5/24/22 23:28, Thomas Monjalon wrote: 24/05/2022 22:06, David Marchand: + count = 0; + for (i = 0; builtin_ctx[i] != NULL; i++, count++) + ; + TAILQ_FOREACH(c, &driver_commands_head, next) { + for (i = 0; c->commands[i].ctx != NULL; i++, count++)

Re: [PATCH 00/12] bugfix for hns3 PMD

2022-05-31 Thread Andrew Rybchenko
On 5/19/22 15:29, Min Hu (Connor) wrote: This patch set contains 12 bugfix for hns3 PMD. The patch series fails to apply to dpdk-next-net/main. Please, rebase and send v2.

Re: [PATCH] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Stephen Hemminger
On Tue, 31 May 2022 09:13:30 + Ke Zhang wrote: > The warning info: > warning: passing argument 1 of ‘memcpy’ discards ‘const’ > qualifier from pointer target type > > Compulsory type conversion to clear compile warning. > > Signed-off-by: Ke Zhang Agree with other comments, please use eth

[PATCH v2] kni: fix build with Linux 5.18

2022-05-31 Thread Jiri Slaby
Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases and call the appropriate function in kni_net. Cc: sta...@dpdk.org Signed-off-by: Jir

[PATCH] kni: fix build with Linux 5.18

2022-05-31 Thread Jiri Slaby
Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases and call the appropriate function in kni_net. Cc: sta...@dpdk.org Signed-off-by: Jir

Re: [PATCH v9 0/5] add telemetry command for show module EEPROM

2022-05-31 Thread Andrew Rybchenko
On 5/26/22 10:32, Robin Zhang wrote: Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 4:40 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves > > Hi Arek, > > Hi Akhil, > > > > Sorry I have missed that, and I

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Akhil Goyal
Hi Arek, > Hi Akhil, > > Sorry I have missed that, and I think we should revert this patch. > It would make sense to have TLS derived numbers for these curves if DH and > ECDH would be in the same op. > But since we decided to split it we are going to go with separate structs for > x448 > and x25

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Akhil Goyal
> > > /** > > > diff --git a/lib/cryptodev/rte_cryptodev.h > > > b/lib/cryptodev/rte_cryptodev.h index 2c2c2edeb7..7d683fd728 100644 > > > --- a/lib/cryptodev/rte_cryptodev.h > > > +++ b/lib/cryptodev/rte_cryptodev.h > > > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability { > >

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Kusztal, ArkadiuszX
Hi Akhil, Sorry I have missed that, and I think we should revert this patch. It would make sense to have TLS derived numbers for these curves if DH and ECDH would be in the same op. But since we decided to split it we are going to go with separate structs for x448 and x25519 as per: https://patc

[PATCH v4 8/8] ci: add RISCV64 cross compilation job

2022-05-31 Thread Stanislaw Kardach
Checks cross-compilation using Ubuntu 20.04 x86. Signed-off-by: David Marchand Signed-off-by: Stanislaw Kardach --- .ci/linux-build.sh | 4 .github/workflows/build.yml | 11 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-

[PATCH v4 7/8] devtools: add RISC-V to test-meson-builds.sh

2022-05-31 Thread Stanislaw Kardach
Validate RISC-V compilation when test-meson-builds.sh is called. The check will be only performed if appropriate toolchain is present on the system (same as with other architectures). Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- devtools/test-meson-buil

[PATCH v4 6/8] test/cpuflags: add test for RISC-V cpu flag

2022-05-31 Thread Stanislaw Kardach
From: Michal Mazurek Add checks for all flag values defined in the RISC-V misa CSR register. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Michal Mazurek Signed-off-by: Stanislaw Kardach --- app/test/test_cpuflags.c | 81 1 file cha

[PATCH v4 5/8] examples/l3fwd: enable RISC-V operation

2022-05-31 Thread Stanislaw Kardach
Add missing em_mask_key() implementation and fix l3fwd_common.h inclusion in FIB lookup functions to enable the l3fwd to be run on RISC-V. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- examples/l3fwd/l3fwd_em.c | 8 examples/l3fwd/l3fwd_fib.c |

[PATCH v4 4/8] net/tap: set BPF syscall ID for RISC-V

2022-05-31 Thread Stanislaw Kardach
Define the missing __NR_bpf syscall id to enable the tap PMD. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- drivers/net/tap/meson.build | 5 - drivers/net/tap/tap_bpf.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH v4 3/8] net/memif: set memfd syscall ID on RISC-V

2022-05-31 Thread Stanislaw Kardach
Define the missing __NR_memfd_create syscall id to enable the memif PMD. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- drivers/net/memif/meson.build | 5 - drivers/net/memif/rte_eth_memif.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-)

[PATCH v4 2/8] net/ixgbe: enable vector stubs for RISC-V

2022-05-31 Thread Stanislaw Kardach
Re-use vector processing stubs in ixgbe PMD defined for PPC for RISC-V. This enables ixgbe PMD usage in scalar mode on this architecture. The ixgbe PMD driver was validated with Intel X520-DA2 NIC and the test-pmd application. Packet transfer checked using all UIO drivers available for non-IOMMU p

[PATCH v4 1/8] eal: add initial support for RISC-V architecture

2022-05-31 Thread Stanislaw Kardach
From: Michal Mazurek Add all necessary elements for DPDK to compile and run EAL on SiFive Freedom U740 SoC which is based on SiFive U74-MC (ISA: rv64imafdc) core complex. This includes: - EAL library implementation for rv64imafdc ISA. - meson build structure for 'riscv' architecture. RTE_ARCH_R

[PATCH v4 0/8] Introduce support for RISC-V architecture

2022-05-31 Thread Stanislaw Kardach
This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with the Freedom U740 SoC running Linux (freedom-u-sdk based kernel). I have tested this codebase using DPD

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 3:50 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > operation enum > > > > > -Original Message- > > From: Akhil Go

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 1:47 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > operation enum > > > /** > > diff --git a/lib/cryptodev/rte_cryptodev.

Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-31 Thread Andrew Rybchenko
On 5/31/22 16:40, Andrew Rybchenko wrote: On 5/25/22 03:40, Pankaj Gupta wrote: v6 (Andrew Rybchenko): Minor style changes in patches description Split FW version get patch to have callbacks reorder seperately Minor fix in FW version get patch to put callback definition, assi

Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-31 Thread Andrew Rybchenko
On 5/25/22 03:40, Pankaj Gupta wrote: v6 (Andrew Rybchenko): Minor style changes in patches description Split FW version get patch to have callbacks reorder seperately Minor fix in FW version get patch to put callback definition, assignment and implementation just after device

RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-31 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Tuesday, May 31, 2022 8:31 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > > > > -Original Message-

Re: [PATCH] app/testpmd: fix help of create meter command

2022-05-31 Thread Ferruh Yigit
On 4/28/2022 3:03 AM, Jin liu wrote: The help message of create meter command is incomplete, lack of policy_id param, update help string. Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Cc: sta...@dpdk.org Signed-off-by: Jin liu Signed-off-by: Chaoyong He Signed-off-by:

  1   2   >