[PATCH v2] net/igc: add I226 support

2022-05-24 Thread Qiming Yang
Added I226 Series device ID in igc driver and updated igc guide document for new devices. Signed-off-by: Qiming Yang Signed-off-by: Kevin Liu --- v2: * rebased --- doc/guides/nics/igc.rst| 14 +++--- doc/guides/rel_notes/release_22_03.rst | 5 + drivers/net/igc/base

RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:10 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh > > > > > - clarified usage of private key i

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:06 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org; Kiran > Kumar Kokkilagadda ; Anoob Joseph > > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform > > > > > - removed

RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:03 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman > > > > > > /** > > > > > @@ -383,22 +385,28

RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:00 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option > > > > > > > > > /** > > > > @@ -397,6 +399,10 @

[PATCH] examples/ethtool: update rxmode to increase functionality

2022-05-24 Thread Muhammad Jawad Hussain
previously rxmode functionality did not allow the user to choose between different vfs nor did it allow the user to choose rxmode settings by default it was set to vf = 0, rxmode = AUPE and the on/off state toggled without letting the user know what state it is in also there were no error messages

RE: [PATCH] app/test: update skipped count when setup returns skipped

2022-05-24 Thread Akhil Goyal
> Subject: [PATCH] app/test: update skipped count when setup returns skipped > > If the setup function returns TEST_SKIPPED, the logs would say the test > case is skipped while the summary count would consider it under failed > cases. Address this by counting such test cases under 'skipped'. > >

RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh

2022-05-24 Thread Akhil Goyal
> > > - clarified usage of private key in Diffie-Hellman. > > > CSRNG capable device should generate private key and then use it for > > > public key generation. > > > > > > Signed-off-by: Arek Kusztal > > > --- > > > lib/cryptodev/rte_crypto_asym.h | 4 > > > 1 file changed, 4 insertions(+)

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-24 Thread Akhil Goyal
> > > - removed asymnetric crypto xform next field. > > > Rationale behind having chaining in symmetric crypto was a fact that > > > encryption and authentication are usually done on the same set of data > > > independent of algorithm. > > > HW usually will be able to handle it in one PCI call. > >

Re: [PATCH v2] app/procinfo: show all non-owned ports

2022-05-24 Thread Stephen Hemminger
On Tue, 24 May 2022 22:46:05 -0700 Subendu Santra wrote: > Show all non-owned ports when no port mask is specified > > show-port option without the mask option, displays only the last > non-owned port. Show all the non-owned ports instead. > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to

RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman

2022-05-24 Thread Akhil Goyal
> > > > /** > > > > @@ -383,22 +385,28 @@ struct rte_crypto_dh_op_param { > > > > /**< > > > > * Output generated private key when op_type is > > > > * DH PRIVATE_KEY_GENERATION > > > > > > Update with actual enum name for this as well > > > > > > > -* Input when

RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option

2022-05-24 Thread Akhil Goyal
> > > > > > /** > > > @@ -397,6 +399,10 @@ struct rte_crypto_dh_op_param { > > >* For ECDH it is a point on the curve. > > >* Output for RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE > > >* Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > > + * > > > + * VERIFY option can be used only

Re: [PATCH v2] app/procinfo: show all non-owned ports

2022-05-24 Thread Subendu Santra
I have updated the v2 of the patch with the explanation. Kindly advise if it looks ok. Regards, Subendu. On Wed, May 25, 2022 at 11:22 AM Subendu Santra wrote: > > Show all non-owned ports when no port mask is specified > > show-port option without the mask option, displays only the last > non-

RE: [EXT] [PATCH 29/40] cryptodev: add salt length and optional label

2022-05-24 Thread Akhil Goyal
> > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > b/lib/cryptodev/rte_crypto_asym.h index 97c3fbee38..c864b8a115 100644 > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > @@ -205,12 +205,29 @@ struct rte_crypto_rsa_priv_key_qt { > > > */ > > > st

[PATCH] net/memif: fix overwriting of head segment

2022-05-24 Thread Joyce Kong
The 'dst_off' was reset in multi segment case. This caused memif buffer segment to write to beginning of mbuf, overwriting previous data. Fix it with this patch. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: sta...@dpdk.org Reported-by: Ferruh Yigit Signed-off-by: Joyce K

[PATCH v2] app/procinfo: show all non-owned ports

2022-05-24 Thread Subendu Santra
Show all non-owned ports when no port mask is specified show-port option without the mask option, displays only the last non-owned port. Show all the non-owned ports instead. Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned ports") Cc: step...@networkplumber.org Signed-of

[PATCH] examples/ethtool: adds promiscuous mode functionality

2022-05-24 Thread Muhammad Jawad Hussain
ethtool did not have promiscuous mode functioality previously which is needed for viewing broadcast and multicast packets. This patch allows user to turn on/off promiscuous mode on each port through command line. Signed-off-by: Muhammad Jawad Hussain --- doc/guides/sample_app_ug/ethtool.rst |

RE: [EXT] [PATCH 30/40] cryptodev: reduce rsa struct to only necessary fields

2022-05-24 Thread Akhil Goyal
> > > - reduced rsa struct to only necessary fields. > > > RSA operation is generally used with one input and one output. > > > One exception for this is signature verification, when RSA verify > > > called, both message and signature are inputs, but there is no rsa > > > output except for op statu

[PATCH v2] app/procinfo: show all non-owned ports

2022-05-24 Thread Subendu Santra
Show all non-owned ports when no port mask is specified show-port option without the mask option, displays only the last non-owned port. Show all the non-owned ports instead. Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned ports") Cc: step...@networkplumber.org Signed-of

RE: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in asym xform

2022-05-24 Thread Akhil Goyal
> > > - Reduced number of comments in asymmetric xform. > > > Information describing basic functionality of well known algorithms > > > are unnecessary. > > > - Added information about data memory lifetime. > > > It was specified how user should work with private data, and it is > > > user's respon

[PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-05-24 Thread Fidaullah Noonari
if rte malloc is called to allocate memory of size is between multiple of hugepage size minus malloc_header_len and hugepage size rte_malloc fails to allocate memory. this fix replaces malloc_elem_trailer_len with malloc_elem_overhead in try_expand_heap() to include malloc_elem_header_len when calc

RE: [PATCH v2 2/4] raw/ifpga: remove vdev when ifpga is closed

2022-05-24 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Wednesday, May 18, 2022 4:29 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v2 2/4] raw/ifpga: r

RE: [PATCH v2 3/4] raw/ifpga: unregister interrupt in ifpga close function

2022-05-24 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Wednesday, May 18, 2022 4:29 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v2 3/4] raw/ifpga: u

RE: [PATCH v2 1/4] raw/ifpga: remove experimental tag from ifpga APIs

2022-05-24 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Wednesday, May 18, 2022 4:29 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v2 1/4] raw/ifpga: r

[PATCH v8 5/5] ethdev: format module EEPROM for SFF-8636

2022-05-24 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8636 Rev 2.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8636.c | 750 ++ lib/ethdev/sff_8636.h

[PATCH v8 4/5] ethdev: format module EEPROM for SFF-8472

2022-05-24 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8472 Rev 12.0 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8472.c | 286 ++ 3 files changed, 291 insertion

[PATCH v8 3/5] ethdev: format module EEPROM for SFF-8079

2022-05-24 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8079 Rev 1.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 3 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8079.c | 406 ++ 3 files changed, 410 insertions

[PATCH v8 2/5] ethdev: common utilities for different SFF specs

2022-05-24 Thread Robin Zhang
This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_common.c | 326 lib/ethdev/sff_common.h | 1

[PATCH v8 1/5] ethdev: add telemetry command for module EEPROM

2022-05-24 Thread Robin Zhang
Add a new telemetry command /ethdev/module_eeprom to dump the module EEPROM of each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 138 ++ li

[PATCH v8 0/5] add telemetry command for show module EEPROM

2022-05-24 Thread Robin Zhang
Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/

RE: [PATCH v1 4/4] raw/ifpga: support ofs card probe

2022-05-24 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Tuesday, May 17, 2022 2:29 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v1 4/4] raw/ifpga: sup

RE: [PATCH v7 5/5] ethdev: format module EEPROM for SFF-8636

2022-05-24 Thread Zhang, RobinX
Hi, David This is a good suggestion and I will adopt it, send v8. Thanks! > -Original Message- > From: David Marchand > Sent: Tuesday, May 24, 2022 5:04 PM > To: Zhang, RobinX > Cc: dev ; Thomas Monjalon ; > Andrew Rybchenko ; Liu, KevinX > > Subject: Re: [PATCH v7 5/5] ethdev: format

[PATCH v1 2/2] raw/ifpga: update secure rsu

2022-05-24 Thread Wei Huang
Update secure RSU (Remote System Update) driver to adapt the changes introduced by OFS. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --- drivers/raw/ifpga/base/ifpga_api.c | 39 +- drivers/raw/ifpga/base/ifpga_feature_dev.h |2 + drivers/raw/ifpga/base/ifpga_fme.c |

[PATCH v1 1/2] raw/ifpga/base: add pmci driver

2022-05-24 Thread Wei Huang
PMCI (Platform Management Control Interface) is a new module in FPGA, which is designed to cooperate with BMC chip to fulfill board management functions. This driver provide interfaces to access registers of BMC chip and external flash of FPGA. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --

[PATCH v1 0/2] Update rsu implementation

2022-05-24 Thread Wei Huang
First patch introduce PMCI driver to provide interface to access PMCI functions which include flash controller. The second patch update RSU (Remote System Update) implementation to adapt with PMCI controller. Wei Huang (2): raw/ifpga/base: add pmci driver raw/ifpga: update secure rsu drivers

[PATCH v6 9/9] net/vmxnet3: fix merge error in Rx data ring initialization

2022-05-24 Thread Pankaj Gupta
Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") Cc: sta...@dpdk.org Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 + 1 file changed, 5 insertions

[PATCH v6 8/9] net/vmxnet3: set packet type for fragmented packet

2022-05-24 Thread Pankaj Gupta
The packet type is set even if it is a fragmented packet. Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 + 1 file changed, 17 insertions(+) diff -

[PATCH v6 6/9] net/vmxnet3: add version 6 support

2022-05-24 Thread Pankaj Gupta
VMXNET3 version 6 supports some new features, including but not limited to: - Increased max MTU up to 9190 - Increased max number of queues, both for Rx and Tx - Removes power-of-two limitations - Extended interrupt structures, required implementation for additional number of queues Tested, usi

[PATCH v6 2/9] net/vmxnet3: implement RETA query and RETA update

2022-05-24 Thread Pankaj Gupta
Add RETA query and RETA update support for VMXNET3. Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- doc/guides/rel_notes/release_21_08.rst | 2 + drivers/net/vmxnet3/vmxnet3_ethdev.c | 67 ++

[PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info

2022-05-24 Thread Pankaj Gupta
Currently the driver assumes that the size of the RETA table is four times the number of Rx queues at multiple places. However, it sets it to four times the maximum number of queues (4 * 32 = 128) when it first initializes the device. Change the other uses to use the stored value, not the assumed d

[PATCH v6 5/9] net/vmxnet3: report HW version on FW version get

2022-05-24 Thread Pankaj Gupta
Support rte_eth_dev_fw_version_get() API. Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens Signed-off-by: Andrew Rybchenko --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 20 1 file changed, 20

[PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-24 Thread Pankaj Gupta
v6 (Andrew Rybchenko): Minor style changes in patches description Split FW version get patch to have callbacks reorder seperately Minor fix in FW version get patch to put callback definition, assignment and implementation just after device info get v5: Use RTE_MIN instead of de

[PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order

2022-05-24 Thread Pankaj Gupta
Driver callbacks initialization should follow callbacks order in the structure definition. Do not reorder callbacks implementation to avoid extra noise in the code. Signed-off-by: Pankaj Gupta Signed-off-by: Andrew Rybchenko --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 +++--- 1 file

[PATCH v6 3/9] net/vmxnet3: add Rx queue usage count utility

2022-05-24 Thread Pankaj Gupta
Count the number of entries in the Rx queue for debugging. Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +++ driver

[PATCH v6 1/9] net/vmxnet3: add version 5 support

2022-05-24 Thread Pankaj Gupta
Add VMXNET3 v5 support. Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- doc/guides/rel_notes/release_21_08.rst | 2 ++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 +-- drivers/net/vmxnet3/vmxnet3_ethdev

RE: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI

2022-05-24 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 24, 2022 11:55 PM > To: Zhang, Qi Z > Cc: Daly, Jeff ; dev@dpdk.org; Wang, Haiyue > ; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru; Richardson, Bruce > ; Mcnamara, John > > Subject: Re: [PATCH v2] ixgbe/base: M

Re: [PATCH] examples/ipsec-secgw: add support of NEON with poll mode

2022-05-24 Thread Konstantin Ananyev
24/05/2022 10:57, Rahul Bhansali пишет: This adds the support of NEON based lpm lookup along with multi packet processing for burst send in packets routing. Performance impact: On cn10k, with poll mode inline protocol, outbound performance increased by upto ~8% and inbound performance increased

Re: [RFC PATCH 2/4] net/bonding: move testpmd commands

2022-05-24 Thread Konstantin Ananyev
24/05/2022 11:15, Thomas Monjalon пишет: 24/05/2022 11:40, Konstantin Ananyev: 20/05/2022 07:59, Andrew Rybchenko пишет: On 5/19/22 14:26, Thomas Monjalon wrote: 19/05/2022 09:40, David Marchand: On Thu, May 19, 2022 at 1:25 AM Konstantin Ananyev wrote: 18/05/2022 18:24, David Marchand пише

[RFT v2 3/3] rte_pie: fix incorrect floating point math

2022-05-24 Thread Stephen Hemminger
The function rte_pie_drop was attempting to do a random probability drop, but because of incorrect usage of fixed point divide it would always return 1. Change to use new rte_rand_float() instead. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzin...@intel.co

[RFT v2 2/3] rte_pie: remove unnecessary floating point

2022-05-24 Thread Stephen Hemminger
The qdelay variable is derived from and compared to 64 bit value so it doesn't have to be floating point. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzin...@intel.com Signed-off-by: Stephen Hemminger --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 inser

[RFT v2 1/3] random: add rte_rand_float()

2022-05-24 Thread Stephen Hemminger
The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to erand48_r in the standard library. Signed-off-by: Stephen Hemminger --- app/test/test_rand_perf.c | 7 +++ doc/guides/rel_notes/releas

[RFT v2 0/3] pie: fix random number issues

2022-05-24 Thread Stephen Hemminger
Alternate way to fix PIE use of random by introducing a fast way to get a random floating point number. It ends up not needing floating point math. Stephen Hemminger (3): random: add rte_rand_float() rte_pie: remove unnecessary floating point rte_pie: fix incorrect floating point math app/

Re: [PATCH] gpu/cuda: GPU_REGISTERED to distinguish GPU memory CPU mapped

2022-05-24 Thread Thomas Monjalon
29/04/2022 16:14, eagost...@nvidia.com: > From: Elena Agostini > > Enable GPU_REGISTERED flag in gpu/cuda driver in the memory list. > If a GPU memory address CPU mapped is freed before being > unmapped, CUDA driver unmaps it before freeing the memory. > > Signed-off-by: Elena Agostini Applied

Re: [PATCH v2 2/2] app/testpmd: register driver specific commands

2022-05-24 Thread Thomas Monjalon
24/05/2022 22:06, David Marchand: > + count = 0; > + for (i = 0; builtin_ctx[i] != NULL; i++, count++) > + ; > + TAILQ_FOREACH(c, &driver_commands_head, next) { > + for (i = 0; c->commands[i].ctx != NULL; i++, count++) > + ; > + } Just a

[PATCH 1/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-05-24 Thread Kathleen Capella
This patch adds the basic NEON Rx path to the iavf driver. It does not include scatter or flex varieties. Tested on N1SDP platform with testpmd mac forwarding and saw Rx-pps = 20M. Signed-off-by: Kathleen Capella Reviewed-by: Ruifeng Wang --- drivers/net/iavf/iavf_rxtx.c | 20 +- dri

[PATCH 0/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-05-24 Thread Kathleen Capella
This patch adds the basic NEON Rx path to iavf driver, including the main Rx function (_recv_raw_pkts_vec) and the functions it depends on. Also, NEON vector path has been added to iavf_set_rx_function. Functional testing with testpmd (rxonly and mac forwarding) and l3fwd have been done on N1SDP pl

RE: [PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-05-24 Thread Honnappa Nagarahalli
> > [konstantin.v.anan...@yandex.ru appears similar to someone who > previously sent you email, but may not be that person. Learn why this could > be a risk at https://aka.ms/LearnAboutSenderIdentification.] > > 16/05/2022 07:10, Feifei Wang пишет: > > > >>> Currently, the transmit side frees t

[PATCH v2 2/2] app/testpmd: register driver specific commands

2022-05-24 Thread David Marchand
Introduce a testpmd API so that drivers can register specific commands. A driver can list some files to compile with testpmd, by setting them in the testpmd_sources (driver local) meson variable. drivers/meson.build then takes care of appending this to a global meson variable, and adding the drive

[PATCH v2 0/2] Split driver specific commands out of testpmd

2022-05-24 Thread David Marchand
Hello, Following TB decision [1] and recent discussions on the driver specific commands in testpmd, here is a proposal on how the split could be done. For now, this series simply moves the testpmd code in the driver directory. The driver specific testpmd code is still compiled as part of testpmd

[PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-24 Thread Don Wallwork
Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added to allow the feature to b

[PATCH v5] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-24 Thread Don Wallwork
Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added to allow the feature to b

Re: [PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-24 Thread Don Wallwork
On 5/24/2022 10:40 AM, Burakov, Anatoly wrote: On 17-May-22 4:31 PM, Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory.  The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lco

RE: [RFT 0/2] pie: floating point fixes

2022-05-24 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 24 May 2022 20.46 > > A couple of small untested changes to address some > issues found while reviewing usage of random in DPDK. > > The PIE code should get rexamined in later release. Untested fixes to seemingly unte

Re: [PATCH v3 0/7] introduce per-queue limit watermark and host shaper

2022-05-24 Thread Thomas Monjalon
24/05/2022 21:00, Morten Brørup: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/05/2022 17:20, Spike Du: > > > LWM(limit watermark) is per RX queue attribute, when RX queue > > fullness reach the LWM limit, HW sends an event to dpdk application. > > Please ignore this comment, it is n

RE: [PATCH v3 0/7] introduce per-queue limit watermark and host shaper

2022-05-24 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 24 May 2022 17.59 > > +Cc people involved in previous versions > > 24/05/2022 17:20, Spike Du: > > LWM(limit watermark) is per RX queue attribute, when RX queue > fullness reach the LWM limit, HW sends an event to dpdk applicat

[RFT 2/2] rte_pie: fix incorrect floating point math

2022-05-24 Thread Stephen Hemminger
The function rte_pie_drop was attempting to do a random probability drop, but because of incorrect usage of fixed point divide it would always return 1. Change to use multiply to compute the probability. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzin...@in

[RFT 1/2] rte_pie: remove unnecessary floating point

2022-05-24 Thread Stephen Hemminger
The qdelay variable is derived from and compared to 64 bit value so it doesn't have to be floating point. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Cc: wojciechx.liguzin...@intel.com Signed-off-by: Stephen Hemminger --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 inser

[RFT 0/2] pie: floating point fixes

2022-05-24 Thread Stephen Hemminger
A couple of small untested changes to address some issues found while reviewing usage of random in DPDK. The PIE code should get rexamined in later release. It should not be exposing internal algorithm, that makes it brittle for ABI. Also, no code in DPDK should ever be doing floating point math

Re: [PATCH 2/6] app/testpmd: register driver specific commands

2022-05-24 Thread Thomas Monjalon
24/05/2022 19:44, David Marchand: > On Tue, May 24, 2022 at 7:21 PM Thomas Monjalon wrote: > > 23/05/2022 09:10, David Marchand: > > > +# Driver specific sources include some testpmd headers. > > > > Suggested reword: > > Driver-specific commands are located in driver directories. > > At

RE: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in asym xform

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 12:59 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 04/40] cryptodev: reduce number of comments in > asym xform > > > - Reduced number of comments in

Re: [PATCH 2/6] app/testpmd: register driver specific commands

2022-05-24 Thread David Marchand
On Tue, May 24, 2022 at 7:21 PM Thomas Monjalon wrote: > > 23/05/2022 09:10, David Marchand: > > Introduce a testpmd API so that drivers can register specific commands. > > > > A driver can list some files to compile with testpmd, by setting them > > in the testpmd_sources (driver local) meson var

Re: [PATCH 2/6] app/testpmd: register driver specific commands

2022-05-24 Thread Thomas Monjalon
23/05/2022 09:10, David Marchand: > Introduce a testpmd API so that drivers can register specific commands. > > A driver can list some files to compile with testpmd, by setting them > in the testpmd_sources (driver local) meson variable. > drivers/meson.build then takes care of appending this to a

Re: [PATCH 1/1] lpm: add a scalar version of lookupx4 function

2022-05-24 Thread Stanisław Kardach
On Thu, May 19, 2022 at 7:04 PM Medvedkin, Vladimir wrote: > > Hi Stanislaw, Michal, > > As far as I can see, this implementation almost completely repeats other > lookupx4() implementations, except for the use of vector instructions. > > On my board (x86_64) in lpm_perf_autotest your implementati

Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: combine default and regular flows

2022-05-24 Thread Ajit Khaparde
*,uint32_t)’ {aka ‘int(struct bnxt_ulp_context *, > unsigned int)’} >211 | ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, >| ^~~ > > > [2] > > +ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > > + uint32_t idx); > > > > > [3] > gcc 13.0.0 "gcc (GCC) 13.0.0 20220524 (experimental)") Bleeding edge gcc. Thanks Ferruh. We will take a look at this. smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v3 0/7] introduce per-queue limit watermark and host shaper

2022-05-24 Thread Thomas Monjalon
+Cc people involved in previous versions 24/05/2022 17:20, Spike Du: > LWM(limit watermark) is per RX queue attribute, when RX queue fullness reach > the LWM limit, HW sends an event to dpdk application. > Host shaper can configure shaper rate and lwm-triggered for a host port. > The shaper limit

Re: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI

2022-05-24 Thread Thomas Monjalon
24/05/2022 15:42, Zhang, Qi Z: > From: Thomas Monjalon > > 18/05/2022 02:03, Zhang, Qi Z: > > > From: Jeff Daly > > > > > > > > Some SFP link partners exhibit a disinclination to autonegotiate > > > > with X550 configured in SFI mode. This patch enables a manual AN-37 > > > > restart to work aro

RE: [EXT] [PATCH 30/40] cryptodev: reduce rsa struct to only necessary fields

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 2:53 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 30/40] cryptodev: reduce rsa struct to only > necessary > fields > > > - reduced rsa struct to onl

Re: [PATCH v4] eal: add bus cleanup to eal cleanup

2022-05-24 Thread Kevin Laatz
On 24/05/2022 10:38, Bruce Richardson wrote: On Tue, May 24, 2022 at 10:25:01AM +0100, Kevin Laatz wrote: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be

[PATCH v3 2/7] common/mlx5: share interrupt management

2022-05-24 Thread Spike Du
There are many duplicate code of creating and initializing rte_intr_handle. Add a new mlx5_os API to do this, replace all PMD related code with this API. Signed-off-by: Spike Du --- drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++ drivers/common/mlx5/linux/mlx5_common_os.h

[PATCH v3 5/7] net/mlx5: support Rx queue based limit watermark

2022-05-24 Thread Spike Du
Add mlx5 specific LWM(limit watermark) configuration and query handler. While the Rx queue fullness reaches the LWM limit, the driver catches an HW event and invokes the user callback. The query handler finds the next RX queue with pending LWM event if any, starting from the given RX queue index.

[PATCH v3 7/7] app/testpmd: add LWM and Host Shaper command

2022-05-24 Thread Spike Du
Add command line options to support LWM per-rxq configure. - Command syntax: set port rxq lwm mlx5 set port host_shaper lwm_triggered <0|1> rate - Example commands: To configure LWM as 30% of rxq size on port 1 rxq 0: testpmd> set port 1 rxq 0 lwm 30 To disable LWM on port 1 rxq 0: testp

[PATCH v3 6/7] net/mlx5: add private API to config host port shaper

2022-05-24 Thread Spike Du
Host port shaper can be configured with QSHR(QoS Shaper Host Register). Add check in build files to enable this function or not. The host shaper configuration affects all the ethdev ports belonging to the same host port. Host shaper can configure shaper rate and lwm-triggered for a host port. The

[PATCH v3 4/7] net/mlx5: add LWM event handling support

2022-05-24 Thread Spike Du
When LWM meets RQ WQE, the kernel driver raises an event to SW. Use devx event_channel to catch this and to notify the user. Allocate this channel per shared device. The channel has a cookie that informs the specific event port and queue. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx5.c

[PATCH v3 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-24 Thread Spike Du
LWM (limit watermark) describes the fullness of a Rx queue. If the Rx queue fullness is above LWM, the device will trigger the event RTE_ETH_EVENT_RX_LWM. LWM is defined as a percentage of Rx queue size with valid value of [0,99]. Setting LWM to 0 means disable it, which is the default. Add LWM's c

[PATCH v3 1/7] net/mlx5: add LWM support for Rxq

2022-05-24 Thread Spike Du
Add lwm(Limit WaterMark) field to Rxq object which indicates the percentage of RX queue size used by HW to raise LWM event to the user. Allow LWM setting in modify_rq command. Allow the LWM configuration dynamically by adding RDY2RDY state change. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx

[PATCH v3 0/7] introduce per-queue limit watermark and host shaper

2022-05-24 Thread Spike Du
LWM(limit watermark) is per RX queue attribute, when RX queue fullness reach the LWM limit, HW sends an event to dpdk application. Host shaper can configure shaper rate and lwm-triggered for a host port. The shaper limits the rate of traffic from host port to wire port. If lwm-triggered is enabled

Re: [PATCH v4] eal: add bus cleanup to eal cleanup

2022-05-24 Thread Kevin Laatz
On 24/05/2022 15:48, Stephen Hemminger wrote: On Tue, 24 May 2022 10:25:01 +0100 Kevin Laatz wrote: + + RTE_LOG(DEBUG, EAL, + "Clean up PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n", + drv->driver.name, de

RE: [EXT] [PATCH 29/40] cryptodev: add salt length and optional label

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 2:30 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 29/40] cryptodev: add salt length and optional label > > > - added salt length and optional label.

Re: [PATCH 2/2] common/cnxk: print NIX inline outbound CPT LF registers

2022-05-24 Thread Ray Kinsella
Rahul Bhansali writes: > This add the support to dump NIX inline outbound CPT LF > registers. > > Signed-off-by: Rahul Bhansali > --- > drivers/common/cnxk/roc_nix_debug.c | 14 ++ > drivers/common/cnxk/roc_nix_inl.h | 1 + > drivers/common/cnxk/version.map | 1 + > 3 file

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-05-24 Thread Ray Kinsella
fengchengwen writes: > Hi all, > > This patch lasts for a long time. Are we waiting for 22.11 to deal with it? That was my read, as can't reliably change the value of _MAX at this stage without it having impact elsewhere. > We have the same requirements for the reset or recovery mechani

RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 2:12 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 21/40] cryptodev: add public key verify option > > > - Added key exchange public key verify option.

Re: [PATCH] doc: announce header split deprecation

2022-05-24 Thread Ray Kinsella
xuan.d...@intel.com writes: > From: Xuan Ding > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to > substitute bit-field header_split in struct rte_eth_rxmode. It allows > to enable header split offload with the header size controlled using > split_hdr_size in the same s

Re: [PATCH 1/2] cmdline: add function to verify valid commands

2022-05-24 Thread Ray Kinsella
Bruce Richardson writes: > The cmdline library cmdline_parse() function parses a command and > executes the action automatically too. The cmdline_valid_buffer function > also uses this function to validate commands, meaning that there is no > function to validate a command as ok without executi

RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 24, 2022 4:52 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman > > > > > -Original Message- > > From:

Re: [PATCH v3] sched: enable/disable TC OV at runtime

2022-05-24 Thread Stephen Hemminger
On Tue, 24 May 2022 13:33:31 + Marcin Danilewicz wrote: > /Marcin > -- > Intel Research and Development Ireland Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Nu

RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 2:08 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 20/40] cryptodev: add elliptic curve diffie hellman > > > > - added elliptic curve Diffie-Hellman

Re: [PATCH v3 1/2] eal: get/set thread priority per thread identifier

2022-05-24 Thread Stephen Hemminger
On Tue, 24 May 2022 04:08:36 -0700 Tyler Retzlaff wrote: > +static int > +thread_map_priority_to_os_value(enum rte_thread_priority eal_pri, > + int *os_pri, int *pol) > +{ > + /* Clear the output parameters */ > + *os_pri = sched_get_priority_min(SCHED_OTHER) - 1; > + *pol

Re: [PATCH v4] eal: add bus cleanup to eal cleanup

2022-05-24 Thread Stephen Hemminger
On Tue, 24 May 2022 10:25:01 +0100 Kevin Laatz wrote: > + > + RTE_LOG(DEBUG, EAL, > + "Clean up PCI driver: %s (%x:%x) device: > "PCI_PRI_FMT" (socket %i)\n", > + drv->driver.name, dev->id.vendor_id, > dev->id.device_id, > +

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-24 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 24, 2022 1:13 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform > > > - removed asymnetric crypto xform next field.

Re: [PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-24 Thread Burakov, Anatoly
On 17-May-22 4:31 PM, Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. EAL option '--huge-worker-stack [stack-size-in

  1   2   >