> > >
> > >  /**
> > > @@ -397,6 +399,10 @@ struct rte_crypto_dh_op_param {
> > >    * For ECDH it is a point on the curve.
> > >    * Output for RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE
> > >    * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE
> > > +  *
> > > +  * VERIFY option can be used only for elliptic curve
> > > +  * point validation, for FFDH (DH) it is user's reponsibility
> > > +  * to check the public key accordingly.
> >
> > What is expected from the user? Please be specific.
> [Arek] - Well, this depends on protocol, usually it is size check for FFDH 
> and zero
> check for x25519/448. Not sure how much information should be provided here.
I can understand we cannot specify everything here.
How about adding in documentation a section to give details?

> > Add reference to the ke_type for which this comment id valid.
> 
> >
> > >    */
> > >   union {
> > >           rte_crypto_uint shared_secret;
> > > --
> > > 2.13.6

Reply via email to