RE: [RFC] ethdev: introduce protocol type based header split

2022-03-07 Thread Ding, Xuan
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: 2022年3月3日 16:55 > To: Ding, Xuan > Cc: Yigit, Ferruh ; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; viachesl...@nvidia.com; Zhang, Qi Z ; > Yu, Ping ; Ding, Xuan ; Wang, > YuanX ; ajit.khapa...@broadcom.com; > jer...@marve

[Bug 954] rte_eth_dev_info::device missing from API reference

2022-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=954 Bug ID: 954 Summary: rte_eth_dev_info::device missing from API reference Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: min

RE: [PATCH] app/testpmd: fix issue with memory leaks when quit testpmd

2022-03-07 Thread Zhang, Ke1X
> -Original Message- > From: Yigit, Ferruh > Sent: Saturday, March 5, 2022 12:44 AM > To: Zhang, Ke1X ; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying ; dev@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix issue with memory leaks when quit > testpmd > > On 3/1/2022 2:06 AM, Ke Zhang

[PATCH] net/iavf: fix potential out of bounds access

2022-03-07 Thread Leyi Rong
Fix potential out-out-bounds access as overrunning callee's array of size 26 by passing argument rxq->rxdid(which evaluates to 63) in call to iavf_rx_scan_hw_ring_flex_rxd. Coverity issue: 376616 Fixes: 7b1ba38904a0 ("net/iavf: fix function pointer in multi-process") Cc: sta...@dpdk.org Signed-of

RE: [PATCH] examples/distributor: one Tx queue is enough

2022-03-07 Thread Honnappa Nagarahalli
The ABI test failure is not related to this patch. Thanks, Honnappa > -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, March 7, 2022 4:40 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; lijuan...@intel.com; > juraj.lin...@pantheon.tech; ohily...@iol.unh.edu; > david.march..

RE: [PATCH v1] raw/ifpga: fix monitor thread issues

2022-03-07 Thread Huang, Wei
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 06:30 > To: Zhang, Tianfei ; Huang, Wei > > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com; > sta...@dpdk.org; Yigit, Ferruh > Subject: Re: [PATCH v1] raw/if

RE: [PATCH v1] raw/ifpga: fix interrupt handle allocation

2022-03-07 Thread Huang, Wei
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 8, 2022 06:24 > To: Huang, Wei ; Zhang, Tianfei > > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com; > sta...@dpdk.org; Yigit, Ferruh > Subject: Re: [PATCH v1] raw/if

Re: [PATCH] app/pdump: free mempool at cleanup resources

2022-03-07 Thread Thomas Monjalon
25/02/2022 03:40, Stephen Hemminger: > On Fri, 25 Feb 2022 09:00:37 +0800 > Tianli Lai wrote: > > > the mempool should be free when cleanup resources. > > > > Signed-off-by: Tianli Lai > > Thanks for fixing this. > > Acked-by: Stephen Hemminger Applied, thanks.

[PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-07 Thread Thinh Tran
I hit a failure during ports drop queue RQ creation when my adapters are on CPU socket ID 1 instead of socket ID 0: EAL: Probe PCI driver: mlx5_pci (15b3:1019) device: 0020:01:00.0 (socket 1) EAL: set_mempolicy failed: Invalid argument mlx5_common: Failed to allocate memory for RQ. mlx5_net: P

[PATCH] examples/distributor: one Tx queue is enough

2022-03-07 Thread Honnappa Nagarahalli
Distributor application creates one Tx queue per core. However the transmit is done only from a single core. Hence creating one Tx queue is enough. Fixes: 07db4a975094 ("examples/distributor: new sample app") Cc: bruce.richard...@intel.com Cc: reshma.pat...@intel.com Cc: sta...@dpdk.org Signed-of

[PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-03-07 Thread jeffd
From: Stephen Douthit 1G Cu SFPs are not officially supported on the X552/X553 family of devices but treat them as 1G SX modules since they usually work. Print a warning though since support isn't validated, similar to what already happens for other unofficially supported SFPs enabled via the al

[PATCH] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs

2022-03-07 Thread jeffd
From: Stephen Douthit Some XGS-PON SFPs have been observed ACKing I2C reads and returning uninitialized garbage while their uC boots. This can lead to the SFP ID code marking an otherwise working SFP module as unsupported if a bogus ID value is read while its internal PHY/microcontroller is stil

Re: [PATCH v1] raw/ifpga: fix monitor thread issues

2022-03-07 Thread Thomas Monjalon
01/03/2022 09:47, Wei Huang: > Monitor thread handles graceful shutdown according to the value of > specific sensors in device, two issues are found below. > 1. Thread is not created when card is probed. > 2. Thread is canceled without checking presence of other cards. > To fix them, thread is crea

Re: [PATCH v1] raw/ifpga: fix interrupt handle allocation

2022-03-07 Thread Thomas Monjalon
21/02/2022 07:51, Zhang, Tianfei: > From: Huang, Wei > > Allocate FPGA interrupt handle instance for each card. It doesn't say what was the issue. > > > > Fixes: e0a1aafe2af9 ("raw/ifpga: introduce IRQ functions") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Wei Huang > > It looks good for

Re: [PATCH v5] raw/ifpga: initialize scalar variable before using

2022-03-07 Thread Thomas Monjalon
28/02/2022 08:58, Zhang, Tianfei: > From: Huang, Wei > > Sent: Monday, February 21, 2022 3:52 PM > > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > > ; Huang, Wei > > Subject: [PATCH v5] raw/ifp

Re: [PATCH] gpu/cuda: missing slash in libcuda.so path

2022-03-07 Thread Thomas Monjalon
01/03/2022 20:42, eagost...@nvidia.com: > From: Elena Agostini > > Signed-off-by: Elena Agostini Applied with this title and commit log: gpu/cuda: fix dependency loading path A slash was missing in libcuda.so path for dlopen.

RE: [PATCH v1] net/mlx5: fix meter creation default state

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Monday, March 7, 2022 10:01 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Li Zhang > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v1] net/mlx5: fix meter

RE: [PATCH] net/mlx5: fix Rx queue private pointers array checking

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, March 3, 2022 5:27 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > Xueming(Steven) Li ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix Rx queue private pointers array checking > > None Rx qu

RE: [PATCH] net/mlx5: fix E-Switch disabling when DV flow disable

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Wednesday, March 2, 2022 9:15 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix E-Switch disabling when DV flow disable > > E-Switch DV flow is supported only when DV flow

RE: [PATCH v2] net/mlx5: fix MPLS/GRE Verbs spec ordering

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, March 2, 2022 7:07 PM > To: Matan Azrad ; Slava Ovsiienko > ; Gregory Etelson > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix MPLS/GRE Verbs spec ordering > > When using Ve

Re: [PATCH v3] graph: remove the useless duplicate name check

2022-03-07 Thread Thomas Monjalon
07/03/2022 13:47, Jerin Jacob: > On Mon, Mar 7, 2022 at 4:30 PM Haiyue Wang wrote: > > > > The node clone API parameter 'name' is the new node's postfix name, not > > the final node name, so it makes no sense to check it. And the new name > > will be checked duplicate when calling API '__rte_node_

[PATCH] net/iavf: replace SMP barrier with thread fence

2022-03-07 Thread Kathleen Capella
Replace the SMP barrier with atomic thread fence for iavf hw ring scan in the bulk Rx path. This patch introduces a change to the iavf driver that was already added to the i40e driver [1] as part of the adoption of the use of compiler atomics. [1] https://patches.dpdk.org/project/dpdk/patch/20210

Re: [PATCH v5] sched: remove useless malloc in pie data init

2022-03-07 Thread Thomas Monjalon
01/03/2022 21:32, Weiguo Li: > 'rte_pie_rt_data_init(NULL)' is not expected, and it's ought to > fail when this happen. The malloc inside the function didn't work. > So remove the malloc otherwise will lead to a memory leak. > > Fixes: 44c730b0e37971 ("sched: add PIE based congestion management")

Re: [PATCH 1/2] net/pcap: add snaplen argument

2022-03-07 Thread Ferruh Yigit
On 3/7/2022 8:30 PM, Tianli Lai wrote: snaplen argument would set the length of each packet that will save to pcap file. Hi Tianli, Overall +1 to add snaplen argument, but please find below comments. Also we are close to finalize the release and this is a new feature, so this can be consider

[PATCH] vhost: fix external message handlers

2022-03-07 Thread David Marchand
Following a rework, external message handlers were receiving a pointer to a vhost_user message (as stated in the API), but lost the ability to interact with fds attached to the message. Restore the original layout and put a build check and reminders. Bugzilla ID: 953 Fixes: 5e0099dc709e ("vhost: r

[PATCH] net/mlx5: fix IPv6 flow item validation for VERB API

2022-03-07 Thread Gregory Etelson
In case the PMD was activated over VERB API, limit IPv6 flow item next protocol mask value to 0 or 0xFF. The limitation is required for RSS flow action TCP and UDP types. Cc: sta...@dpdk.org Fixes: 491757372f98 ("net/mlx5: enforce limitation on IPv6 next protocol") Signed-off-by: Gregory Etelson

Re: [PATCH] raw/ntb: add check for DB intr handler registering

2022-03-07 Thread Thomas Monjalon
10/02/2022 11:43, Guo, Junfeng: > > > -Original Message- > > From: Guo, Junfeng > > Sent: Thursday, February 10, 2022 15:18 > > To: Wu, Jingjing > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering > > > > > > > > > -Orig

Re: [DPDK] /lib/eal: fix failed to stop device monitor error

2022-03-07 Thread Thomas Monjalon
02/03/2022 11:53, Long Li: > > Subject: Re: [DPDK] /lib/eal: fix failed to stop device monitor error > > > > Hello, > > > > > > The title should start with eal/linux: > > > > On Fri, Feb 11, 2022 at 10:01 AM wrote: > > > > > > From: Wenxuan Wu > > > > > > The ret value in rte_dev_event_monito

[Bug 953] Virtio Crypto Test failed

2022-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=953 Bug ID: 953 Summary: Virtio Crypto Test failed Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: No

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-03-07 Thread Bruce Richardson
On Mon, Mar 07, 2022 at 05:43:51PM +0100, Thomas Monjalon wrote: > 15/02/2022 16:34, Bruce Richardson: > > On Tue, Feb 15, 2022 at 02:50:48PM +0100, Karl Bonde Torp wrote: > > > On Tue, 15 Feb 2022 at 12:27, Bruce Richardson > > > wrote: > > > > > > > > On Tue, Feb 15, 2022 at 12:07:55PM +0100, Ka

Re: [PATCH] bus/pci: enhance driver pointer documentation

2022-03-07 Thread Thomas Monjalon
01/03/2022 11:53, David Marchand: > Setting driver pointer before mapping required for write combining > support since commit 4a928ef9f611 ("bus/pci: enable write combining > during mapping"). > > Move comments that got separated after different changes. > Also change the condition relying on dev-

[PATCH] app/testpmd: fix use of indirect action after port close

2022-03-07 Thread Dmitry Kozlyuk
When a port was closed, indirect actions could remain with their handles no longer valid. If a newly attached device was assigned the same ID as the closed port, those indirect actions became accessible again. Any attempt to use them resulted in an undefined behavior. Automatically flush indirect a

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-03-07 Thread Thomas Monjalon
15/02/2022 16:34, Bruce Richardson: > On Tue, Feb 15, 2022 at 02:50:48PM +0100, Karl Bonde Torp wrote: > > On Tue, 15 Feb 2022 at 12:27, Bruce Richardson > > wrote: > > > > > > On Tue, Feb 15, 2022 at 12:07:55PM +0100, Karl Bonde Torp wrote: > > > > On Mon, 14 Feb 2022 at 14:48, Bruce Richardson >

RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value

2022-03-07 Thread Zhang, Roy Fan
> -Original Message- > From: Bronowski, PiotrX > Sent: Monday, March 7, 2022 3:33 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; tho...@monjalon.net; > gak...@marvell.com; Yigit, Ferruh ; Doherty, Declan > ; Bronowski, PiotrX > ; sta...@dpdk.org > Subject: [PATCH v2] crypto/ipsec_mb: fix usa

RE: [PATCH 1/2] app/testpmd: add test for remote PD and CTX

2022-03-07 Thread Michael Baum
On 3/3/2022 2:57 PM, Ferruh Yigit wrote: > On 3/1/2022 8:26 PM, Michael Baum wrote: > > Add mlx5 internal option in testpmd run-time function "port attach" to > > add another parameter named "mlx5_socket" for attaching port and add 2 > > devargs before. > > > > The arguments are "cmd_fd" and "pd_

Re: [PATCH] net/hinic: fix Tx mbuf length problem

2022-03-07 Thread Stephen Hemminger
On Mon, 7 Mar 2022 22:12:20 +0800 Junjie Lin <277600...@qq.com> wrote: > From: Junjie Lin > > The Tx mbuf needs to be ignored if the pkt_len member is zero. > > Fixes: 54faba2295bd ("net/hinic:adds Tx queue xstats members") > Cc: sta...@dpdk.org > > Signed-off-by: Junjie Lin Not all drivers

Re: [PATCH 2/2] app/pdump: add filter argument

2022-03-07 Thread Stephen Hemminger
On Tue, 8 Mar 2022 04:30:41 +0800 Tianli Lai wrote: > filter argument contain size and snaplen argument. > size argument set the pcap file size, if the total packet > length over this value, pdump process will exist. > snaplen argument set each packet length to save pcap file. > > Signed-off-by

RE: [PATCH 2/2] app/testpmd: add test for external RxQ

2022-03-07 Thread Michael Baum
On 3/3/2022 3:02 PM, Ferruh Yigit wrote: > On 3/1/2022 8:26 PM, Michael Baum wrote: > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index d6490947c4..de5665c886 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b

[PATCH v2] crypto/ipsec_mb: fix usage of untrusted value

2022-03-07 Thread Piotr Bronowski
This patch removes coverity defect CID 375828: Untrusted value as argument (TAINTED_SCALAR) Coverity issue: CID 375828 Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") Signed-off-by: Piotr Bronowski Cc: sta...@dpdk.org --- v2: use a different logic to check digest length --- drivers

[PATCH] maintainers: Update MAINTAINERS for FIPS validation

2022-03-07 Thread Brian Dooley
Replace Marko Kovacevic with Brian Dooley and Fan Zhang Signed-off-by: Brian Dooley Cc: Marko Kovacevic Cc: Fan Zhang Cc: Akhil Goyal --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 75778343a5..c9c1cf7285 100644 --- a/MAINT

Re: [PATCH] examples/kni: add CR character at print log

2022-03-07 Thread Ferruh Yigit
On 3/7/2022 9:05 AM, Tianli Lai wrote: add CR character at print link state information Signed-off-by: Tianli Lai --- examples/kni/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5b20a7b62..e99ef5c38a 100644 --- a/ex

[PATCH v3] devtools/cocci: update cocci for ethdev namespace

2022-03-07 Thread Aman Singh
Changed the filter from ETH_SPEED to ETH_SPEED_NUM to make the match more specific. Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA as these were missed before. Signed-off-by: Aman Singh --- *v3: Rather than exception for ETH_SPEED_10G & ETH_SPEED_25G macro's made search filter more specific

[PATCH] net/hinic: fix Tx mbuf length problem

2022-03-07 Thread Junjie Lin
From: Junjie Lin The Tx mbuf needs to be ignored if the pkt_len member is zero. Fixes: 54faba2295bd ("net/hinic:adds Tx queue xstats members") Cc: sta...@dpdk.org Signed-off-by: Junjie Lin --- drivers/net/hinic/hinic_pmd_tx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/n

Re: release candidate 22.03-rc2

2022-03-07 Thread Pei Zhang
Hello Thomas, The testing with dpdk 22.03-rc2 from Red Hat looks good. We tested below 19 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Guest wi

[PATCH] net/hinic: fix Tx mbuf lenght problem

2022-03-07 Thread Junjie Lin
From: Junjie Lin The Tx mbuf needs to be ignored if the pkt_len member is zero. Fixes: 54faba2295bd ("net/hinic:adds Tx queue xstats members") Cc: sta...@dpdk.org Signed-off-by: Junjie Lin --- drivers/net/hinic/hinic_pmd_tx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/n

[Bug 952] unit tests fail when machine has more than 128 cores

2022-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=952 Bug ID: 952 Summary: unit tests fail when machine has more than 128 cores Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: no

Re: [PATCH 0/2] add missing local symbols catch-all

2022-03-07 Thread David Marchand
On Sun, Mar 6, 2022 at 10:20 AM Thomas Monjalon wrote: > > The libraries (and driver) regexdev, gpudev and auxiliary bus > were missing "local:*" in their version.map linker script > which catch all non-listed functions to be hidden in shared libraries. > > Thomas Monjalon (2): > regexdev: fix s

[PATCH v3 2/2] ethdev: prohibit polling of a stopped queue

2022-03-07 Thread Dmitry Kozlyuk
Whether it is allowed to call Rx/Tx functions for a stopped queue was undocumented. Some PMDs make this behavior a no-op either by explicitly checking the queue state or by the way how their routines are implemented or HW works. No-op behavior may be convenient for application developers. But it a

[PATCH v3 0/2] app/testpmd: skip stopped queues when forwarding

2022-03-07 Thread Dmitry Kozlyuk
It was unspecified what happens of a stopped queue is polled. Declare that polling is prohibited and modify testpmd to follow this. Rationale is described in the commit log; it follows the discussion: http://inbox.dpdk.org/dev/bl1pr12mb594551a71273709e1c04a8bab9...@bl1pr12mb5945.namprd12.prod.outlo

[PATCH v3 1/2] app/testpmd: do not poll stopped queues

2022-03-07 Thread Dmitry Kozlyuk
Calling Rx/Tx functions on a stopped queue is not supported. Do not run packet forwarding for streams that use stopped queues. Each stream has a read-only "disabled" field, so that lcore function can skip such streams. Forwarding engines can set this field using a new "stream_init" callback functi

[PATCH] crypto/ipsec_mb: fix usage of untrusted value

2022-03-07 Thread Piotr Bronowski
This patch removes coverity defect CID 375828: Untrusted value as argument (TAINTED_SCALAR) Coverity issue: CID 375828 Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") Signed-off-by: Piotr Bronowski --- drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH v3] graph: remove the useless duplicate name check

2022-03-07 Thread Jerin Jacob
On Mon, Mar 7, 2022 at 4:30 PM Haiyue Wang wrote: > > The node clone API parameter 'name' is the new node's postfix name, not > the final node name, so it makes no sense to check it. And the new name > will be checked duplicate when calling API '__rte_node_register'. > > And update the test case t

[PATCH 2/2] app/pdump: add filter argument

2022-03-07 Thread Tianli Lai
filter argument contain size and snaplen argument. size argument set the pcap file size, if the total packet length over this value, pdump process will exist. snaplen argument set each packet length to save pcap file. Signed-off-by: Tianli Lai --- app/pdump/main.c | 213 +

[PATCH 1/2] net/pcap: add snaplen argument

2022-03-07 Thread Tianli Lai
snaplen argument would set the length of each packet that will save to pcap file. Signed-off-by: Tianli Lai --- drivers/net/pcap/pcap_ethdev.c | 63 ++ 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pca

RE: [PATCH v3] doc: add steps to configure VF interface as trusted

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Asaf Penso > Sent: Monday, February 28, 2022 10:11 AM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v3] doc: add steps to configure VF interface as trusted > > Tru

RE: regarding Intel E810

2022-03-07 Thread Zhang, Qi Z
Hi Krishnakumar: I’m not an expert on SGX, but as I know there are many limitations to running code in the SGX enclave due to security considerations. usually, the DMA should be setup outside of the SGX, so I guess you should not run rte_eal_init within SGX. Regards Qi From: Sudharshan Krishn

[PATCH v3] graph: remove the useless duplicate name check

2022-03-07 Thread Haiyue Wang
The node clone API parameter 'name' is the new node's postfix name, not the final node name, so it makes no sense to check it. And the new name will be checked duplicate when calling API '__rte_node_register'. And update the test case to call clone API twice to check the real name duplicate. Sign

RE: [PATCH] examples/l3fwd: resolve stack buffer overflow issue

2022-03-07 Thread Walsh, Conor
Hi Rahul, I must have forgot to put my tag on this because I thought I reviewed it already. I reviewed and tested it again this morning. Thanks, Reviewed-by: Conor Walsh > -Original Message- > From: Rahul Bhansali > Sent: Monday 7 March 2022 06:45 > To: Rahul Bhansali ; dev@dpdk.org;

RE: [PATCH v2] doc: add steps to configure VF interface as trusted

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Asaf Penso > Sent: Monday, February 28, 2022 9:40 AM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2] doc: add steps to configure VF interface as trusted > > Trus

RE: [PATCH] net/mlx5: fix flex item availability

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Wednesday, March 2, 2022 1:07 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix flex item availability > > Flex item availability i

RE: [PATCH v1] net/mlx5: fix meter policy creation assert

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Wednesday, March 2, 2022 12:33 PM > To: Matan Azrad ; Slava Ovsiienko > ; or...@nvidia.com ; tho...@monjalon.net ; Raja > Zidane > Cc: dev@dpdk.org ; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v1] net/mlx5: fix meter policy cr

RE: [PATCH] net/mlx5: fix the needless reference count for table

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, March 2, 2022 9:58 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > Xueming(Steven) Li ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the needless reference count for table > > In the prev

RE: [PATCH] net/mlx5: fix modify port action validation

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, March 2, 2022 3:34 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH] net/mlx5: fix modify port action validation > > Certain flows containing a modify header action for an L4

RE: [PATCH v2 0/2] net/mlx5: external RxQ fixes

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Wednesday, March 2, 2022 9:58 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2 0/2] net/mlx5: external RxQ fixes > > Some fixes about external RxQ support. > They fix missing refcnt

RE: [PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Wednesday, March 2, 2022 5:31 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Yongseok Koh > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v4] net/mlx5: fix the NIC egress flow mismatc

RE: [PATCH v2] net/mlx5: fix shared RSS destroy failure

2022-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, March 2, 2022 1:20 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Suanming Mou > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix

RE: [PATCH 1/2] regexdev: fix section attribute of symbols

2022-03-07 Thread Ori Kam
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Sunday, March 6, 2022 11:20 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Ray Kinsella ; Ori Kam > ; Jerin Jacob > ; Pavan Nikhilesh > Subject: [PATCH 1/2] regexdev: fix section attribute of symbols > > The functions used b

RE: [PATCH v1] net/mlx5: fix meter creation default state

2022-03-07 Thread Matan Azrad
From: Rongwei Liu > Disable means there is no packet drop in the meter. Meter is active always but > programmed with another CIR/CBS value. > > If the user wants to disable the meter in creation, PMD calls the disable() > API > manually after meter initialized. > > Fixes: 444320186393 ("net/m

[Bug 951] net/mlx5: error when using rte_pktmbuf_attach_extbuf

2022-03-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=951 Bug ID: 951 Summary: net/mlx5: error when using rte_pktmbuf_attach_extbuf Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

[PATCH v2] graph: remove the useless duplicate name check

2022-03-07 Thread Haiyue Wang
The node clone API parameter 'name' is the new node's postfix name, not the final node name, so it makes no sense to check it. And the new name will be checked duplicate when calling API '__rte_node_register'. And update the test case to call clone API twice to check the real name duplicate. Sign

RE: [PATCH v1] graph: remove the useless duplicate name check

2022-03-07 Thread Wang, Haiyue
> -Original Message- > From: Jerin Jacob > Sent: Monday, March 7, 2022 15:45 > To: Wang, Haiyue > Cc: dpdk-dev ; Jerin Jacob ; Kiran Kumar K > ; > Nithin Dabilpuram > Subject: Re: [PATCH v1] graph: remove the useless duplicate name check > > On Mon, Mar 7, 2022 at 12:47 PM Haiyue Wang

[PATCH v1] net/mlx5: fix meter creation default state

2022-03-07 Thread Rongwei Liu
Disable means there is no packet drop in the meter. Meter is active always but programmed with another CIR/CBS value. If the user wants to disable the meter in creation, PMD calls the disable() API manually after meter initialized. Fixes: 444320186393 ("net/mlx5: support meter creation with polic