On Mon, Mar 7, 2022 at 4:30 PM Haiyue Wang <haiyue.w...@intel.com> wrote:
>
> The node clone API parameter 'name' is the new node's postfix name, not
> the final node name, so it makes no sense to check it. And the new name
> will be checked duplicate when calling API '__rte_node_register'.
>
> And update the test case to call clone API twice to check the real name
> duplicate.
>
> Signed-off-by: Haiyue Wang <haiyue.w...@intel.com>
Acked-by: Jerin Jacob <jer...@marvell.com>
> ---
> v3: No need to define another node id var.
> v2: update the test case.
> ---
> app/test/test_graph.c | 6 ++++++
> lib/graph/node.c | 4 ----
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_graph.c b/app/test/test_graph.c
> index 35e1a95b89..1a2d1e6fab 100644
> --- a/app/test/test_graph.c
> +++ b/app/test/test_graph.c
> @@ -550,6 +550,12 @@ test_node_clone(void)
> node_id = rte_node_from_name("test_node00");
> tm->test_node[0].idx = node_id;
>
> + dummy_id = rte_node_clone(node_id, "test_node00");
> + if (rte_node_is_invalid(dummy_id)) {
> + printf("Got invalid id when clone, Expecting fail\n");
> + return -1;
> + }
> +
> /* Clone with same name, should fail */
> dummy_id = rte_node_clone(node_id, "test_node00");
> if (!rte_node_is_invalid(dummy_id)) {
> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index 79230035a2..ae6eadb260 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -150,10 +150,6 @@ node_clone(struct node *node, const char *name)
> goto fail;
> }
>
> - /* Check for duplicate name */
> - if (node_has_duplicate_entry(name))
> - goto fail;
> -
> reg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges));
> if (reg == NULL) {
> rte_errno = ENOMEM;
> --
> 2.35.1
>
