RE: [PATCH 2/2] examples/l3fwd: make RX and TX queue size configurable

2022-02-07 Thread Ruifeng Wang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, February 2, 2022 2:04 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; lijuan...@intel.com; > juraj.lin...@pantheon.tech; ohily...@iol.unh.edu; > david.march...@redhat.com; tho...@monjalon.net; jer...@marvell.com > Cc: Kat

[PATCH v2] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC

2022-02-07 Thread Yiding Zhou
gcc will report error "unused parameter 'rxq'" when the macro RTE_LIBRTE_ICE_16BYTE_RX_DESC is defined. use RTE_SET_USED to avoid it Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling") Cc: sta...@dpdk.org Signed-off-by: Yiding Zhou --- drivers/net/ice/ice_rxtx.c | 4 1 file chang

[PATCH v3] net/ice: fix pattern check logic in FDIR

2022-02-07 Thread Junfeng Guo
Mask for IPv4/UDP/TCP/SCTP addr/port are not supported in current code. Thus we need to check each pattern mask. Only zero-mask and full-mask are allowed to pass the pattern parse, otherwise will return failure. Fixes: 54be6102ef97 ("net/ice: fix pattern check for FDIR parser") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: support queue-based priority flow control

2022-02-07 Thread Ajit Khaparde
On Mon, Feb 7, 2022 at 5:54 AM wrote: > > From: Jerin Jacob > > Based on device support and use-case need, there are two different ways > to enable PFC. The first case is the port level PFC configuration, in > this case, rte_eth_dev_priority_flow_ctrl_set() API shall be used to > configure the PF

RE: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC

2022-02-07 Thread Zhou, YidingX
> -Original Message- > From: Richardson, Bruce > Sent: Monday, February 7, 2022 9:46 PM > To: Wang, Haiyue > Cc: Zhou, YidingX ; Yang, Qiming > ; Zhang, Qi Z ; > dev@dpdk.org > Subject: Re: [PATCH] net/ice: fix gcc error with - > DRTE_LIBRTE_ICE_16BYTE_RX_DESC > > On Mon, Feb 07, 2022

Re: [PATCH v2 0/2] eal: support configuring runtime directory

2022-02-07 Thread Stephen Hemminger
On Sat, 5 Feb 2022 09:10:59 -0800 Stephen Hemminger wrote: > Found this while exploring running a DPDK service with systemd > container environment. It helps if the place DPDK puts its runtime > directory is configurable. > > v2 - fix dpdk_telemetry.py to use append dpdk > > Stephen Hemminger

[PATCH v2] net/ice: fix pattern check logic in FDIR

2022-02-07 Thread Junfeng Guo
Mask for IPv4/UDP/TCP/SCTP addr/port are not supported in current code. Thus we need to check the pattern with non-zero spec value. If the spec is non-zero value but its mask is not full-mask, this Flow Director rule is not supported and will return failed. Fixes: 54be6102ef97 ("net/ice: fix patte

[PATCH] net/ice: fix pattern check logic in FDIR

2022-02-07 Thread Junfeng Guo
Mask for IPv4/UDP/TCP/SCTP addr/port are not supported in current code. Thus we need to check the pattern with non-zero spec value. If the spec is non-zero value but its mask is not full-mask, this Flow Director rule is not supported and will return failed. Fixes: 54be6102ef97 ("net/ice: fix patte

[PATCH] doc: nohz_full already implies rcu_nocbs

2022-02-07 Thread Tudor Brindus
>From Documentation/admin-guide/kernel-parameters.txt, specifically the last sentence: nohz_full= [KNL,BOOT,SMP,ISOL] The argument is a cpu list, as described above. In kernels built with CONFIG_NO_HZ_FULL=y, set the specified list of CPUs whose tick will be stopped

Re: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-07 Thread Stephen Hemminger
On Sun, 6 Feb 2022 15:16:22 + "Ananyev, Konstantin" wrote: > > > This patchset introduces config file support for l3fwd > > > and its lookup methods LPM, FIB, and EM, similar to > > > that of l3fwd-acl. This allows for route rules to be > > > defined in configuration files and edited there in

[PATCH v3 1/1] vhost: integrate dmadev in asynchronous data-path

2022-02-07 Thread Jiayu Hu
Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Signed-off-by: Sunil Pai G --- doc/guides/prog_guide/vhost_lib.rst | 97 +- example

[PATCH v3 0/1] integrate dmadev in vhost

2022-02-07 Thread Jiayu Hu
Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in vhost. To enable the flexibility of using DMA devices in different function modules, not limited in vhost, vhost doesn't manage DMA devices. Ap

RE: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-07 Thread Ananyev, Konstantin
> > + > > +/** > > + * Thread mutex representation. > > + */ > > +typedef struct rte_thread_mutex_tag { > > + void *mutex_id; /**< mutex identifier */ > > +} rte_thread_mutex; > > I wonder can't we have something like that instead: > > for posix: > typedef pthread_mutex_t rte_thread_mutex_t

RE: [PATCH v5 1/2] examples/l3fwd: add config file support for LPM/FIB

2022-02-07 Thread Han, YingyaX
-Original Message- From: Sean Morrissey Sent: Saturday, February 5, 2022 3:59 AM Cc: dev@dpdk.org; Morrissey, Sean ; Ananyev, Konstantin Subject: [PATCH v5 1/2] examples/l3fwd: add config file support for LPM/FIB Add support to define ipv4 and ipv6 forwarding tables from reading fro

Re: [PATCH v2 5/6] eal/windows: fix the curly braces mismatch problem

2022-02-07 Thread Kadam, Pallavi
On 2/7/2022 4:37 AM, Weiguo Li wrote: Remove the incomplete cplusplus guard in internal header. Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation") Cc: pallavi.ka...@intel.com Signed-off-by: Weiguo Li --- Acked-by: Pallavi Kadam

RE: [PATCH 0/2] Add logic to IAVF to count continuous DD bits for Arm

2022-02-07 Thread Kathleen Capella
The failure in ci/iol-x86_64-unit-testing on this patch seems to be unrelated to the patch. > -Original Message- > From: Kathleen Capella > Sent: Friday, February 4, 2022 6:26 PM > Cc: dev@dpdk.org; nd ; Dharmik Thakkar > ; Honnappa Nagarahalli > ; Kathleen Capella > > Subject: [PATCH 0

Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-07 Thread Owen Hilyard
The Community CI hasn't been able to schedule downtime to update dpdk-ci across all of our systems since the refactoring Ali did. However, the patch was still applied on next-net and had a compilation error. See https://lab.dpdk.org/results/dashboard/patchsets/20895/. It was applied onto https://gi

Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Stephen Hemminger
On Mon, 7 Feb 2022 18:28:03 + Akhil Goyal wrote: > > On Mon, 7 Feb 2022 17:28:26 + > > Ferruh Yigit wrote: > > > > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > > > On Sat, 5 Feb 2022 03:43:33 +0530 > > > > Akhil Goyal wrote: > > > > > > > >> +/** > > > >> + * @internal > >

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On Mon, 7 Feb 2022 17:28:26 + > Ferruh Yigit wrote: > > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > > On Sat, 5 Feb 2022 03:43:33 +0530 > > > Akhil Goyal wrote: > > > > > >> +/** > > >> + * @internal > > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete > cas

Re: [PATCH v3 01/10] ethdev: introduce flow pre-configuration hints

2022-02-07 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 11:30 PM Alexander Kozyrev wrote: > > On Monday, February 7, 2022 9:52 Jerin Jacob wrote: > > On Sun, Feb 6, 2022 at 8:56 AM Alexander Kozyrev > > wrote: > > > > > > The flow rules creation/destruction at a large scale incurs a performance > > > penalty and may negatively

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Stephen Hemminger
On Mon, 7 Feb 2022 17:28:26 + Ferruh Yigit wrote: > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > On Sat, 5 Feb 2022 03:43:33 +0530 > > Akhil Goyal wrote: > > > >> +/** > >> + * @internal > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > >> + */ > >> +

RE: [PATCH v3 01/10] ethdev: introduce flow pre-configuration hints

2022-02-07 Thread Alexander Kozyrev
On Monday, February 7, 2022 9:52 Jerin Jacob wrote: > On Sun, Feb 6, 2022 at 8:56 AM Alexander Kozyrev > wrote: > > > > The flow rules creation/destruction at a large scale incurs a performance > > penalty and may negatively impact the packet processing when used > > as part of the datapath logic

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On Sat, 5 Feb 2022 03:43:33 +0530 > Akhil Goyal wrote: > > > +/** > > + * @internal > > + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > > + */ > > +__rte_internal > > +int > > +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); > > Maybe use RTE_INI

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 5:23 PM, Stephen Hemminger wrote: On Sat, 5 Feb 2022 03:43:33 +0530 Akhil Goyal wrote: +/** + * @internal + * Register mbuf dynamic field and flag for IP reassembly incomplete case. + */ +__rte_internal +int +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); Maybe

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add queue based pfc CLI options

2022-02-07 Thread Ajit Khaparde
On Mon, Feb 7, 2022 at 5:54 AM wrote: > > From: Sunil Kumar Kori > > Patch adds command line options to configure queue based > priority flow control. > > - Syntax command is given as below: > > set pfc_queue_ctrl rx\ > tx > > - Example command to configure queue based priority f

Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 4:47 PM, Ali Alnubani wrote: -Original Message- From: Ferruh Yigit Sent: Monday, February 7, 2022 6:37 PM To: Ali Alnubani ; kumaraparameshwaran rathinavel ; dev@dpdk.org; dpdklab Cc: Kumara Parameshwaran ; c...@dpdk.org Subject: Re: [PATCH v1] drivers/net: use internal API

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Stephen Hemminger
On Sat, 5 Feb 2022 03:43:33 +0530 Akhil Goyal wrote: > +/** > + * @internal > + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > + */ > +__rte_internal > +int > +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); Maybe use RTE_INIT() constructor for this

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add queue based pfc CLI options

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 1:55 PM, jer...@marvell.com wrote: From: Sunil Kumar Kori Patch adds command line options to configure queue based priority flow control. - Syntax command is given as below: set pfc_queue_ctrl rx\ tx - Example command to configure queue based priority flow control

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: support queue-based priority flow control

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 1:55 PM, jer...@marvell.com wrote: From: Jerin Jacob Based on device support and use-case need, there are two different ways to enable PFC. The first case is the port level PFC configuration, in this case, rte_eth_dev_priority_flow_ctrl_set() API shall be used to configure the PFC,

[PATCH v7 1/2] common/cnxk: support priority flow ctrl config API

2022-02-07 Thread skori
From: Sunil Kumar Kori CNXK platforms support priority flow control(802.1qbb) to pause respective traffic per class on that link. Patch adds RoC interface to configure priority flow control on MAC block i.e. CGX on cn9k and RPM on cn10k. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix RoC A

[PATCH v7 2/2] net/cnxk: support priority flow control

2022-02-07 Thread skori
From: Sunil Kumar Kori Patch implements priority flow control support for CNXK platforms. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix application restart issue. v2..v3: - fix pause quanta configuration for cn10k. - fix review comments. v3..v4: - fix PFC configuration with other ty

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> -Original Message- > From: Ferruh Yigit > Sent: Monday, February 7, 2022 10:11 PM > To: Akhil Goyal ; dev@dpdk.org; > olivier.m...@6wind.com > Cc: Anoob Joseph ; ma...@nvidia.com; > konstantin.anan...@intel.com; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; rosen...@intel.com;

RE: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-07 Thread Ali Alnubani
> -Original Message- > From: Ferruh Yigit > Sent: Monday, February 7, 2022 6:37 PM > To: Ali Alnubani ; kumaraparameshwaran rathinavel > ; dev@dpdk.org; dpdklab > > Cc: Kumara Parameshwaran ; c...@dpdk.org > Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from > name

Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 4:20 PM, Akhil Goyal wrote: On 2/7/2022 2:20 PM, Akhil Goyal wrote: On 2/4/2022 10:13 PM, Akhil Goyal wrote: Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets a

Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 4:08 PM, Ali Alnubani wrote: -Original Message- From: Ferruh Yigit Sent: Thursday, February 3, 2022 1:32 PM To: kumaraparameshwaran rathinavel ; dev@dpdk.org Cc: Kumara Parameshwaran ; c...@dpdk.org; Ali Alnubani Subject: Re: [PATCH v1] drivers/net: use internal API to get e

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On 2/7/2022 2:20 PM, Akhil Goyal wrote: > >> On 2/4/2022 10:13 PM, Akhil Goyal wrote: > >>> Hardware IP reassembly may be incomplete for multiple reasons like > >>> reassembly timeout reached, duplicate fragments, etc. > >>> To save application cycles to process these packets again, a new > >>> m

RE: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-07 Thread Ali Alnubani
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 3, 2022 1:32 PM > To: kumaraparameshwaran rathinavel ; > dev@dpdk.org > Cc: Kumara Parameshwaran ; c...@dpdk.org; > Ali Alnubani > Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from > name > > On

Re: [PATCH v2 5/7] net/ixgbe: Fix SFP detection and linking on hotplug

2022-02-07 Thread Ferruh Yigit
On 12/6/2021 10:19 PM, Stephen Douthit wrote: Currently the ixgbe driver does not ID any SFP except for the first one plugged in. This can lead to no-link, or incorrect speed conditions. For example: * If link is initially established with a 1G SFP, and later a 1G/10G multispeed part is later i

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-07 Thread Ferruh Yigit
On 1/19/2022 12:31 AM, Wang, Haiyue wrote: -Original Message- From: Stephen Douthit Sent: Wednesday, January 19, 2022 05:06 To: Wang, Haiyue ; Morten Brørup ; Lu, Wenzhuo ; Zhang, Helin ; Zhang, Qi Z Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org Subject: Re: [PATCH v2 3/7] net/ixgbe:

Re: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-07 Thread Ananyev, Konstantin
> Add functions for mutex init, destroy, lock, unlock, trylock. > > Windows does not have a static initializer. Initialization > is only done through InitializeCriticalSection(). To overcome this, > RTE_INIT_MUTEX macro is added to replace static initialization > of mutexes. The macro calls rte_th

[PATCH] net/mlx5: fix inline length for multi-segment TSO

2022-02-07 Thread Dariusz Sosnowski
This patch removes a redundant assert in mlx5_tx_packet_multi_tso(). That assert assured that the amount of bytes requested to be inlined is greater than or equal to the minimum amount of bytes required to be inlined. This requirement is either derived from the NIC inlining mode or configured throu

RE: [dpdk-dev v2] crypto/openssl: openssl 3.0 support on sym MAC routine

2022-02-07 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Monday, February 7, 2022 3:24 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev v2] crypto/openssl: openssl 3.0 support on sym MAC > routine > > This patch update the symmetric EVP MAC routine in crypto openssl pmd > to adopt openssl 3.0

Re: [PATCH] ethdev: introduce ethdev dump API

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 12:56 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Monday, 7 February 2022 13.36 On 2/7/2022 12:18 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Monday, 7 February 2022 12.46 On 2/7/2022 1:47 AM, Min Hu (Conno

[dpdk-dev v2] crypto/openssl: openssl 3.0 support on sym MAC routine

2022-02-07 Thread Kai Ji
This patch update the symmetric EVP MAC routine in crypto openssl pmd to adopt openssl 3.0 library. Signed-off-by: Kai Ji v2: - commit message update --- drivers/crypto/openssl/compat.h | 12 ++ drivers/crypto/openssl/openssl_pmd_private.h | 4 + drivers/crypto/openssl/rte_open

Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 2:20 PM, Akhil Goyal wrote: On 2/4/2022 10:13 PM, Akhil Goyal wrote: Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show

Re: [PATCH v3 01/10] ethdev: introduce flow pre-configuration hints

2022-02-07 Thread Jerin Jacob
On Sun, Feb 6, 2022 at 8:56 AM Alexander Kozyrev wrote: > > The flow rules creation/destruction at a large scale incurs a performance > penalty and may negatively impact the packet processing when used > as part of the datapath logic. This is mainly because software/hardware > resources are alloca

RE: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create

2022-02-07 Thread Power, Ciara
Hi Akhil, Some replies inline. Thanks, Ciara >-Original Message- >From: Akhil Goyal >Sent: Monday 7 February 2022 09:05 >To: Power, Ciara ; dev@dpdk.org; >tho...@monjalon.net >Cc: Zhang, Roy Fan ; Anoob Joseph >; m...@ashroe.eu; Doherty, Declan > >Subject: RE: [EXT] [PATCH v3 4/4] cryp

RE: [EXT] Re: [PATCH v4 1/3] ethdev: introduce IP reassembly offload

2022-02-07 Thread Akhil Goyal
Hi Ferruh, Thanks for review, Will send the next version soon. Please see the comments inline. > On 2/4/2022 10:13 PM, Akhil Goyal wrote: > > IP Reassembly is a costly operation if it is done in software. > > The operation becomes even more costlier if IP fragments are encrypted. > > However, if i

RE: [EXT] [PATCH v3 1/4] crypto: use single buffer for asymmetric session

2022-02-07 Thread Power, Ciara
Hi Akhil, Left some replies inline. I will address all other comments in v4. Thanks, Ciara >-Original Message- >From: Akhil Goyal >Sent: Monday 7 February 2022 08:20 >To: Power, Ciara ; dev@dpdk.org >Cc: Zhang, Roy Fan ; Anoob Joseph >; m...@ashroe.eu; Doherty, Declan >; Ankur Dwivedi ;

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On 2/4/2022 10:13 PM, Akhil Goyal wrote: > > Hardware IP reassembly may be incomplete for multiple reasons like > > reassembly timeout reached, duplicate fragments, etc. > > To save application cycles to process these packets again, a new > > mbuf dynflag is added to show that the mbuf received i

Re: [PATCH 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-07 Thread Nithin Kumar Dabilpuram
On 2/7/22 3:22 PM, Ananyev, Konstantin wrote: Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. In other cases such as Tx Inline protocol offload, checksum computation is implicitly taken care by HW. Why is that? These is two separate HW offload and user has to enable e

Re: [PATCH v2 1/4] net/cnxk: avoid command copy from Tx queue

2022-02-07 Thread Jerin Jacob
On Wed, Jan 19, 2022 at 12:43 PM wrote: > > From: Pavan Nikhilesh > > Tx command is prepared based on offloads enabled and stored in > Tx queue structure at tx_queue_setup phase. > In fastpath the command is copied from Tx queue to LMT line for > all the packets. > Since, the command contents are

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/4/2022 10:13 PM, Akhil Goyal wrote: Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show that the mbuf received is not reassemble

[dpdk-dev] [PATCH v4 2/2] app/testpmd: add queue based pfc CLI options

2022-02-07 Thread jerinj
From: Sunil Kumar Kori Patch adds command line options to configure queue based priority flow control. - Syntax command is given as below: set pfc_queue_ctrl rx\ tx - Example command to configure queue based priority flow control on rx and tx side for port 0, Rx queue 0, Tx

[dpdk-dev] [PATCH v4 1/2] ethdev: support queue-based priority flow control

2022-02-07 Thread jerinj
From: Jerin Jacob Based on device support and use-case need, there are two different ways to enable PFC. The first case is the port level PFC configuration, in this case, rte_eth_dev_priority_flow_ctrl_set() API shall be used to configure the PFC, and PFC frames will be generated using based on V

Re: [PATCH v4 1/3] ethdev: introduce IP reassembly offload

2022-02-07 Thread Ferruh Yigit
On 2/4/2022 10:13 PM, Akhil Goyal wrote: IP Reassembly is a costly operation if it is done in software. The operation becomes even more costlier if IP fragments are encrypted. However, if it is offloaded to HW, it can considerably save application cycles. Hence, a new offload feature is exposed

Re: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC

2022-02-07 Thread Bruce Richardson
On Mon, Feb 07, 2022 at 01:14:18PM +, Wang, Haiyue wrote: > > -Original Message- > > From: Yiding Zhou > > Sent: Tuesday, February 8, 2022 00:48 > > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org > > Subject: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC > >

Re: [PATCH 0/6] fix the curly braces mismatch problem

2022-02-07 Thread Bruce Richardson
On Mon, Feb 07, 2022 at 07:44:29PM +0800, Weiguo Li wrote: > On Mon, 7 Feb 2022 09:29:58 +, Bruce Richardson wrote: > > Any headers that have filenames not starting with "rte_" are internal > > headers, and so should have the guards removed. Therefore, I think that > > most patches in this set

[PATCH] net/mlx5: fix Meter capabilities reporting

2022-02-07 Thread Alexander Kozyrev
Meter capabilities reporting is not up to date. Mellanox NICs support RFC2698 and RFC4115 as well as RFC2697. Add these marker operations to the capabilities list. Fixes: 6bc327b94fe ("net/mlx5: fill meter capabilities using DevX") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyrev Acked-by: V

[PATCH] net/mlx5: fix Committed Bucket Size calculation

2022-02-07 Thread Alexander Kozyrev
Committed Bucket Size calculation tries to fit into 8-bit wide mantissa field by setting 256 as a maximum value for it. To compensate for this increase in the mantissa value the exponent value has to be reduced by 8. But it gives a negative exponent value for CBS less than 128. And negative exponen

RE: [PATCH v3 10/10] app/testpmd: implement rte flow queue indirect actions

2022-02-07 Thread Ori Kam
Hi Alex, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 10/10] app/testpmd: implement rte flow queue indirect > actions > > Add testpmd support for the rte_flow_q_action_handle API. > Provide the command line interface for op

RE: [PATCH v3 09/10] app/testpmd: implement rte flow pull operations

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 09/10] app/testpmd: implement rte flow pull operations > > Add testpmd support for the rte_flow_q_pull API. > Provide the command line interface for pulling operatio

RE: [PATCH v3 08/10] app/testpmd: implement rte flow push operations

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 08/10] app/testpmd: implement rte flow push operations > > Add testpmd support for the rte_flow_q_push API. > Provide the command line interface for pushing operatio

RE: [PATCH v3 06/10] app/testpmd: implement rte flow table management

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 06/10] app/testpmd: implement rte flow table management > > Add testpmd support for the rte_flow_table API. > Provide the command line interface for the flow > table

RE: [PATCH v3 07/10] app/testpmd: implement rte flow queue flow operations

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 07/10] app/testpmd: implement rte flow queue flow > operations > > Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. > Provide the command line

RE: [PATCH v3 05/10] app/testpmd: implement rte flow template management

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > To: dev@dpdk.org > Subject: [PATCH v3 05/10] app/testpmd: implement rte flow template management > > Add testpmd support for the rte_flow_pattern_template and > rte_flow_actions_templa

RE: [PATCH v3 04/10] app/testpmd: implement rte flow configuration

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 04/10] app/testpmd: implement rte flow configuration > > Add testpmd support for the rte_flow_configure API. > Provide the command line interface for the Flow manage

RE: [PATCH v3 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-07 Thread Ori Kam
HI Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > To: dev@dpdk.org > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@intel.com; mohammad.abdul.a...@intel.c

RE: [PATCH v3 02/10] ethdev: add flow item/action templates

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 02/10] ethdev: add flow item/action templates > > Treating every single flow rule as a completely independent and separate > entity negatively impacts the flow rules

RE: [PATCH v3 01/10] ethdev: introduce flow pre-configuration hints

2022-02-07 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, February 6, 2022 5:25 AM > Subject: [PATCH v3 01/10] ethdev: introduce flow pre-configuration hints > > The flow rules creation/destruction at a large scale incurs a performance > penalty and may negatively impa

Re: [PATCH v2 5/6] eal/windows: fix the curly braces mismatch problem

2022-02-07 Thread Dmitry Kozlyuk
2022-02-07 20:37 (UTC+0800), Weiguo Li: > Remove the incomplete cplusplus guard in internal header. > > Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation") > Cc: pallavi.ka...@intel.com > > Signed-off-by: Weiguo Li Acked-by: Dmitry Kozlyuk

RE: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC

2022-02-07 Thread Wang, Haiyue
> -Original Message- > From: Yiding Zhou > Sent: Tuesday, February 8, 2022 00:48 > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC > > gcc will report error "unused parameter 'rxq'" when the macro > RTE_LIBR

Re: [PATCH] net/sfc: add missing lock release statements

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 11:15 AM, Ivan Malov wrote: Fixes: 155583abe63c ("net/sfc: implement representor queue setup and release") Fixes: 75f080fdf74a ("net/sfc: implement port representor start and stop") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/

Re: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create

2022-02-07 Thread Thomas Monjalon
07/02/2022 10:04, Akhil Goyal: > > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > > b/doc/guides/prog_guide/cryptodev_lib.rst > > index 62bd3577f5..8e16461dc6 100644 > > --- a/doc/guides/prog_guide/cryptodev_lib.rst > > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > > @@ -1236,10 +1236,10

RE: [PATCH] ethdev: introduce ethdev dump API

2022-02-07 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, 7 February 2022 13.36 > > On 2/7/2022 12:18 PM, Morten Brørup wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Monday, 7 February 2022 12.46 > >> > >> On 2/7/2022 1:47 AM, Min Hu (Connor) wrote: > >>> Add

[PATCH v2 6/6] eventdev: remove cplusplus guard in private header file

2022-02-07 Thread Weiguo Li
This private header contains an incomplete cplusplus guard, just remove it. Fixes: d35e61322de52 ("eventdev: move inline APIs into separate structure") Cc: pbhagavat...@marvell.com Signed-off-by: Weiguo Li --- lib/eventdev/eventdev_pmd.h | 4 1 file changed, 4 deletions(-) diff --git a/li

[PATCH v2 5/6] eal/windows: fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
Remove the incomplete cplusplus guard in internal header. Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation") Cc: pallavi.ka...@intel.com Signed-off-by: Weiguo Li --- lib/eal/windows/include/dirent.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/eal/windows/include/dirent

[PATCH v2 4/6] net/dpaa2: fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
Remove the incomplete cplusplus guard in internal headers. Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver") Cc: sunil.k...@nxp.com Signed-off-by: Weiguo Li --- drivers/net/dpaa2/dpaa2_sparser.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_sparser.h b/

[PATCH v2 3/6] net/cxgbe: fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
Remove the incomplete cplusplus guard in internal header. Fixes: 3bd122eef2cc ("cxgbe/base: add hardware API for Chelsio T5 series adapters") Cc: rahul.lakkire...@chelsio.com Signed-off-by: Weiguo Li --- drivers/net/cxgbe/base/common.h | 4 1 file changed, 4 deletions(-) diff --git a/dri

[PATCH v2 2/6] common/mlx5: fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
Remove the incomplete cplusplus guard in internal headers. Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows") Cc: tal...@nvidia.com Signed-off-by: Weiguo Li --- drivers/common/mlx5/windows/mlx5_win_defs.h | 4 drivers/common/mlx5/windows/mlx5_win_ext.h | 4 2 files ch

[PATCH v2 1/6] bus/dpaa: fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
Supplement the missing half of braces for the extern "C" block, or remove the incomplete guard in internal header. Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations") Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton") Cc: shreyansh.j...@nxp.com Signed-off-by: Weig

Re: [PATCH] ethdev: introduce ethdev dump API

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 12:18 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Monday, 7 February 2022 12.46 On 2/7/2022 1:47 AM, Min Hu (Connor) wrote: Added the ethdev dump API which provides functions for query private info Isn't API and function are same thing in this

RE: [PATCH] ethdev: introduce ethdev dump API

2022-02-07 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, 7 February 2022 12.46 > > On 2/7/2022 1:47 AM, Min Hu (Connor) wrote: > > Added the ethdev dump API which provides functions for query private > info > > Isn't API and function are same thing in this contexts? > > > from device

Re: [PATCH] ethdev: introduce ethdev dump API

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 1:47 AM, Min Hu (Connor) wrote: Added the ethdev dump API which provides functions for query private info Isn't API and function are same thing in this contexts? from device. There exists many private properties in different PMD drivers, such as adapter state, Rx/Tx func algorithm

Re: [PATCH 0/6] fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
On Mon, 7 Feb 2022 09:29:58 +, Bruce Richardson wrote: > Any headers that have filenames not starting with "rte_" are internal > headers, and so should have the guards removed. Therefore, I think that > most patches in this set should just be removing guards. From my tests with > building our p

Re: [PATCH 5/6] eal/windows: fix the curly braces mismatch problem

2022-02-07 Thread Weiguo Li
On Sun, 6 Feb 2022 19:23:03 +0300, Dmitry Kozlyuk wrote: > This file is not public, used only from DPDK C code. > Rather then adding the opening part, the closing part should be removed. > The "Fixes" tag is incorrect, should be: > Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation") >

RE: [PATCH v2] net/af_xdp: re-enable secondary process support

2022-02-07 Thread Loftus, Ciara
> >> > >> On 2/4/2022 12:54 PM, Ciara Loftus wrote: > >>> Secondary process support had been disabled for the AF_XDP PMD > >>> because there was no logic in place to share the AF_XDP socket > >>> file descriptors between the processes. This commit introduces > >>> this logic using the IPC APIs. > >

[PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint

2022-02-07 Thread Arek Kusztal
This patch adds crypto uint typedef so adding comment about byte-order becomes unnecessary. It makes API comments more tidy, and more consistent with other asymmetric crypto APIs. Additionally it reorganizes code that enums, externs and forward declarations are moved to the top of the header file

[PATCH v2 3/4] crypto: use rte macro instead of direct attribute

2022-02-07 Thread Arek Kusztal
This commit replaces __extension__ attribute with RTE_STD_C11 in anonymous unions. It makes API consistent in terms of usage of C11 feature macro. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/crypto

[PATCH v2 2/4] crypto: clarify usage of random numbers in asym

2022-02-07 Thread Arek Kusztal
This commit clarifies usage of random numbers in asymmetric crypto API. User is now allowed to provide information to the PMD if random number should be generated or should be read from user input. If PMD does not support random number generation user should always provide it, if PMD does not supp

[PATCH v2 1/4] crypto: add dsa random number k

2022-02-07 Thread Arek Kusztal
This commit adds random number 'k' to dsa op param struct. This parameter is crucial in stituation where: - PMD cannot generate random number - user would like to provide random source Addtionally it makes DSA consistent with ECDSA in terms of 'k' which includes this parameter. Signed-off-by: Ar

[PATCH v2 0/4] Clarify asymmetric random, add 'k' and crypto uint

2022-02-07 Thread Arek Kusztal
This patchset introduces following changes: 1) DSA 'k' was added that devices withouth random support can work. 2) Clarified usage of random numbers in asym, as per discussion from December. 3) Added typedef for crypto_uint to remove some repeating comments making code more readable. Additionally

[PATCH] net/sfc: add missing lock release statements

2022-02-07 Thread Ivan Malov
Fixes: 155583abe63c ("net/sfc: implement representor queue setup and release") Fixes: 75f080fdf74a ("net/sfc: implement port representor start and stop") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov --- drivers/net/sfc/sfc_repr_proxy.c | 5 + 1 file changed, 5 insertions(+) diff --git a/dr

[PATCH v4 2/2] eventdev: update crypto caps get to return SW cap

2022-02-07 Thread Ganapati Kundapura
update rte_event_crypto_adapter_caps_get() to return SW_CAP if PMD callback is not registered. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 79b9ea3..6988bf1 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.

[PATCH v4 1/2] eventdev/crypto_adapter: move crypto ops to circular buffer

2022-02-07 Thread Ganapati Kundapura
Move crypto ops to circular buffer to retain crypto ops when cryptodev/eventdev are temporarily full Signed-off-by: Ganapati Kundapura --- v4: * Retain the non enqueued crypto ops in circular buffer to process later and stop the dequeue from eventdev till all the crypto ops are enqueued to c

RE: [PATCH v3 1/2] eventdev/crypto_adapter: move crypto ops to circular buffer

2022-02-07 Thread Kundapura, Ganapati
Hi Abhi, > -Original Message- > From: Gujjar, Abhinandan S > Sent: 13 January 2022 16:36 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; Jayatheerthan, Jay ; > dev@dpdk.org > Subject: RE: [PATCH v3 1/2] eventdev/crypto_adapter: move crypto ops to > circular buffer > > Hi Ganapati, >

Re: [PATCH v2] net/af_xdp: re-enable secondary process support

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 7:49 AM, Loftus, Ciara wrote: On 2/4/2022 12:54 PM, Ciara Loftus wrote: Secondary process support had been disabled for the AF_XDP PMD because there was no logic in place to share the AF_XDP socket file descriptors between the processes. This commit introduces this logic using the I

[PATCH v2 1/1] vhost: move fds outside of VhostUserMessage

2022-02-07 Thread Christophe Fontaine
From: Christophe Fontaine FDs at the end of the VhostUserMessage structure limits the size of the payload. Move them to an other englobing structure, before the header & payload of a VhostUserMessage. Also removes a reference to fds in the VHUMsg structure defined in drivers/net/virtio/virtio_use

[PATCH v2 0/1] Removes FDs from VhostUserMessage structure

2022-02-07 Thread Christophe Fontaine
This patch removes the file descriptors from the struct VhostUserMessage as it is not part of the spec. These FDs are moved to a englobing context structure. v2: rebased on top of dpdk-next-virtio Christophe Fontaine (1): vhost: move fds outside of VhostUserMessage drivers/net/virtio/virtio_u

RE: [PATCH 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-07 Thread Ananyev, Konstantin
> Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. > In other cases such as Tx Inline protocol offload, checksum computation > is implicitly taken care by HW. Why is that? These is two separate HW offload and user has to enable each of them explicitly. Also we can TX clear-t

  1   2   >