On Mon, Feb 07, 2022 at 07:44:29PM +0800, Weiguo Li wrote:
> On Mon, 7 Feb 2022 09:29:58 +0000, Bruce Richardson wrote:
> > Any headers that have filenames not starting with "rte_" are internal
> > headers, and so should have the guards removed. Therefore, I think that
> > most patches in this set should just be removing guards. From my tests with
> > building our public headers in C++ files, resulting in series[1], I only
> > found one public header with an incorrect guard.
> >
> > /Bruce
> >
> > [1]http://patches.dpdk.org/project/dpdk/list/?series=21466
> >
>
> Hi Bruce,
>
> Thanks for your tip!
>
> BTW it's strange that some file include these headers by angle-brackets.
>
> I'll update this patch set later.
>
Thanks.
BTW: if you do find any headers that are being exposed as public headers,
but don't have "rte_" in the filename, please flag them as needing fixing
too. There shouldn't be any, but just in case....
