[dpdk-dev] [PATCH 2/2] net/bnxt: fix stat context allocation

2021-10-29 Thread Kalesh A P
From: Kalesh AP stat_ctx_alloc is called within the context of each rx/tx ring. i.e from bnxt_alloc_hwrm_rx_ring and bnxt_alloc_hwrm_tx_ring(). So, there is no need to invoke bnxt_alloc_all_hwrm_stat_ctxs() from bnxt_start_nic(). Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when need

[dpdk-dev] [PATCH 1/2] net/bnxt: fix freeing aggregation rings

2021-10-29 Thread Kalesh A P
From: Kalesh AP During port stop, we clear "eth_dev->data->scattered_rx" at the beginning. As a result, in bnxt_free_hwrm_rx_ring() the check bnxt_need_agg_ring() returns false and we end up not freeing the Rx aggregation rings which results in resource leak in the FW. Fixes: 657c2a7f1dd4 ("net/

Re: [dpdk-dev] [PATCH v2 00/26] net/ngbe: add many features

2021-10-29 Thread Ferruh Yigit
On 10/29/2021 11:15 PM, Ferruh Yigit wrote: On 10/21/2021 10:49 AM, Jiawen Wu wrote: This patch adds a number of major features to complete ngbe PMD. v2: - Add support to get Rx/Tx burst mode info. - Drop Rx interrupt support. - Minor code tweaks. Jiawen Wu (26):    net/ngbe: add packet type  

Re: [dpdk-dev] [PATCH v2 26/26] net/ngbe: add Tx done cleanup

2021-10-29 Thread Ferruh Yigit
On 10/21/2021 10:50 AM, Jiawen Wu wrote: Add support for API rte_eth_tx_done_cleanup(). Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 1 + drivers/net/ngbe/ngbe_rxtx.c | 89 ++ drivers/net/ngbe/ngbe_rxtx.h | 1 + 3 files changed, 91 inse

Re: [dpdk-dev] [PATCH v2 20/26] net/ngbe: support device LED on and off

2021-10-29 Thread Ferruh Yigit
On 10/21/2021 10:50 AM, Jiawen Wu wrote: Support device LED on and off. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 10 +++ drivers/net/ngbe/base/ngbe_hw.c| 48 ++ drivers/net/ngbe/base/ngbe_hw.h| 3 ++ drivers/net/ngbe/base/ngb

Re: [dpdk-dev] [PATCH v2 07/26] net/ngbe: support jumbo frame

2021-10-29 Thread Ferruh Yigit
On 10/21/2021 10:50 AM, Jiawen Wu wrote: diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini index 053dff3a2f..9785820ea0 100644 --- a/doc/guides/nics/features/ngbe.ini +++ b/doc/guides/nics/features/ngbe.ini @@ -9,6 +9,7 @@ Link status = Y Link status e

Re: [dpdk-dev] [PATCH v2 00/26] net/ngbe: add many features

2021-10-29 Thread Ferruh Yigit
On 10/21/2021 10:49 AM, Jiawen Wu wrote: This patch adds a number of major features to complete ngbe PMD. v2: - Add support to get Rx/Tx burst mode info. - Drop Rx interrupt support. - Minor code tweaks. Jiawen Wu (26): net/ngbe: add packet type net/ngbe: support scattered Rx net/ngbe:

[dpdk-dev] [PATCH] pcapng: do not use deprecated ETH_LINK_UP

2021-10-29 Thread Stephen Hemminger
RTE_ prefix was added by: commit 295968d17407 ("ethdev: add namespace") Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files") Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pcapng/rte_pcapng.

[dpdk-dev] [RFC] ethdev: mark old ETH_LINK macros as deprecated

2021-10-29 Thread Stephen Hemminger
The new definitions should be favored and used by all new code. Fixes: 295968d17407 ("ethdev: add namespace") Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_eth

Re: [dpdk-dev] [PATCH v13 3/7] net/iavf: add support for asynchronous virt channel messages

2021-10-29 Thread Ferruh Yigit
On 10/28/2021 5:04 PM, Radu Nicolau wrote: @@ -339,15 +340,35 @@ _clear_cmd(struct iavf_info *vf) static inline int _atomic_set_cmd(struct iavf_info *vf, enum virtchnl_ops ops) { - int ret = rte_atomic32_cmpset((volatile uint32_t *)&vf->pend_cmd, - VIRTCHNL_OP_UNKNOWN, o

Re: [dpdk-dev] [PATCH v3 02/10] vdpa/sfc: add support for device initialization

2021-10-29 Thread Mattias Rönnblom
On 2021-10-29 16:46, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Add HW initialization and vDPA device registration support. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Used rte_memzone_reserve_aligned for mcdi buffer allocation. * Freeing mcdi buff wh

Re: [dpdk-dev] [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-10-29 Thread Mattias Rönnblom
On 2021-10-29 16:46, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Add new vDPA PMD to support vDPA operations of Xilinx devices. This patch implements probe and remove functions. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Updated logging macros to remo

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-29 Thread Stephen Hemminger
On Fri, 29 Oct 2021 18:50:57 +0100 Ferruh Yigit wrote: > On 10/20/2021 10:42 PM, Stephen Hemminger wrote: > > + /* DPDK reports in units of Mbps */ > > + rte_eth_link_get(port, &link); > > + if (link.link_status == ETH_LINK_UP) > > Should use renamed 'RTE_ETH_LINK_UP' macro with RTE_ pre

[dpdk-dev] [PATCH v2 2/2] mbuf: fix dump of dynamic fields and flags

2021-10-29 Thread Alexander Bechikov
I suppose this issue is introduced by d4902ed31c63 ("mbuf: check shared memory before dumping dynamic space"). Cc: sta...@dpdk.org Fixes: d4902ed31c63 ("mbuf: check shared memory before dumping dynamic space") Signed-off-by: Alexander Bechikov --- v2: * Drop changes with log message from v1, bec

[dpdk-dev] [PATCH v2 1/2] mbuf: Improved error message. Added check if shared memory already allocated

2021-10-29 Thread Alexander Bechikov
Signed-off-by: Alexander Bechikov --- lib/mbuf/rte_mbuf_dyn.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/mbuf/rte_mbuf_dyn.c b/lib/mbuf/rte_mbuf_dyn.c index db8e020665..a3bc9b66d2 100644 --- a/lib/mbuf/rte_mbuf_dyn.c +++ b/lib/mbuf/rte_mbuf_dyn.c @@ -116,7 +116,8

Re: [dpdk-dev] [PATCH v3 5/9] gpudev: add memory API

2021-10-29 Thread Mattias Rönnblom
On 2021-10-09 03:53, eagost...@nvidia.com wrote: From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. Such workload distribution can be achieved by sharing some memory. As a first step, the featur

Re: [dpdk-dev] [PATCH v13 5/7] net/iavf: add xstats support for inline IPsec crypto

2021-10-29 Thread Ferruh Yigit
On 10/28/2021 5:04 PM, Radu Nicolau wrote: @@ -1619,6 +1668,7 @@ static int iavf_dev_xstats_get(struct rte_eth_dev *dev, struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); struct iavf_vsi *vsi = &vf->vsi; struct virtchnl_eth_stats *pstats = NULL; +

Re: [dpdk-dev] [PATCH v8 5/5] examples/l3fwd-power: support virtio/vhost

2021-10-29 Thread Ferruh Yigit
On 10/25/2021 3:47 PM, Miao Li wrote: - /* this is checked in H/W */ + /* if this is not checked in H/W, check it. */ + if ((port_conf.rxmode.offloads & DEV_RX_OFFLOAD_IPV4_CKSUM) == 0) { s/DEV_RX_OFFLOAD_IPV4_CKSUM/RTE_ETH_RX_OFFLOAD_IPV4_CKSUM/ + uint16_t act

Re: [dpdk-dev] dpdk-testpmd app with SRIOV VF on Kubernetes POD not working

2021-10-29 Thread David Marchand
On Tue, Jul 20, 2021 at 3:18 PM Truring Team wrote: > > After build dpdk-20.11 inside POD run the dpdk-testpmd then following > > segment fault occurs > > > > [root@centos7-testpmd dpdk-20.11]#* gdb ./build/app/dpdk-testpmd* > > > > GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-120.el7 > > > > Copy

Re: [dpdk-dev] [PATCH] test-compress-perf: fix unused-but-set-variable error

2021-10-29 Thread David Marchand
On Fri, Oct 29, 2021 at 7:18 PM Jim Harris wrote: > > clang-13 rightfully complains that the total_deq_ops > variable in cperf_cyclecount_op_setup is set but not > used, since the final accumulated total_deq_ops > results isn't used anywhere. So just remove the > total_deq_ops variable. Unused fr

Re: [dpdk-dev] [PATCH] power: fix unused-but-set variable error

2021-10-29 Thread David Marchand
On Fri, Oct 29, 2021 at 7:17 PM Jim Harris wrote: > > clang-13 rightfully complains that the tot_ppi > variable in update_stats is set but not used, since > the final accumulated tot_ppi results isn't used > anywhere. So just remove the tot_ppi variable. Dead code, from the start... Fixes: 450f07

Re: [dpdk-dev] [PATCH] eal: fix unused-but-set-variable error

2021-10-29 Thread David Marchand
On Fri, Oct 29, 2021 at 7:17 PM Jim Harris wrote: > > clang-13 rightfully complains that the total_mem > variable in eal_parse_socket_arg is set but not > used, since the final accumulated total_mem > result isn't used anywhere. So just remove the > total_mem variable. > It was left behind by cha

Re: [dpdk-dev] [PATCH 3/4] dma/cnxk: add dma channel operations

2021-10-29 Thread Radha Mohan
On Fri, Oct 29, 2021 at 7:54 AM Jerin Jacob wrote: > > On Thu, Oct 28, 2021 at 11:48 PM Radha Mohan wrote: > > > > On Tue, Oct 26, 2021 at 1:49 AM Jerin Jacob wrote: > > > > > > On Tue, Oct 26, 2021 at 9:43 AM Radha Mohan Chintakuntla > > > wrote: > > > > > > > > Add functions for the dmadev vc

Re: [dpdk-dev] [PATCH v6 1/5] net/virtio: add initial RSS support

2021-10-29 Thread Maxime Coquelin
On 10/29/21 19:40, Ferruh Yigit wrote: On 10/27/2021 3:22 PM, Maxime Coquelin wrote: Provide the capability to update the hash key, hash types and RETA table on the fly (without needing to stop/start the device). However, the key length and the number of RETA entries are fixed to 40B and 128

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-29 Thread Ferruh Yigit
On 10/20/2021 10:42 PM, Stephen Hemminger wrote: + /* DPDK reports in units of Mbps */ + rte_eth_link_get(port, &link); + if (link.link_status == ETH_LINK_UP) Should use renamed 'RTE_ETH_LINK_UP' macro with RTE_ prefix.

Re: [dpdk-dev] [PATCH v6 1/5] net/virtio: add initial RSS support

2021-10-29 Thread Ferruh Yigit
On 10/27/2021 3:22 PM, Maxime Coquelin wrote: Provide the capability to update the hash key, hash types and RETA table on the fly (without needing to stop/start the device). However, the key length and the number of RETA entries are fixed to 40B and 128 entries respectively. This is done in order

Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser

2021-10-29 Thread Ajit Khaparde
On Fri, Oct 29, 2021 at 10:22 AM Ferruh Yigit wrote: > > On 10/26/2021 6:14 AM, Ajit Khaparde wrote: > > Minor fixes are needed in the RTE_FLOW RSS action parser. > > 1. Update the comment in the parser to indicate rss level 1 implies > > RSS on outer header. > > 2. RSS action will not be supporte

Re: [dpdk-dev] [PATCH v13 4/7] net/iavf: add iAVF IPsec inline crypto support

2021-10-29 Thread Ferruh Yigit
On 10/28/2021 5:04 PM, Radu Nicolau wrote: Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Implement support for rte_security packet metadata Add defini

Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser

2021-10-29 Thread Ferruh Yigit
On 10/26/2021 6:14 AM, Ajit Khaparde wrote: Minor fixes are needed in the RTE_FLOW RSS action parser. 1. Update the comment in the parser to indicate rss level 1 implies RSS on outer header. 2. RSS action will not be supported if level is > 1. 3. RSS action will not be supported if user or applic

[dpdk-dev] [PATCH] test-compress-perf: fix unused-but-set-variable error

2021-10-29 Thread Jim Harris
clang-13 rightfully complains that the total_deq_ops variable in cperf_cyclecount_op_setup is set but not used, since the final accumulated total_deq_ops results isn't used anywhere. So just remove the total_deq_ops variable. Signed-off-by: Jim Harris --- app/test-compress-perf/comp_perf_test_cy

[dpdk-dev] [PATCH] power: fix unused-but-set variable error

2021-10-29 Thread Jim Harris
clang-13 rightfully complains that the tot_ppi variable in update_stats is set but not used, since the final accumulated tot_ppi results isn't used anywhere. So just remove the tot_ppi variable. Signed-off-by: Jim Harris --- lib/power/rte_power_empty_poll.c | 3 +-- 1 file changed, 1 insertion(+

[dpdk-dev] [PATCH] eal: fix unused-but-set-variable error

2021-10-29 Thread Jim Harris
clang-13 rightfully complains that the total_mem variable in eal_parse_socket_arg is set but not used, since the final accumulated total_mem result isn't used anywhere. So just remove the total_mem variable. Signed-off-by: Jim Harris --- lib/eal/linux/eal.c | 2 -- 1 file changed, 2 deletions(-)

Re: [dpdk-dev] [PATCH] net/hns3: fix mailbox communication with HW

2021-10-29 Thread Ferruh Yigit
On 10/28/2021 12:52 PM, Min Hu (Connor) wrote: Mailbox is the communication mechanism between SW and HW. There exist two approaches for SW to recongnize mailbox message from HW. One way is using match_id, the other is to compare the message code. The two approaches are independent and used in dif

Re: [dpdk-dev] [dpdk-techboard] [PATCH v2] vhost: mark vDPA driver API as internal

2021-10-29 Thread Thomas Monjalon
28/10/2021 16:15, Maxime Coquelin: > This patch marks the vDPA driver APIs as internal and > rename the corresponding header file to vdpa_driver.h. > > Signed-off-by: Maxime Coquelin > --- > > Hi Techboard, > > Please vote for an exception for this unannounced API > breakage. [...] > lib/vhost

Re: [dpdk-dev] [PATCH 1/3] eventdev: allow for event devices requiring maintenance

2021-10-29 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob > Sent: Friday, October 29, 2021 4:18 PM > To: mattias.ronnblom ; Van Haaren, Harry > ; McDaniel, Timothy > ; Pavan Nikhilesh ; > Hemant Agrawal ; Liang Ma > > Cc: Richardson, Bruce ; Jerin Jacob > ; Gujjar, Abhinandan S ; > Carrillo, Erik G ; Jaya

Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry

2021-10-29 Thread Jerin Jacob
On Fri, Oct 22, 2021 at 5:27 PM Tomasz Duszynski wrote: > > Add initial support for baseband telemetry. > > Signed-off-by: Tomasz Duszynski > --- Updated as raw/cnxk_bphy: support telemetry Added /cnxk/bphy/info telemetry endpoint. Signed-off-by: Tomasz Duszynski Acked-by: Je

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 5:27 PM Mattias Rönnblom wrote: > > On 2021-10-25 11:03, Jerin Jacob wrote: > > On Mon, Oct 25, 2021 at 1:05 PM Mattias Rönnblom > > wrote: > >> On 2021-10-19 20:14, jer...@marvell.com wrote: > >>> From: Jerin Jacob > >>> > >>> > >>> Dataplane Workload Accelerator library

Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix ctrl+c issue

2021-10-29 Thread Burakov, Anatoly
On 29-Oct-21 3:05 PM, Harneet Singh wrote: Currently, EAL init cannot be interrupted with SIGINT because the signal handler is already overridden by the time EAL init happens. Fix it by moving signal handler installation to after EAL initialization, to allow SIGNIT to interrupt EAL initializati

[dpdk-dev] [PATCH] net/sfc: add Xilinx vendor/device ID for Riverhead VF

2021-10-29 Thread Andrew Rybchenko
From: Igor Romanov Add the device and vendor numbers to the PCI ID map so that a VF can be probed. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/sfc/sfc_ethdev.c | 1 + 2 files changed, 2 insertions(+) diff

Re: [dpdk-dev] [PATCH 1/3] eventdev: allow for event devices requiring maintenance

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 8:33 PM Mattias Rönnblom wrote: > > On 2021-10-29 16:38, Jerin Jacob wrote: > > On Tue, Oct 26, 2021 at 11:02 PM Mattias Rönnblom > > wrote: > >> Extend Eventdev API to allow for event devices which require various > >> forms of internal processing to happen, even when eve

Re: [dpdk-dev] [PATCH 1/3] eventdev: allow for event devices requiring maintenance

2021-10-29 Thread Mattias Rönnblom
On 2021-10-29 16:38, Jerin Jacob wrote: > On Tue, Oct 26, 2021 at 11:02 PM Mattias Rönnblom > wrote: >> Extend Eventdev API to allow for event devices which require various >> forms of internal processing to happen, even when events are not >> enqueued to or dequeued from a port. >> >> PATCH v1: >

Re: [dpdk-dev] [PATCH v2] ci: fix aarch64 cross compilation in GHA

2021-10-29 Thread David Marchand
On Fri, Oct 29, 2021 at 1:28 PM David Marchand wrote: > > CC_FOR_BUILD is a Travis env variable. If ARM still has some credits for Travis builds, can you try this patch? Thanks. -- David Marchand

[dpdk-dev] [PATCH] hash: fix use after free in thash

2021-10-29 Thread Vladimir Medvedkin
This patch fixes use after free in thash library, reported by ASAN. Bugzilla ID: 868 Fixes: 28ebff11c2dc ("hash: add predictable RSS") Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_thash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/ha

Re: [dpdk-dev] [PATCH 3/4] dma/cnxk: add dma channel operations

2021-10-29 Thread Jerin Jacob
On Thu, Oct 28, 2021 at 11:48 PM Radha Mohan wrote: > > On Tue, Oct 26, 2021 at 1:49 AM Jerin Jacob wrote: > > > > On Tue, Oct 26, 2021 at 9:43 AM Radha Mohan Chintakuntla > > wrote: > > > > > > Add functions for the dmadev vchan setup and DMA operations. > > > > > > Signed-off-by: Radha Mohan C

Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

2021-10-29 Thread David Marchand
On Fri, Oct 29, 2021 at 11:21 AM David Marchand wrote: > > Replying on this patch since there is no cover letter. > > This series looks acceptable to me for rc2. > > Patch 3 and 4 will be merged first, since they fix issues that would > be hit with ASan enabled. > > I have comments mainly on rewor

[dpdk-dev] [PATCH v3 10/10] vdpa/sfc: set a multicast filter during vDPA init

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Insert unknown multicast filter to allow IPv6 neighbor discovery Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- drivers/vdpa/sfc/sfc_vdpa.h| 3 ++- drivers/vdpa/sfc/sfc_vdpa_filter.c | 19 +-- 2 files changed, 19 inse

[dpdk-dev] [PATCH v3 08/10] vdpa/sfc: add support for MAC filter config

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add support for unicast and broadcast MAC filter configuration. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- doc/guides/vdpadevs/sfc.rst| 4 ++ drivers/vdpa/sfc/meson.build | 1 + drivers/vdpa/sfc/sfc_vdpa.c| 32 +

[dpdk-dev] [PATCH v3 09/10] vdpa/sfc: add support to set vring state

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implements vDPA ops set_vring_state to configure vring state. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 54 ++--- 1 file changed, 50 inse

[dpdk-dev] [PATCH v3 06/10] vdpa/sfc: add support for dev conf and dev close ops

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops dev_conf and dev_close for DMA mapping, interrupt and virtqueue configurations. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Removed redundant null check while calling free(). * Added error handling for rte_vhost_get

[dpdk-dev] [PATCH v3 07/10] vdpa/sfc: add support to get queue notify area info

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement the vDPA ops get_notify_area to get the notify area info of the queue. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Added error log in sfc_vdpa_get_notify_area. drivers/vdpa/sfc/sfc_vdpa_ops.c | 168

[dpdk-dev] [PATCH v3 04/10] vdpa/sfc: get device supported max queue count

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_queue_num to get the maximum number of queues supported by the device. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 16 +--- 1 file changed,

[dpdk-dev] [PATCH v3 05/10] vdpa/sfc: add support to get VFIO device fd

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_vfio_device_fd to get the VFIO device fd. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 24 1 file changed, 24 insertions(+) dif

[dpdk-dev] [PATCH v3 03/10] vdpa/sfc: add support to get device and protocol features

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_feature and get_protocol_features. This patch retrieves device supported features and enables protocol features. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin --- doc/guides/vdpadevs/features/

[dpdk-dev] [PATCH v3 02/10] vdpa/sfc: add support for device initialization

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add HW initialization and vDPA device registration support. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Used rte_memzone_reserve_aligned for mcdi buffer allocation. * Freeing mcdi buff when DMA map fails. * Fixed one typo. doc/guide

[dpdk-dev] [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-10-29 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add new vDPA PMD to support vDPA operations of Xilinx devices. This patch implements probe and remove functions. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Updated logging macros to remove redundant code. v3: * Replaced depreciated

[dpdk-dev] [PATCH v3 00/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-10-29 Thread Vijay Srivastava
This patch series introduces vDPA driver for Xilinx devices. The Xilinx vDPA (vhost data path acceleration) provides support for the Xilinx SN1022 SmartNICs. Vijay Kumar Srivastava (10): vdpa/sfc: introduce Xilinx vDPA driver vdpa/sfc: add support for device initialization vdpa/sfc: add supp

Re: [dpdk-dev] [dpdk-dev v1 7/7] crypto/qat: qat driver rework clean up

2021-10-29 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v1 7/7] crypto/qat: qat driver rework clean up > > This patch rename back refactor code to qat_sym.c and qat_asym.c, meson > bui

Re: [dpdk-dev] [dpdk-dev v1 6/7] app/test: cryptodev test fix

2021-10-29 Thread Zhang, Roy Fan
Hi Kai, > -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai ; De Lara Guarch, Pablo > ; adamx.dybkow...@intel.com > Subject: [dpdk-dev] [dpdk-dev v1 6/7] app/test: cryptodev test fix > > test_mixed_auth_cipher: e

Re: [dpdk-dev] [dpdk-dev v1 5/7] crypto/qat: qat driver datapath rework

2021-10-29 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v1 5/7] crypto/qat: qat driver datapath > rework > > This patch introduce op_build_request func in qat enqueue op > burst. Add-i

Re: [dpdk-dev] [dpdk-dev v1 4/7] crypto/qat: qat driver session method rework

2021-10-29 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v1 4/7] crypto/qat: qat driver session method > rework > > The patch introduce set_session & set_raw_dp_ctx methods to qat gen d

Re: [dpdk-dev] [PATCH 1/3] eventdev: allow for event devices requiring maintenance

2021-10-29 Thread Jerin Jacob
On Tue, Oct 26, 2021 at 11:02 PM Mattias Rönnblom wrote: > > Extend Eventdev API to allow for event devices which require various > forms of internal processing to happen, even when events are not > enqueued to or dequeued from a port. > > PATCH v1: > - Adapt to the move of fastpath function poi

Re: [dpdk-dev] [dpdk-dev v1 3/7] crypto/qat: qat driver asym op refactor

2021-10-29 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v1 3/7] crypto/qat: qat driver asym op > refactor > > This patch add-in refactored qat asymmetric build request > function imple

Re: [dpdk-dev] [dpdk-dev v1 2/7] crypto/qat: qat driver sym op refactor

2021-10-29 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v1 2/7] crypto/qat: qat driver sym op refactor > > This patch add-in refactored qat symmetirc build request function > implement

[dpdk-dev] [Bug 870] Fragmented packets incorrect RSS distribution with TAP PMD on Hyper-V platform

2021-10-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=870 Bug ID: 870 Summary: Fragmented packets incorrect RSS distribution with TAP PMD on Hyper-V platform Product: DPDK Version: 20.11 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH 0/3] fix max pools argument parsing

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 3:45 AM Volodymyr Fialko wrote: > > This series should fix issue with max pool argument parsing for cnxk > platforms > > Volodymyr Fialko (3): > mempool/cnxk: fix max pools argument parsing > common/cnxk: add roc npa init callback support > mempool/cnxk: parse max poo

Re: [dpdk-dev] [PATCH] net/octeontx_ep: Remove otx2 common dependency

2021-10-29 Thread Jerin Jacob
On Tue, Oct 26, 2021 at 9:10 PM Pradeep Nalla wrote: > > octeontx_ep driver's dependency on octeontx2 common code is > removed as going forward ep driver will include files from > its own path. > > Signed-off-by: Pradeep Nalla Updated as net/octeontx_ep: remove octeontx2 dependency oct

Re: [dpdk-dev] [PATCH 2/2] common/cnxk: sync mbox with AF

2021-10-29 Thread Jerin Jacob
On Mon, Oct 25, 2021 at 9:25 AM wrote: > > From: Kiran Kumar K > > Sync mbox with AF, And bump up the version. > > Signed-off-by: Kiran Kumar K Updated as common/cnxk: update mailbox version to 0xb Sync mailbox definition with AF kernel driver. Signed-off-by: Kiran Kumar K A

Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

2021-10-29 Thread Thomas Monjalon
29/10/2021 16:06, Dumitrescu, Cristian: > From: Thomas Monjalon > > 28/10/2021 12:17, Liguzinski, WojciechX: > > > Implement PIE based congestion management based on rfc8033 > > > > An explanation is missing about why RED code is removed. > > I don't know whether it deserves a separate commit, >

Re: [dpdk-dev] [PATCH 1/2] common/octeontx2: sync mbox with AF

2021-10-29 Thread Jerin Jacob
On Mon, Oct 25, 2021 at 9:25 AM wrote: > > From: Kiran Kumar K > > Sync mbox with AF, And bump up the version. > > Signed-off-by: Kiran Kumar K Updated as common/octeontx2: update mailbox version to 0xb Sync mailbox definition with AF kernel driver. Signed-off-by: Kiran Kumar K

Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

2021-10-29 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Friday, October 29, 2021 2:58 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder ; Ajmera, > Megha ; Liguzinski, WojciechX > ; david.march...@redhat.com; Mcnamara, > John > Subject: Re: [dpdk-dev] [PATCH v19 1/5] sch

[dpdk-dev] [PATCH] examples/l3fwd-power: fix ctrl+c issue

2021-10-29 Thread Harneet Singh
Currently, EAL init cannot be interrupted with SIGINT because the signal handler is already overridden by the time EAL init happens. Fix it by moving signal handler installation to after EAL initialization, to allow SIGNIT to interrupt EAL initialization. Fixes: d7937e2e3d12 ("power: initial imp

Re: [dpdk-dev] [dpdk-dev v1 1/7] crypro/qat: qat driver refactor skeleton

2021-10-29 Thread Zhang, Roy Fan
Hi Kai, > -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, October 26, 2021 6:25 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v1 1/7] crypro/qat: qat driver refactor > skeleton > > Add-in enqueue/dequeue op burst and build-request skeleton funct

Re: [dpdk-dev] [PATCH v8 5/5] lib/distributor: use wait event scheme

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 1:50 PM Feifei Wang wrote: > > Instead of polling for bufptr64 to be updated, use > wait event for this case. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang With the change in the subject as distributor: ... Probably can be fixed in merge time. Acked-by: Je

Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

2021-10-29 Thread Thomas Monjalon
28/10/2021 12:17, Liguzinski, WojciechX: > Implement PIE based congestion management based on rfc8033 An explanation is missing about why RED code is removed. I don't know whether it deserves a separate commit, but at least it should be removed consisently in lib and example code in the same patch

Re: [dpdk-dev] [PATCH v8 3/5] eal: use wait event scheme for mcslock

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 1:50 PM Feifei Wang wrote: > > Instead of polling for mcslock to be updated, use wait event scheme > for this case. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob > --- > lib/eal/include/generic/rte_mcslock.h | 5 +++-- > 1 file cha

Re: [dpdk-dev] [PATCH v8 2/5] eal: use wait event for read pflock

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 1:50 PM Feifei Wang wrote: > > Instead of polling for read pflock update, use wait event scheme for > this case. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob > --- > lib/eal/include/generic/rte_pflock.h | 4 +--- > 1 file changed,

Re: [dpdk-dev] [PATCH v8 1/5] eal: add new definitions for wait scheme

2021-10-29 Thread Jerin Jacob
On Fri, Oct 29, 2021 at 1:50 PM Feifei Wang wrote: > > Introduce macros as generic interface for address monitoring. > > Add '__LOAD_EXC_128' for size of 128. For different size, encapsulate > '__LOAD_EXC_16', '__LOAD_EXC_32', '__LOAD_EXC_64' and '__LOAD_EXC_128' > into a new macro '__LOAD_EXC'. >

[dpdk-dev] Overriding rte_config.h

2021-10-29 Thread Ben Magistro
With the transition to meson, what is the best way to provide custom values to parameters in rte_config.h? When using makefiles, (from memory, I think) we used common_base as a template that was copied in as a replacement for defconfig_x86 Our current thinking is to apply a locally maintained

Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

2021-10-29 Thread Thomas Monjalon
28/10/2021 12:17, Liguzinski, WojciechX: > Implement PIE based congestion management based on rfc8033 > > Signed-off-by: Liguzinski, WojciechX > Acked-by: Cristian Dumitrescu > Acked-by: Jasvinder Singh > > -- > Changes in V19: > - ACKs included in patches Would be good to fix your own name a

Re: [dpdk-dev] [PATCH v2] ci: fix aarch64 cross compilation in GHA

2021-10-29 Thread Aaron Conole
David Marchand writes: > CC_FOR_BUILD is a Travis env variable. > This results in GHA aarch64 cross compilation jobs building x86 > binaries. > > Example in a recent job on main branch: > 2021-10-28T09:51:06.4976495Z + .ci/linux-build.sh > 2021-10-28T09:51:06.4985674Z + [ -n build ] > 2021-10-28T

Re: [dpdk-dev] [PATCH v13 7/7] net/iavf: update doc with inline crypto support

2021-10-29 Thread Ferruh Yigit
On 10/28/2021 5:05 PM, Radu Nicolau wrote: Update the PMD doc, feature matrix and release notes with the new inline crypto feature. Signed-off-by: Radu Nicolau Squashed the patch in next-net to commit where the feature is implemented, thanks.

Re: [dpdk-dev] [PATCH 2/2] net/iavf: fix build error

2021-10-29 Thread Ferruh Yigit
On 10/29/2021 12:14 PM, Radu Nicolau wrote: Fix build error and wrong parameter used for function call Fixes: 7dd3f3e43732 ("net/iavf: add iAVF IPsec inline crypto support") Signed-off-by: Radu Nicolau Squashed into relevant commit in next-net, thanks. net/iavf: support IPsec inline crypto

Re: [dpdk-dev] [PATCH 1/2] net/iavf: fix build error

2021-10-29 Thread Ferruh Yigit
On 10/29/2021 12:14 PM, Radu Nicolau wrote: Fix clang build error, remove unused function Fixes: f12d8bf150f5 ("net/iavf: rework Tx path") Signed-off-by: Radu Nicolau Squashed into relevant commit in next-net, thanks. net/iavf: rework Tx path

[dpdk-dev] [PATCH v4] net/ice: fix performance issue for Rx timestamp

2021-10-29 Thread Simei Su
In Rx data path, it reads hardware registers per packet, resulting in big performance drop. This patch improves performance from two aspects: (1) replace per packet hardware register read by per burst. (2) reduce hardware register read time from 3 to 2 when the low value of time is not close to

Re: [dpdk-dev] [PATCH v13 2/4] DPDK code adapts to ASan

2021-10-29 Thread Peng, ZhihongX
> -Original Message- > From: David Marchand > Sent: Friday, October 29, 2021 5:23 PM > To: Peng, ZhihongX > Cc: Thomas Monjalon ; Burakov, Anatoly > ; Ananyev, Konstantin > ; Stephen Hemminger > ; Dumitrescu, Cristian > ; Mcnamara, John > ; Richardson, Bruce > ; dev ; Lin, Xueqin > > Sub

Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

2021-10-29 Thread Peng, ZhihongX
> -Original Message- > From: David Marchand > Sent: Friday, October 29, 2021 5:22 PM > To: Peng, ZhihongX > Cc: Thomas Monjalon ; Burakov, Anatoly > ; Ananyev, Konstantin > ; Stephen Hemminger > ; Dumitrescu, Cristian > ; Mcnamara, John > ; Richardson, Bruce > ; dev ; Lin, Xueqin > > Sub

Re: [dpdk-dev] [EXT] [PATCH] interrupts: do not resize event list for non MSIX

2021-10-29 Thread David Marchand
On Fri, Oct 29, 2021 at 11:38 AM Harman Kalra wrote: > > Resizing event list only makes sense in MSIX case. > > > > Besides, event list has always been RTE_MAX_RXTX_INTR_VEC_ID large. > > Let's restore this assumption for code that might rely on this property and > > only enlarge the event list wh

Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key

2021-10-29 Thread De Lara Guarch, Pablo
Hi Vidya, > -Original Message- > From: dev On Behalf Of Vidya Sagar Velumuri > Sent: Wednesday, October 27, 2021 9:41 AM > To: adwiv...@marvell.com; ano...@marvell.com; ktejas...@marvell.com; > ndabilpu...@marvell.com; gak...@marvell.com; Doherty, Declan > > Cc: dev@dpdk.org > Subject: [

[dpdk-dev] [PATCH] test/mbuf: fix access to freed memory

2021-10-29 Thread Olivier Matz
Seen by ASan. In the external buffer mbuf test, we check that the buffer is freed by checking that its refcount is 0. This is not a valid condition, because it accesses to an already freed area. Fix this by setting a boolean flag in the callback when rte_free() is actually called, and check this

[dpdk-dev] [Bug 869] [asan] eventdev: use-after-free in event_eth_tx_adapter_autotest

2021-10-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=869 Bug ID: 869 Summary: [asan] eventdev: use-after-free in event_eth_tx_adapter_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UN

[dpdk-dev] [Bug 868] [asan] thash: use after free in thash_autotest

2021-10-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=868 Bug ID: 868 Summary: [asan] thash: use after free in thash_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] test/cmdline: fix memory leak

2021-10-29 Thread Olivier Matz
On Fri, Oct 29, 2021 at 01:23:15PM +0200, David Marchand wrote: > Previous change wrongly removed a valid cmdline_free(). > > Fixes: 6ad06203a587 ("cmdline: free on exit") > > Signed-off-by: David Marchand Acked-by: Olivier Matz Thanks!

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-29 Thread Mattias Rönnblom
On 2021-10-25 11:03, Jerin Jacob wrote: > On Mon, Oct 25, 2021 at 1:05 PM Mattias Rönnblom > wrote: >> On 2021-10-19 20:14, jer...@marvell.com wrote: >>> From: Jerin Jacob >>> >>> >>> Dataplane Workload Accelerator library >>> == >>> >>> Definition of Dataplane

[dpdk-dev] [Bug 867] [asan] mbuf: use-after-free in mbuf_autotest

2021-10-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=867 Bug ID: 867 Summary: [asan] mbuf: use-after-free in mbuf_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-10-29 Thread Vijay Kumar Srivastava
Hi Stephen, >-Original Message- >From: Stephen Hemminger >Sent: Friday, August 13, 2021 9:06 PM >To: Vijay Kumar Srivastava >Cc: dev@dpdk.org; maxime.coque...@redhat.com; chenbo@intel.com; >andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava >Subject: Re: [dpdk-dev] [PATCH 01/10]

[dpdk-dev] [PATCH 2/2] net/iavf: fix build error

2021-10-29 Thread Radu Nicolau
Fix build error and wrong parameter used for function call Fixes: 7dd3f3e43732 ("net/iavf: add iAVF IPsec inline crypto support") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ipsec_c

[dpdk-dev] [PATCH 1/2] net/iavf: fix build error

2021-10-29 Thread Radu Nicolau
Fix clang build error, remove unused function Fixes: f12d8bf150f5 ("net/iavf: rework Tx path") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index c782cacc6e..bef2

[dpdk-dev] [PATCH v2] ci: fix aarch64 cross compilation in GHA

2021-10-29 Thread David Marchand
CC_FOR_BUILD is a Travis env variable. This results in GHA aarch64 cross compilation jobs building x86 binaries. Example in a recent job on main branch: 2021-10-28T09:51:06.4976495Z + .ci/linux-build.sh 2021-10-28T09:51:06.4985674Z + [ -n build ] 2021-10-28T09:51:06.4987636Z + [ true = true ] 2021

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix lookaside IPsec IPv6 support

2021-10-29 Thread Anoob Joseph
> Subject: [PATCH] crypto/octeontx2: fix lookaside IPsec IPv6 support > > Fixing IPv6 mixed tunnel mode support by updating inputs to firmware. > > Fixes: 4edede7bc6ee ("crypto/octeontx2: support lookaside IPsec IPv6") > Cc: sta...@dpdk.org > > Signed-off-by: Tejasree Kondoj Acked-by: Anoob Jo

[dpdk-dev] [PATCH] test/cmdline: fix memory leak

2021-10-29 Thread David Marchand
Previous change wrongly removed a valid cmdline_free(). Fixes: 6ad06203a587 ("cmdline: free on exit") Signed-off-by: David Marchand --- app/test/test_cmdline_lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c index f238094b07..f

  1   2   >