> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Friday, October 29, 2021 2:58 PM > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com> > Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>; Ajmera, > Megha <megha.ajm...@intel.com>; Liguzinski, WojciechX > <wojciechx.liguzin...@intel.com>; david.march...@redhat.com; Mcnamara, > John <john.mcnam...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion > management > > 28/10/2021 12:17, Liguzinski, WojciechX: > > Implement PIE based congestion management based on rfc8033 > > An explanation is missing about why RED code is removed. > I don't know whether it deserves a separate commit, > but at least it should be removed consisently in lib and example code > in the same patch. > > Cristian, please make efforts to help this patchset be properly organized. > A blind ack is not enough. > The RED code is not removed. It is simply the macro renamed to CMAN (Congestion Management) to include both RED and PIE.
- Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support ... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v18 0/5] Add PIE supp... Dumitrescu, Cristian
- Re: [dpdk-dev] [PATCH v18 0/5] Add PIE ... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v18 0/5] Add PIE ... Liguzinski, WojciechX
- Re: [dpdk-dev] [PATCH v18 0/5] Add PIE ... Thomas Monjalon
- [dpdk-dev] [PATCH v19 0/5] Add PIE support for HQoS ... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v19 1/5] sched: add PIE based... Liguzinski, WojciechX
- Re: [dpdk-dev] [PATCH v19 1/5] sched: add P... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v19 1/5] sched: a... Liguzinski, WojciechX
- Re: [dpdk-dev] [PATCH v19 1/5] sched: add P... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v19 1/5] sched: a... Dumitrescu, Cristian
- Re: [dpdk-dev] [PATCH v19 1/5] sched: a... Thomas Monjalon
- [dpdk-dev] [PATCH v19 3/5] example/ip_pipeline:... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v19 2/5] example/qos_sched: a... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v19 4/5] doc/guides/prog_guid... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v19 5/5] app/test: add tests ... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v20 0/5] Add PIE support for ... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v20 1/5] sched: add PIE b... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v20 2/5] example/qos_sche... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v20 3/5] example/ip_pipel... Liguzinski, WojciechX
- [dpdk-dev] [PATCH v20 4/5] doc/guides/prog_... Liguzinski, WojciechX