On Fri, Oct 29, 2021 at 7:17 PM Jim Harris <james.r.har...@intel.com> wrote:
>
> clang-13 rightfully complains that the total_mem
> variable in eal_parse_socket_arg is set but not
> used, since the final accumulated total_mem
> result isn't used anywhere. So just remove the
> total_mem variable.
>
It was left behind by change:
Fixes: 0a703f0f36c1 ("eal/linux: fix parsing zero socket memory and limits")
> Signed-off-by: Jim Harris <james.r.har...@intel.com>
> ---
> lib/eal/linux/eal.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 81fdebc6a0..60b4924838 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -562,7 +562,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t
> *socket_arg)
> char * arg[RTE_MAX_NUMA_NODES];
> char *end;
> int arg_num, i, len;
> - uint64_t total_mem = 0;
>
> len = strnlen(strval, SOCKET_MEM_STRLEN);
> if (len == SOCKET_MEM_STRLEN) {
> @@ -594,7 +593,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t
> *socket_arg)
> (arg[i][0] == '\0') || (end == NULL) || (*end
> != '\0'))
> return -1;
> val <<= 20;
> - total_mem += val;
> socket_arg[i] = val;
> }
>
Reviewed-by: David Marchand <david.march...@redhat.com>
--
David Marchand
