Re: [dpdk-dev] [PATCH v7 2/2] vhost: enable IOMMU for async vhost

2021-10-12 Thread Yang, YvonneX
> -Original Message- > From: Ding, Xuan > Sent: Monday, October 11, 2021 4:00 PM > To: dev@dpdk.org; Burakov, Anatoly ; > maxime.coque...@redhat.com; Xia, Chenbo > Cc: Hu, Jiayu ; Jiang, Cheng1 ; > Richardson, Bruce ; Pai G, Sunil > ; Wang, Yinan ; Yang, > YvonneX ; Ding, Xuan > Subje

Re: [dpdk-dev] [PATCH v7 1/2] vfio: allow partially unmapping adjacent memory

2021-10-12 Thread Yang, YvonneX
> -Original Message- > From: Ding, Xuan > Sent: Monday, October 11, 2021 4:00 PM > To: dev@dpdk.org; Burakov, Anatoly ; > maxime.coque...@redhat.com; Xia, Chenbo > Cc: Hu, Jiayu ; Jiang, Cheng1 ; > Richardson, Bruce ; Pai G, Sunil > ; Wang, Yinan ; Yang, > YvonneX ; Ding, Xuan > Subje

[dpdk-dev] [Bug 824] RTE_LCORE_FOREACH goes over unactive cores with dynamic linking on BlueField 2

2021-10-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=824 Tom Barbette (barbe...@kth.se) changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONF

Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment

2021-10-12 Thread 蔡慧超
Hi,Konstantin I'm glad to receive your ack! Follow the documentation 《Contributing Code to DPDK》: 1.Update Patchwork to mark your previous patches as “Superseded”. --Who is responsible for this update, I just tried, prompt no permission update( You don't have permissions to edit patch 'ip_frag:

Re: [dpdk-dev] [PATCH v3] eventdev/rx_adapter: add telemetry callbacks

2021-10-12 Thread Naga Harish K, S V
> -Original Message- > From: Kundapura, Ganapati > Sent: Tuesday, October 12, 2021 9:44 PM > To: Naga Harish K, S V ; Jayatheerthan, Jay > ; jerinjac...@gmail.com; dev@dpdk.org > Cc: Kinsella, Ray ; Thomas Monjalon > ; David Marchand > Subject: RE: [PATCH v3] eventdev/rx_adapter: add t

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates

2021-10-12 Thread Alexander Kozyrev
> From: Ajit Khaparde On Tuesday, October 12, 2021 > 22:27 > To: Alexander Kozyrev > > > > > From: Ivan Malov On Wednesday, October 6, > 2021 13:25 > > > On 06/10/2021 07:48, Alexander Kozyrev wrote: > > > > Treating every single flow rule as a completely independent and > separate > > > > enti

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates

2021-10-12 Thread Ajit Khaparde
On Tue, Oct 12, 2021 at 6:25 PM Alexander Kozyrev wrote: > > > From: Ivan Malov On Wednesday, October 6, 2021 > > 13:25 > > On 06/10/2021 07:48, Alexander Kozyrev wrote: > > > Treating every single flow rule as a completely independent and separate > > > entity negatively impacts the flow rules

[dpdk-dev] [Bug 827] unit_tests_eal/link_bonding:Failed to execute link_bonding_autotest

2021-10-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=827 Bug ID: 827 Summary: unit_tests_eal/link_bonding:Failed to execute link_bonding_autotest Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCON

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Anoob Joseph
Hi Thomas, Ray, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 12, 2021 8:37 PM > To: Anoob Joseph ; Akhil Goyal > ; dev@dpdk.org; Kinsella, Ray > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; > pablo.de.lara.gua...@intel

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates

2021-10-12 Thread Alexander Kozyrev
> From: Ivan Malov On Wednesday, October 6, 2021 13:25 > On 06/10/2021 07:48, Alexander Kozyrev wrote: > > Treating every single flow rule as a completely independent and separate > > entity negatively impacts the flow rules insertion rate. Oftentimes in an > > application, many flow rules share a

Re: [dpdk-dev] [PATCH 3/3] ethdev: add async queue-based flow rules operations

2021-10-12 Thread Alexander Kozyrev
> From: Ivan Malov on Wednesday, October 6, 2021 12:25 > On 06/10/2021 07:48, Alexander Kozyrev wrote: > > A new, faster, queue-based flow rules management mechanism is needed for > > applications offloading rules inside the datapath. This asynchronous > > and lockless mechanism frees the CPU for

Re: [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit

2021-10-12 Thread Peng, ZhihongX
> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, October 13, 2021 10:36 AM > To: Peng, ZhihongX > Cc: olivier.m...@6wind.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit > > 2021-10-13 01:53 (UTC+), Peng, Zhihong

[dpdk-dev] [PATCH] net/ice/base: fix null pointer dereferences for parser

2021-10-12 Thread Junfeng Guo
Null-checking "p" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Thus correct the code lines and remove the redundant line. Fixes: c84f8aa2100c ("net/ice/base: add parser runtime skeleton") Cc: sta...@dpdk.org Signed-off-by: Junfeng Guo ---

[dpdk-dev] [PATCH 3/3] net/txgbe: fix VXLAN-GPE packet checksum

2021-10-12 Thread Jiawen Wu
Parse inner L2 length to set correct packet type, and ensure that hardware can compute the checksum successfully. Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ptypes.c | 24 +++--- drivers/net/txgbe

[dpdk-dev] [PATCH 1/3] net/txgbe: fix to get interrupt status

2021-10-12 Thread Jiawen Wu
It's necessary to set 1 on TXGBE_PX_INTA register to get interrupts normally, when legacy interrupt mode is used. Fixes: 2fc745e6b606 ("net/txgbe: add interrupt operation") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 1 + drivers/net/txgbe/txgbe_ethde

[dpdk-dev] [PATCH 2/3] net/txgbe: set fixed flag for exact link speed

2021-10-12 Thread Jiawen Wu
Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/net/txgbe/txgbe_et

[dpdk-dev] [PATCH 0/3] txgbe fixes

2021-10-12 Thread Jiawen Wu
Fix legacy interrupt abnormal, VXLAN-GPE packet inner checksum error, and support to set fixed link speed. Jiawen Wu (3): net/txgbe: fix to get interrupt status net/txgbe: set fixed flag for exact link speed net/txgbe: fix VXLAN-GPE packet checksum drivers/net/txgbe/base/txgbe_regs.h | 1

Re: [dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-10-12 Thread Wang, Jie1X
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 12, 2021 10:38 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX > Subject: Re: [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash > o

Re: [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit

2021-10-12 Thread Dmitry Kozlyuk
2021-10-13 01:53 (UTC+), Peng, ZhihongX: > > -Original Message- > > From: Dmitry Kozlyuk > > Sent: Monday, October 11, 2021 4:26 PM > > To: Peng, ZhihongX > > Cc: olivier.m...@6wind.com; dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [PATCH v3 1/2] lib/cmdline: release cl when cmdline

Re: [dpdk-dev] [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove

2021-10-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Monday, October 11, 2021 4:13 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Guo, Junfeng ; Yang, SteveX > ; Zhang, RobinX > Subject: [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove > > Firmware will return I40E

[dpdk-dev] [PATCH v4 1/2] lib/cmdline: release cl when cmdline exit

2021-10-12 Thread zhihongx . peng
From: Zhihong Peng Malloc cl in the cmdline_stdin_new function, so release in the cmdline_stdin_exit function is logical, so that cl will not be released alone. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- doc/guides/rel_notes/release_21_11.

[dpdk-dev] [PATCH v4 2/2] app/test: delete cmdline free function

2021-10-12 Thread zhihongx . peng
From: Zhihong Peng Cmdline will be released in cmdline_stdin_exit function, so it does not need to be released here. Fixes: acdabc450ea0 ("test: fix terminal settings on exit") Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- app/test/test.c | 1 - app/test/test_cmdline_lib.c |

Re: [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit

2021-10-12 Thread Peng, ZhihongX
> -Original Message- > From: Dmitry Kozlyuk > Sent: Monday, October 11, 2021 4:26 PM > To: Peng, ZhihongX > Cc: olivier.m...@6wind.com; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit > > 2021-10-08 06:41 (UTC+), zhihongx.p...@int

[dpdk-dev] [PATCH v2] net/virtio: fix indirect descriptors reconnection

2021-10-12 Thread Xuan Ding
Add initialization for packed ring indirect descriptors in reconnection path. Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup") Cc: sta...@dpdk.org Cc: yong@intel.com Signed-off-by: Xuan Ding Tested-by: Yinan Wang --- v2: * Fix the position of some declaration

[dpdk-dev] [PATCH] net/enic: fix filter mode detection

2021-10-12 Thread Hyong Youb Kim
vnic_dev_capable_filter_mode() currently fails when CMD_CAPABILITY(CMD_ADD_FILTER) returns ERR_EPERM. In turn, this failure causes the driver initialization to fail. But, firmware may legitimately return ERR_EPERM. For example, VF vNIC returns ERR_EPERM when it does not support filtering at all. S

Re: [dpdk-dev] [PATCH v2 00/10] net/sfc: add support for tunnel offload

2021-10-12 Thread Ivan Malov
Hi Ferruh, On 13/10/2021 02:46, Ferruh Yigit wrote: On 10/5/2021 12:55 AM, Ivan Malov wrote: The first 6 patches comprise the fundamental part of the series. They are trying to be future-proof with respect to the planned HW/FW changes. 4 more patches form the adaptation part of some sort to mak

Re: [dpdk-dev] [PATCH] net/virtio: fix indirect descriptors reconnection

2021-10-12 Thread Wang, Yinan
Tested-by: Yinan Wang > -Original Message- > From: Ding, Xuan > Sent: 2021?8?19? 13:35 > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Wang, Yinan > ; Ding, Xuan ; > sta...@dpdk.org; Liu, Yong > Subject: [PATCH] net/virtio: fix indirect descriptors reconne

[dpdk-dev] [PATCH v3 10/10] net/sfc: refine pattern of GROUP flows in tunnel offload

2021-10-12 Thread Ivan Malov
By design, in a GROUP flow, outer match criteria go to "ENC" fields of the action rule match specification. The current HW/FW hasn't got support for these fields (except the VXLAN VNI) yet. As a workaround, start parsing the pattern from the tunnel item. Signed-off-by: Ivan Malov Reviewed-by: An

[dpdk-dev] [PATCH v3 09/10] net/sfc: support counters in tunnel offload JUMP rules

2021-10-12 Thread Ivan Malov
Such a counter will only report the number of hits, which is actually a sum of two contributions (the JUMP rule's own counter + indirect increments issued by counters of the associated GROUP rules. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_flow.c|

[dpdk-dev] [PATCH v3 08/10] net/sfc: use action rules in tunnel offload JUMP rules

2021-10-12 Thread Ivan Malov
By design, JUMP flows should be represented solely by the outer rules. But the HW/FW hasn't got support for setting Rx mark from RECIRC_ID on outer rule lookup yet. Neither does it support outer rule counters. As a workaround, an action rule of lower priority is used to do the job. Signed-off-by:

[dpdk-dev] [PATCH v3 07/10] net/sfc: override match on ETH in tunnel offload JUMP rules

2021-10-12 Thread Ivan Malov
The current HW/FW doesn't allow to match on MAC addresses in outer rules. One day this will change for sure, but right now a workaround is needed. Match on VLAN presence in outer rules is also unsupported. Ignore it. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/s

[dpdk-dev] [PATCH v3 06/10] net/sfc: implement control path operations in tunnel offload

2021-10-12 Thread Ivan Malov
Support generic callbacks which callers will invoke to get PMD-specific actions and items used to produce JUMP and GROUP flows and to detect tunnel information. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp.c | 47 + drivers/net/sfc/sfc_dp.h

[dpdk-dev] [PATCH v3 05/10] net/sfc: support GROUP flows in tunnel offload

2021-10-12 Thread Ivan Malov
GROUP is an in-house term for so-called "tunnel_match" flows. On parsing, they are detected by virtue of PMD-internal item MARK. It associates a given flow with its tunnel context. Such a flow is represented by a MAE action rule which is chained with the corresponding JUMP rule's outer rule by vir

[dpdk-dev] [PATCH v3 04/10] common/sfc_efx/base: add RECIRC ID match in action rules API

2021-10-12 Thread Ivan Malov
Currently, there is an API for setting recirculation ID in outer rules. Add an API to let action rules match on it. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx.h | 13 ++ drivers/common/sfc_efx/base/efx_mae.c | 36 +

[dpdk-dev] [PATCH v3 03/10] net/sfc: support JUMP flows in tunnel offload

2021-10-12 Thread Ivan Malov
JUMP is an in-house term for so-called "tunnel_set" flows. On parsing, they are identified by virtue of actions MARK (PMD-internal) and JUMP. The action MARK associates a given flow with its tunnel context. Such a flow is represented by a MAE outer rule (OR) which has its recirculation ID set. Thi

[dpdk-dev] [PATCH v3 02/10] common/sfc_efx/base: add API to set RECIRC ID in outer rules

2021-10-12 Thread Ivan Malov
When an outer rule is hit, it can pass recirculation ID down to action rule lookup, and action rules can match on this ID instead of matching on the outer rule allocation handle. By default, recirculation ID is assumed to be zero. Add an API to set recirculation ID in outer rules. Signed-off-by:

[dpdk-dev] [PATCH v3 01/10] net/sfc: fence off 8 bits in Rx mark for tunnel offload

2021-10-12 Thread Ivan Malov
Later patches add support for tunnel offload on Riverhead (EF100). A board can host at most 254 tunnels. Partially offloaded (missed) tunnel packets are identified by virtue of 8 high bits in Rx mark. Add basic definitions of the upcoming tunnel offload support and take care of the dedicated bits

[dpdk-dev] [PATCH v3 00/10] net/sfc: add support for tunnel offload

2021-10-12 Thread Ivan Malov
The first 6 patches comprise the fundamental part of the series. They are trying to be future-proof with respect to the planned HW/FW changes. 4 more patches form the adaptation part of some sort to make the offload work on the currently available HW/FW. This patch series should be applied on top

Re: [dpdk-dev] [PATCH v25 1/6] dmadev: introduce DMA device library

2021-10-12 Thread fengchengwen
On 2021/10/13 3:09, Thomas Monjalon wrote: > 11/10/2021 09:33, Chengwen Feng: >> --- /dev/null >> +++ b/doc/guides/prog_guide/dmadev.rst >> @@ -0,0 +1,60 @@ >> +.. SPDX-License-Identifier: BSD-3-Clause >> + Copyright 2021 HiSilicon Limited >> + >> +DMA Device Library >> +== >> + >

Re: [dpdk-dev] [PATCH v2 00/10] net/sfc: add support for tunnel offload

2021-10-12 Thread Ferruh Yigit
On 10/5/2021 12:55 AM, Ivan Malov wrote: The first 6 patches comprise the fundamental part of the series. They are trying to be future-proof with respect to the planned HW/FW changes. 4 more patches form the adaptation part of some sort to make the offload work on the currently available HW/FW.

Re: [dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD

2021-10-12 Thread Ferruh Yigit
On 10/12/2021 8:46 PM, Ivan Malov wrote: In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. The issue has not been solved. Applications still assume that metadata features always work an

Re: [dpdk-dev] [PATCH v3 01/12] ethdev: add port representor item to flow API

2021-10-12 Thread Ivan Malov
Hi, On 12/10/2021 23:55, Slava Ovsiienko wrote: Hi, Please, see below. -Original Message- From: dev On Behalf Of Ivan Malov Sent: Sunday, October 10, 2021 17:39 To: dev@dpdk.org Cc: NBU-Contact-Thomas Monjalon ; Ori Kam ; Xiaoyun Li ; Ferruh Yigit ; Andrew Rybchenko Subject: [dpdk-d

Re: [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD

2021-10-12 Thread Ajit Khaparde
On Tue, Oct 12, 2021 at 11:16 AM Ajit Khaparde wrote: > > On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit wrote: > > > > On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > > > On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde > > > wrote: > > > > > >> Apart from fixing an issue with Rx queue state at startup

Re: [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD

2021-10-12 Thread Ajit Khaparde
On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit wrote: > > On 10/7/2021 5:54 PM, Ajit Khaparde wrote: > > On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde > > wrote: > > > >> Apart from fixing an issue with Rx queue state at startup, > >> this patchset enhances support for RSS action and > >> optimizes

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-12 Thread Thomas Monjalon
12/10/2021 22:34, Dumitrescu, Cristian: > From: Thomas Monjalon > > 01/09/2021 14:20, Jasvinder Singh: > > > These APIs were introduced in 18.05, therefore removing > > > experimental tag to promote them to stable state. > > > > > > Signed-off-by: Jasvinder Singh > > > --- > > > lib/pipeline/rte

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-12 Thread Thomas Monjalon
12/10/2021 21:26, Walker, Benjamin: > > From: Thomas Monjalon > > 12/10/2021 18:59, Walker, Benjamin: > > > For networking drivers, maybe. But certainly years and years ago when SPDK > > was started no one recommended putting an nvme driver into DPDK. > > > > No one from SPDK project proposed suc

Re: [dpdk-dev] [PATCH v4 0/3] patchset for bnxt PMD

2021-10-12 Thread Ferruh Yigit
On 10/12/2021 10:18 PM, Ajit Khaparde wrote: Apart from fixing an issue with Rx queue state at startup, this patchset enhances support for RSS action and optimizes the mbuf requirement at startup by creating the aggregation rings only when needed (rx_scatter is enabled). Please apply! -- v1->v2:

Re: [dpdk-dev] [PATCH] doc: add table of supported operating systems for cryptodevs

2021-10-12 Thread Tal Shnaiderman
Hi Crypto PMD maintainers, This patch adds to the crypto documentation guide a table of supported operating systems per crypto PMD. However, I'm not sure my assumption regarding the FreeBSD OS support is correct, I based it on the meson.build script of each PMD and marked FreeBSD = Y (supported

Re: [dpdk-dev] [PATCH v6 2/3] eal: add memory pre-allocation from existing files

2021-10-12 Thread Dmitry Kozlyuk
> -Original Message- > From: David Marchand > Sent: 12 октября 2021 г. 20:33 > To: Dmitry Kozlyuk > Cc: dev ; Slava Ovsiienko ; Anatoly > Burakov ; NBU-Contact-Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add memory pre-allocation from > existing files > > External em

[dpdk-dev] [PATCH] app/test-eventdev: add burst enqueue support in perf_queue test

2021-10-12 Thread Rashmi Shetty
A new command line option prod_enq_burst_sz is introduced to set burst size for eventdev enqueue at producer in perf_queue test. The newly added function perf_producer_burst is called when prod_enq_burst_sz is greater than 1. Signed-off-by: Rashmi Shetty --- app/test-eventdev/evt_common.h

[dpdk-dev] [PATCH] doc: add table of supported operating systems for cryptodevs

2021-10-12 Thread Tal Shnaiderman
Added table to the crypto device drivers documentation stating the support of each PMD on Linux, FreeBSD and Windows. Signed-off-by: Tal Shnaiderman --- Depends-on: series-19563 ("Support MLX5 crypto driver on Windows") --- doc/guides/conf.py | 5 + doc/guides/crypt

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-10-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, September 1, 2021 1:21 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; m...@ashroe.eu > Subject: [PATCH] net/softnic: remove experimental table from API > > This API was introduced in 18.08, therefore removing > experi

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, September 1, 2021 1:20 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; m...@ashroe.eu; > Zhang, Roy Fan > Subject: [PATCH] pipeline: remove experimental tag from API > > These APIs were introduced in 18.05, therefore

Re: [dpdk-dev] [PATCH] sched: remove experimental tag from the API

2021-10-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, September 1, 2021 1:19 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; m...@ashroe.eu > Subject: [PATCH] sched: remove experimental tag from the API > > This API was introduced in 18.05, therefore removing > experiment

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Monday, September 27, 2021 11:18 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; m...@ashroe.eu; Zhang, Roy Fan > ; Singh, Jasvinder > Subject: Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API > > 01/09/2021 14:2

Re: [dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields and flags

2021-10-12 Thread Stephen Hemminger
On Tue, 12 Oct 2021 21:39:57 +0200 David Marchand wrote: > As stated in the API, dynamic field and flags should be created with no > additional flag (simply in the API for future changes). > > Fix the dynamic flag register helper which was not enforcing it and add > unit tests. > > Fixes: 4958c

Re: [dpdk-dev] [PATCH] memzone: enforce valid flags when reserving

2021-10-12 Thread Stephen Hemminger
On Tue, 12 Oct 2021 21:39:26 +0200 David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH] eal/linux: allow hugetlbfs sub-directories

2021-10-12 Thread John Levon
On Tue, Oct 12, 2021 at 09:03:09PM +0200, David Marchand wrote: > > diff --git a/doc/guides/rel_notes/release_21_11.rst > > b/doc/guides/rel_notes/release_21_11.rst > > index 54718ff367..9fe689356b 100644 > > --- a/doc/guides/rel_notes/release_21_11.rst > > +++ b/doc/guides/rel_notes/release_21_1

[dpdk-dev] [PATCH 3/5] crypto/mlx5: use OS agnostic functions for UMEM operations

2021-10-12 Thread Tal Shnaiderman
use the functions mlx5_os_umem_reg, mlx5_os_umem_dereg mlx5_os_get_umem_id instead of the glue functions to support UMEM operations on all OSs. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 8 drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2 fi

[dpdk-dev] [PATCH 0/5] Support MLX5 crypto driver on Windows

2021-10-12 Thread Tal Shnaiderman
Support the MLX5 crypto driver on Windows OS by moving the driver's control path communication with the Kernel to be OS agnostic. --- Depends-on: series-19421 ("mlx5: sharing global MR cache between drivers") --- Tal Shnaiderman (5): common/mlx5: add DV enums to Windows defs file crypto/mlx5:

[dpdk-dev] [PATCH 1/5] common/mlx5: add DV enums to Windows defs file

2021-10-12 Thread Tal Shnaiderman
Add needed DV enums used by the crypto PMD and missing for Windows OS. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/windows/mlx5_win_defs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/co

[dpdk-dev] [PATCH 5/5] crypto/mlx5: support on Windows

2021-10-12 Thread Tal Shnaiderman
Add support for mlx5 crypto pmd on Windows OS. Add changes to release note and pmd guide. Signed-off-by: Tal Shnaiderman --- doc/guides/cryptodevs/mlx5.rst | 15 --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/common/mlx5/version.map | 2 +

[dpdk-dev] [PATCH 2/5] crypto/mlx5: replace UNIX functions with EAL functions

2021-10-12 Thread Tal Shnaiderman
Use the OS agnostic EAL function rte_mem_page_size to get page size value instead of the Linux specific implementation. Also remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azr

[dpdk-dev] [PATCH 4/5] crypto/mlx5: fix size of UMR WQE

2021-10-12 Thread Tal Shnaiderman
The size of the UMR WQE allocated object is decided by a sizof operation on the struct, however since the struct contains a union of flexible array members this sizeof results can differ between compilers. GCC for example treats the union as 0 sized, MSVC adds a padding of 16Bits. To resolve the

Re: [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD

2021-10-12 Thread Ferruh Yigit
On 10/12/2021 8:03 PM, Ajit Khaparde wrote: On Tue, Oct 12, 2021 at 11:16 AM Ajit Khaparde wrote: On Tue, Oct 12, 2021 at 11:14 AM Ferruh Yigit wrote: On 10/7/2021 5:54 PM, Ajit Khaparde wrote: On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde wrote: Apart from fixing an issue with Rx queue

Re: [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath

2021-10-12 Thread Ivan Malov
Hi Ferruh, I apologise: there was a defect in v6. I re-submitted the series (v7): https://patches.dpdk.org/project/dpdk/list/?series=19571 Thank you. On 12/10/2021 21:08, Ferruh Yigit wrote: On 10/5/2021 4:56 PM, Ivan Malov wrote: Detect the flag in Rx prefix and pass it to users. Signed-off

[dpdk-dev] [PATCH v7 5/5] net/sfc: report user flag on EF100 native datapath

2021-10-12 Thread Ivan Malov
Detect the flag in Rx prefix and pass it to users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ef100_rx.c | 18 ++ drivers/net/sfc/sfc_rx.c | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/

[dpdk-dev] [PATCH v7 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag

2021-10-12 Thread Ivan Malov
Add an RxQ flag to request support for user flag field of Rx prefix. The feature is supported only on EF100 and EF10 ESSB. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_rx.c | 54 -- drivers/commo

[dpdk-dev] [PATCH v7 3/5] net/sfc: support flow mark delivery on EF100 native datapath

2021-10-12 Thread Ivan Malov
MAE counter engine gets generation counts by virtue of the mark, so the code to extract the field is already in place, but flow action MARK doesn't benefit from it. Support this use case, too. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc

[dpdk-dev] [PATCH v7 2/5] net/sfc: support API to negotiate delivery of Rx metadata

2021-10-12 Thread Ivan Malov
Initial support for the method. Later patches will extend it to make FLAG and MARK delivery available on EF100 native datapath. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h| 2 ++ drivers/net/sfc/sfc_ethdev.c | 29

[dpdk-dev] [PATCH v7 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD

2021-10-12 Thread Ivan Malov
Provide an API to let the application control the NIC's ability to deliver specific kinds of per-packet metadata to the PMD. Checks for the NIC's ability to set these kinds of metadata in the first place (support for the flow actions) belong in flow API responsibility domain (flow validate mechani

[dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD

2021-10-12 Thread Ivan Malov
In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. The issue has not been solved. Applications still assume that metadata features always work and do not need to be configured in advance.

[dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields and flags

2021-10-12 Thread David Marchand
As stated in the API, dynamic field and flags should be created with no additional flag (simply in the API for future changes). Fix the dynamic flag register helper which was not enforcing it and add unit tests. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Signed-off-by: David

[dpdk-dev] [PATCH] memzone: enforce valid flags when reserving

2021-10-12 Thread David Marchand
If we do not enforce valid flags are passed by an application, this application might face issues in the future when we add more flags. Signed-off-by: David Marchand --- app/test/test_memzone.c | 24 lib/eal/common/eal_common_memzone.c | 17 +

Re: [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath

2021-10-12 Thread Ivan Malov
Hi Ferruh, On 12/10/2021 21:08, Ferruh Yigit wrote: On 10/5/2021 4:56 PM, Ivan Malov wrote: Detect the flag in Rx prefix and pass it to users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton <...> @@ -407,6 +409,15 @@ sfc_ef100_rx_prefix_to_offloads(cons

[dpdk-dev] [PATCH v6 5/5] net/sfc: report user flag on EF100 native datapath

2021-10-12 Thread Ivan Malov
Detect the flag in Rx prefix and pass it to users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ef100_rx.c | 18 ++ drivers/net/sfc/sfc_rx.c | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/

[dpdk-dev] [PATCH v6 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag

2021-10-12 Thread Ivan Malov
Add an RxQ flag to request support for user flag field of Rx prefix. The feature is supported only on EF100 and EF10 ESSB. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_rx.c | 54 -- drivers/commo

[dpdk-dev] [PATCH v6 3/5] net/sfc: support flow mark delivery on EF100 native datapath

2021-10-12 Thread Ivan Malov
MAE counter engine gets generation counts by virtue of the mark, so the code to extract the field is already in place, but flow action MARK doesn't benefit from it. Support this use case, too. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc

[dpdk-dev] [PATCH v6 2/5] net/sfc: support API to negotiate delivery of Rx metadata

2021-10-12 Thread Ivan Malov
Initial support for the method. Later patches will extend it to make FLAG and MARK delivery available on EF100 native datapath. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h| 2 ++ drivers/net/sfc/sfc_ethdev.c | 29

[dpdk-dev] [PATCH v6 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD

2021-10-12 Thread Ivan Malov
Provide an API to let the application control the NIC's ability to deliver specific kinds of per-packet metadata to the PMD. Checks for the NIC's ability to set these kinds of metadata in the first place (support for the flow actions) belong in flow API responsibility domain (flow validate mechani

[dpdk-dev] [PATCH v6 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD

2021-10-12 Thread Ivan Malov
In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. The issue has not been solved. Applications still assume that metadata features always work and do not need to be configured in advance.

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash

2021-10-12 Thread Ori Kam
Hi Jie, > -Original Message- > From: dev On Behalf Of Jie Wang > Sent: Tuesday, October 12, 2021 1:25 PM > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS > Hash > > Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. > > Signed-off-by: Wenjun

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: support PPPoL2TPv2oUDP RSS Hash

2021-10-12 Thread Ori Kam
Hi Jie, The first comment you are missing the maintainer (me) Second shouldn't this be the first patch of the series? Third this patch is about matching on new protocols why there is RSS hash in the title? > -Original Message- > From: dev On Behalf Of Jie Wang > Sent: Tuesday, Octo

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-12 Thread Walker, Benjamin
> From: Thomas Monjalon > 12/10/2021 18:59, Walker, Benjamin: > > For networking drivers, maybe. But certainly years and years ago when SPDK > was started no one recommended putting an nvme driver into DPDK. > > No one from SPDK project proposed such thing. > I asked several times in person why t

Re: [dpdk-dev] [PATCH v25 1/6] dmadev: introduce DMA device library

2021-10-12 Thread Thomas Monjalon
11/10/2021 09:33, Chengwen Feng: > --- /dev/null > +++ b/doc/guides/prog_guide/dmadev.rst > @@ -0,0 +1,60 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright 2021 HiSilicon Limited > + > +DMA Device Library > +== > + > +The DMA library provides a DMA device framework for

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] eal/x86: fix some CPU extended features definitions

2021-10-12 Thread David Marchand
On Fri, Oct 8, 2021 at 2:07 PM David Marchand wrote: > > Caught while checking CPUID related stuff in OVS. > > According to [1], for Structured Extended Feature Flags Enumeration Leaf > (EAX = 0x07H, ECX = 0): > > - BMI1 is associated to EBX, bit 3 (was incorrectly 2), > - SMEP is associated to EB

Re: [dpdk-dev] [PATCH] eal/linux: allow hugetlbfs sub-directories

2021-10-12 Thread David Marchand
On Tue, Oct 12, 2021 at 6:06 PM John Levon wrote: > > get_hugepage_dir() was implemented in such a way that a --huge-dir > option had to exactly match the mountpoint, but there's no reason for > this restriction: DPDK might not be the only user of hugepages, and > shouldn't assume it owns an entir

Re: [dpdk-dev] [PATCH v25 2/6] dmadev: add control plane API support

2021-10-12 Thread Thomas Monjalon
11/10/2021 09:33, Chengwen Feng: > +Device Configuration > + > + > +The rte_dma_configure API is used to configure a DMA device. > + > +.. code-block:: c > + > + int rte_dma_configure(int16_t dev_id, > + const struct rte_dma_conf *dev_conf); > + > +The

[dpdk-dev] [PATCH v2] build/ppc: enable build support for Power10

2021-10-12 Thread Thinh Tran
For native build, enabling building the highest cpu_instruction_set supported by the build host, including the new POWER10. For cross compile, verifying that the compiler supports the cpu_instruction_set specified in the cross-file Signed-off-by: Thinh Tran Reviewed-by: David Christensen v2:

Re: [dpdk-dev] [PATCH] test: remove autotest python wrapper

2021-10-12 Thread David Marchand
On Mon, Oct 11, 2021 at 3:11 PM Aaron Conole wrote: > > This tool was used in the past to execute unit tests with make. > > Meson has its own list of unit test, and its own way of calling them. > > > > Since the switch to meson only builds, there is nothing depending on the > > script in DPDK itse

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/service: fix race in attr check

2021-10-12 Thread David Marchand
On Mon, Oct 11, 2021 at 4:54 PM David Marchand wrote: > > The CI reported rare (and cryptic) failures like: > > RTE>>service_autotest > + --- + > + Test Suite : service core test suite > + --

Re: [dpdk-dev] [PATCH] test/service_cores: fix wrong comment

2021-10-12 Thread David Marchand
On Thu, Aug 19, 2021 at 10:13 AM Van Haaren, Harry wrote: > > > -Original Message- > > From: Joyce Kong > > Sent: Thursday, August 19, 2021 7:11 AM > > To: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > > ; honnappa.nagaraha...@arm.com; > > ruifeng.w...@arm.com > > Cc: dev@dpdk.org;

Re: [dpdk-dev] [kmods PATCH] windows/netuio: add interrupt support

2021-10-12 Thread William Tu
On Mon, Oct 11, 2021 at 6:11 PM Dmitry Kozlyuk wrote: > > Add IOCTL for interrupt event delivery to user space. > > * IOCTL_NETUIO_INTR_CONTROL: > Enable/disable the delivery of interrupt events. > This is a software switch to ignore received interrupts. > Programming the HW to stop issuing

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-12 Thread Thomas Monjalon
12/10/2021 18:59, Walker, Benjamin: > > From: dev On Behalf Of Thomas Monjalon > > 12/10/2021 02:35, Harris, James R: > > > On 10/11/21, 5:55 AM, "Thomas Monjalon" wrote: > > > > > > The meson option enable_driver_sdk is described as "Install headers > > > to build > > drivers." > > > S

[dpdk-dev] [PATCH v6 3/5] app/testpmd: dump port info for shared Rx queue

2021-10-12 Thread Xueming Li
In case of shared Rx queue, polling any member port returns mbufs for all members. This patch dumps mbuf->port for each packet. Signed-off-by: Xueming Li --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 51506e49404..e9

[dpdk-dev] [PATCH v6 5/5] app/testpmd: add forwarding engine for shared Rx queue

2021-10-12 Thread Xueming Li
To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build| 1 + app/test-pmd/share

[dpdk-dev] [PATCH v6 4/5] app/testpmd: force shared Rx queue polled on same core

2021-10-12 Thread Xueming Li
Shared Rx queue must be polled on same core. This patch checks and stops forwarding if shared RxQ being scheduled on multiple cores. It's suggested to use same number of Rx queues and polling cores. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 100 +

[dpdk-dev] [PATCH v6 1/5] ethdev: introduce shared Rx queue

2021-10-12 Thread Xueming Li
In current DPDK framework, each Rx queue is pre-loaded with mbufs to save incoming packets. For some PMDs, when number of representors scale out in a switch domain, the memory consumption became significant. Polling all ports also leads to high cache miss, high latency and low throughput. This pat

[dpdk-dev] [PATCH v6 0/5] ethdev: introduce shared Rx queue

2021-10-12 Thread Xueming Li
In current DPDK framework, all Rx queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high latency and low throughputs. This patch introd

[dpdk-dev] [PATCH v6 2/5] app/testpmd: new parameter to enable shared Rx queue

2021-10-12 Thread Xueming Li
Adds "--rxq-share=X" parameter to enable shared RxQ, share if device supports, otherwise fallback to standard RxQ. Share group number grows per X ports. X defaults to MAX, implies all ports join share group 1. Forwarding engine "shared-rxq" should be used which Rx only and update stream statistic

  1   2   3   4   >