[dpdk-dev] [PATCH v7 3/3] doc: remove i40evf related documentation

2021-09-23 Thread Robin Zhang
As announced in the deprecation note, i40evf has been removed. So removing deprecation notice and other i40evf related documentation. Signed-off-by: Robin Zhang --- doc/guides/howto/lm_bond_virtio_sriov.rst | 4 +-- doc/guides/nics/features/i40e_vf.ini | 40 --- doc/gui

[dpdk-dev] [PATCH v7 1/3] net/i40e: remove i40evf

2021-09-23 Thread Robin Zhang
The default VF driver for Intel 700 Series Ethernet Controller already switch to iavf in DPDK 21.05. And i40evf is no need to maintain now, so remove i40evf related code. Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_osdep.h |1 - drivers/net/i40e/i40e_ethdev.h | 78 +- dri

[dpdk-dev] [PATCH v7 2/3] net/iavf: remove i40evf devargs option

2021-09-23 Thread Robin Zhang
Due to i40evf will be removed, so there's no need to keep the devargs option "driver=i40evf" in iavf. Signed-off-by: Robin Zhang --- drivers/net/iavf/iavf_ethdev.c | 52 ++ 1 file changed, 2 insertions(+), 50 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev

[dpdk-dev] [PATCH v7 0/3] net/i40e: remove i40evf

2021-09-23 Thread Robin Zhang
In DPDK 21.05, iavf already became the default VF for i40e devices. So remove i40evf due to it's no need to maintain now. v7: - rebase code. v6: - remove i40e_vf struct and related code, remove doc i40e_vf.ini. v5: - rebase code. v4: - resolve compile warning issue. v3: - remove VF related cod

Re: [dpdk-dev] Not able to start IAVF PMD with dpdk 20.11.3

2021-09-23 Thread Dey, Souvik
With vfio_pci , I am getting the following error and bind itself is failing, due to probe fail with EINVAL. [root@connexip swe]# ./dpdk-devbind.py -b vfio_pci 08:00.0 Error: bind failed for :08:00.0 - Cannot open /sys/bus/pci/drivers/vfio_pci/bind Sep 24 01:50:29 connexip kernel: [ 323.37640

Re: [dpdk-dev] [PATCH] net/ice: fix double free ACL flow entry

2021-09-23 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Friday, September 24, 2021 1:41 PM > To: Yu, DapengX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/ice: fix double free ACL flow entry > > > > > -Original Message- > > From: Yu, Da

Re: [dpdk-dev] [PATCH] net/ice: retry getting VF VSI map after it fails

2021-09-23 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Tuesday, September 14, 2021 11:09 > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; > sta...@dpdk.org > Subject: [PATCH] net/ice: retry getting VF VSI map after it fails > > From: Dapeng Yu > > The requ

Re: [dpdk-dev] [PATCH] net/iavf: fix frequent command interaction leads to high cpu

2021-09-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Qiming Chen > Sent: Saturday, September 11, 2021 12:02 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Qiming Chen ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix frequent command interaction leads > to high cpu

Re: [dpdk-dev] [PATCH] net/ice: fix double free ACL flow entry

2021-09-23 Thread Su, Simei
> -Original Message- > From: Yu, DapengX > Sent: Friday, September 3, 2021 6:04 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Su, Simei ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix double free ACL flow entry > > From: Dapeng Yu > > If call ice_flow_r

[dpdk-dev] [PATCH v2] examples/vhost: fix use-after-free on drain vhost

2021-09-23 Thread Wenwu Ma
When a vdev is removed in destroy_device function, the corresponding vhost TX buffer will also be freed, but the vhost TX buffer may still be used in the drain_vhost function, which will cause an error of heap-use-after-free. Therefore, before accessing vhost TX buffer, we need to check whether the

Re: [dpdk-dev] [PATCH] net/ice: enable Rx timestamp on Flex Descriptor

2021-09-23 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Saturday, September 18, 2021 2:57 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Su, Simei > > Subject: [PATCH] net/ice: enable Rx timestamp on Flex Descriptor > > Use the dynamic mbuf to register timestamp field and flag. > The

[dpdk-dev] [PATCH] net/bnxt: improve error recovery information messages

2021-09-23 Thread Kalesh A P
From: Kalesh AP The error recovery async event messages are often mistaken for errors. Improved the wording to clarify the meaning of these events. Also, take the first step towards more inclusive language. The references to master will be changed to primary. For example: "bnxt_is_master_func" wi

[dpdk-dev] [PATCH v6 5/9] baseband/la12xx: add queue and modem config support

2021-09-23 Thread nipun . gupta
From: Hemant Agrawal This patch add support for connecting with modem and creating the ipc channel as queues with modem for the exchange of data. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS| 1 + doc/guides/bbdevs/index.rst

[dpdk-dev] [PATCH v6 9/9] app/bbdev: add test vectors for transport blocks

2021-09-23 Thread nipun . gupta
From: Nipun Gupta This patch adds two test vectors for transport block in network byte order: - LDPC encode for Transport Block - LDPC decode for Transport block Signed-off-by: Nipun Gupta --- app/test-bbdev/test_vectors/ldpc_dec_tb.data | 265 +++ app/test-bbdev/test_vectors/l

[dpdk-dev] [PATCH v6 6/9] baseband/la12xx: add enqueue and dequeue support

2021-09-23 Thread nipun . gupta
From: Hemant Agrawal Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- doc/guides/bbdevs/features/la12xx.ini | 13 + doc/guides/bbdevs/la12xx.rst | 47 ++- drivers/baseband/la12xx/bbdev

[dpdk-dev] [PATCH v6 8/9] app/bbdev: handle endianness of test data

2021-09-23 Thread nipun . gupta
From: Nipun Gupta With data input, output and harq also supported in big endian format, this patch updates the testbbdev application to handle the endianness conversion as directed by the the driver being used. If the driver supports big endian data processing, conversion from little endian to b

[dpdk-dev] [PATCH v6 4/9] baseband/la12xx: add support for multiple modems

2021-09-23 Thread nipun . gupta
From: Hemant Agrawal This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 64 +++--- drivers/baseband/la12xx/bbdev_la12xx.h | 56 +++ d

[dpdk-dev] [PATCH v6 7/9] app/bbdev: enable la12xx for bbdev

2021-09-23 Thread nipun . gupta
From: Hemant Agrawal this patch adds la12xx driver in test bbdev Signed-off-by: Hemant Agrawal --- app/test-bbdev/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build index edb9deef84..a726a5b3fa 100644 --- a/app/test-bbdev/

[dpdk-dev] [PATCH v6 3/9] baseband/la12xx: add devargs for max queues

2021-09-23 Thread nipun . gupta
From: Hemant Agrawal This patch adds dev args to take max queues as input Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12x

[dpdk-dev] [PATCH v6 2/9] baseband: introduce NXP LA12xx driver

2021-09-23 Thread nipun . gupta
From: Hemant Agrawal This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS | 9 ++ drivers/baseband/la12xx/bbdev_la12xx.c| 1

[dpdk-dev] [PATCH v6 0/9] baseband: add NXP LA12xx driver

2021-09-23 Thread nipun . gupta
From: Nipun Gupta This series introduces the BBDEV LA12xx poll mode driver (PMD) to support an implementation for offloading High Phy processing functions like LDPC Encode / Decode 5GNR wireless acceleration function, using PCI based LA12xx Software defined radio. Please check the documentation

[dpdk-dev] [PATCH v6 1/9] bbdev: add big endian processing data processing info

2021-09-23 Thread nipun . gupta
From: Nipun Gupta This patch intoduces a new info pertaining to bbdev device to process the data in big endian order. Signed-off-by: Nipun Gupta --- lib/bbdev/rte_bbdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index 7017124414..3acc0

[dpdk-dev] Minutes of Technical Board Meeting, 2021-Sep-22

2021-09-23 Thread Jerin Jacob Kollanukkaran
Minutes of Technical Board Meeting, 2021-Sep-22 Members Attending - -Aaron -Bruce -Ferruh -Hemant -Honnappa -Jerin (Chair) -Kevin -Konstantin -Maxime -Olivier -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meeti

Re: [dpdk-dev] [PATCH v2 4/6] examples/ioat: port application to dmadev APIs

2021-09-23 Thread fengchengwen
On 2021/9/18 0:41, Kevin Laatz wrote: > The dmadev library abstraction allows applications to use the same APIs for > all DMA device drivers in DPDK. This patch updates the ioatfwd application > to make use of the new dmadev APIs, in turn making it a generic application > which can be used with any

[dpdk-dev] [PATCH v4 2/2] lib/pipeline: Fix gcc compilation error using ASan

2021-09-23 Thread zhihongx . peng
From: Zhihong Peng After adding ASan, the gcc compilation check will be stricter. "Control reaches end of non-void function" error occurs here. Fixes: f38913b7fb8e (pipeline: add meter array to SWX) Cc: sta...@dpdk.org Signed-off-by: Xueqin Lin Signed-off-by: Zhihong Peng --- lib/pipeline/rt

[dpdk-dev] [PATCH v4 1/2] Enable ASan for memory detector on DPDK

2021-09-23 Thread zhihongx . peng
From: Zhihong Peng AddressSanitizer (ASan) is a google memory error detect standard tool. It could help to detect use-after-free and {heap,stack,global}-buffer overflow bugs in C/C++ programs, print detailed error information when error happens, large improve debug efficiency. By referring to it

[dpdk-dev] [PATCH v4 2/2] lib/pipeline: Fix gcc compilation error using ASan

2021-09-23 Thread zhihongx . peng
From: Zhihong Peng After adding ASan, the gcc compilation check will be stricter. "Control reaches end of non-void function" error occurs here. Fixes: f38913b7fb8e (pipeline: add meter array to SWX) Cc: sta...@dpdk.org Signed-off-by: Xueqin Lin Signed-off-by: Zhihong Peng --- lib/pipeline/rt

[dpdk-dev] [PATCH v4 1/2] Enable ASan for memory detector on DPDK

2021-09-23 Thread zhihongx . peng
From: Zhihong Peng AddressSanitizer (ASan) is a google memory error detect standard tool. It could help to detect use-after-free and {heap,stack,global}-buffer overflow bugs in C/C++ programs, print detailed error information when error happens, large improve debug efficiency. By referring to it

Re: [dpdk-dev] [PATCH] examples/vhost: fix use-after-free on drain vhost

2021-09-23 Thread Xia, Chenbo
Hi Wenwu, > -Original Message- > From: Ma, WenwuX > Sent: Friday, September 24, 2021 4:30 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, Jiayu > ; Yang, YvonneX ; Ma, WenwuX > > Subject: [PATCH] examples/vhost: fix use-after-free on drain vhost > > When a vdev

[dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost

2021-09-23 Thread Miao Li
In l3fwd-power, there is default port configuration which requires RSS and IPV4/UDP/TCP checksum. Once device does not support these, the l3fwd-power will exit and report an error. This patch updates the port configuration based on device capabilities after getting the device information to support

[dpdk-dev] [PATCH v3 4/5] power: modify return of queue_stopped

2021-09-23 Thread Miao Li
Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_stopped when rte_eth_rx_queue_info_get r

[dpdk-dev] [PATCH v3 3/5] net/vhost: implement rte_power_monitor API

2021-09-23 Thread Miao Li
This patch implements rte_power_monitor API in vhost PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and vhost_get_mo

[dpdk-dev] [PATCH v3 2/5] vhost: implement rte_power_monitor API

2021-09-23 Thread Miao Li
This patch defines rte_vhost_power_monitor_cond which is used to pass some information to vhost driver. The information is including the address to monitor, the expected value, the mask to extract value read from 'addr', the value size of monitor address, the match flag used to distinguish the valu

[dpdk-dev] [PATCH v3 1/5] net/virtio: implement rte_power_monitor API

2021-09-23 Thread Miao Li
This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_

[dpdk-dev] [PATCH v3 0/5] Implement rte_power_monitor API in virtio/vhost PMD

2021-09-23 Thread Miao Li
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). v3: -fix

Re: [dpdk-dev] [PATCH v2 2/2] vhost: enable IOMMU for async vhost

2021-09-23 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, September 23, 2021 10:56 PM > To: Hu, Jiayu ; Ding, Xuan ; > dev@dpdk.org; Burakov, Anatoly ; Xia, Chenbo > > Cc: Jiang, Cheng1 ; Richardson, Bruce > ; Pai G, Sunil ; Wang, > Yinan ; Yang, YvonneX > Subject: Re: [PATCH v2 2/2

Re: [dpdk-dev] Not able to start IAVF PMD with dpdk 20.11.3

2021-09-23 Thread Wu, Jingjing
Could you have a try to switch from uio_pci_generic to vfio_pci? From: Dey, Souvik Sent: Thursday, September 23, 2021 11:29 PM To: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing Subject: Not able to start IAVF PMD with dpdk 20.11.3 Hi All, Trying to test E810 Sr-IOV based nic card with 20.11.

Re: [dpdk-dev] [PATCH] lib: remove sched.h from public headers

2021-09-23 Thread William Tu
On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk wrote: > > Public headers including POSIX-specific were unusable > on Windows. These includes were superfluous, remove them. > > Signed-off-by: Dmitry Kozlyuk > --- Write a program, include rte_eal.h, link with DPDK library, then hit the issue. Ver

[dpdk-dev] [PATCH v3 2/2] event/cnxk: add external clock support for timer

2021-09-23 Thread pbhagavatula
From: Pavan Nikhilesh Add external clock support for cnxk timer adapter. External clock mapping is as follows: RTE_EVENT_TIMER_ADAPTER_EXT_CLK0 = TIM_CLK_SRC_10NS, RTE_EVENT_TIMER_ADAPTER_EXT_CLK1 = TIM_CLK_SRC_GPIO, RTE_EVENT_TIMER_ADAPTER_EXT_CLK2 = TIM_CLK_SRC_PTP, RTE_EVENT_TIMER_ADAPTER_EXT

[dpdk-dev] [PATCH v3 1/2] event/cnxk: update min interval calculation

2021-09-23 Thread pbhagavatula
From: Pavan Nikhilesh Minimum supported interval should now be retrieved from mailbox based on the clock source and clock frequency. Signed-off-by: Pavan Nikhilesh --- v3: - Add new mbox interface. v2: - Fixed devargs parsing and rebased. drivers/common/cnxk/roc_mbox.h | 17 +++ driv

Re: [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory

2021-09-23 Thread spyroot
The second issue is in CONFIG_RSS_LUT. That *VIRTCHNL_OP_CONFIG_RSS_LUT* ; is optional so if it returns ret it must be handled correctly. int *iavf_configure_rss_lut*

[dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory

2021-09-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=814 Bug ID: 814 Summary: Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory Product: DPDK Version: 20.11 Hardware: All OS: All S

Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-23 Thread Tal Shnaiderman
> Subject: [PATCH] bus/pci: fix numa node return value > > External email: Use caution opening links or attachments > > > On older CPUs, currently numa_node returns value only for socket 0. > Instead, application should be able to make correct decision and also to keep > consistent with the Linu

[dpdk-dev] [Bug 813] Linking error with DPDK 17.11.4 during compilation

2021-09-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=813 Bug ID: 813 Summary: Linking error with DPDK 17.11.4 during compilation Product: DPDK Version: 17.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major

Re: [dpdk-dev] [PATCH v6 08/10] ipsec: add support for SA telemetry

2021-09-23 Thread Ananyev, Konstantin
> Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > --- > lib/ipsec/esp_inb.c | 1 + > lib/ipsec/esp_outb.c | 12 +- > lib/ipsec/meson.build | 2 +- > lib/ipsec/rte_ipsec.h |

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Stephen Hemminger
On Thu, 23 Sep 2021 16:11:42 + "Pattan, Reshma" wrote: > > > > +* Similar behavior to rte_bpf_eth callback. > > +* if BPF program returns zero value for a given packet, > > +* then it will be ignored. > > +*/ > Looks like wrong callback name

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Stephen Hemminger
On Thu, 23 Sep 2021 16:11:42 + "Pattan, Reshma" wrote: > > struct pdump_request { > > + uint16_t flags; > Why is the flags type changed from unit32_t unint16_t? Only to pack the structure. They were unused.

[dpdk-dev] [PATCH v3] net/af_packet: remove timestamp from packet status

2021-09-23 Thread Tudor Cornea
We should eliminate the timestamp status from the packet status. This should only matter if timestamping is enabled on the socket, but we might hit a kernel bug, which is fixed in newer releases. For interfaces of type 'veth', the sent skb is forwarded to the peer and back into the network stack w

Re: [dpdk-dev] [PATCH] cryptodev: build on Windows

2021-09-23 Thread Kadam, Pallavi
On 9/13/2021 10:16 AM, Tal Shnaiderman wrote: Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman --- Acked-by: Pallavi Kadam

[dpdk-dev] RTE_REGISTER_BUS does not work on Windows

2021-09-23 Thread William Tu
Hi, I'm trying to run OVS-DPDK on Windows (building OVS binaries and statically link DPDK windows library), and it doesn't work due to rte_bus_scan() find no available devices. (However, when using dpdk-testpmd.exe, it finds the device successfully) I realized that the PCI bus driver calls RTE_RE

Re: [dpdk-dev] [PATCH] metrics: promote metrics deinitialize API

2021-09-23 Thread Thomas Monjalon
03/09/2021 15:09, Kinsella, Ray: > > On 03/09/2021 14:08, Harman Kalra wrote: > > Remove experimental flag from rte_metrics_deinit(). > > This API was introduced in 19.11 release. > > > > Signed-off-by: Harman Kalra > > Acked-by: Ray Kinsella Sorted function in .map in alphabetical order, app

Re: [dpdk-dev] [PATCH] eal/windows: fix token pasting build warning

2021-09-23 Thread Thomas Monjalon
15/09/2021 21:25, Dmitry Kozlyuk: > 2021-09-13 19:55 (UTC+0300), Tal Shnaiderman: > > When building DPDK on Windows in debug mode the following > > warning appear: > > > > warning: token pasting of ',' and __VA_ARGS__ is a GNU extension > > [-Wgnu-zero-variadic-macro-arguments] #define open(path,

Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-23 Thread Thomas Monjalon
23/09/2021 17:44, Tal Shnaiderman: > > Subject: [PATCH] bus/pci: fix numa node return value > > > > On older CPUs, currently numa_node returns value only for socket 0. > > Instead, application should be able to make correct decision and also to > > keep > > consistent with the Linux code, replace

Re: [dpdk-dev] [PATCH 1/5] compressdev: rename fields for Windows compatibility

2021-09-23 Thread Thomas Monjalon
15/09/2021 23:40, Dmitry Kozlyuk: > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -662,6 +662,9 @@ API Changes > * sched: Removed ``tb_rate``, ``tc_rate``, ``tc_period`` and ``tb_size`` >from ``struct rte_sched_subport_params``. > > +* compr

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Stephen Hemminger
On Thu, 23 Sep 2021 16:11:42 + "Pattan, Reshma" wrote: > > +/* > > + * Note: version numbers intentionally start at 3 > > + * in order to catch any application built with older out > > + * version of DPDK using incompatible client request format. > > + */ > > enum pdump_version { > > - V1

Re: [dpdk-dev] [PATCH] net/virtio: fix virtio-user init when using existing tap

2021-09-23 Thread David Marchand
On Thu, Sep 23, 2021 at 5:39 PM Olivier Matz wrote: > > Hi David, > > On Fri, Sep 17, 2021 at 11:33:44AM +0200, David Marchand wrote: > > When attaching to an existing mono queue tap, the virtio-user was not > > reporting that the virtio device was not properly initialised which > > prevented from

Re: [dpdk-dev] [PATCH v6 07/10] ipsec: add support for NAT-T

2021-09-23 Thread Ananyev, Konstantin
> > Add support for the IPsec NAT-Traversal use case for Tunnel mode > packets. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > --- > lib/ipsec/iph.h | 17 ++

Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen

2021-09-23 Thread Kevin Traynor
On 30/08/2021 11:42, Thomas Monjalon wrote: A lot of flags are parts of a group but are documented alone. The Doxygen syntax @{ and @} for grouping is used to make flags appear together and have a common description. Some Rx/Tx offload flags and RSS definitions are not grouped because they need

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > > +++ b/lib/meson.build > +'bpf', > 'bitratestats', If alphabetical order, should bpf come after bitratestats? > +/* > + * Note: version numbers intentionally start at 3 > + * in order to catch any ap

Re: [dpdk-dev] [PATCH v2 1/9] drivers/crypto: introduce IPsec-mb framework

2021-09-23 Thread Thomas Monjalon
23/09/2021 17:28, Ciara Power: > From: Fan Zhang > > This patch introduces the new framework making > all common code of SW crypto PMDs implementations built on top of > intel-ipsec-mb library shareable, also helps to reduce future effort > on the code maintenance and feature updates. Which PMD

Re: [dpdk-dev] [PATCH] net/virtio: fix virtio-user init when using existing tap

2021-09-23 Thread Olivier Matz
Hi David, On Fri, Sep 17, 2021 at 11:33:44AM +0200, David Marchand wrote: > When attaching to an existing mono queue tap, the virtio-user was not > reporting that the virtio device was not properly initialised which > prevented from starting the port later. > > $ ip tuntap add test mode tap > $ d

Re: [dpdk-dev] [PATCH v2 1/6] examples/ioat: always use same lcore for both DMA requests enqueue and dequeue

2021-09-23 Thread Kevin Laatz
On 20/09/2021 12:24, Conor Walsh wrote: From: Konstantin Ananyev Few changes in ioat sample behaviour: - Always do SW copy for packet metadata (mbuf fields) - Always use same lcore for both DMA requests enqueue and dequeue Main reasons for that: a) it is safer, as idxd PMD doesn't support MT

[dpdk-dev] Not able to start IAVF PMD with dpdk 20.11.3

2021-09-23 Thread Dey, Souvik
Hi All, Trying to test E810 Sr-IOV based nic card with 20.11.3 dpdk. I am running the host kernel driver and only the VF is attached to the VM where I am running dpdk. But when I attaching the VF to the testpmd it is throwing the below error. Is there are way to move forward here ? [root@c

[dpdk-dev] [PATCH v2 9/9] doc/rel_notes: added note for SW Crypto PMD change

2021-09-23 Thread Ciara Power
The SW Crypto PMDs were consolidated into one IPSec_MB PMD. This patch adds a release note to highlight this change. Signed-off-by: Ciara Power --- doc/guides/rel_notes/release_21_11.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/

[dpdk-dev] [PATCH v2 8/9] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-09-23 Thread Ciara Power
From: Kai Ji Add in new chacha20_poly1305 support in ipsec_mb. Add in new chacha20_poly1305 test vector for SGL test. Signed-off-by: Kai Ji Signed-off-by: Ciara Power --- v2: - Added unused tag to session configure parameter. - Added release note. - Added documentation for PMD. --- app

[dpdk-dev] [PATCH v2 7/9] drivers/crypto: move zuc PMD to IPsec-mb framework

2021-09-23 Thread Ciara Power
From: Piotr Bronowski This patch removes the crypto/zuc folder and gathers all zuc PMD implementation specific details into a single file, pmd_zuc.c in the crypto/ipsec_mb folder. Signed-off-by: Piotr Bronowski Signed-off-by: Ciara Power --- v2: Updated maintainers file. --- MAINTAINERS

[dpdk-dev] [PATCH v2 6/9] crypto/ipsec_mb: add snow3g digest appended ops support

2021-09-23 Thread Ciara Power
From: Piotr Bronowski This patch enables out-of-place auth-cipher operations where digest should be encrypted along with the rest of raw data. It also adds support for partially encrypted digest when using auth-cipher operations. Signed-off-by: Damian Nowak Signed-off-by: Kai Ji Signed-off-by:

[dpdk-dev] [PATCH v2 5/9] drivers/crypto: move snow3g PMD to IPsec-mb framework

2021-09-23 Thread Ciara Power
From: Piotr Bronowski This patch removes the crypto/snow3g folder and gathers all snow3g PMD implementation specific details into a single file, pmd_snow3g.c in the crypto/ipsec_mb folder. Signed-off-by: Piotr Bronowski Signed-off-by: Ciara Power --- v2: Updated maintainers file. --- MAINTAI

[dpdk-dev] [PATCH v2 4/9] drivers/crypto: move kasumi PMD to IPsec-mb framework

2021-09-23 Thread Ciara Power
From: Piotr Bronowski This patch removes the crypto/kasumi folder and gathers all kasumi PMD implementation specific details into a single file, pmd_kasumi.c in the crypto/ipsec_mb folder. Signed-off-by: Piotr Bronowski Signed-off-by: Ciara Power --- v2: Updated maintainers file. --- MAINTAI

[dpdk-dev] [PATCH v2 3/9] drivers/crypto: move aesni-gcm PMD to IPsec-mb framework

2021-09-23 Thread Ciara Power
From: Piotr Bronowski This patch removes the crypto/aesni_gcm folder and gathers all aesni-gcm PMD implementation specific details into a single file, pmd_aesni_gcm.c in the crypto/ipsec_mb folder. A redundant check for iv length is removed. Signed-off-by: Piotr Bronowski Signed-off-by: Ciara P

[dpdk-dev] [PATCH v2 2/9] drivers/crypto: move aesni-mb PMD to IPsec-mb framework

2021-09-23 Thread Ciara Power
From: Piotr Bronowski This patch removes the crypto/aesni_mb folder and gathers all aesni-mb PMD implementation specific details into a single file, pmd_aesni_mb.c in crypto/ipsec_mb. Signed-off-by: Piotr Bronowski Signed-off-by: Ciara Power --- v2: Updated maintainers file. --- MAINTAINERS

[dpdk-dev] [PATCH v2 1/9] drivers/crypto: introduce IPsec-mb framework

2021-09-23 Thread Ciara Power
From: Fan Zhang This patch introduces the new framework making all common code of SW crypto PMDs implementations built on top of intel-ipsec-mb library shareable, also helps to reduce future effort on the code maintenance and feature updates. Signed-off-by: Fan Zhang Signed-off-by: Ciara Power

[dpdk-dev] [PATCH v2 0/9] drivers/crypto: introduce ipsec_mb framework

2021-09-23 Thread Ciara Power
This set of patches introduces a new framework, making all common code of SW crypto PMD implementations built on top of intel-ipsec-mb library sharable. This helps to reduce future effort on the code maintenance and future updates. It also moves all SW PMD implementation specific details into singl

Re: [dpdk-dev] [PATCH v2 2/2] vhost: enable IOMMU for async vhost

2021-09-23 Thread Maxime Coquelin
On 9/23/21 16:39, Hu, Jiayu wrote: Hi Xuan, -Original Message- From: Ding, Xuan Sent: Friday, September 17, 2021 1:26 PM To: dev@dpdk.org; Burakov, Anatoly ; maxime.coque...@redhat.com; Xia, Chenbo Cc: Hu, Jiayu ; Jiang, Cheng1 ; Richardson, Bruce ; Pai G, Sunil ; Wang, Yinan ; Yan

Re: [dpdk-dev] [PATCH v2 2/2] vhost: enable IOMMU for async vhost

2021-09-23 Thread Hu, Jiayu
Hi Xuan, > -Original Message- > From: Ding, Xuan > Sent: Friday, September 17, 2021 1:26 PM > To: dev@dpdk.org; Burakov, Anatoly ; > maxime.coque...@redhat.com; Xia, Chenbo > Cc: Hu, Jiayu ; Jiang, Cheng1 ; > Richardson, Bruce ; Pai G, Sunil > ; Wang, Yinan ; Yang, > YvonneX ; Ding, Xuan

Re: [dpdk-dev] [PATCH v6 06/10] ipsec: add transmit segmentation offload support

2021-09-23 Thread Ananyev, Konstantin
> Add support for transmit segmentation offload to inline crypto processing > mode. This offload is not supported by other offload modes, as at a > minimum it requires inline crypto for IPsec to be supported on the > network interface. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Ni

Re: [dpdk-dev] [PATCH v2 0/6] port ioatfwd app to dmadev

2021-09-23 Thread Kevin Laatz
Hi Chengwen, On 23/09/2021 14:53, fengchengwen wrote: Hi Kevin, Can you add the following functions? 1. Add dump dmadev which trigger by signal, like: ... static void dma_dump(void) { uint32_t i, j; if (copy_mode != COPY_MODE_DMA_NUM) return;

Re: [dpdk-dev] [PATCH v2 0/6] port ioatfwd app to dmadev

2021-09-23 Thread fengchengwen
Hi Kevin, Can you add the following functions? 1. Add dump dmadev which trigger by signal, like: ... static void dma_dump(void) { uint32_t i, j; if (copy_mode != COPY_MODE_DMA_NUM) return; for (i = 0; i < cfg.nb_ports; i++) { for (j

Re: [dpdk-dev] [PATCH v4 0/5] Add lookaside IPsec tests

2021-09-23 Thread Power, Ciara
Hi Anoob, >-Original Message- >From: Anoob Joseph >Sent: Friday 17 September 2021 14:15 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; >Ananyev, Konstantin >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara >;

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-23 Thread fengchengwen
On 2021/9/23 1:29, Jerin Jacob wrote: > On Wed, Sep 22, 2021 at 10:06 PM Bruce Richardson > wrote: >> >> On Wed, Sep 22, 2021 at 08:56:50AM +0100, Bruce Richardson wrote: >>> On Wed, Sep 22, 2021 at 09:51:42AM +0800, fengchengwen wrote: On 2021/9/22 2:11, Jerin Jacob wrote: > On Tue, Sep

[dpdk-dev] app/testpmd: [RFC] Create flex item object

2021-09-23 Thread Gregory Etelson
app/testpmd: [RFC] Create flex item object RTE flex item infrastructure allows application to create a parser for custom network header in port hardware and offload flow rules to match the custom protocol elements. RTE flex item API was introduced in https://patchwork.dpdk.org/project/dpdk/patch/2

Re: [dpdk-dev] [PATCH v6 05/10] ipsec: add support for AEAD algorithms

2021-09-23 Thread Ananyev, Konstantin
> > Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. I think it would be good to add new test-cases to examples/ipsec-secgw/test harness to cover these new algs supported. Apart from that: Acked-by: Konstantin Ananyev > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau

Re: [dpdk-dev] [PATCH v6 04/10] mbuf: add IPsec ESP tunnel type

2021-09-23 Thread Ananyev, Konstantin
> > Add tunnel type for IPsec ESP tunnels > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > Acked-by: Akhil Goyal > Acked-by: Olivier Matz > --- > lib/mbuf/rte_mbuf_core.h | 1 + >

Re: [dpdk-dev] [PATCH v6 03/10] security: add ESN field to ipsec_xform

2021-09-23 Thread Ananyev, Konstantin
> > Update ipsec_xform definition to include ESN field. > This allows the application to control the ESN starting value. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > Acked-by: A

[dpdk-dev] [PATCH V2 1/2] app/testpmd: add tunnel types

2021-09-23 Thread Eli Britstein
Current testpmd implementation supports VXLAN only for tunnel offload. Add GRE, NVGRE and GENEVE for tunnel offload flow matches. For example: testpmd> flow tunnel create 0 type vxlan port 0: flow tunnel #1 type vxlan testpmd> flow tunnel create 0 type nvgre port 0: flow tunnel #2 type nvgre testp

[dpdk-dev] [PATCH V2 2/2] net/mlx5: add support for more tunnel types

2021-09-23 Thread Eli Britstein
Accept RTE_FLOW_ITEM_TYPE_GRE, RTE_FLOW_ITEM_TYPE_NVGRE and RTE_FLOW_ITEM_TYPE_GENEVE as valid tunnel types. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Cc: sta...@dpdk.org Signed-off-by: Eli Britstein --- drivers/net/mlx5/mlx5_flow.c | 3 +++ 1 file changed, 3 insertions(+) dif

Re: [dpdk-dev] [PATCH v6 02/10] security: add UDP params for IPsec NAT-T

2021-09-23 Thread Ananyev, Konstantin
> Add support for specifying UDP port params for UDP encapsulation option. > RFC3948 section-2.1 does not enforce using specific the UDP ports for > UDP-Encapsulated ESP Header > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Dani

Re: [dpdk-dev] [PATCH v6 01/10] security: add support for TSO on IPsec session

2021-09-23 Thread Ananyev, Konstantin
> Allow user to provision a per security session maximum segment size > (MSS) for use when Transmit Segmentation Offload (TSO) is supported. > The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG > ol_flags are specified in mbuf. > > Signed-off-by: Declan Doherty > Signed-off-by: Ra

Re: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process

2021-09-23 Thread Loftus, Ciara
> > > > > > > > > > Doing basic operations like info_get or get_stats was broken > > > > > in af_xdp PMD. The info_get would crash because dev->device > > > > > was NULL in secondary process. Fix this by doing same initialization > > > > > as af_packet and tap devices. > > > > > > > > > > The get_s

[dpdk-dev] [dpdk-announce] DMARC mitigation in dpdk.org's mailing list

2021-09-23 Thread Ali Alnubani
Hi all, Due to the changes that Mailman (our mailing list software) does to posts before distributing them, DKIM and DMARC verification will fail for emails originating from the domains that support them. This causes some posts to go into spam/quarantine and sometimes completely discarded depen

[dpdk-dev] [PATCH 1/2] vdpa/mlx5: workaround FW first completion in start

2021-09-23 Thread Xueming Li
After a vDPA application restart, qemu restores VQ with used and available index, new incoming packet triggers virtio driver to handle buffers. Under heavy traffic, no available buffer for firmware to receive new packets, no Rx interrupts generated, driver is stuck on endless interrupt waiting. As

[dpdk-dev] [PATCH 2/2] vdpa/mlx5: retry VAR allocation during vDPA restart

2021-09-23 Thread Xueming Li
VAR is the device memory space for the virtio queues doorbells, qemu could mmap it to directly to speed up doorbell push. On a busy system, Qemu takes time to release VAR resources during driver shutdown. If vdpa restarted quickly, the VAR allocation failed with error 28 since the VAR is singleton

Re: [dpdk-dev] [PATCH v3] telemetry: add support for dicts of dicts

2021-09-23 Thread Thomas Monjalon
15/09/2021 10:30, Power, Ciara: > >From: Nicolau, Radu > > > >Add support for dicts of dicts to telemetry library. > >Increase the max string size to 128. > > > >Signed-off-by: Declan Doherty > >Signed-off-by: Radu Nicolau > >--- > > app/test/test_telemetry_data.c | 29 > >li

[dpdk-dev] [PATCH v2 1/2] sched: adds function to get 64 bits greatest common divisor

2021-09-23 Thread Xueming Li
This patch adds new function that compute the greatest common divisor of 64 bits, also changes the original 32 bits function to call this new 64 bits version. Signed-off-by: Xueming Li Cc: sta...@dpdk.org --- lib/sched/rte_sched_common.h | 15 --- 1 file changed, 12 insertions(+), 3

[dpdk-dev] [PATCH v2 0/2] sched: adds function to get 64 bits greatest common divisor

2021-09-23 Thread Xueming Li
Adds 64bit version of GCD. v1: keep both 32 and 64 bit version v2: - update 32bit function comments - add mlx5 patch Xueming Li (2): sched: adds function to get 64 bits greatest common divisor vdpa/mlx5: fix large VM memory region registration drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 6 +++---

[dpdk-dev] [PATCH v2 2/2] vdpa/mlx5: fix large VM memory region registration

2021-09-23 Thread Xueming Li
When VM size larger than 4G(u32) and memory region larger than 4G, the 32 bits GCD function overflow and returned wrong value that resulted memory registration failed. This patch calls 64 bits GCD function to avoid overflow. Fixes: cc07a42da250 ("vdpa/mlx5: prepare memory regions") Cc: ma...@mell

Re: [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide

2021-09-23 Thread Thomas Monjalon
15/09/2021 17:04, David Marchand: > On Wed, Sep 15, 2021 at 11:50 AM Bruce Richardson > wrote: > > > > Add a note for the preference of using "()" rather than "\" for line > > continuations in meson. > > > > Suggested-by: David Marchand > > Signed-off-by: Bruce Richardson > > Reviewed-by: David

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-23 Thread Anoob Joseph
Hi Ciara, I'm planning to send next version addressing Akhil's comments. Can you review and ack patches if you don't have further comments? Thanks, Anoob > -Original Message- > From: Power, Ciara > Sent: Thursday, September 23, 2021 4:57 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty,

Re: [dpdk-dev] [PATCH] vhost: merge repeated loop in vhost Tx

2021-09-23 Thread Maxime Coquelin
On 9/10/21 11:05, Gaoxiang Liu wrote: To improve performance of vhost Tx, merge repeated loop in eth_vhost_tx. Move "vlan insert" from eth_vhost_tx to virtio_dev_rx_packed and virtio_dev_rx_split to reduce a loop iteration. Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software

Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests

2021-09-23 Thread Power, Ciara
Hi Anoob, >-Original Message- >From: Anoob Joseph >Sent: Thursday 23 September 2021 12:09 >To: Power, Ciara ; Akhil Goyal >; Doherty, Declan ; Zhang, >Roy Fan ; Ananyev, Konstantin > >Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti >; Tejasree Kondoj ; >Hemant Agrawal ; Nicolau, Radu >

  1   2   >