On Thu, 23 Sep 2021 16:11:42 +0000 "Pattan, Reshma" <reshma.pat...@intel.com> wrote:
> > +/* > > + * Note: version numbers intentionally start at 3 > > + * in order to catch any application built with older out > > + * version of DPDK using incompatible client request format. > > + */ > > enum pdump_version { > > - V1 = 1 > > + PDUMP_CLIENT_LEGACY = 3, > > + PDUMP_CLIENT_PCAPNG = 4, > The version numbering was internal to library, applications do not have > control over it, can't we start enumeration from 1? Although, DPDK does not support mixing versions between primary/secondary process. Someone is sure to try. I wanted to make sure that if user did something invalid like using old pdump (built with DPDK 20.11) and new application that it would fail in a direct manner.