Re: [dpdk-dev] [PATCH] net/iavf: support FDIR L3 fields for IP fragment packets

2021-08-16 Thread Wu, Wenjun1
Hi Ferruh, I am sorry my description caused confusion. I will split this patch into two, rework the commit log and send it later. > -Original Message- > From: Yigit, Ferruh > Sent: Friday, August 13, 2021 10:00 PM > To: Wu, Wenjun1 ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei ; Zhang,

Re: [dpdk-dev] [PATCH] version: 21.11-rc0

2021-08-16 Thread David Marchand
On Sun, Aug 8, 2021 at 9:27 PM Thomas Monjalon wrote: > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > new file mode 100644 > index 00..d707a554ef > --- /dev/null > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -0,0 +1,136 @@ [snip]

Re: [dpdk-dev] [PATCH v1 1/2] net/iavf: remove redundant default RSS field for IP fragment packets

2021-08-16 Thread Wu, Wenjun1
Hi Ferruh, This patch removes support of IPID for both IPv4 and IPv6 fragment packets, because it is not expected in default RSS. The impact is that IPID will not be used to calculate the hash value in default RSS for IP fragment packet. I will rework commit log and send v2 patch later. >

Re: [dpdk-dev] [PATCH] examples/vhost: fix memory leak on forwarding packets.

2021-08-16 Thread Jiang, Cheng1
Acked-by: Cheng Jiang > -Original Message- > From: Ma, WenwuX > Sent: Wednesday, August 18, 2021 1:13 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Jiang, Cheng1 ; Hu, Jiayu ; > Ma, WenwuX ; sta...@dpdk.org > Subject: [PATCH] examples/vhost: fix memory leak o

[dpdk-dev] [PATCH] examples/vhost: fix memory leak on forwarding packets.

2021-08-16 Thread Wenwu Ma
In function virtio_tx_local(), when the device receiving the packet is the same as the device to which the packet is forwarded, or the device is removed, we return but not free the packet, it will cause a memory leak. Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: s

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-16 Thread Stephen Hemminger
On Tue, 17 Aug 2021 08:57:18 +0530 wrote: > From: Jerin Jacob > > Introducing oops handling API with following specification > and enable stub implementation for Linux and FreeBSD. > > On rte_eal_init() invocation, the EAL library installs the > oops handler for the essential signals. > The rt

Re: [dpdk-dev] [PATCH v2 2/6] eal: oops handling API implementation

2021-08-16 Thread Stephen Hemminger
On Tue, 17 Aug 2021 08:57:19 +0530 wrote: > +#define oops_print(...) rte_log(RTE_LOG_ERR, RTE_LOGTYPE_EAL, __VA_ARGS__) It is problematic to call rte_log from a signal handler. The malloc pool maybe corrupted and rte_log can call functions that use malloc. Even rte_dump_stack() is unsafe from t

[dpdk-dev] [PATCH] net/ice: fix wrong rxdid

2021-08-16 Thread Qi Zhang
Since DPDK 20.11 the default rxdid is changed from 16 to 22, but the DCF data path didn't change, the patch fix the gap. Fixes: 12443386a0b0 ("net/ice: support flex Rx descriptor RxDID22") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c | 6 +++--- 1 file changed, 3 in

[dpdk-dev] [PATCH v2 6/6] test/oops: support unit test case for oops handling APIs

2021-08-16 Thread jerinj
From: Jerin Jacob Added unit test cases for all the oops handling APIs. Signed-off-by: Jerin Jacob --- app/test/meson.build | 2 + app/test/test_oops.c | 121 +++ 2 files changed, 123 insertions(+) create mode 100644 app/test/test_oops.c diff --git a

[dpdk-dev] [PATCH v2 5/6] eal/arm64: support register dump for oops

2021-08-16 Thread jerinj
From: Jerin Jacob Dump the arm64 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index a0f9526d96..9c783f936a 100644 -

[dpdk-dev] [PATCH v2 4/6] eal/x86: support register dump for oops

2021-08-16 Thread jerinj
From: Jerin Jacob Dump the x86 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index a7f00ecd4e..a0f952

[dpdk-dev] [PATCH v2 3/6] eal: support libunwind based backtrace

2021-08-16 Thread jerinj
From: Jerin Jacob adding optional libwind library dependency to DPDK for enhanced backtrace based on ucontext. Signed-off-by: Jerin Jacob --- .github/workflows/build.yml | 2 +- .travis.yml | 2 +- config/meson.build | 8 +++ lib/eal/unix/eal_oops.c | 47 +++

[dpdk-dev] [PATCH v2 2/6] eal: oops handling API implementation

2021-08-16 Thread jerinj
From: Jerin Jacob Implement the base oops handling APIs. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 176 ++-- 1 file changed, 169 insertions(+), 7 deletions(-) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c index 53b580f733..7b

[dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-16 Thread jerinj
From: Jerin Jacob Introducing oops handling API with following specification and enable stub implementation for Linux and FreeBSD. On rte_eal_init() invocation, the EAL library installs the oops handler for the essential signals. The rte_oops_signals_enabled() API provides the list of signals th

[dpdk-dev] [PATCH v2 0/6] support oops handling

2021-08-16 Thread jerinj
From: Jerin Jacob v2: - Fix powerpc build (David Christensen) It is handy to get detailed OOPS information like Linux kernel when DPDK application crashes without losing any of the features provided by coredump infrastructure by the OS. This patch series introduces the APIs to handle OOPS in DP

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx

2021-08-16 Thread Li, Xiaoyun
> -Original Message- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 15:10 > To: Li, Xiaoyun > Cc: jer...@marvell.com; dev@dpdk.org; Nithin Dabilpuram > ; rasl...@mellanox.com; sta...@dpdk.org > Subject: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx > > Fix verbose m

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum

2021-08-16 Thread Li, Xiaoyun
> -Original Message- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 15:10 > To: Li, Xiaoyun > Cc: jer...@marvell.com; dev@dpdk.org; Nithin Dabilpuram > ; jia@intel.com; sta...@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer > chksum

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum

2021-08-16 Thread Li, Xiaoyun
> -Original Message- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 18:56 > To: Li, Xiaoyun > Cc: jer...@marvell.com; dev@dpdk.org; jia@intel.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run > without outer chksum > > On

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-16 Thread Stephen Hemminger
On Mon, 16 Aug 2021 15:27:28 +0530 Aman Singh wrote: > Added macros to simplify print of MAC address. > The six bytes of a MAC address are extracted in > a macro here, to improve code readablity. > > Signed-off-by: Aman Singh > Reviewed-by: Ferruh Yigit > --- > The change in the document will

Re: [dpdk-dev] [PATCH v16] app/testpmd: support multi-process

2021-08-16 Thread Singh, Aman Deep
On 8/2/2021 1:33 PM, Thomas Monjalon wrote: 02/08/2021 03:51, Min Hu (Connor): 在 2021/7/26 15:28, Min Hu (Connor) 写道: 在 2021/7/26 14:30, Thomas Monjalon 写道: 26/07/2021 02:26, Min Hu (Connor): 在 2021/7/24 19:45, Thomas Monjalon 写道: 10/07/2021 05:50, Min Hu (Connor): This patch adds multi-p

Re: [dpdk-dev] 5/6] eal/arm64: support register dump for oops

2021-08-16 Thread Jerin Jacob
On Tue, Aug 3, 2021 at 4:20 AM David Christensen wrote: > > > > On 7/30/21 1:49 AM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Dump the arm64 arch state register in oops > > handling routine. > > > > Signed-off-by: Jerin Jacob > > --- > > lib/eal/unix/eal_oops.c | 19

Re: [dpdk-dev] [PATCH v1 2/2] examples/fips_validation: fix resetting pointer

2021-08-16 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Thursday, August 12, 2021 3:25 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Roy Fan ; Power, > Ciara ; Kovacevic, Marko > > Subject: [PATCH v1 2/2] examples/fips_validation: fix resetting pointer > > The env.digest memory was freed

Re: [dpdk-dev] [PATCH v1 1/2] examples/fips_validation: fix unused malloc

2021-08-16 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Thursday, August 12, 2021 3:25 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Roy Fan ; Power, > Ciara ; damianx.no...@intel.com; Kovacevic, > Marko > Subject: [PATCH v1 1/2] examples/fips_validation: fix unused malloc > > The val.va

Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log

2021-08-16 Thread Ferruh Yigit
On 7/29/2021 1:18 PM, Heinrich Kuhn wrote: > > > On 2021/07/23 16:14, Thomas Monjalon wrote: >> Please review. >> >> 28/06/2021 13:13, Andrew Rybchenko: >>> Hi Heinrich, >>> >>> could you take a look at the patch? >>> >>> Thanks, >>> Andrew. >>> >>> On 5/18/21 1:41 PM, Ferruh Yigit wrote: Lo

[dpdk-dev] [Bug 745] performance-thread build failure with clang 12.0.1

2021-08-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=745 Jerin (jerinjac...@gmail.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[dpdk-dev] [PATCH] examples/performance-thread: fix build issue with clang 12.0.1

2021-08-16 Thread jerinj
From: Jerin Jacob In clang 12.0.1 version, the use of pthread_yield() deprecated, use sched_yield() instead. log: Compiling C object examples/dpdk-pthread_shim.p/performance-thread_pthread_shim_main.c.o ../examples/performance-thread/pthread_shim/main.c: In function 'helloworld_pthread': ../exa

Re: [dpdk-dev] [PATCH] checkpatch: enable volatile warning

2021-08-16 Thread Dharmik Thakkar
Hi, Apologies for the delayed response! > On Mar 10, 2021, at 9:10 AM, Stephen Hemminger > wrote: > > On Wed, 10 Mar 2021 12:10:01 +0100 > Thomas Monjalon wrote: > >> 10/03/2021 12:04, Dharmik Thakkar: >>> Enable volatile considered harmful warning since use of volatile >>> is suspect. >>>

[dpdk-dev] [PATCH V4 4/4] examples/pipeline: add learner table example

2021-08-16 Thread Cristian Dumitrescu
Added the files to illustrate the learner table usage. Signed-off-by: Cristian Dumitrescu --- V2: Added description to the .spec file. examples/pipeline/examples/learner.cli | 37 +++ examples/pipeline/examples/learner.spec | 127 2 files changed, 164 insertions(

[dpdk-dev] [PATCH V4 2/4] pipeline: add support for learner tables

2021-08-16 Thread Cristian Dumitrescu
Add pipeline level support for learner tables. Signed-off-by: Cristian Dumitrescu --- V2: Added more configuration consistency checks. V3: Fixed one coding style indentation error. V4: Fixed a pointer dereferencing issue in function rte_swx_ctl_pipeline_learner_stats_read(). lib/pipeline/rte_

[dpdk-dev] [PATCH V4 3/4] examples/pipeline: add support for learner tables

2021-08-16 Thread Cristian Dumitrescu
Add application-level support for learner tables. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 174 1 file changed, 174 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index a29be05ef4..ad6e3db8d7 100644 -

[dpdk-dev] [PATCH V4 1/4] table: add support learner tables

2021-08-16 Thread Cristian Dumitrescu
A learner table is typically used for learning or connection tracking, where it allows for the implementation of the "add on miss" scenario: whenever the lookup key is not found in the table (lookup miss), the data plane can decide to add this key to the table with a given action with no control pl

Re: [dpdk-dev] EAL: failed to parse device "XX:XX.X" on CentOS 7

2021-08-16 Thread Mikulicz, Szymon (Nokia - PL/Krakow)
Hi Thao, the original issue was resolved by updating pkg-config. I compiled a new version of it on our centos 7 setup. We are currently using pkg-config 0.29.2 and it works. BR, SM On 8/13/21 12:32 AM, Thao Hull wrote: Hi. This looks similar to the problem I am having. https://lore.kernel.org

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum

2021-08-16 Thread Nithin Dabilpuram
On Mon, Aug 16, 2021 at 08:48:20AM +, Li, Xiaoyun wrote: > Hi > > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Monday, August 16, 2021 15:10 > > To: Li, Xiaoyun > > Cc: jer...@marvell.com; dev@dpdk.org; Nithin Dabilpuram > > ; jia@intel.com; sta...@dpdk.org > > Subj

[dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-16 Thread Aman Singh
Added macros to simplify print of MAC address. The six bytes of a MAC address are extracted in a macro here, to improve code readablity. Signed-off-by: Aman Singh Reviewed-by: Ferruh Yigit --- The change in the document will be done in seperate patch. To ensure document has direct reference of t

[dpdk-dev] [PATCH v4 1/2] net: added macro for MAC address print

2021-08-16 Thread Aman Singh
Added macro to print six bytes of MAC address. The MAC addresses will be printed in lower case hexadecimal format. In case there is a specific check for upper case MAC address, the user may need to make a change in such test case after this patch. Signed-off-by: Aman Singh Reviewed-by: Ferruh Yig

[dpdk-dev] [PATCH v4 0/2] Use macro to print MAC address

2021-08-16 Thread Aman Singh
Added macros to simplyfy print of MAC address. The six bytes of mac address is extracted using a macro to improve code readability. Aman Singh (2): net: added macro for MAC address print net: added macro to extract MAC address bytes app/pdump/main.c | 5 +--- ap

[dpdk-dev] Minutes of Technical Board Meeting, 2021-08-11

2021-08-16 Thread Ferruh Yigit
Minutes of Technical Board Meeting, 2021-08-11 Members Attending: 8/12 - Aaron Conole - Ferruh Yigit (Chair) - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Stephen Hemminger NOTE: The Technical Board meetings take place every s

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum

2021-08-16 Thread Li, Xiaoyun
Hi > -Original Message- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 15:10 > To: Li, Xiaoyun > Cc: jer...@marvell.com; dev@dpdk.org; Nithin Dabilpuram > ; jia@intel.com; sta...@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer > chksum

[dpdk-dev] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx

2021-08-16 Thread Nithin Dabilpuram
Fix verbose mode dump for Tx to dump tx offload flags instead of Rx offload flags. Fixes: d862c45b5955 ("app/testpmd: move dumping packets to a separate function") Cc: rasl...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- app/test-pmd/util.c | 6 +- 1 file changed, 5

[dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum

2021-08-16 Thread Nithin Dabilpuram
Donot use outer metadata when neither outer ip checksum nor outer udp checksum is enabled. PMD's will ignore the outer_l2_len and outer_l3_len in cases where none of the outer checksum is enabled and hence only l2_len and l3_len will be used to calculate the offsets for L2 or L3 header. Fixes: 3c3