> -----Original Message----- > From: Power, Ciara <[email protected]> > Sent: Thursday, August 12, 2021 3:25 PM > To: [email protected] > Cc: [email protected]; Zhang, Roy Fan <[email protected]>; Power, > Ciara <[email protected]>; [email protected]; Kovacevic, > Marko <[email protected]> > Subject: [PATCH v1 1/2] examples/fips_validation: fix unused malloc > > The val.val pointer is allocated memory, however this memory is then > freed in get_writeback_data() without being used beforehand. > The pointer is then allocated memory again before use, > so the very first allocation is removed as it was unnecessary. > > Fixes: f4797bae0050 ("examples/fips_validation: support plain SHA") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Ciara Power <[email protected]> > --- > examples/fips_validation/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/examples/fips_validation/main.c > b/examples/fips_validation/main.c > index c175fe6ac2..2db00620ce 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -1635,7 +1635,6 @@ fips_mct_sha_test(void) > int ret; > uint32_t i, j; > > - val.val = rte_malloc(NULL, (MAX_DIGEST_SIZE*SHA_MD_BLOCK), 0); > for (i = 0; i < SHA_MD_BLOCK; i++) > md[i].val = rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0); > > -- > 2.25.1
Acked-by: Fan Zhang <[email protected]>
