Re: [dpdk-dev] [PATCH 2/2] maint changes for marvell qlogic drivers

2021-07-29 Thread Devendra Singh Rawat
>-Original Message- >From: Igor Russkikh >Sent: Tuesday, July 27, 2021 1:33 PM >To: dev@dpdk.org >Cc: Rasesh Mody ; Devendra Singh Rawat >; Ferruh Yigit ; >jerinjac...@gmail.com; Igor Russkikh >Subject: [PATCH 2/2] maint changes for marvell qlogic drivers > >Adding Marvell prefix for q

Re: [dpdk-dev] [PATCH 2/2] vhost: notice Vhost ops struct renaming

2021-07-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 29, 2021 10:43 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > Richardson, Bruce ; Yigit, Ferruh > ; tho...@monjalon.net; acon...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 2/2] vhost: noti

Re: [dpdk-dev] [PATCH 1/2] vhost: announce vDPA driver API marking as internal

2021-07-29 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 29, 2021 10:43 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > Richardson, Bruce ; Yigit, Ferruh > ; tho...@monjalon.net; acon...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 1/2] vhost: anno

[dpdk-dev] [PATCH] drivers: remove meson 0.46.0 warning

2021-07-29 Thread jerinj
From: Jerin Jacob Since meson 0.46.0 version, the extract_all_objects() API need to pass explicit boolean value. To remove the following warning[1], added explicit `true` for extract_all_objects() use in codebase whever there is no argument. [1] WARNING: extract_all_objects called without setti

Re: [dpdk-dev] [PATCH] app/testpmd: fix vm_hotplug after removal of rte_eth_devices

2021-07-29 Thread Li, Xiaoyun
> -Original Message- > From: Gributs, Paulis > Sent: Wednesday, July 28, 2021 21:49 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; tho...@monjalon.net; Gributs, Paulis > > Subject: [PATCH] app/testpmd: fix vm_hotplug after removal of rte_eth_devices > > After removing rte_eth_dev

Re: [dpdk-dev] [PATCH] net/mlx5: fix the meter hierarchy validation with yellow

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, July 29, 2021 7:04 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; NBU-Contact-Thomas Monjalon > ; Shun Hao > Subject: [PATCH] net/mlx5: fix the meter hierarchy validation with yello

Re: [dpdk-dev] [PATCH] net/mlx5: fix the EIR calculation

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, July 29, 2021 7:04 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; NBU-Contact-Thomas Monjalon > > Subject: [PATCH] net/mlx5: fix the EIR calculation > > Before the yellow color pol

Re: [dpdk-dev] [PATCH] net/mlx5: fix the green color policy RSS queues overwritten

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, July 29, 2021 7:04 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; NBU-Contact-Thomas Monjalon > > Subject: [PATCH] net/mlx5: fix the green color policy RSS queues overwritten > > B

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter profile validation

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, July 29, 2021 7:04 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; NBU-Contact-Thomas Monjalon > > Subject: [PATCH] net/mlx5: fix meter profile validation > > After the support for

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Gregory Etelson
Hello Olivier, > > > > Fixes: 51f694dd40f5 ("app/testpmd: rework checksum forward engine") > > Cc: sta...@dpdk.org > > As said previously, I think the correct Fixes line is: > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") > I updated the Fixes hash in v4. > Acked-b

[dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Gregory Etelson
csumonly engine calculates TX checksum of a tunnelled packet for outer headers only or separately for outer and inner headers. The calculation method is determined by checksum configuration options. If TX checksum calculation is separated, the inner headers are processed before outer headers. Inne

[dpdk-dev] [PATCH] net/mlx5: fix the meter hierarchy validation with yellow

2021-07-29 Thread Bing Zhao
In mlx5 PMD, the meter hierarchy only supports the green color. It means that a meter action can only be in the green action list. In the meanwhile, the yellow action list should be empty now. Any action for the yellow color policy will be considered invalid if the green color policy is a hierarchy

[dpdk-dev] [PATCH] net/mlx5: fix the EIR calculation

2021-07-29 Thread Bing Zhao
Before the yellow color policy was supported, the only supported profile of metering is RFC2697 and EIR is not part of the profile. When creating a meter with this profile, the EIR part was always zero. After the yellow color policy supported and RFC2698 & 4115 support was introduced, EIR is relev

[dpdk-dev] [PATCH] net/mlx5: fix meter profile validation

2021-07-29 Thread Bing Zhao
After the support for yellow color and RFC2698 & RFC4115 were added, the profile validation adjustment was missed. With this fix, the validation is like below: 1. Legacy metering only supports RFC2697 without EBS. 2. ASO metering can support all the three profiles. 3. For backward compatibili

[dpdk-dev] [PATCH] net/mlx5: fix the green color policy RSS queues overwritten

2021-07-29 Thread Bing Zhao
Both green policy and yellow policy could support RSS actions simultaneous, the Rx queues configuration may be different between them while the other fields should be the same. When the only green color policy was supported in the past, the queues copied and saved in the temporary workspace were u

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queues creation type check for scheduling

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Thursday, July 29, 2021 3:27 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix Tx queues creation type check for scheduling > > The send scheduling on timestamp offload

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-07-29 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Juraj Linkeš >Sent: Tuesday, July 27, 2021 6:35 PM >To: Thomas Monjalon ; Bruce Richardson >; Pavan Nikhilesh Bhagavatula >; Honnappa Nagarahalli > >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; >Jan Viktorin ; Ruifeng Wang >; nd >Subject: Re

[dpdk-dev] [PATCH] compress/mlx5: fix level translation in xform API

2021-07-29 Thread Raja Zidane
Compression Level is interpreted by each PMD differently. However, lower numbers give faster compression at the expense of compression ratio, while higher numbers may give better compression ratios but are likely slower. The level affects the block size, which affects performance, the bigger the bl

[dpdk-dev] [PATCH v2 3/3] net/mlx5: preserve indirect actions across port restart

2021-07-29 Thread Dmitry Kozlyuk
MLX5 PMD uses reference counting to manage RX queue resources. After port stop shared RSS actions kept references to RX queues, preventing resource release. As a result, internal PMD mempool for such queues had been exhausted after a number of port restarts. Diagnostic message from rte_eth_dev_star

[dpdk-dev] [PATCH v2 2/3] net/mlx5: create drop queue using DevX

2021-07-29 Thread Dmitry Kozlyuk
Drop queue creation and destruction were not implemented for DevX flow engine and Verbs engine methods were used as a workaround. Implement these methods for DevX so that there is a valid queue ID that can be used regardless of queue configuration via API. Cc: sta...@dpdk.org Signed-off-by: Dmitr

[dpdk-dev] [PATCH v2 1/3] net/mlx5: discover max flow priority using DevX

2021-07-29 Thread Dmitry Kozlyuk
Maximum available flow priority was discovered using Verbs API regardless of the selected flow engine. This required some Verbs objects to be initialized in order to use DevX engine. Make priority discovery an engine method and implement it for DevX using its API. Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH v2 0/4] net/mlx5: keep indirect actions across port restart

2021-07-29 Thread Dmitry Kozlyuk
It is unspecified what happens to indirect actions when a port is stopped, possibly reconfigured, and started again. MLX5 PMD, the first one to implement indirect action API, intended to keep them across such a sequence, but the implementation was buggy, This patcheset fixes it. There is no consen

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queues creation type check for scheduling

2021-07-29 Thread Thomas Monjalon
29/07/2021 14:26, Viacheslav Ovsiienko: > + if (config->tx_pp && > + (priv->config.dv_esw_en || > + priv->obj_ops.txq_obj_new != mlx5_os_txq_obj_new)) { > + /* > + * HAVE_MLX5DV_DEVX_UAR_OFFSET is required to support > + * packet pacing and

[dpdk-dev] [PATCH v5] doc: spell check

2021-07-29 Thread Henry Nadeau
Spell checked and corrected documentation. If there are any errors, or I have changed something that wasn't an error please reach out to me so I can update the dictionary. Cc: sta...@dpdk.org Signed-off-by: Henry Nadeau --- doc/guides/contributing/coding_style.rst| 2 +- doc/guides/cryp

[dpdk-dev] [PATCH] net/mlx5: fix Tx queues creation type check for scheduling

2021-07-29 Thread Viacheslav Ovsiienko
The send scheduling on timestamp offload requires the Send Queue (SQ) shares its User Access Region (UAR) with the pacing Clock Queue. The SQ can be created by mlx5 PMD either with DevX or with Verbs. If the SQ is being created with DevX the dedicated UAR can be specified and all the SQs share the

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Olivier Matz
On Thu, Jul 29, 2021 at 12:39:48PM +0300, Gregory Etelson wrote: > csumonly engine calculates TX checksum of a tunnelled packet for outer > headers only or separately for outer and inner headers. The > calculation method is determined by checksum configuration options. > If TX checksum calculation

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Olivier Matz
On Thu, Jul 29, 2021 at 10:31:45AM +, Gregory Etelson wrote: > Hello Olivier, > > [:snip:] > > > > > > Correct. Inner checksum is offloaded and outer computed in software. > > > > I think this approach is not sane: the value of the outer checksum depends > > on > > the inner checksum, so it

Re: [dpdk-dev] [v1, 1/3] telemetry: enable storing pointer value

2021-07-29 Thread Bruce Richardson
On Thu, Jul 29, 2021 at 08:55:35PM +0530, Gowrishankar Muthukrishnan wrote: > At present, value of pointer variable or address can only be > stored in u64 type which is slightly not human readable, hence > this patch is. It adds telemetry support to store pointer value, > which is stringified. > >

[dpdk-dev] [v1, 3/3] common/cnxk: add telemetry endpoints to npa

2021-07-29 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 23 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++ drivers/common/cnxk/meson.build | 4 + drivers/common/cnxk/roc_platform.h |

[dpdk-dev] [v1, 2/3] test/telemetry: add unit tests for pointer value

2021-07-29 Thread Gowrishankar Muthukrishnan
Adding tests to evaluate pointer value in array and dict. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_telemetry_data.c | 124 + app/test/test_telemetry_json.c | 28 ++-- 2 files changed, 145 insertions(+), 7 deletions(-) diff --git a/app/test

[dpdk-dev] [v1, 1/3] telemetry: enable storing pointer value

2021-07-29 Thread Gowrishankar Muthukrishnan
At present, value of pointer variable or address can only be stored in u64 type which is slightly not human readable, hence this patch is. It adds telemetry support to store pointer value, which is stringified. Signed-off-by: Gowrishankar Muthukrishnan --- lib/telemetry/rte_telemetry.h | 37 +++

[dpdk-dev] [v1, 0/3] common/cnxk: enable npa telemetry

2021-07-29 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry in NPA LF of cnxk. Gowrishankar Muthukrishnan (3): telemetry: enable storing pointer value test/telemetry: add unit tests for pointer value common/cnxk: add telemetry endpoints to npa app/test/test_telemetry_data.c | 124 + app/test

[dpdk-dev] [PATCH 2/2] vhost: notice Vhost ops struct renaming

2021-07-29 Thread Maxime Coquelin
This patch announce the renaming of struct vhost_device_ops to rte_vhost_device_ops in DPDK v21.11. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecat

[dpdk-dev] [PATCH 0/2] vhost: v21.11 deprecation notices

2021-07-29 Thread Maxime Coquelin
Two deprecations planned for DPDK v21.11 in Vhost: - marking vDPA driver API as internal - prefixing Vhost ops struct with rte_ Maxime Coquelin (2): vhost: announce vDPA driver API marking as internal vhost: notice Vhost ops struct renaming doc/guides/rel_notes/deprecation.rst | 7 +++

[dpdk-dev] [PATCH 1/2] vhost: announce vDPA driver API marking as internal

2021-07-29 Thread Maxime Coquelin
This patch announces the marking if all the vDPA driver API as internal. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 9584d6bfd7..

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Gregory Etelson
Hello Olivier, [:snip:] > > > > Correct. Inner checksum is offloaded and outer computed in software. > > I think this approach is not sane: the value of the outer checksum depends on > the inner checksum, so it has to be calculated after. There is a comment in > the > code about this: > >

Re: [dpdk-dev] [PATCH v3] app/procinfo: add device registers dump

2021-07-29 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Min Hu (Connor) > Signed-off-by: Chengchang Tang > Signed-off-by: Min Hu (Connor) Acked-by: Reshma Pattan

Re: [dpdk-dev] [PATCH v2 0/7] Refactor the NFP PMD

2021-07-29 Thread Heinrich Kuhn
On 2021/07/23 11:18, Thomas Monjalon wrote: > 16/07/2021 10:35, Heinrich Kuhn: >> This patch set restructures the NFP PMD, aligning it more with the >> common layout adopted by most other PMD's. Although the changes look >> fairly large, functionally nothing is added or removed from the driver >

[dpdk-dev] [PATCH v3 7/7] net/nfp: batch file rename for consistency

2021-07-29 Thread Heinrich Kuhn
Rename the nfp_net.c file to nfp_common as it now contains functions common to VF and PF functionality. Rename the header file too to be consistent. Also remove the "net" naming from the _ctrl and _logs files for consistency across the PMD. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman

[dpdk-dev] [PATCH v3 6/7] net/nfp: move PF functions into new file

2021-07-29 Thread Heinrich Kuhn
Similar to the last commit, this changeset moves all the PF specific functions to a new file called nfp_ethdev.c. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build |1 + drivers/net/nfp/nfp_ethdev.c | 1067 ++ drivers/n

[dpdk-dev] [PATCH v3 5/7] net/nfp: move VF functions into new file

2021-07-29 Thread Heinrich Kuhn
Move any ethdev functionality specific to VF devices into a new file called nfp_ethdev_vf.c. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build | 1 + drivers/net/nfp/nfp_ethdev_vf.c | 504 drivers/net/nfp/nfp_net.c

[dpdk-dev] [PATCH v3 4/7] net/nfp: prototype common functions in header file

2021-07-29 Thread Heinrich Kuhn
The majority of "ethdev" type functions are used for both PF devices and VF devices. Prototype these functions in the nfp_net_pmd header file in preparation of splitting PF and VF specific functions. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/nfp_net.c | 87

[dpdk-dev] [PATCH v3 3/7] net/nfp: move CPP bridge to a separate file

2021-07-29 Thread Heinrich Kuhn
This commit moves the CPP bridge logic to a separate file. A new corresponding header file is also created. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build | 1 + drivers/net/nfp/nfp_cpp_bridge.c | 392 +++ drivers/net/

[dpdk-dev] [PATCH v3 2/7] net/nfp: move rxtx functions to their own file

2021-07-29 Thread Heinrich Kuhn
Create a new rxtx file and move the Rx/Tx functions to this file. This commit will also move the needed shared functions to the nfp_net_pmd.h file as needed. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/meson.build |1 + drivers/net/nfp/nfp_net.c | 1090

[dpdk-dev] [PATCH v3 1/7] net/nfp: split rxtx headers into separate file

2021-07-29 Thread Heinrich Kuhn
This change splits out the rx/tx specific structs and defines from the main nfp_net_pmd header file and into their own header file. Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/nfp_net.c | 1 + drivers/net/nfp/nfp_net_pmd.h | 248 ---

[dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD

2021-07-29 Thread Heinrich Kuhn
This patch set restructures the NFP PMD, aligning it more with the common layout adopted by most other PMD's. Although the changes look fairly large, functionally nothing is added or removed from the driver and the existing code is mostly just reorganized into the familiar structure seen in other P

Re: [dpdk-dev] [PATCH] net/mlx5: fix timestamp initialization on empty clock queue

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, July 28, 2021 5:24 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix timestamp initialization on empty clock queue > > The committing completions by clock queu

[dpdk-dev] [PATCH v3] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Gregory Etelson
csumonly engine calculates TX checksum of a tunnelled packet for outer headers only or separately for outer and inner headers. The calculation method is determined by checksum configuration options. If TX checksum calculation is separated, the inner headers are processed before outer headers. Inne

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-29 Thread fengchengwen
Thanks, comment inline On 2021/7/29 17:15, Bruce Richardson wrote: > On Thu, Jul 29, 2021 at 09:26:31AM +0800, fengchengwen wrote: >> Thanks, inline comment >> >> On 2021/7/28 19:13, Bruce Richardson wrote: >>> On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: This patch introduc

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-29 Thread fengchengwen
Thanks, comment inline On 2021/7/29 18:44, Jerin Jacob wrote: > On Thu, Jul 29, 2021 at 6:56 AM fengchengwen wrote: >> >> Thanks, inline comment >> >> On 2021/7/28 19:13, Bruce Richardson wrote: >>> On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: This patch introduce 'dmadevic

Re: [dpdk-dev] [PATCH v11 2/2] doc: add dmadev library guide

2021-07-29 Thread fengchengwen
sorry, self-response, add an explanation inline On 2021/7/29 21:13, fengchengwen wrote: > On 2021/7/29 19:02, Jerin Jacob wrote: > > [snip] > >>> + >>> +The DMA library follows the same basic principles as those used in DPDK's >>> +Ethernet Device framework and the RegEx framework. The DMA frame

Re: [dpdk-dev] [PATCH v11 2/2] doc: add dmadev library guide

2021-07-29 Thread fengchengwen
On 2021/7/29 19:02, Jerin Jacob wrote: [snip] >> + >> +The DMA library follows the same basic principles as those used in DPDK's >> +Ethernet Device framework and the RegEx framework. The DMA framework >> provides >> +a generic DMA device framework which supports both physical (hardware) >> +and

[dpdk-dev] [PATCH v12 1/6] dmadev: introduce DMA device library public APIs

2021-07-29 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob -

[dpdk-dev] [PATCH v12 2/6] dmadev: introduce DMA device library internal header

2021-07-29 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v12 5/6] doc: add DMA device library guide

2021-07-29 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/dmadev.rst | 147 +++ doc/guides/prog_guide/index.rst | 1 + 2 files changed, 148 insertions(+) create mode 100644 doc/guides/prog_guide/dmadev.rst diff --git a/d

[dpdk-dev] [PATCH v12 3/6] dmadev: introduce DMA device library PMD header

2021-07-29 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v12 6/6] maintainers: add for dmadev

2021-07-29 Thread Chengwen Feng
This patch add Chengwen Feng as dmadev's maintainer. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/guides/rel_notes/release_21_08.rst | 6 ++ 2 files changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8013ba1..84cfb1a 100644 --- a

[dpdk-dev] [PATCH v12 0/6] support dmadev

2021-07-29 Thread Chengwen Feng
This patch set contains six patch for new add dmadev. Chengwen Feng (6): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DMA

[dpdk-dev] [PATCH v12 4/6] dmadev: introduce DMA device library implementation

2021-07-29 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix typo in flow engine type

2021-07-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Asaf Penso > Sent: Wednesday, July 28, 2021 12:40 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Slava > Ovsiienko ; Matan Azrad ; > Raslan Darawsheh ; sta...@dpdk.org > Subject: [PATCH 1/1] net/mlx5: fix typo in flow engine type > > The concre

Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log

2021-07-29 Thread Heinrich Kuhn
On 2021/07/23 16:14, Thomas Monjalon wrote: > Please review. > > 28/06/2021 13:13, Andrew Rybchenko: >> Hi Heinrich, >> >> could you take a look at the patch? >> >> Thanks, >> Andrew. >> >> On 5/18/21 1:41 PM, Ferruh Yigit wrote: >>> Logging should be converted to dynamic log. >>> >>> Signed-of

Re: [dpdk-dev] [PATCH v11 2/2] doc: add dmadev library guide

2021-07-29 Thread Jerin Jacob
On Tue, Jul 27, 2021 at 9:13 AM Chengwen Feng wrote: > > This patch adds dmadev library guide. > > Signed-off-by: Chengwen Feng > --- > doc/guides/prog_guide/dmadev.rst | 123 > +++ > doc/guides/prog_guide/index.rst | 1 + > 2 files changed, 124 insertions

[dpdk-dev] [PATCH] crypto/mlx5: fix driver probing error flow

2021-07-29 Thread Michael Baum
In crypto driver probing, there are two validations after context allocation. When one of them fails, the context structure was not freed what caused a memory leak. Free it. Fixes: debb27ea3442 ("crypto/mlx5: create login object using DevX") Fixes: e8db4413cba5 ("crypto/mlx5: add keytag configur

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-29 Thread Jerin Jacob
On Thu, Jul 29, 2021 at 6:56 AM fengchengwen wrote: > > Thanks, inline comment > > On 2021/7/28 19:13, Bruce Richardson wrote: > > On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: > >> This patch introduce 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs of

[dpdk-dev] [PATCH 21.11 3/3] test/crypto: add lookaside IPsec ICV corrupt test case

2021-07-29 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec ICV corrupt test case. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30 -- app/test/test_crypto

[dpdk-dev] [PATCH 21.11 2/3] test/crypto: add combined mode tests

2021-07-29 Thread Anoob Joseph
Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 74 +++-- app/test/test_cryptodev_security_ipsec.c | 107 +-- a

[dpdk-dev] [PATCH 21.11 1/3] test/crypto: add lookaside IPsec tests

2021-07-29 Thread Anoob Joseph
Added test case for lookaside IPsec. Following tests are added, 1. Inbound known vector [AES-GCM 128, 192 & 256] 2. Outbound known vector [AES-GCM 128, 192 & 256] Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build | 1 + app/test

[dpdk-dev] [PATCH 21.11 0/3] Add lookaside IPsec tests

2021-07-29 Thread Anoob Joseph
Add lookaside IPsec functional tests. Known vector tests and combined mode framework is added. Known vector tests for outbound operations would use predefined IV and sequence number as 1. So plain packet would get encrypted to generate the IPsec packet. Tests would compare against known vector. K

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-29 Thread Ananyev, Konstantin
Hi Anoob, > Now that we have an agreement on bitfields (hoping no one else has an > objection), I would like to discuss one more topic. It is more related > to checksum offload, but it's better that we discuss along with other similar > items (like soft expiry). > > L3 & L4 checksum can be tris

[dpdk-dev] [PATCH] common/sfc_efx/base: do not validate MAE action COUNT order

2021-07-29 Thread Ivan Malov
In DPDK + Open vSwitch use case, action COUNT is always the first one to be added. In particular, it goes before action DECAP in that use case. The current code enforces the right order (DECAP goes before COUNT), and this provokes failures. As an exception, do not validate the order for action COUN

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-29 Thread Bruce Richardson
On Thu, Jul 29, 2021 at 09:26:31AM +0800, fengchengwen wrote: > Thanks, inline comment > > On 2021/7/28 19:13, Bruce Richardson wrote: > > On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: > >> This patch introduce 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The

Re: [dpdk-dev] [PATCH 1/2] drivers/qat: fix wrong return value for invalid service

2021-07-29 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 28, 2021 5:19 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Trahe, Fiona ; Zhang, Roy > Fan ; Kusztal, ArkadiuszX > > Subject: [PATCH 1/2] drivers/qat: fix wrong return value for invalid service > > Fix invalid va

Re: [dpdk-dev] [PATCH 2/2] crypto/qat: fix asymmetric crypto pmd create on gen3

2021-07-29 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 28, 2021 5:19 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Trahe, Fiona ; Zhang, Roy > Fan ; Kusztal, ArkadiuszX > > Subject: [PATCH 2/2] crypto/qat: fix asymmetric crypto pmd create on gen3 > > This patch disabl

Re: [dpdk-dev] [EXT] [PATCH 01/10] security: add support for TSO on IPsec session

2021-07-29 Thread Nicolau, Radu
Hi, thanks for reviewing. I'm OOO at the moment, I will send an updated patchset next week. On 7/27/2021 9:34 PM, Akhil Goyal wrote: Allow user to provision a per security session maximum segment size (MSS) for use when Transmit Segmentation Offload (TSO) is supported. The MSS value will be use

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Olivier Matz
On Wed, Jul 28, 2021 at 04:07:51PM +, Gregory Etelson wrote: > Hello Oliver, > > Please see my comments below > > > On Tue, Jul 27, 2021 at 04:07:57PM +0300, Gregory Etelson wrote: > > > TX checksum of a tunnelled packet can be calculated for outer headers > > > only or for both outer and inn

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-29 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 13, 2021 12:18 AM > To: Ajit Khaparde ; Somnath Kotur > ; John Daley > ; Hyong Youb Kim ; Beilei Xing > ; Qiming Yang > ; Qi Zhang ; Haiyue Wang > ; Matan Azrad > ; Shahaf Shuler ; Slava Ovsiienko > ; NBU-Contact-Th

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-29 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 20, 2021 5:00 PM > To: Xueming(Steven) Li ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; Hyong Youb Kim > ; Beilei Xing > ; Qiming Yang ; Qi Zhang > ; Haiyue Wang > ; Matan Azrad ; Shahaf Shuler > ; Slava Ovsiien

Re: [dpdk-dev] [PATCH v3 4/8] test/mcslock: use compiler atomics for lcores sync

2021-07-29 Thread Olivier Matz
On Thu, Jul 29, 2021 at 07:19:13AM +, Joyce Kong wrote: > Hi Olivier, > > > -Original Message- > > From: Olivier Matz > > Sent: Wednesday, July 28, 2021 5:57 PM > > To: Joyce Kong > > Cc: tho...@monjalon.net; david.march...@redhat.com; > > roret...@linux.microsoft.com; step...@networ

Re: [dpdk-dev] [PATCH v4] bus: clarify log for non-NUMA-aware devices

2021-07-29 Thread Andrew Rybchenko
On 7/29/21 1:06 AM, Dmitry Kozlyuk wrote: PCI, vmbus, and auxiliary drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing

Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags

2021-07-29 Thread Michał Krawczyk
czw., 29 lip 2021 o 09:26 Olivier Matz napisał(a): > > Hi Michał, > > On Thu, Jul 29, 2021 at 08:40:00AM +0200, Michał Krawczyk wrote: > > śr., 28 lip 2021 o 16:27 Olivier Matz napisał(a): > > > > > > Hi Michał, > > > > > > On Wed, Jul 14, 2021 at 12:02:32PM +0200, Michał Krawczyk wrote: > > > >

Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags

2021-07-29 Thread Olivier Matz
Hi Michał, On Thu, Jul 29, 2021 at 08:40:00AM +0200, Michał Krawczyk wrote: > śr., 28 lip 2021 o 16:27 Olivier Matz napisał(a): > > > > Hi Michał, > > > > On Wed, Jul 14, 2021 at 12:02:32PM +0200, Michał Krawczyk wrote: > > > pon., 12 lip 2021 o 19:03 Ghalem Boudour > > > napisał(a): > > > > >

Re: [dpdk-dev] [PATCH v3 4/8] test/mcslock: use compiler atomics for lcores sync

2021-07-29 Thread Joyce Kong
Hi Olivier, > -Original Message- > From: Olivier Matz > Sent: Wednesday, July 28, 2021 5:57 PM > To: Joyce Kong > Cc: tho...@monjalon.net; david.march...@redhat.com; > roret...@linux.microsoft.com; step...@networkplumber.org; > andrew.rybche...@oktetlabs.ru; harry.van.haa...@intel.com; H

Re: [dpdk-dev] [PATCH 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro

2021-07-29 Thread Eli Britstein
On 7/28/2021 6:28 PM, Olivier Matz wrote: External email: Use caution opening links or attachments On Tue, Jul 13, 2021 at 09:49:09AM +0300, Eli Britstein wrote: In rte_pktmbuf_mtod_offset macro, there is a casting from char * to type 't', which may cause cast-align warning when using gcc fl