29/07/2021 14:26, Viacheslav Ovsiienko:
> + if (config->tx_pp &&
> + (priv->config.dv_esw_en ||
> + priv->obj_ops.txq_obj_new != mlx5_os_txq_obj_new)) {
> + /*
> + * HAVE_MLX5DV_DEVX_UAR_OFFSET is required to support
> + * packet pacing and already checked above. Hence, we should
> + * only make sure the SQs will be created with DevX, not with
> + * Verbs. Verbs allocates the SQ UAR on its own and it can't
> + * be shared with Clock Queue UAR as it required for the
> + * Tx scheduling feature.
> + */
> + DRV_LOG(ERR, "Verbs SQs, UAR can't be shared"
> + " as required for packet pacing");
Don't split logs.
> + err = ENODEV;
> + goto error;
> + err = ENODEV;
> + goto error;
I assume only the last 2 lines should be kept.
