Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power

2021-07-09 Thread Thomas Monjalon
23/06/2021 16:14, Burakov, Anatoly: > On 23-Jun-21 1:09 PM, David Hunt wrote: > > On 23/6/2021 11:14 AM, Burakov, Anatoly wrote: > >> On 22-Jun-21 3:07 PM, David Hunt wrote: > >>> The PMD Power Management scheme currently has 3 modes, > >>> scale, monitor and pause. However, it would be nice to > >

Re: [dpdk-dev] [PATCH] examples/pipeline: add FIB example

2021-07-09 Thread Thomas Monjalon
10/07/2021 00:13, Thomas Monjalon: > 09/07/2021 23:43, Thomas Monjalon: > > 09/07/2021 19:07, Cristian Dumitrescu: > > > Add example for FIB with VRF and ECMP support. > > > > > > Signed-off-by: Cristian Dumitrescu > > > Signed-off-by: Churchill Khangar > > > > Applied, thanks. > > Sorry, no i

Re: [dpdk-dev] [PATCH V2] pipeline: add support for LPM lookup

2021-07-09 Thread Thomas Monjalon
10/07/2021 00:13, Thomas Monjalon: > 09/07/2021 23:41, Thomas Monjalon: > > 08/07/2021 12:11, Cristian Dumitrescu: > > > Add support for the Longest Prefix Match (LPM) lookup to the SWX > > > pipeline. > > > > > > Signed-off-by: Cristian Dumitrescu > > > Signed-off-by: Churchill Khangar > > > >

Re: [dpdk-dev] [PATCH V4 3/5] pipeline: add support for selector tables

2021-07-09 Thread Thomas Monjalon
10/07/2021 02:20, Cristian Dumitrescu: > Add pipeline-level support for selector tables, > > Signed-off-by: Cristian Dumitrescu > --- > Change log: > > V3 -> V4: Fixed proper name of allocated structure > (rte_swx_table_selector_params instead of rte_swx_pipeline_selector_params). Applied (with

[dpdk-dev] [PATCH v16] app/testpmd: support multi-process

2021-07-09 Thread Min Hu (Connor)
This patch adds multi-process support for testpmd. For example the following commands run two testpmd processes: * the primary process: ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 * the secondary process: ./dpdk-testpmd --proc-type=auto -l 2-3 -

Re: [dpdk-dev] [PATCH 0/4] features for hns3 PMD

2021-07-09 Thread Min Hu (Connor)
在 2021/7/9 17:20, Andrew Rybchenko 写道: On 7/9/21 4:32 AM, Min Hu (Connor) wrote: Thanks Andrew, "net/hns3: supports disabling PFC by dev configure API" this patch could be abandoned. The other three can be applied. 在 2021/6/14 23:00, Andrew Rybchenko 写道: On 6/13/21 6:05 AM, Min Hu (Connor

[dpdk-dev] [PATCH v2 1/3] net/hns3: add query basic info support for VF

2021-07-09 Thread Min Hu (Connor)
From: Chengchang Tang There are some feautres of VF depend on PF, so it's necessary for VF to know whether current PF supports. Therefore, the final capability set of VF will be composed of the capability set of hardware and the capability set of PF. For comatibility reasons, the mailbox HNS3_MB

[dpdk-dev] [PATCH v2 2/3] net/hns3: support for VF modify VLAN filter state

2021-07-09 Thread Min Hu (Connor)
From: Chengchang Tang Since the HW limitation for VF, the VLAN filter is default enabled, and is not allowed to be closed. Now, the limitation has been removed in Kunpeng930 network engine, so this patch add support for VF to modify the VLAN filter state. A capabilities bit is added to different

[dpdk-dev] [PATCH v2 3/3] net/hns3: support multiple TC MAC pause

2021-07-09 Thread Min Hu (Connor)
From: Huisong Li MAC PAUSE can take effect on a single TC or multiple TCs, depending on the hardware. For example, the Kunpeng 920 supports MAC pause in a single TC, and the Kunpeng 930 supports MAC pause in multiple TCs. This patch supports MAC PAUSE in multiple TC for some hardware. Signed-off

[dpdk-dev] [PATCH v2 0/3] features for hns3 PMD

2021-07-09 Thread Min Hu (Connor)
This patchset contains 3 features for hns3 PMD: add query basic info support for VF support for VF modify VLAN filter state support multiple TC MAC pause Chengchang Tang (2): net/hns3: add query basic info support for VF net/hns3: support for VF modify VLAN filter state Huisong Li (1): net/

Re: [dpdk-dev] [PATCH V3 1/5] examples/pipeline: improve table update CLI commands

2021-07-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Friday, July 9, 2021 11:14 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Khangar, Churchill > Subject: Re: [dpdk-dev] [PATCH V3 1/5] examples/pipeline: improve table > update CLI commands > > 09/07/2021 23:37, Thomas Monjalon: >

[dpdk-dev] [PATCH V4 5/5] examples/pipeline: add selector example

2021-07-09 Thread Cristian Dumitrescu
Added the files to illustrate the selector table usage. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/selector.cli | 31 examples/pipeline/examples/selector.spec | 95 examples/pipeline/examples/selector.txt | 4 + 3 files changed, 130 ins

[dpdk-dev] [PATCH V4 4/5] examples/pipeline: add support for selector tables

2021-07-09 Thread Cristian Dumitrescu
Add application-evel support for selector tables. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 563 1 file changed, 563 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c ind

[dpdk-dev] [PATCH V4 3/5] pipeline: add support for selector tables

2021-07-09 Thread Cristian Dumitrescu
Add pipeline-level support for selector tables, Signed-off-by: Cristian Dumitrescu --- Change log: V3 -> V4: Fixed proper name of allocated structure (rte_swx_table_selector_params instead of rte_swx_pipeline_selector_params). lib/pipeline/rte_swx_ctl.c | 700

[dpdk-dev] [PATCH V4 1/5] examples/pipeline: improve table update CLI commands

2021-07-09 Thread Cristian Dumitrescu
From: Churchill Khangar For more felxibility, the single monolithic table update command is split into table entry add, table entry delete, table default entry add, pipeline commit and pipeline abort. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cl

[dpdk-dev] [PATCH V4 2/5] table: add support for selector tables

2021-07-09 Thread Cristian Dumitrescu
A selector table is made up of groups of weighted members, with a given member potentially part of several groups. The select operation returns a member ID by first selecting a group based on an input group ID and then selecting a member within that group based on hashing one or several input heade

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix build failure

2021-07-09 Thread Ajit Khaparde
On Fri, Jul 9, 2021 at 8:37 AM Ajit Khaparde wrote: > Fix build failures because of uninitialized variables. > > ../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function > ‘ulp_mapper_index_tbl_process’: > ../drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:43: error: ‘*(unsigned int > *)((char *)&glb_res +

Re: [dpdk-dev] [PATCH V3 1/5] examples/pipeline: improve table update CLI commands

2021-07-09 Thread Thomas Monjalon
09/07/2021 23:37, Thomas Monjalon: > 03/07/2021 00:46, Cristian Dumitrescu: > > From: Churchill Khangar > > > > For more felxibility, the single monolithic table update command is > > split into table entry add, table entry delete, table default entry > > add, pipeline commit and pipeline abort.

Re: [dpdk-dev] [PATCH V2] pipeline: add support for LPM lookup

2021-07-09 Thread Thomas Monjalon
09/07/2021 23:41, Thomas Monjalon: > 08/07/2021 12:11, Cristian Dumitrescu: > > Add support for the Longest Prefix Match (LPM) lookup to the SWX > > pipeline. > > > > Signed-off-by: Cristian Dumitrescu > > Signed-off-by: Churchill Khangar > > Applied, thanks. Sorry, no it cannot be in 21.08-rc

Re: [dpdk-dev] [PATCH] examples/pipeline: add FIB example

2021-07-09 Thread Thomas Monjalon
09/07/2021 23:43, Thomas Monjalon: > 09/07/2021 19:07, Cristian Dumitrescu: > > Add example for FIB with VRF and ECMP support. > > > > Signed-off-by: Cristian Dumitrescu > > Signed-off-by: Churchill Khangar > > Applied, thanks. Sorry, no it cannot be in 21.08-rc1 because the series "selector t

Re: [dpdk-dev] [PATCH v2] app/procinfo: add device registers dump

2021-07-09 Thread Thomas Monjalon
21/06/2021 04:17, Min Hu (Connor): > From: Chengchang Tang > > This patch add support for dump the device registers from a running > application. It can help developers locate the problem. > > Signed-off-by: Chengchang Tang > Signed-off-by: Min Hu (Connor) > --- > v2: > * some logs are adjuste

Re: [dpdk-dev] [PATCH] examples/pipeline: add FIB example

2021-07-09 Thread Thomas Monjalon
09/07/2021 19:07, Cristian Dumitrescu: > Add example for FIB with VRF and ECMP support. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Churchill Khangar Applied, thanks.

Re: [dpdk-dev] [PATCH V2] pipeline: add support for LPM lookup

2021-07-09 Thread Thomas Monjalon
08/07/2021 12:11, Cristian Dumitrescu: > Add support for the Longest Prefix Match (LPM) lookup to the SWX > pipeline. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Churchill Khangar Applied, thanks.

Re: [dpdk-dev] [PATCH V3 1/5] examples/pipeline: improve table update CLI commands

2021-07-09 Thread Thomas Monjalon
03/07/2021 00:46, Cristian Dumitrescu: > From: Churchill Khangar > > For more felxibility, the single monolithic table update command is > split into table entry add, table entry delete, table default entry > add, pipeline commit and pipeline abort. > > Signed-off-by: Churchill Khangar > Signed

Re: [dpdk-dev] [PATCH V2] pipeline: fix table entry read

2021-07-09 Thread Thomas Monjalon
06/07/2021 00:56, Cristian Dumitrescu: > The rte_swx_pipeline_table_entry_read() function is used to read from > a character string a table entry that is to be added to the table, > deleted from the table or set as the default entry of the table. > Addition needs both the match and the part of the

Re: [dpdk-dev] [PATCH V3] table: fix bucket empty logic

2021-07-09 Thread Thomas Monjalon
> > Due to a typo, only 3 out of 4 keys in the bucket of the exact match > > table were considered, which can result in valid keys being > > incorrectly dropped from the table. > > > > Fixes: d0a00966618ba ("table: add exact match SWX table") > > Cc: sta...@dpdk.org > > Cc: Cristian Dumitrescu >

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix build failure

2021-07-09 Thread Thomas Monjalon
09/07/2021 20:38, Ajit Khaparde: > On Fri, Jul 9, 2021 at 8:37 AM Ajit Khaparde > wrote: > > > Fix build failures because of uninitialized variables. > > > > ../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function > > ‘ulp_mapper_index_tbl_process’: > > ../drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:4

[dpdk-dev] [PATCH v2] net/bnxt: fix missing barriers in completion handling

2021-07-09 Thread Lance Richardson
Ensure that Rx/Tx/Async completion entry fields are accessed only after the completion's valid flag has been loaded and verified. This is needed for correct operation on systems that use relaxed memory consistency models. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Fixes: 6eb3cc2294fd ("

Re: [dpdk-dev] [PATCH 0/2] bugfix for SVE compile

2021-07-09 Thread Thomas Monjalon
28/06/2021 04:57, Chengwen Feng: > This patch set contains two bugfixes for SVE compile. > Note: > 1) Because 2/2 patch needs backport to 20.11 so we separate it. > 2) These two patches already acked by ARM guys from previous threads. > > Chengwen Feng (2): > build: fix SVE compile error with gc

Re: [dpdk-dev] [PATCH 1/2] build: fix SVE compile error with gcc8.3

2021-07-09 Thread Thomas Monjalon
28/06/2021 04:57, Chengwen Feng: > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -488,3 +488,9 @@ if cc.get_define('__ARM_FEATURE_CRYPTO', args: > machine_args) != '' > compile_time_cpuflags += ['RTE_CPUFLAG_AES', 'RTE_CPUFLAG_PMULL', > 'RTE_CPUFLAG_SHA1', 'RTE_CPUFLAG

[dpdk-dev] [PATCH v2] net/bnxt: fix build failure

2021-07-09 Thread Ajit Khaparde
Fix build failures because of uninitialized variables. ../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function ‘ulp_mapper_index_tbl_process’: ../drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:43: error: ‘*(unsigned int *)((char *)&glb_res + offsetof(struct bnxt_ulp_glb_resource_info, resource_func))’

Re: [dpdk-dev] [PATCH v10 0/8] Enhancements for PMD power management

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 6:08 PM Anatoly Burakov wrote: > > This patchset introduces several changes related to PMD power management: > > - Changed monitoring intrinsics to use callbacks as a comparison function, > based > on previous patchset [1] but incorporating feedback [2] - this hopefully

Re: [dpdk-dev] [PATCH v3] doc: policy on the promotion of experimental APIs

2021-07-09 Thread Tyler Retzlaff
On Fri, Jul 09, 2021 at 11:46:54AM +0530, Jerin Jacob wrote: > > + > > +Promotion to stable > > +~~~ > > + > > +Ordinarily APIs marked as ``experimental`` will be promoted to the stable > > ABI > > +once a maintainer and/or the original contributor is satisfied that the > > API is

Re: [dpdk-dev] [PATCH] net/bnxt: fix build failure

2021-07-09 Thread Lance Richardson
On Fri, Jul 9, 2021 at 4:48 AM Thomas Monjalon wrote: > > 09/07/2021 00:49, Ajit Khaparde: > > Fix build failures because of uninitialized variable usage. > > You should add the error log here. > You don't mention the condition of failure. > Nobody reproduced a failure so far. Hi Thomas, This ad

Re: [dpdk-dev] [PATCH] net/bnxt: fix missing barriers in completion handling

2021-07-09 Thread Lance Richardson
On Fri, Jul 9, 2021 at 2:00 AM Ruifeng Wang wrote: > > > +/** > > + * Check validity of a completion ring entry. If the entry is valid, > > include a > > + * C11 __ATOMIC_ACQUIRE fence to ensure that subsequent loads of fields > > in the > > + * completion are not hoisted by the compiler or by t

Re: [dpdk-dev] [PATCH] net/bnxt: fix build failure

2021-07-09 Thread Ajit Khaparde
On Fri, Jul 9, 2021 at 1:48 AM Thomas Monjalon wrote: > 09/07/2021 00:49, Ajit Khaparde: > > Fix build failures because of uninitialized variable usage. > > You should add the error log here. > You don't mention the condition of failure. > Nobody reproduced a failure so far. > Sure. I did not not

Re: [dpdk-dev] [PATCH v4 0/3] Use WFE for spinlock and ring

2021-07-09 Thread Thomas Monjalon
07/07/2021 07:48, Ruifeng Wang: > The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling > for a memory location to become equal to a given value'[1]. > > Use the API for the rte spinlock and ring implementations. > With the wait until equal APIs being stable, changes will not im

[dpdk-dev] RHEL 7 support

2021-07-09 Thread Thomas Monjalon
Hi, I would like to open a discussion about RHEL 7 support in DPDK. How long do we want to support it in new DPDK versions? Can we drop RHEL 7 support starting DPDK 21.11? If we decide to drop RHEL 7 support, does it mean we can generally use standard C11 atomics? What other benefits or impacts

Re: [dpdk-dev] [PATCH v18 0/7] aarch64 -> aarch32 cross compilation support

2021-07-09 Thread Thomas Monjalon
07/07/2021 15:25, Juraj Linkeš: > Add support for aarch32 cross build in meson. > > Aarch32 is an execution state that allows execution of 32-bit code on > armv8 machines. This execution state contains a superset of previous > armv7 32-bit instructions and features. Thus the aarch32 build is disti

[dpdk-dev] [PATCH 4/4] ethdev: remove jumbo offload flag

2021-07-09 Thread Ferruh Yigit
Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checking reported 'dev_info.max_mtu' or 'dev_info.max_rx_pktlen'. And instead of application explicitly set this flag to enable jumbo frames, this can be deduc

[dpdk-dev] [PATCH 3/4] ethdev: move check to library for MTU set

2021-07-09 Thread Ferruh Yigit
Move requested MTU value check to the API to prevent the duplicated code. Signed-off-by: Ferruh Yigit --- drivers/net/axgbe/axgbe_ethdev.c| 15 --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/cxgbe/cxgbe_ethdev.c| 13 + drivers/net/dpaa/dp

[dpdk-dev] [PATCH 2/4] ethdev: move jumbo frame offload check to library

2021-07-09 Thread Ferruh Yigit
Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, and application should enable the jumbo frame offload support for it. When jumbo frame offload is not enabled by application, but MTU bigger than RTE_ETHER_MTU is requested there are two options, either fail or enable jumbo fr

[dpdk-dev] [PATCH] examples/pipeline: add FIB example

2021-07-09 Thread Cristian Dumitrescu
Add example for FIB with VRF and ECMP support. Signed-off-by: Cristian Dumitrescu Signed-off-by: Churchill Khangar --- Depends-on: patch-17716 ("[V2] pipeline: add support for LPM lookup") examples/pipeline/examples/fib.cli| 58 ++ examples/pipeline/examples/fib.spec

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-09 Thread Tyler Retzlaff
On Fri, Jul 09, 2021 at 01:34:06PM +0200, Thomas Monjalon wrote: > 09/07/2021 02:16, Tyler Retzlaff: > > On Thu, Jul 08, 2021 at 10:39:13PM +0200, Thomas Monjalon wrote: > > > 08/07/2021 21:21, Tyler Retzlaff: > > > > (2) importing exported data symbols from a dll/dso on windows requires > > > >

[dpdk-dev] [PATCH v10 8/8] examples/l3fwd-power: support multiq in PMD modes

2021-07-09 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov Tested-by: David Hunt --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power

[dpdk-dev] [PATCH v10 7/8] power: support monitoring multiple Rx queues

2021-07-09 Thread Anatoly Burakov
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monitor is not supported by the hardware. Signed-off-by: A

[dpdk-dev] [PATCH v10 6/8] power: support callbacks for multiple Rx queues

2021-07-09 Thread Anatoly Burakov
Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism relies on ethdev Rx callbacks, so it is very difficult

[dpdk-dev] [PATCH v10 5/8] power: remove thread safety from PMD power API's

2021-07-09 Thread Anatoly Burakov
Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, which will greatly increase the possibility of various

[dpdk-dev] [PATCH v10 4/8] eal: add power monitor for multiple events

2021-07-09 Thread Anatoly Burakov
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a wake up on RTM transaction abort, so if we add the a

[dpdk-dev] [PATCH v10 3/8] doc: add PMD power management NIC feature

2021-07-09 Thread Anatoly Burakov
At this point, multiple different Ethernet drivers from multiple vendors will support the PMD power management scheme. It would be useful to add it to the NIC feature table to indicate support for it. Suggested-by: David Marchand Signed-off-by: Anatoly Burakov --- Notes: v10: - Added mi

[dpdk-dev] [PATCH v10 2/8] net/af_xdp: add power monitor support

2021-07-09 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v8: - Fix checkpatch issue v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+

[dpdk-dev] [PATCH v10 1/8] eal: use callbacks for power monitoring comparison

2021-07-09 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value in a specific way. This commit replaces the co

[dpdk-dev] [PATCH v10 0/8] Enhancements for PMD power management

2021-07-09 Thread Anatoly Burakov
This patchset introduces several changes related to PMD power management: - Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virt

Re: [dpdk-dev] [PATCH v9 3/8] doc: add PMD power management NIC feature

2021-07-09 Thread Burakov, Anatoly
On 09-Jul-21 4:53 PM, Anatoly Burakov wrote: At this point, multiple different Ethernet drivers from multiple vendors will support the PMD power management scheme. It would be useful to add it to the NIC feature table to indicate support for it. Suggested-by: David Marchand Signed-off-by: Anato

[dpdk-dev] [PATCH v2 1/1] power: fix potential null dereferences

2021-07-09 Thread Anatoly Burakov
Currently, the error paths can lead to attempts at dereferencing NULL pointers. Add the check to avoid attempts at dereferencing NULL pointers. Coverity issue: 371895 Coverity issue: 371889 Fixes: 06cffd468fdd ("power: refactor ACPI and intel_pstate support") Cc: anatoly.bura...@intel.com Signed-

Re: [dpdk-dev] [dpdk-stable] [EXT] [PATCH] compress/mlx5: fix memory region unregistration

2021-07-09 Thread Thomas Monjalon
08/07/2021 08:25, Michael Baum: > Hi, > > From: Akhil Goyal > > > The issue can cause illegal physical address access while a huge-page > > > A is released and huge-page B is allocated on the same virtual address. > > > The old MR can be matched using the virtual address of huge-page B but > > >

[dpdk-dev] [PATCH v9 8/8] examples/l3fwd-power: support multiq in PMD modes

2021-07-09 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov Tested-by: David Hunt --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power

[dpdk-dev] [PATCH v9 7/8] power: support monitoring multiple Rx queues

2021-07-09 Thread Anatoly Burakov
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monitor is not supported by the hardware. Signed-off-by: A

[dpdk-dev] [PATCH v9 6/8] power: support callbacks for multiple Rx queues

2021-07-09 Thread Anatoly Burakov
Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism relies on ethdev Rx callbacks, so it is very difficult

[dpdk-dev] [PATCH v9 5/8] power: remove thread safety from PMD power API's

2021-07-09 Thread Anatoly Burakov
Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, which will greatly increase the possibility of various

[dpdk-dev] [PATCH v9 4/8] eal: add power monitor for multiple events

2021-07-09 Thread Anatoly Burakov
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a wake up on RTM transaction abort, so if we add the a

[dpdk-dev] [PATCH v9 3/8] doc: add PMD power management NIC feature

2021-07-09 Thread Anatoly Burakov
At this point, multiple different Ethernet drivers from multiple vendors will support the PMD power management scheme. It would be useful to add it to the NIC feature table to indicate support for it. Suggested-by: David Marchand Signed-off-by: Anatoly Burakov --- doc/guides/nics/features.rst

[dpdk-dev] [PATCH v9 1/8] eal: use callbacks for power monitoring comparison

2021-07-09 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value in a specific way. This commit replaces the co

[dpdk-dev] [PATCH v9 0/8] Enhancements for PMD power management

2021-07-09 Thread Anatoly Burakov
This patchset introduces several changes related to PMD power management: - Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virt

[dpdk-dev] [PATCH v9 2/8] net/af_xdp: add power monitor support

2021-07-09 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v8: - Fix checkpatch issue v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+

Re: [dpdk-dev] [PATCH v1] doc: update ABI in MAINTAINERS file

2021-07-09 Thread Thomas Monjalon
25/06/2021 10:08, Ferruh Yigit: > On 6/22/2021 4:50 PM, Ray Kinsella wrote: > > Update to ABI MAINTAINERS. > > > > Signed-off-by: Ray Kinsella > > --- > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > ABI Policy & Versioning > > M: Ray Kinsella > > -M: Neil Horman > > F: lib/eal/include/rte_co

Re: [dpdk-dev] [PATCH] maintainers: update for ARM v8

2021-07-09 Thread Thomas Monjalon
25/06/2021 16:27, jer...@marvell.com: > From: Jerin Jacob > > Resigning my maintainership for ARM v8 architecture. > > Signed-off-by: Jerin Jacob > --- > > Resigning due to not getting enough quality time to review arm64 architecture > patches. > > Unlike those days where arm64 architecture s

Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number

2021-07-09 Thread Thomas Monjalon
21/06/2021 03:52, Ruifeng Wang: > From: Thomas Monjalon > > 18/06/2021 10:53, Thierry Herbelot: > > > On 6/18/21 10:51 AM, Thomas Monjalon wrote: > > > > 18/06/2021 04:09, Ruifeng Wang: > > > >> From: Thierry Herbelot > > > >>> 'part_number_config': { > > > >>> -'0xc00': {'machine_a

Re: [dpdk-dev] [PATCH v2 01/20] crypto/cnxk: add driver skeleton

2021-07-09 Thread David Marchand
Hello, On Thu, Jul 8, 2021 at 10:15 PM David Marchand wrote: > - Reproduced the issue in Ubuntu 18.04 GHA vms: > > FAILED: drivers/rte_crypto_cnxk.pmd.c > /usr/bin/python3 ../buildtools/gen-pmdinfo-cfile.py > /home/runner/work/dpdk/dpdk/build/buildtools ar > /home/runner/work/dpdk/dpdk/build/driv

[dpdk-dev] [PATCH 3/3] bitrate: promote rte_stats_bitrate_free() to stable

2021-07-09 Thread Kevin Traynor
rte_stats_bitrate_free() has been in DPDK since 20.11. Its signature is very basic as it just frees an opaque data struct allocated in rte_stats_bitrate_create() and returns void. It's unlikely that such a basic signature would need to change so might as well promote it to stable for the next maj

[dpdk-dev] [PATCH 2/3] bitrate: change calc implementation to match API description

2021-07-09 Thread Kevin Traynor
rte_stats_bitrate_calc() API states it returns 'Negative value on error'. However, the implementation will return the error code from rte_eth_stats_get() which may be non-zero on error. Change the implementation of rte_stats_bitrate_calc() to match the API description by always returning a negati

[dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description

2021-07-09 Thread Kevin Traynor
rte_stats_bitrate_reg() API states it returns 'Zero on success'. However, the implementation directly returns the return of rte_metrics_reg_names() which may be zero or positive on success, with a positive value also indicating the index. The user of rte_stats_bitrate_reg() should not care about

Re: [dpdk-dev] [PATCH] kni: update link only on change

2021-07-09 Thread Thomas Monjalon
24/06/2021 15:32, Ferruh Yigit: > 'rte_kni_update_link()' updates virtual KNI interface link using kernel > sysfs interface. > If the requested link status is same as interface link status, do not > update the link status but return with success. > > Signed-off-by: Ferruh Yigit Applied, thanks.

Re: [dpdk-dev] [PATCH v1 1/1] power: fix potential null dereferences

2021-07-09 Thread David Hunt
On 9/7/2021 4:09 PM, David Marchand wrote: On Fri, Jul 9, 2021 at 5:02 PM Anatoly Burakov wrote: Currently, the error paths can lead to attempts at dereferencing NULL pointers. Add the check to avoid attempts at dereferencing NULL pointers. Coverity issue: 371895 This patch also fixes C

Re: [dpdk-dev] [PATCH v1 1/1] power: fix potential null dereferences

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 5:02 PM Anatoly Burakov wrote: > > Currently, the error paths can lead to attempts at dereferencing NULL > pointers. Add the check to avoid attempts at dereferencing NULL > pointers. > Coverity issue: 371895 > Fixes: 06cffd468fdd ("power: refactor ACPI and intel_pstate sup

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] build: fix symlink of drivers for Windows

2021-07-09 Thread Thomas Monjalon
28/05/2021 10:19, Bruce Richardson: > On Mon, Apr 26, 2021 at 11:07:32AM +0100, Nick Connolly wrote: > > The symlink-drivers-solibs.sh script was disabled as part of 'install' > > for Windows because there is no support for shell scripts. However, > > this means that driver related DLLs are not pre

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-07-09 Thread David Marchand
On Thu, Jun 24, 2021 at 4:35 PM Burakov, Anatoly wrote: > Right, so the idea is store the PMD-specific data in the monitor > condition, and leave it to the callback to interpret it. > > The obvious question then is, how many values is enough? Two? Three? > Four? This option doesn't really solve th

[dpdk-dev] [PATCH v1 1/1] power: fix potential null dereferences

2021-07-09 Thread Anatoly Burakov
Currently, the error paths can lead to attempts at dereferencing NULL pointers. Add the check to avoid attempts at dereferencing NULL pointers. Fixes: 06cffd468fdd ("power: refactor ACPI and intel_pstate support") Cc: anatoly.bura...@intel.com Signed-off-by: Anatoly Burakov --- lib/power/power_

Re: [dpdk-dev] [PATCH v8 5/7] power: support callbacks for multiple Rx queues

2021-07-09 Thread Burakov, Anatoly
On 09-Jul-21 3:46 PM, David Marchand wrote: On Fri, Jul 9, 2021 at 4:42 PM Burakov, Anatoly wrote: You'd have to walk me through/translate whatever it is that you just said as i have no idea what any of that means :D https://git.dpdk.org/dpdk/commit/?id=fa5dbd825a Thanks, i'll separate it

Re: [dpdk-dev] [PATCH v8 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-07-09 Thread David Marchand
On Thu, Jul 8, 2021 at 4:14 PM Anatoly Burakov wrote: > > Currently, l3fwd-power enforces the limitation of having one queue per > lcore. This is no longer necessary, so remove the limitation. Title prefix is examples/l3fwd-power: for consistency sake. -- David Marchand

Re: [dpdk-dev] [PATCH v8 5/7] power: support callbacks for multiple Rx queues

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 4:42 PM Burakov, Anatoly wrote: > You'd have to walk me through/translate whatever it is that you just > said as i have no idea what any of that means :D https://git.dpdk.org/dpdk/commit/?id=fa5dbd825a -- David Marchand

Re: [dpdk-dev] [PATCH v8 5/7] power: support callbacks for multiple Rx queues

2021-07-09 Thread Burakov, Anatoly
On 09-Jul-21 3:24 PM, David Marchand wrote: On Thu, Jul 8, 2021 at 4:14 PM Anatoly Burakov wrote: diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 403c2b03a3..a96e12d155 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -912,6 +912,16

Re: [dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison

2021-07-09 Thread Burakov, Anatoly
On 09-Jul-21 2:46 PM, Thomas Monjalon wrote: 08/07/2021 16:13, Anatoly Burakov: doc/guides/rel_notes/release_21_08.rst| 2 ++ drivers/event/dlb2/dlb2.c | 17 -- drivers/net/i40e/i40e_rxtx.c | 20 +++ drivers/net/iavf/iavf_rxtx.c

Re: [dpdk-dev] [PATCH v8 5/7] power: support callbacks for multiple Rx queues

2021-07-09 Thread David Marchand
On Thu, Jul 8, 2021 at 4:14 PM Anatoly Burakov wrote: > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index 403c2b03a3..a96e12d155 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -912,6 +912,16 @@ Supports to get Rx/Tx packet burst

Re: [dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq driver

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 12:56 PM Richael Zhuang wrote: > > v8: > fix build issue with clang This cover letter is empty and we only have a partial changelog. I'll trust David Hunt reviews and go ahead with the series. Please put some effort in the cover letter and tracking changes for future contri

Re: [dpdk-dev] [PATCH v7] build: use platform for generic and native builds

2021-07-09 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Friday, July 9, 2021 2:31 PM > To: Juraj Linkeš ; Bruce Richardson > > Cc: dev@dpdk.org; david.march...@redhat.com; > honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; > ferruh.yi...@intel.com; jerinjac...@gmail.com > Subject: Re: [

Re: [dpdk-dev] [PATCH v8 1/7] power_intrinsics: use callbacks for comparison

2021-07-09 Thread Thomas Monjalon
08/07/2021 16:13, Anatoly Burakov: > doc/guides/rel_notes/release_21_08.rst| 2 ++ > drivers/event/dlb2/dlb2.c | 17 -- > drivers/net/i40e/i40e_rxtx.c | 20 +++ > drivers/net/iavf/iavf_rxtx.c | 20 +++ > drivers

Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58

2021-07-09 Thread Thomas Monjalon
01/07/2021 11:57, Bruce Richardson: > On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote: > > On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote: > > > The `doc` target used `echo` as its command. > > > On Windows, `echo` is always a shell built-in, there is no binary. > > > Startin

Re: [dpdk-dev] [PATCH v7] build: use platform for generic and native builds

2021-07-09 Thread Thomas Monjalon
07/07/2021 15:59, Bruce Richardson: > On Tue, Jul 06, 2021 at 11:44:28AM +0200, Juraj Linkeš wrote: > > The current meson option 'machine' should only specify the ISA, which is > > not sufficient for Arm, where setting ISA implies other settings as well > > (and is used in Arm configuration as such

Re: [dpdk-dev] [PATCH v1] net/octeontx/base: fix debug build with clang

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 8:03 AM Shijith Thotton wrote: > > From: David Marchand > > Remove conflicting declaration of this symbol. > > Fixes: d0d654986018 ("net/octeontx: support event Rx adapter") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] crypto/cnxk: fix debug build failure

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 10:47 AM Tejasree Kondoj wrote: > > Removing usage of unavailable macro. Fixes: baee42a6beff ("crypto/cnxk: add IPsec datapath") > > Reported-by: Ali Alnubani > Suggested-by: David Marchand > Signed-off-by: Tejasree Kondoj Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k

2021-07-09 Thread David Marchand
On Fri, Jul 9, 2021 at 8:29 AM Anoob Joseph wrote: > > Add PCI ID for crypo_cn9k PMD. > > To avoid conflicting PCI ID in crypto_octeontx2 and > crypto_cn9k PMDs, disable crypto_cn9k PMD when built with > octeontx2 config. > > The lack of PCI ID is causing debug build to fail for > crypto_cn9k PMD.

Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows

2021-07-09 Thread Thomas Monjalon
09/07/2021 02:16, Tyler Retzlaff: > On Thu, Jul 08, 2021 at 10:39:13PM +0200, Thomas Monjalon wrote: > > 08/07/2021 21:21, Tyler Retzlaff: > > > (2) importing exported data symbols from a dll/dso on windows requires > > > that the symbol be decorated with dllimport. optionally loading > > >

[dpdk-dev] [PATCH v8 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq

2021-07-09 Thread Richael Zhuang
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [PATCH v8 1/2] power: add support for cppc cpufreq

2021-07-09 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang Acked-by: David Hunt --- app/test/test_power.c

[dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq driver

2021-07-09 Thread Richael Zhuang
v8: fix build issue with clang Richael Zhuang (2): power: add support for cppc cpufreq test/power: round cpuinfo cur freq only in CPPC cpufreq app/test/test_power.c | 3 +- app/test/test_power_cpufreq.c | 26 +- doc/guides/rel_notes/release_21_08.rst | 4 + lib

Re: [dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq

2021-07-09 Thread Richael Zhuang
> -Original Message- > From: David Marchand > Sent: Friday, July 9, 2021 5:10 PM > To: Richael Zhuang > Cc: dev ; Yu Jiang ; David Hunt > > Subject: Re: [dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq > > On Fri, Jul 9, 2021 at 5:34 AM Richael Zhuang > wrote: > > > > Cu

Re: [dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq

2021-07-09 Thread David Hunt
On 9/7/2021 4:34 AM, Richael Zhuang wrote: Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- --snip-- Hi

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-09 Thread Andrew Rybchenko
On 7/9/21 6:57 PM, Jie Wang wrote: > This patch reapply Rx/Tx offloads configuration for all ports > after the program configuring the device port. When the program > configures the ports, the default Rx/Tx offloads are modified. > > So it is need to reapply Rx/Tx offloads configuration before > t

Re: [dpdk-dev] [PATCH 0/4] features for hns3 PMD

2021-07-09 Thread Andrew Rybchenko
On 7/9/21 4:32 AM, Min Hu (Connor) wrote: > Thanks Andrew, > "net/hns3: supports disabling PFC by dev configure API" > this patch could be abandoned. > > The other three can be applied. > > > 在 2021/6/14 23:00, Andrew Rybchenko 写道: >> On 6/13/21 6:05 AM, Min Hu (Connor) wrote: >>> This patch set

  1   2   >