> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Friday, July 9, 2021 2:31 PM > To: Juraj Linkeš <juraj.lin...@pantheon.tech>; Bruce Richardson > <bruce.richard...@intel.com> > Cc: dev@dpdk.org; david.march...@redhat.com; > honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; > ferruh.yi...@intel.com; jerinjac...@gmail.com > Subject: Re: [dpdk-dev] [PATCH v7] build: use platform for generic and native > builds > > 07/07/2021 15:59, Bruce Richardson: > > On Tue, Jul 06, 2021 at 11:44:28AM +0200, Juraj Linkeš wrote: > > > The current meson option 'machine' should only specify the ISA, > > > which is not sufficient for Arm, where setting ISA implies other > > > settings as well (and is used in Arm configuration as such). > > > Use the existing 'platform' meson option to differentiate the type > > > of the build (native/generic) and set ISA accordingly, unless the > > > user chooses to override it with a new option, 'cpu_instruction_set'. > > > The 'machine' option set the ISA in x86 builds and set > > > native/default 'build type' in aarch64 builds. These two new > > > variables, 'platform' and 'cpu_instruction_set', now properly set > > > both ISA and build type for all architectures in a uniform manner. > > > The 'machine' option also doesn't describe very well what it sets. > > > The new option, 'cpu_instruction_set', is much more descriptive. > > > Keep 'machine' for backwards compatibility. > > > > > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > > > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > > Applied, thanks. > > I did few doc formatting improvements and removed some mentions to Arm as > a SoC is not necessarily Arm (Risc-V is coming). > >
Ok, thanks, Thomas.
