Hello, On Thu, Jul 8, 2021 at 10:15 PM David Marchand <david.march...@redhat.com> wrote: > - Reproduced the issue in Ubuntu 18.04 GHA vms: > > FAILED: drivers/rte_crypto_cnxk.pmd.c > /usr/bin/python3 ../buildtools/gen-pmdinfo-cfile.py > /home/runner/work/dpdk/dpdk/build/buildtools ar > /home/runner/work/dpdk/dpdk/build/drivers/libtmp_rte_crypto_cnxk.a > drivers/rte_crypto_cnxk.pmd.c /usr/bin/python3 > ../buildtools/pmdinfogen.py elf > Traceback (most recent call last): > File "../buildtools/pmdinfogen.py", line 274, in <module> > main() > File "../buildtools/pmdinfogen.py", line 269, in main > drivers = load_drivers(image) > File "../buildtools/pmdinfogen.py", line 203, in load_drivers > drivers.append(Driver.load(image, symbol)) > File "../buildtools/pmdinfogen.py", line 157, in load > driver.pci_ids = cls._load_pci_ids(image, pci_table_name_symbol) > File "../buildtools/pmdinfogen.py", line 177, in _load_pci_ids > pci_id = rte_pci_id.from_buffer_copy(data) > ValueError: Buffer size too small (4 instead of at least 12 bytes)
I spent some time trying to understand this error, there is probably multiple bug(s) somewhere between pyelftools/ctype/pmdinfogen. In any case, on my f32, before https://git.dpdk.org/dpdk/commit/?id=b146c30d3c0e (that hides the issue), with a more "recent" pyelftools + python than Ubuntu 18.04, I can see: $ cat $HOME/builds/build-clang-shared/drivers/rte_crypto_cnxk.pmd.c static __attribute__((unused)) const char *generator = "../../dpdk/buildtools/pmdinfogen.py"; const char crypto_cn9k_pmd_info[] __attribute__((used)) = "PMD_INFO_STRING= {\"name\": \"crypto_cn9k\", \"kmod\": \"vfio-pci\", \"pci_ids\": [[10272, 25926, 28516, 24946], [11824, 11569, 11827, 25446]]}"; const char crypto_cn10k_pmd_info[] __attribute__((used)) = "PMD_INFO_STRING= {\"name\": \"crypto_cn10k\", \"kmod\": \"vfio-pci\", \"pci_ids\": [[6013, 41203, 65535, 65535]]}"; $ nm -S /home/dmarchan/builds/build-clang-shared/drivers/librte_crypto_cnxk.so |grep cpt_table 000000000001d400 0000000000000018 b pci_id_cpt_table 000000000001d2f0 0000000000000018 d pci_id_cpt_table You'll notice the former is located in bss. $ hexdump -s $(($(printf "%d" 0x000000000001d400) - $(printf "%d" 0x1000))) -n $(printf "%d" 0x18) /home/dmarchan/builds/build-clang-shared/drivers/librte_crypto_cnxk.so 001c400 6e61 2067 6576 7372 6f69 206e 3031 302e 001c410 312e 2820 6546 6f64 001c418 $ hexdump -s $(($(printf "%d" 0x000000000001d2f0) - $(printf "%d" 0x1000))) -n $(printf "%d" 0x18) /home/dmarchan/builds/build-clang-shared/drivers/librte_crypto_cnxk.so 001c2f0 ffff 00ff 177d a0f3 ffff ffff 0000 0000 001c300 0000 0000 0000 0000 001c308 Those values match what the pmd.c file contains. Are we missing a "memset()" for such symbols in pmdinfogen? Or maybe a warning that we are adding an empty pci ids table.. There is no urgency, but if you find some time to look at this. Thanks. -- David Marchand
