> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Friday, July 9, 2021 11:14 PM > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com> > Cc: dev@dpdk.org; Khangar, Churchill <churchill.khan...@intel.com> > Subject: Re: [dpdk-dev] [PATCH V3 1/5] examples/pipeline: improve table > update CLI commands > > 09/07/2021 23:37, Thomas Monjalon: > > 03/07/2021 00:46, Cristian Dumitrescu: > > > From: Churchill Khangar <churchill.khan...@intel.com> > > > > > > For more felxibility, the single monolithic table update command is > > > split into table entry add, table entry delete, table default entry > > > add, pipeline commit and pipeline abort. > > > > > > Signed-off-by: Churchill Khangar <churchill.khan...@intel.com> > > > Signed-off-by: Cristian Dumitrescu <cristian.dumitre...@intel.com> > > > > Series applied, thanks. > > Sorry, only first 2 patches are really kept, > because the patch 3 fails 32-bit compilation: > > lib/pipeline/rte_swx_pipeline.c:9851:33: error: > array subscript ‘struct rte_swx_table_selector_params[0]’ > is partly outside array bounds of ‘unsigned char[24]’ [-Werror=array-bounds] > >
Hi Thomas, I just set V4 for this patch set (and the entire series); it was basically just a typo that created a small memory allocation bug: the code was incorrectly using sizeof(struct rte_swx_pipeline_selector_params) instead of sizeof(struct rte_swx_table_selector_params) for the calloc call, hence the warning. I know it is very late at night right now and you are still awake working to get RC1 done (I am just 1 hour before you time zone wise ;)), I would appreciate if you could still look at applying this for RC1, only if possible. Thank you so much! Regards, Cristian
