Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

2021-05-11 Thread Akhil Goyal
> From: Akhil Goyal > > Hi Matan, > > > > > > > +Prerequisites > > > > > > > +- > > > > > > > + > > > > > > > +- Mellanox OFED version: **5.3** > > > > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED > > > > > > > details. > > > > > > > > > > > > Since the driver is by

[dpdk-dev] [PATCH] net/mlx5: fix the mirror not work with meter action

2021-05-11 Thread Jiawei Wang
While there's mirror action prior to the meter action in the E-Switch flow, means that the packets should be duplicated into port firstly, and then do meter and send to the original destination. MLX5 PMD will split the above E-Switch flow into two sub flows, similar as mirror with modify action bef

Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

2021-05-11 Thread Akhil Goyal
> From: Akhil Goyal > > > > > > Also set feature flag in the code and the documentation in this > patch. > > > > > > I see that you are setting all of them in a single patch in the end. > > > > > > This is not correct. It should be added where the feature is > supported. > > > > > > Please fix thi

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

2021-05-11 Thread Akhil Goyal
> From: Akhil Goyal > > > > > > > +static void > > > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > > > > + struct rte_cryptodev_sym_session > > > > > > > *sess) { > > > > > > > + struct mlx5_crypto_priv *priv = dev->data->dev_private; > > >

[dpdk-dev] [PATCH] net/mlx5: support RSS expansion for NVGRE

2021-05-11 Thread Jiawei Wang
Currently RSS expansion only support GRE and GRE KEY. This patch add RSS expansion for NVGRE item so PMD can expand flow item correctly. Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") Cc: sta...@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 9

[dpdk-dev] [PATCH v2] net/i40e: fix VF RSS configuration

2021-05-11 Thread Alvin Zhang
The kernel driver supports VF RSS configuration message "VIRTCHNL_OP_GET_RSS_HENA_CAPS and VIRTCHNL_OP_SET_RSS_HENA", this patch adds PMD support for these messages. Fixes: b81295c474b0 ("net/i40e: add user callback for VF to PF message") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- v2: U

Re: [dpdk-dev] [PATCH] net/i40e: fix VF RSS configuration

2021-05-11 Thread Xing, Beilei
> -Original Message- > From: Zhang, AlvinX > Sent: Wednesday, May 12, 2021 1:48 PM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PATCH] net/i40e: fix VF RSS configuration > > The kernel driver supports VF RSS configuration message > "V

Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

2021-05-11 Thread Matan Azrad
From: Akhil Goyal > Hi Matan, > > > > > > +Prerequisites > > > > > > +- > > > > > > + > > > > > > +- Mellanox OFED version: **5.3** > > > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > > > > > > > Since the driver is by default compiled off due to t

Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

2021-05-11 Thread Matan Azrad
From: Akhil Goyal > > From: Akhil Goyal > > > > From: Akhil Goyal > > > > > > From: Suanming Mou > > > > > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the > > > > > > keytag is also

Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

2021-05-11 Thread Matan Azrad
From: Akhil Goyal > > > > > Also set feature flag in the code and the documentation in this patch. > > > > > I see that you are setting all of them in a single patch in the end. > > > > > This is not correct. It should be added where the feature is > > > > > supported. > > > > > Please fix thi

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

2021-05-11 Thread Matan Azrad
From: Akhil Goyal > > > > > > +static void > > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > > > + struct rte_cryptodev_sym_session *sess) > > > > > > { > > > > > > + struct mlx5_crypto_priv *priv = dev->data->dev_private; > > > > > > +

[dpdk-dev] [PATCH] net/i40e: fix VF RSS configuration

2021-05-11 Thread Alvin Zhang
The kernel driver supports VF RSS configuration message "VIRTCHNL_OP_GET_RSS_HENA_CAPS and VIRTCHNL_OP_SET_RSS_HENA", this patch adds PMD support for these messages. Fixes: b81295c474b0 ("net/i40e: add user callback for VF to PF message") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drive

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-11 Thread Akhil Goyal
> From: Akhil Goyal > > > > > > > +fmt_name = 'mlx5_crypto' > > > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > > > See RTE_LOG_REGISTER. > > > > > > > > Compilation works fine even after

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-05-11 Thread Feifei Wang
Hi, Slava Please see below. > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月11日 16:19 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; sta...@dpdk.org; Ruifeng Wang > ; nd ; nd > 主题: RE: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache > > Hi,

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-11 Thread Matan Azrad
From: Akhil Goyal > > > > > > +fmt_name = 'mlx5_crypto' > > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > See RTE_LOG_REGISTER. > > > > > > Compilation works fine even after removing this d

[dpdk-dev] [PATCH] net/ice: fix VSI array out of bounds

2021-05-11 Thread Wang Jie
In the loop, when the index of array "vsi->rss_key" is equal to "vsi->rss_key_size", the array will be out of bounds. Fixes: 50370662b727 ("net/ice: support device and queue ops") Signed-off-by: Wang Jie --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH v3 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq

2021-05-11 Thread Richael Zhuang
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [PATCH v3 1/2] power: add support for cppc cpufreq

2021-05-11 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app/test/test_power.c | 3 +- app/test/test_power_c

[dpdk-dev] [PATCH v3 0/2] power: add support for cppc cpufreq driver

2021-05-11 Thread Richael Zhuang
v3: rebase on Anatoly's patch: http://dpdk.org/patch/92077; fix check_cur_freq bug: round cur freq only when using CPPC driver Richael Zhuang (2): power: add support for cppc cpufreq test/power: round cpuinfo cur freq only when using CPPC cpufreq app/test/test_power.c | 3 +- app/

[dpdk-dev] [PATCH v2 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq

2021-05-11 Thread Richael Zhuang
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set when using CPPC cpufreq driver. For other cpufreq driver, no need to round it currently, or else this check will fail with turbo enabled. For example, with acpi_cpufreq, cpuinfo_cur_freq can be 240

[dpdk-dev] [PATCH v2 1/2] power: add support for cppc cpufreq

2021-05-11 Thread Richael Zhuang
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are supported, which are both not available on arm64 platforms. Add support for cppc_cpufreq driver which works on most arm64 platforms. Signed-off-by: Richael Zhuang --- app/test/test_power.c | 3 +- app/test/test_power_c

[dpdk-dev] [PATCH v2 0/2] power: add support for cppc cpufreq driver

2021-05-11 Thread Richael Zhuang
v2: rebase on Anatoly's patch: http://dpdk.org/patch/92077; fix check_cur_freq bug: round cur freq only when using CPPC driver Richael Zhuang (2): power: add support for cppc cpufreq test/power: round cpuinfo cur freq only when using CPPC cpufreq app/test/test_power.c | 3 +- app/

Re: [dpdk-dev] [PATCH v4 3/3] vhost: fix offload flags in Rx path

2021-05-11 Thread Wang, Yinan
Hi David, Since vhost tx offload can’t work now, we report a Bugzilla as below, could you help to take a look? https://bugs.dpdk.org/show_bug.cgi?id=702 We also tried vhost example with VM2VM iperf test, large pkts also can't forwarding. BR, Yinan > -Original Message- > From: dev On

[dpdk-dev] [PATCH] net/ice: fix VSI array out of bounds

2021-05-11 Thread Jie Wang
From: Wang Jie In the loop, when the index of array "vsi->rss_key" is equal to "vsi->rss_key_size", the array will be out of bounds. Fixes: 50370662b727 ("net/ice: support device and queue ops") Signed-off-by: Wang Jie --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [Bug 702] [dpdk-21.05] perf_vm2vm_virtio_net_perf/test_vm2vm_split_ring_iperf_with_tso: vm can't forward big packets

2021-05-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=702 Bug ID: 702 Summary: [dpdk-21.05] perf_vm2vm_virtio_net_perf/test_vm2vm_split_ring_iperf _with_tso: vm can't forward big packets Product: DPDK Version: unspecified

[dpdk-dev] [PATCH] vhost: fix unintended sign extension in async split ring

2021-05-11 Thread Cheng Jiang
Change the variable type in store_dma_desc_info_split() to fix suspicious implicit sign extension. Coverity issue: 370604, 370607, 370609 Fixes: 3d6cb86b0de5 (vhost: refactor async split ring functions) Signed-off-by: Cheng Jiang --- lib/vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH] vhost: fix unintended sign extension in async packed ring

2021-05-11 Thread Cheng Jiang
Change the variable type in store_dma_desc_info_packed() to fix suspicious implicit sign extension. Coverity issue: 370608, 370610, 370612 Fixes: 873e8dad6f49 (vhost: support packed ring in async datapath) Signed-off-by: Cheng Jiang --- lib/vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion

[dpdk-dev] [PATCH v2] lib/librte_power: fix using variables before validity check

2021-05-11 Thread Min Hu (Connor)
From: HongBo Zheng In function power_guest_channel_read_msg, 'lcore_id' is used before validity check, which may cause buffer 'global_fds' accessed by index 'lcore_id' overflow. This patch moves the validity check of 'lcore_id' before the 'lcore_id' being used for the first time. Fixes: 9dc843e

Re: [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color

2021-05-11 Thread Haifei Luo
HI Ferruh, Will update the doc and send V3. Thank you. -Original Message- From: Ferruh Yigit Sent: Wednesday, May 12, 2021 3:22 AM To: Haifei Luo ; Matan Azrad ; Ori Kam ; Slava Ovsiienko ; Xiaoyun Li Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; Raslan Darawsheh Subject: Re:

Re: [dpdk-dev] [PATCH v3 2/2] eal: fix side effects in ptr align macros

2021-05-11 Thread Wang, Haiyue
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Tuesday, May 11, 2021 16:45 > To: Wang, Haiyue ; david.march...@redhat.com; Matan > Azrad ; > Shahaf Shuler ; Viacheslav Ovsiienko > ; Jiawen Wu > ; Jian Wang ; Chautru, > Nicolas > ; Thomas Monjalon ; Yigit, > Ferruh > ;

Re: [dpdk-dev] [PATCH 6/6] doc: add link status event pre-conditions

2021-05-11 Thread Min Hu (Connor)
在 2021/5/12 0:14, Ferruh Yigit 写道: On 5/7/2021 10:08 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch adds link status event pre-conditions. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- doc/guides/nics/hns3.rst | 10 ++ 1 file changed, 10 insertions

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix port ID format specifier

2021-05-11 Thread Thomas Monjalon
12/05/2021 00:34, Tyler Retzlaff: > On Thu, May 06, 2021 at 01:13:07AM +0200, Thomas Monjalon wrote: > > 06/05/2021 00:45, Tyler Retzlaff: > > > as a side question, what is the projects stance on getting more warnings > > > clean? there are a few not enabled that i'd really like to see e.g. > > > f

Re: [dpdk-dev] [dpdk-announce] release candidate 21.05-rc2

2021-05-11 Thread Thinh Tran
DPDK 21.05 RC2 on IBM Power result * DPDK: v21.05-rc2-8-gbe81f77d8 * OS: RHEL 8.3 kernel level: 4.18.0-240.el8.ppc64le * GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. System tested: - IBM Power9 Model 8

Re: [dpdk-dev] [PATCH 1/2] net/ark: fix bug introduced during thread name addition

2021-05-11 Thread Ed Czeck
There is only one patch for this submission. (The second one remains under development). Thanks, On Tue, May 11, 2021 at 6:50 PM Ferruh Yigit wrote: > On 5/11/2021 11:48 PM, Ferruh Yigit wrote: > > On 5/11/2021 9:58 PM, Ed Czeck wrote: > >> Fixes: fdefe038eb9b ("net/ark: set generator delay th

Re: [dpdk-dev] [PATCH 1/2] net/ark: fix bug introduced during thread name addition

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 11:48 PM, Ferruh Yigit wrote: > On 5/11/2021 9:58 PM, Ed Czeck wrote: >> Fixes: fdefe038eb9b ("net/ark: set generator delay thread name") >> Cc: fengcheng...@huawei.com >> >> Signed-off-by: Ed Czeck > > Acked-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks. > (changed th

Re: [dpdk-dev] [PATCH 1/2] net/ark: fix bug introduced during thread name addition

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 9:58 PM, Ed Czeck wrote: > Fixes: fdefe038eb9b ("net/ark: set generator delay thread name") > Cc: fengcheng...@huawei.com > > Signed-off-by: Ed Czeck Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. (changed the patch title and added a commit log, please check)

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix port ID format specifier

2021-05-11 Thread Tyler Retzlaff
On Thu, May 06, 2021 at 01:13:07AM +0200, Thomas Monjalon wrote: > 06/05/2021 00:45, Tyler Retzlaff: > > as a side question, what is the projects stance on getting more warnings > > clean? there are a few not enabled that i'd really like to see e.g. > > format, conversion, truncation etc.. > > > >

Re: [dpdk-dev] [PATCH v4] net/mlx5: fix tunnel offload private items location

2021-05-11 Thread Ferruh Yigit
On 5/6/2021 10:57 AM, Gregory Etelson wrote: > Tunnel offload API requires application to query PMD for specific flow > items and actions. Application uses these PMD specific elements to > build flow rules according to the tunnel offload model. > The model does not restrict private elements locatio

Re: [dpdk-dev] [PATCH v1] net/enic: enable GENEVE offload via VNIC configuration

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 8:25 PM, John Daley wrote: > The admin-configured vNIC settings (i.e. via CIMC or UCSM) now include > Geneve offload. Use that setting to decide whether to enable or > disable Geneve offload and remove the devarg 'geneve-opt'. > > Also, the firmware now allows the driver to change the

Re: [dpdk-dev] [PATCH v2 0/2] Thread termination leak fixes

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 12:33 PM, David Marchand wrote: > After looking at the control thread API use in recent changes, I noticed > that some thread resources are not properly released. > This series fixes two net drivers. > Series applied to dpdk-next-net/main, thanks. > Additional notes: > - I noticed t

[dpdk-dev] [PATCH] doc: remove PDF requirements

2021-05-11 Thread Thomas Monjalon
The documentation is generated in HTML only. The PDF format is abandoned since DPDK 20.11 while dropping support of the make-based build. This decision has been mentioned by the Technical Board: https://mails.dpdk.org/archives/dev/2021-January/195549.html Fixes: 3cc6ecfdfe85 ("build: remove makef

[dpdk-dev] [PATCH 1/2] net/ark: fix bug introduced during thread name addition

2021-05-11 Thread Ed Czeck
Fixes: fdefe038eb9b ("net/ark: set generator delay thread name") Cc: fengcheng...@huawei.com Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index 6372cf7740..

Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning

2021-05-11 Thread Thomas Monjalon
10/05/2021 16:48, Bruce Richardson: > On Mon, May 10, 2021 at 04:06:00PM +0200, David Marchand wrote: > > On Mon, May 10, 2021 at 2:55 PM Kevin Laatz wrote: > > > > > > In the function __idxd_completed_ops() we have a parameter shadow warning > > > due to a local variable having the same name as o

Re: [dpdk-dev] [PATCH v4] eal: fix memory mapping for 32-bit targets

2021-05-11 Thread Thomas Monjalon
11/05/2021 18:08, Dmitry Kozlyuk: > 2021-05-11 11:56 (UTC-0400), Lance Richardson: > > > v4: Identical to v1, with now included in rte_eal_paging.h > > > to (hopefully) make off_t available for Windows builds. > > > > With this version, using off_t is no longer a problem, however based on

Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets

2021-05-11 Thread Thomas Monjalon
10/05/2021 17:31, Burakov, Anatoly: > On 10-May-21 1:42 PM, Thomas Monjalon wrote: > > +Cc Anatoly > > > > 08/05/2021 16:27, Lance Richardson: > >> For 32-bit targets, size_t is normally a 32-bit type and > >> does not have sufficient range to represent 64-bit offsets > >> that can are needed when

[dpdk-dev] DTS Workgroup: MoM 05/28/2021

2021-05-11 Thread Honnappa Nagarahalli
Hello, I plan to send out the MoM for the DTS workgroup meetings. Please feel free to add or correct anything that I might have missed. The minutes will be short as most of the discussion is being captured in the google doc [1]. Thank you, Honnappa Attendees: Aaron Conole Daniel Martin

Re: [dpdk-dev] [PATCH v4] eal: fix memory mapping for 32-bit targets

2021-05-11 Thread Lance Richardson
> v4: Identical to v1, with now included in rte_eal_paging.h > to (hopefully) make off_t available for Windows builds. With this version, using off_t is no longer a problem, however based on the new compilation error it appears that for Windows, off_t is a 32-bit type while size_t is a 64-b

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-05-11 Thread Honnappa Nagarahalli
> > >> >> > >> >> > > >> >> > The patch still holds true for CRC though as it is listed > >> >> > separately below > >> >> > https://urldefense.proofpoint.com/v2/url?u=https- > >> >3A__developer.arm.com_architectures_cpu-2Darchitecture_a- > >> >2D&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMV

[dpdk-dev] [PATCH v1] net/enic: enable GENEVE offload via VNIC configuration

2021-05-11 Thread John Daley
The admin-configured vNIC settings (i.e. via CIMC or UCSM) now include Geneve offload. Use that setting to decide whether to enable or disable Geneve offload and remove the devarg 'geneve-opt'. Also, the firmware now allows the driver to change the Geneve port number. So extend udp_tunnel_port_{ad

Re: [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 10:28 AM, Haifei Luo wrote: > Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined. > Add the CLI for this action in meter policy: color type (types) > There are three types: green, yellow and red. > > Example for the new policy meter CLIs: >add port meter policy 0 1 g_act

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix tunnel offload flows

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 9:03 AM, Gregory Etelson wrote: > Tunnel offload model requires application to obtain PMD related flow > items or actions to construct a flow rule. These elements acquire > internal PMD flow resources that must be explicitly released. > > The patch destroys tunnel offload PMD resource

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-05-11 Thread Pavan Nikhilesh Bhagavatula
>> >> >> >> > >> >> > The patch still holds true for CRC though as it is listed >> >> > separately below >> >> > https://urldefense.proofpoint.com/v2/url?u=https- >> >3A__developer.arm.com_architectures_cpu-2Darchitecture_a- >> >2D&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB- >> >fmvgGV3o- >

[dpdk-dev] [PATCH v4] eal: fix memory mapping for 32-bit targets

2021-05-11 Thread Lance Richardson
For 32-bit targets, size_t is normally a 32-bit type and does not have sufficient range to represent 64-bit offsets that can are needed when mapping PCI addresses. Use off_t instead, which is usually a 64-bit type when compiled with _D_FILE_OFFSET_BITS=64 as is the case for DPDK. Found when attemp

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix IPv6 header initialization

2021-05-11 Thread Lance Richardson
On Tue, May 11, 2021 at 10:31 AM David Marchand wrote: > > On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson > wrote: > > > > Fix two issues found when writing PMD unit tests for HW ptype and > > L4 checksum offload: > > Would those unit tests be interesting to other pmd driver writers? > I think

Re: [dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD

2021-05-11 Thread Ferruh Yigit
On 5/10/2021 2:38 PM, Min Hu (Connor) wrote: > This patch set contains four bugfix for hns3 PMD > > Chengwen Feng (4): > net/hns3: fix unsupported mbx msg id log error > net/hns3: fix secondary process request start/stop Rx/Tx > net/hns3: fix memory barrier incorrectly placed > net/hns3: r

Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities

2021-05-11 Thread Akhil Goyal
Hi Matan, > > > > > +Prerequisites > > > > > +- > > > > > + > > > > > +- Mellanox OFED version: **5.3** > > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED details. > > > > > > > > Since the driver is by default compiled off due to the dependency on > > > > external Lib

Re: [dpdk-dev] [PATCH 1/2] net/ark: fix leak on thread termination

2021-05-11 Thread Ed Czeck
Thank you. Acked-by: Ed Czeck On Thu, May 6, 2021 at 5:45 AM David Marchand wrote: > A terminated pthread should be joined or detached so that its associated > resources are released. > > The "ark-delay-pg" thread is just used to delay some task but it is never > joined by the thread that cre

Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument

2021-05-11 Thread Akhil Goyal
> > From: Akhil Goyal > > > From: Akhil Goyal > > > > > From: Suanming Mou > > > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the > > > > > keytag is also supplied in the BSF as plaintext. T

Re: [dpdk-dev] [PATCH] net/hns3: fix TM QCN error event report by MSIX

2021-05-11 Thread Ferruh Yigit
On 5/8/2021 8:40 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > The TM QCN error event should report by RAS other than MSIX. > > Also this patch adds fifo int enable configuration before the TM QCN > error event is enabled. > > Fixes: f53a793bb7c2 ("net/hns3: add more hardware error types

Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API

2021-05-11 Thread Akhil Goyal
> > > > > > > Also set feature flag in the code and the documentation in this patch. > > > > I see that you are setting all of them in a single patch in the end. > > > > This is not correct. It should be added where the feature is supported. > > > > Please fix this for all the feature flags. > > >

Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets

2021-05-11 Thread Lance Richardson
On Tue, May 11, 2021 at 4:18 AM Thomas Monjalon wrote: > > 08/05/2021 16:27, Lance Richardson: > > For 32-bit targets, size_t is normally a 32-bit type and > > does not have sufficient range to represent 64-bit offsets > > that can are needed when mapping PCI addresses. Use uint64_t > > instead. >

Re: [dpdk-dev] [PATCH v2 2/2] net/ice: fix leak on thread termination

2021-05-11 Thread Dmitry Kozlyuk
2021-05-11 13:33 (UTC+0200), David Marchand: > A terminated pthread should be joined or detached so that its associated > resources are released. > > The "ice-reset-" threads are used to service some reset task in the > background, but they are never joined by the thread that created them. > The e

Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations

2021-05-11 Thread Akhil Goyal
> > > > > > > +static void > > > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > > > + struct rte_cryptodev_sym_session *sess) { > > > > > + struct mlx5_crypto_priv *priv = dev->data->dev_private; > > > > > + struct mlx5_crypto_session *sess_pri

Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD

2021-05-11 Thread Akhil Goyal
> > > > > > > + > > > > > +fmt_name = 'mlx5_crypto' > > > > > +deps += ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > See RTE_LOG_REGISTER. > > > > Compilation works fine even after removing this dependency. > > I beli

Re: [dpdk-dev] [PATCH 3/3] eal/windows: cleanup interrupt resources

2021-05-11 Thread Ranjit Menon
On 5/1/2021 7:33 PM, Dmitry Kozlyuk wrote: Interrupt manager in Windows EAL allocates on IOCP and starts a control thread that runs indefinitely. At DPDK cleanup this thread was not stopped and IOCP handle was not closed. Gracefully stop interrupt-handling in rte_eal_cleanup(). The thread alre

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources

2021-05-11 Thread Ranjit Menon
On 5/11/2021 12:59 AM, Dmitry Kozlyuk wrote: 2021-05-11 09:41 (UTC+0200), Thomas Monjalon: 02/05/2021 04:33, Dmitry Kozlyuk: Interrupt manager in Windows EAL allocates on IOCP and starts a control thread that runs indefinitely. At DPDK cleanup this thread was not stopped and IOCP handle was n

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-05-11 Thread Honnappa Nagarahalli
> >> > >> > > >> > The patch still holds true for CRC though as it is listed > >> > separately below > >> > https://urldefense.proofpoint.com/v2/url?u=https- > >3A__developer.arm.com_architectures_cpu-2Darchitecture_a- > >2D&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB- > >fmvgGV3o- > >g_fj

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/txgbe: fix to strip QINQ

2021-05-11 Thread Ferruh Yigit
On 5/8/2021 7:35 AM, Jiawen Wu wrote: > Support to enable and disable QINQ hardware strip, when configure vlan > offload with QINQ strip mask. If there are packets have QINQ tag to RSS, > users should enable QINQ strip before configuring the RSS. > > Fixes: 220b0e49bc47 ("net/txgbe: support VLAN")

[dpdk-dev] GRO-Flow-Chaining

2021-05-11 Thread kumaraparameshwaran rathinavel
Hi All, I just need few clarifications in the GRO code that is present In the below code where the merge fails because the IP length is greater than 65536 we do a insert_new_item but we send prev_idx rather than the cur_idx. This would work for index 0 and 1 but when cur_idx is 1 and merge fails,

Re: [dpdk-dev] [PATCH 0/6] bugfix for hns3 PMD

2021-05-11 Thread Ferruh Yigit
On 5/7/2021 10:08 AM, Min Hu (Connor) wrote: > This patch set contains 6 bugfixes for hns3 PMD. > > Chengwen Feng (5): > net/hns3: return code when PCI config space write fail > net/hns3: fix logging info when clear all FDIR rules > net/hns3: clear hash map when clear all FDIR rules > net/

Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check

2021-05-11 Thread McDaniel, Timothy
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, May 11, 2021 10:32 AM > To: dev@dpdk.org; McDaniel, Timothy ; Xing, > Beilei ; Wu, Jingjing ; Yang, > Qiming ; Zhang, Qi Z ; Wang, > Haiyue ; Matan Azrad ; Shahaf > Shuler ; Viacheslav Ovsiienko ; > Richardson, Bruce ; Ananyev,

Re: [dpdk-dev] [PATCH 6/6] doc: add link status event pre-conditions

2021-05-11 Thread Ferruh Yigit
On 5/7/2021 10:08 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > This patch adds link status event pre-conditions. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > doc/guides/nics/hns3.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/doc

Re: [dpdk-dev] [PATCH v4] eal: fix memory mapping for 32-bit targets

2021-05-11 Thread Dmitry Kozlyuk
2021-05-11 11:56 (UTC-0400), Lance Richardson: > > v4: Identical to v1, with now included in rte_eal_paging.h > > to (hopefully) make off_t available for Windows builds. > > With this version, using off_t is no longer a problem, however based on the > new compilation error it appears that

Re: [dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check

2021-05-11 Thread Burakov, Anatoly
On 11-May-21 4:31 PM, Anatoly Burakov wrote: Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value.

Re: [dpdk-dev] [21.08 PATCH v1 2/2] net/af_xdp: add power monitor support

2021-05-11 Thread Burakov, Anatoly
On 11-May-21 4:31 PM, Anatoly Burakov wrote: Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- static const struct eth_dev_ops ops = { - .dev_start = eth_dev_start, - .dev_stop = eth_dev_stop, - .dev_close = eth_dev_close, -

[dpdk-dev] [21.08 PATCH v1 2/2] net/af_xdp: add power monitor support

2021-05-11 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- drivers/net/af_xdp/rte_eth_af_xdp.c | 52 - 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_a

[dpdk-dev] [21.08 PATCH v1 1/2] power: invert the monitor check

2021-05-11 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value. We can reverse the check, and instead have mo

Re: [dpdk-dev] [PATCH] doc: fix build with Sphinx 4

2021-05-11 Thread Thomas Monjalon
11/05/2021 15:25, David Marchand: > On Tue, May 11, 2021 at 2:41 PM Thomas Monjalon wrote: > > > > 10/05/2021 22:48, Thomas Monjalon: > > > Sphinx 4.0 became stricter with permalink configuration: > > > " > > > html_add_permalinks has been deprecated since v3.5.0. > > > Please use html_permalinks

Re: [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-05-11 Thread Pattan, Reshma
> -Original Message- > From: Hunt, David > > [Reshma]: Do we need to return -1 here and in other failure scenarios > > below. > > > Hi Reshma, > > We might do, but that's not something I had intended to address in this patch > set. > > We should look at this in a future patch, OK?

Re: [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-05-11 Thread David Hunt
On 29/4/2021 11:34 AM, Pattan, Reshma wrote: -Original Message- From: dev On Behalf Of David Hunt +TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) { return 0; [Reshma]: Do we need to return -1 here and in other failure scenarios below. Hi Reshma, We might do, but that's not s

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix IPv6 header initialization

2021-05-11 Thread David Marchand
On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson wrote: > > Fix two issues found when writing PMD unit tests for HW ptype and > L4 checksum offload: Would those unit tests be interesting to other pmd driver writers? > >- The version field in the IPv6 header was being set to zero, > whi

Re: [dpdk-dev] [PATCH] doc: add more description for hns3 PMD

2021-05-11 Thread Ferruh Yigit
On 5/6/2021 2:30 PM, Min Hu (Connor) wrote: > This patch adds more description for hns3 PMD document, that is: > 'Sample Application Notes', 'Statistics','Performance tuning'. > > Signed-off-by: Min Hu (Connor) Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] net/enic: enable GENEVE offload via VNIC configuration

2021-05-11 Thread Ferruh Yigit
On 5/5/2021 7:39 PM, John Daley wrote: > The admin-configured vNIC settings (i.e. via CIMC or UCSM) now include > Geneve offload. Use that setting to decide whether to enable or > disable Geneve offload and remove the devarg 'geneve-opt'. > > Also, the firmware now allows the driver to change the

Re: [dpdk-dev] [PATCH] net/af_xdp: fix build warning for kernels < 5.4

2021-05-11 Thread Ferruh Yigit
On 5/10/2021 9:47 AM, Ciara Loftus wrote: > Prior to this change, two implementations of rx_syscall_handler > existed although only one was needed (for the zero copy path which > is only available from kernel 5.4 and onwards). Remove the second > definition from compat.h and move the first definiti

Re: [dpdk-dev] How to disable SVE auto vectorization while using GCC

2021-05-11 Thread Honnappa Nagarahalli
> > > >> > >> Thanks for your suggestions, we found that the -fno-tree-vectorize > >> option works. > >> PS: This option is not successfully added in the earliest test. > >> > >> Solution: > >> 1. use the -fno-tree-vectorize option to prevent compiler generate > >> auto vetorization > >>code,

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-05-11 Thread David Marchand
On Sat, May 8, 2021 at 2:25 AM Piotr Kubaj wrote: > > Including below. > From 87ad59cc894b227444936fb6a7968932abdc460f Mon Sep 17 00:00:00 2001 > From: Piotr Kubaj > Date: Tue, 23 Mar 2021 00:40:47 +0100 > Subject: [PATCH] ppc64le: fix build without glibc > > __ppc_get_timebase() is only present

Re: [dpdk-dev] [dpdk-ci] dpdk-next-crypto/master is failing tests

2021-05-11 Thread David Marchand
On Thu, May 6, 2021 at 6:15 PM Brandon Lo wrote: > > Hi all, > > dpdk-next-qos and dpdk-next-pipeline remotes have been removed. > dpdk-next-virtio and dpdk-next-crypto remotes have been switched to > track main and for-main branches respectively. Thank you Brandon. Just an additional question.

Re: [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS

2021-05-11 Thread David Marchand
On Thu, May 6, 2021 at 5:15 PM David Marchand wrote: > > Testing OVS build against 21.05-rc2 revealed some issues. > Bits were also missing on OVS side, so for people interested, a > rebased dpdk-latest OVS branch is available at: > https://github.com/david-marchand/ovs/commits/dpdk-latest Series

Re: [dpdk-dev] [EXT] Re: [PATCH] common/cpt: add checks for offset overflow

2021-05-11 Thread Anoob Joseph
Hi Thomas, > Should it be merged in DPDK 21.05-rc3, or wait for 21.08? Either is fine. This patch is just adding some extra parameter checks. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 11, 2021 6:59 PM > To: Jerin Jacob Kollanukkaran ; Anoob Joseph

Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check

2021-05-11 Thread Pattan, Reshma
> -Original Message- > From: Min Hu (Connor) > > Another suggestion if you would like to improve the code, is below, > > You can move "global_fds[lcore_id]" check to immediate after the line > "fds.fd = global_fds[lcore_id]; " > Hi, thanks Pattan. > But I think "global_fds[lcore_id]"

Re: [dpdk-dev] [PATCH v4 00/19] net/ena: update ENA PMD to v2.3.0

2021-05-11 Thread Michał Krawczyk
wt., 11 maj 2021 o 15:07 Ferruh Yigit napisał(a): > > On 5/11/2021 7:45 AM, Michal Krawczyk wrote: > > Hi, > > > > this version updates the driver to version 2.3.0, which fixes multiple > > bugs, contains part of the work on making the ENA PMD fully MP aware, and > > also updates HAL to the latest

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix reporting of RSS capabilities

2021-05-11 Thread Ferruh Yigit
On 5/10/2021 5:45 PM, Heinrich Kuhn wrote: > Before this change the dev_infos callback always reported RSS > capabilities regardless of whether the capability is supported by the > device or not. First check the capabilities field in the BAR of the > device and advertise RSS functionality according

Re: [dpdk-dev] [PATCH] common/cpt: add checks for offset overflow

2021-05-11 Thread Thomas Monjalon
10/05/2021 11:44, Anoob Joseph: > Add checks to catch overflow of any offsets. Offset control word > specifies, > > 1. 16 bits encryption offset > 2. 8 bits IV offset > 3. 8 bits auth offset > > Signed-off-by: Anoob Joseph Should it be merged in DPDK 21.05-rc3, or wait for 21.08?

Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-05-11 Thread Thomas Monjalon
This patch series is stucked. That's too often the case for the power lib/example/test patches. 29/04/2021 12:34, Pattan, Reshma: > From: dev On Behalf Of David Hunt > > +TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) { > > > return 0; > > [Reshma]: Do we need to return -1 here and in other

Re: [dpdk-dev] [PATCH] doc: fix build with Sphinx 4

2021-05-11 Thread David Marchand
On Tue, May 11, 2021 at 2:41 PM Thomas Monjalon wrote: > > 10/05/2021 22:48, Thomas Monjalon: > > Sphinx 4.0 became stricter with permalink configuration: > > " > > html_add_permalinks has been deprecated since v3.5.0. > > Please use html_permalinks and html_permalinks_icon instead. > > " > > > >

Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check

2021-05-11 Thread Thomas Monjalon
Any comment please? 29/04/2021 02:43, Min Hu (Connor): > > 在 2021/4/28 23:13, Pattan, Reshma 写道: > > > > > >> -Original Message- > >> From: dev On Behalf Of Min Hu (Connor) > >> > >> + if (lcore_id >= RTE_MAX_LCORE) { > >> + RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of

Re: [dpdk-dev] [PATCH v4] log: register with standardized names

2021-05-11 Thread Thomas Monjalon
11/05/2021 14:52, Bruce Richardson: > On Tue, May 11, 2021 at 02:38:10PM +0200, Thomas Monjalon wrote: > > From: David Marchand > > > > Let's try to enforce the convention where most drivers use a pmd. logtype > > with their class reflected in it, and libraries use a lib. logtype. > > > > Introd

Re: [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color

2021-05-11 Thread Ferruh Yigit
On 5/11/2021 1:34 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, May 11, 2021 12:35 PM >> To: Haifei Luo ; ma...@nvidia.com; or...@nvidia.com; >> viachesl...@nvidia.com; Li, Xiaoyun >> Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvi

[dpdk-dev] [PATCH v3 4/4] net/tap: fix build with gcc11

2021-05-11 Thread Ferruh Yigit
Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) There are multiple build errors, like: In file included from ../drivers/net/tap/tap_flow.c:13: In function ‘rte_jhash_2hashes’, inlined from ‘rte_jhash’ at ../lib/hash/rte_jhash.h:28

[dpdk-dev] [PATCH v3 3/4] net/ice/base: fix build with gcc11

2021-05-11 Thread Ferruh Yigit
Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) There are multiple build errors, like: ../drivers/net/ice/base/ice_switch.c: In function ‘ice_add_marker_act’: ../drivers/net/ice/base/ice_switch.c:3727:15: warning: array subscr

  1   2   >