On Thu, May 06, 2021 at 01:13:07AM +0200, Thomas Monjalon wrote: > 06/05/2021 00:45, Tyler Retzlaff: > > as a side question, what is the projects stance on getting more warnings > > clean? there are a few not enabled that i'd really like to see e.g. > > format, conversion, truncation etc.. > > > > i looked at lib/eal previously and there are... hundreds? of instances so > > it's a non-trivial task. the problem i see is somehow getting to a > > warnings clean state where we can enable -Werror in the CI pipeline but > > at the same time figuring out how to prevent new instances from > > appearing until we do. > > I don't understand the question. > We are already supposed to be warning-free, > and -werror should be enabled in all CI labs. > What are the gaps?
with the warnings we have enabled -Werror passes, but we don't have all the warnings we could have that are of value. it would be great to see -Wconversion -Wsign-compare -Wsign-conversion passing clean. i admit it is a lot of work though.
