> From: Akhil Goyal > > > > > > Also set feature flag in the code and the documentation in this > patch. > > > > > > I see that you are setting all of them in a single patch in the end. > > > > > > This is not correct. It should be added where the feature is > supported. > > > > > > Please fix this for all the feature flags. > > > > > > > > > > No, in this stage no feature is really supported, the actual time > > > > > it will be supported is after the datapath patches and capabilities > > > > > set. > > > > > > > > > Move the patch after adding data path, but documentation should be > > > > part > > > Of > > > > this patch. > > > > > > I will squash this patch to the session commit. > > > > I am not asking you to squash the patch to the session commit. > > The point is documentation patch should be part of code patch which > > Introduced that feature. This methodology has been discussed in the past > > and is being followed now. Please discuss this in techboard in case of > > deviation. > > Not sure this is mandatory when you add a new PMD. In case of a new PMD also we try to follow this as much as we can. IMO, this can be done here.
> For sure you right in general. > > Anyway, the session commit is the better place to this code. > > > Regards, > > Akhil
