Re: [dpdk-dev] [PATCH] net/iavf: fix VLAN tag extraction handling in AVX512 path

> -Original Message- > From: dev On Behalf Of Leyi Rong > Sent: Thursday, April 22, 2021 10:49 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH] net/iavf: fix VLAN tag extraction handling in > AVX512 path > > The new VIRTCHNL_VF_OFFLOAD_VL

[dpdk-dev] [PATCH] net/ice: fix VXLAN flow rule creation error

From: Dapeng Yu In original implementation, error returned when creating VXLAN flow rule with SCTP or TCP as layer 3 protocol of inner segment. There are several root causes for the error: 1. ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_UDP into protocol header flag of inner segment of VXLAN F

[dpdk-dev] [PATCH v2 4/4] doc: add MLX5 PMD integrity item support

Add MLX5 PMD integrity item support to 21.05 release notes. Add MLX5 PMD integrity item limitations to the PMD records. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 15 +++ doc/guides/rel_notes/release_21_02.rst | 1 +

[dpdk-dev] [PATCH v2 3/4] net/mlx5: support integrity flow item

MLX5 PMD supports the following integrity filters for outer and inner network headers: - l3_ok - l4_ok - ipv4_csum_ok - l4_csum_ok `level` values 0 and 1 reference outer headers. `level` > 1 reference inner headers. Flow rule items supplied by application must explicitly specify network headers r

[dpdk-dev] [PATCH v2 2/4] net/mlx5: update PRM definitions

Add integrity and IPv4 IHL bits to PRM file. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 31 drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 35 ++--

[dpdk-dev] [PATCH v2 1/4] ethdev: fix integrity flow item

Add integrity item definition to the rte_flow_desc_item array. The new entry allows to build RTE flow item from a data stored in rte_flow_item_integrity type. Add bitmasks to the integrity item value. The masks allow to query multiple integrity filters in a single compare operation. Fixes: b10a42

[dpdk-dev] [PATCH v2 0/4] net/mlx5: add integrity flow item support

Support integrity flow item in MLX5 PMD. Integrity flow item was described in commit b10a421a1f3b ("ethdev: add packet integrity check flow rules") v2: Add MLX5 PMD integrity item support to 21.05 release notes. Use RTE_BIT64() macro in RTE_FLOW_ITEM_INTEGRITY_* definition. Acked-by: Viacheslav O

[dpdk-dev] [PATCH v2] doc: add config file option for hns3 PMD

This patch adds description of max TQP number per PF for config file option. Signed-off-by: Min Hu (Connor) --- v2: * deleted unexpected unindent. --- doc/guides/nics/hns3.rst | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/hns3.rst b/doc/g

[dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator

This patch fixes issue with OVS 2.15 not working on DPAA/FSLMC based platform due to missing support for these busses in dev_iterate. This patch adds dpaa_bus and fslmc to dev iterator for bus arguments. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port

From: Kalesh AP The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no extra check needed for VF along with BNXT_SINGLE_PF(bp). Also make error messages more explicit. Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port") Fixes: f86febfb46da ("net/bnxt: support VF"

Re: [dpdk-dev] [PATCH] net/txgbe: fix null pointer check problem

On April 27, 2021 11:31 PM, Ferruh Yigit wrote: > On 4/25/2021 1:54 PM, Min Hu (Connor) wrote: > > From: HongBo Zheng > > > > In function cons_parse_ntuple_filter, item->spec and item->mask should > > be confirmed not null before use memcmp on it, current judgement > > (item->spec || item->mask) j

[dpdk-dev] [PATCH v4] net/i40e: extend VF reset waiting time

When starting VF, VF will issue reset command to PF, wait a fixed amount of time, and assume VF reset is done on PF side. However, compared with kernel PF, DPDK PF needs more time to setup. If we run DPDK PF to support DPDK VF, the original delay will not be enough. When we first start VF after PF

[dpdk-dev] [PATCH v3] net/i40e: extend VF reset waiting time

When starting VF, VF will issue reset command to PF, wait a fixed amount of time, and assume VF reset is done on PF side. However, compared with kernel PF, DPDK PF needs more time to setup. If we run DPDK PF to support DPDK VF, the original delay wil not be enough. When we first start VF after PF i

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Thursday, April 29, 2021 9:34 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > The performance drop is caused by that the RX scalar path is selected when > AVX512 i

Re: [dpdk-dev] [PATCH v6 0/3] support flow for IP fragment in ICE

> -Original Message- > From: Guo, Jia > Sent: Tuesday, April 13, 2021 6:06 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Xu, Ting ; Guo, Jia > Subject: [PATCH v6 0/3] support flow for IP fragment in ICE > > Support RSS hash and FDIR for IP fragment packets in ICE PMD. >

Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.

> -Original Message- > From: Yang, Qiming > Sent: Thursday, April 29, 2021 10:30 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH 0/6] net/ice: base update update batch 3. > > Hi, > > > -Original Message- > > From: Zhang, Qi Z > > Sent: 2021年4月29日 8:42 > > To: Y

[dpdk-dev] [PATCH v2] raw/ifpga: fix ifpga device name format

The device name format used in ifpga_rawdev_create() was changed to "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy() was left as "IFPGA:%x:%02x.%x", it should be changed synchronously. To prevent further similar errors, macro "IFPGA_RAWDEV_NAME_FMT" is defined to replace this for

Re: [dpdk-dev] [PATCH 2/2] eal: fix service core index validity

Hi, fixed in v2, thanks. 在 2021/4/21 10:33, Stephen Hemminger 写道: On Wed, 21 Apr 2021 09:17:17 +0800 "Min Hu (Connor)" wrote: idx = strtoul(corelist, &end, 10); if (errno || end == NULL) return -1; + if (idx < 0 || idx >= R

[dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity

This patch adds checking for service core index validity when parsing service corelist. Fixes: 7dbd7a6413ef ("service: add -S corelist option") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/eal/common/eal_common_options.c | 6 -- 1 file changed, 4

[dpdk-dev] [PATCH v2 0/2] fix bugs for librte eal

This patchset fixed some bugs for librte_eal. Min Hu (Connor) (2): eal: check mp reply result eal: fix service core index validity --- v2: * set variables an unsigned type. lib/eal/common/eal_common_options.c | 6 -- lib/eal/common/malloc_mp.c | 4 +--- 2 files changed, 5 insert

[dpdk-dev] [PATCH v2 1/2] eal: check mp reply result

This patch adds checking for mp reply result in handle_sync(). Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/eal/common/malloc_mp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletion

Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.

Hi, > -Original Message- > From: Zhang, Qi Z > Sent: 2021年4月29日 8:42 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 0/6] net/ice: base update update batch 3. > > Add IP fragment support in base code and couple QinQ improvement. > update the release date as the las

[dpdk-dev] [PATCH v2] raw/ifpga: fix ifpga device name format

The device name format used in ifpga_rawdev_create() was changed to "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy() was left as "IFPGA:%x:%02x.%x", it should be changed synchronously. To prevent further similar errors, macro "IFPGA_RAWDEV_NAME_FMT" is defined to replace this for

Re: [dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time

Hi Ferruh, I realized there were some ambiguities. I will modify commit in the new patch. Regards, Wenjun -Original Message- From: Yigit, Ferruh Sent: Wednesday, April 28, 2021 5:30 PM To: Wu, Wenjun1 ; dev@dpdk.org; Xing, Beilei Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: extend VF

Re: [dpdk-dev] [PATCH] eal: fix use wrong time API

Hi, Morten, fixed in v2, thanks. 在 2021/4/28 18:59, Morten Brørup 写道: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of fengchengwen Sent: Wednesday, April 28, 2021 12:36 PM On 2021/4/28 17:24, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Min Hu (Connor) Sen

[dpdk-dev] [PATCH v2] eal: fix use wrong time API

Currently, the mp uses gettimeofday() API to get the time, and used as timeout parameter. But the time which gets from gettimeofday() API isn't monotonically increasing. The process may fail if the system time is changed. This fixes it by using clock_gettime() API with monotonic attribution. Fix

[dpdk-dev] [PATCH] net/bnxt: fix dynamic VNIC count

Ensure that the current count of in-use VNICs is decremented when a VNIC is freed. Don't attempt VNIC allocation when the maximum supported number of VNICs is currently allocated. Fixes: 49d0709b257f ("net/bnxt: delete and flush L2 filters cleanly") Fixes: d24610f7bfda ("net/bnxt: allow flow creat

[dpdk-dev] [PATCH] net/bnxt: fix initialization of filter struct

Initialize filter structure to all zeroes on allocation. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_filter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

Re: [dpdk-dev] [PATCH v9 2/4] vhost: add support for packed ring in async vhost

Reviewed-by: Jiayu Hu > -Original Message- > From: Jiang, Cheng1 > Sent: Tuesday, April 27, 2021 4:04 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong ; Jiang, Cheng1 > Subject: [PATCH v9 2/4] vhost: add suppor

[dpdk-dev] [PATCH] doc: add config file option for hns3 PMD

This patch adds description of max TQP number per PF for config file option. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/hns3.rst | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst index d51d9b1..03b75

[dpdk-dev] [PATCH] net/iavf: fix performance drop

The performance drop is caused by that the RX scalar path is selected when AVX512 is disabled and some HW offload is enabled. Actaully, the HW offload is supported by AVX2 and SSE. In this scenario AVX2 path should be chosen. This patch removes the offload related check for SSE and AVX2 as SSE and

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

> The fix by not changing Rx implementation, but making sure correct Rx path > selected, right? Can you please clarify this in the commit log? > > So the performance drop fixed for whoever have the vector path supported and > offloads enabled, can be good to highlight in the patch title, otherwise

Re: [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: fix check of port and core

在 2021/4/28 21:29, Iremonger, Bernard 写道: Hi Min, -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 21, 2021 8:00 AM To: dev@dpdk.org Cc: Yigit, Ferruh ; Iremonger, Bernard ; Kantecki, Tomasz ; Richardson, Bruce ; tho...@monjalon.net Subject: [PATCH v2 1/3] examples/fl

[dpdk-dev] [PATCH v3 3/3] examples/skeleton: fix check of port and core

According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -a :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93

[dpdk-dev] [PATCH v3 1/3] examples/flow_classify: fix check of port and core

According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -a :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93

[dpdk-dev] [PATCH v3 2/3] examples/l2fwd-cat: fix check of port and core

According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -a :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93

[dpdk-dev] [PATCH v3 0/3] fix check of port and core

Currently, some examples check that the port is on the same NUMA node as the polling thread for best performance. The method is to compare the socket id of port and that of current core. If the result is different, warning info will be given. But it ignores the port which is from numa node 0, that

Re: [dpdk-dev] [PATCH v6 03/10] windows/eal: translate Windows errors to errno-style errors

2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > Add function to translate Windows error codes to > errno-style error codes. > > Signed-off-by: Narcisa Vasile Commit topic should be "eal/windows", not "windows/eal". > --- > lib/librte_eal/include/rte_thread.h

Re: [dpdk-dev] [PATCH v6 02/10] eal: add thread attributes

2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > Implement thread attributes for: > * thread affinity > * thread priority > > Implement functions for managing thread attributes. > > Signed-off-by: Narcisa Vasile > --- > lib/librte_eal/common/rte_thread.c

Re: [dpdk-dev] [PATCH v6 01/10] eal: add thread id and simple thread functions

2021-04-02 18:38 (UTC-0700), Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > Add the thread identifier type. > Add functions for comparing thread ids and obtaining the thread id > for the current thread. > > Signed-off-by: Narcisa Vasile > --- (For the whole series.) Please summarize and

Re: [dpdk-dev] [PATCH v2] common/iavf: fix wrong order of protocol header types

> -Original Message- > From: Xu, Ting > Sent: Sunday, April 25, 2021 2:53 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Zhang, Qi Z ; Xu, Ting ; > sta...@dpdk.org > Subject: [PATCH v2] common/iavf: fix wrong order of protocol header types > > The new virtchnl protocol

Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check

在 2021/4/28 23:13, Pattan, Reshma 写道: -Original Message- From: dev On Behalf Of Min Hu (Connor) + if (lcore_id >= RTE_MAX_LCORE) { + RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of range 0...%d\n", + lcore_id, RTE_MAX_LCORE-1);

[dpdk-dev] [PATCH 6/6] net/ice/base: support IP fragment RSS and FDIR

Add support for IP fragment RSS hash and FDIR function. Separate IP fragment and IP other packet types. The patch also update the release date in README. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 2 +- drivers/net/ice/base/ic

[dpdk-dev] [PATCH 5/6] net/ice/base: signed External Device Package Programming

External topology devices (e.g. PHYs) connected to 100G or to SoC that includes 100G IP might have a firmware engine within the device and the firmware is usually loaded from NVM connected to the topology device. The topology device NVM images can be updated using SW tools but such solution poses a

[dpdk-dev] [PATCH 4/6] net/ice/base: modififcation to support L3 DSCP QoS

The base code support to build configuration TLVs in DSCP mode has not been implemented before, so the functions to do so and the flow control to determine if we are in VLAN or DSCP mode need to be added. The current value for maximum number of DCB APPs (ICE_DCBX_MAX_APPS) is not sufficient when s

[dpdk-dev] [PATCH 3/6] net/ice/base: add print if DDP/FW don't support QinQ as expected

Currently if the driver supports QinQ there is no message/information if the DDP and/or FW don't support QinQ. Add functionality that prints if the DDP and/or FW don't support QinQ if the driver attempts to configured DVM. This will make it more obvious to users in the field that they need to updat

[dpdk-dev] [PATCH 2/6] net/ice/base: add function for post DDP download VLAN mode configuration

Currently it's not clear that only the first PF downloads the package and configures the VLAN mode. When this is happening all other PFs are blocked on the global configuration lock. Once the package is successfully downloaded and the global configuration lock has been released then all PFs resume

[dpdk-dev] [PATCH 1/6] net/ice/base: add IP fragment flags

Add the IPv6 fragment flags and the IPv4 fragment field shift. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 2 +- drivers/net/ice/base/ice_fdir.h | 16 2 files changed, 13 insertions(+), 5 deletions(-) diff --gi

[dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.

Add IP fragment support in base code and couple QinQ improvement. update the release date as the last base patch for DPDK 21.05. Qi Zhang (6): net/ice/base: add IP fragment flags net/ice/base: add function for post DDP download VLAN mode configuration net/ice/base: add print if DDP/FW do

Re: [dpdk-dev] [PATCH] net/bnxt: fix dynamic VNIC count

On Wed, 28 Apr 2021 18:03:44 -0400 Lance Richardson wrote: > Ensure that the current count of in-use VNICs is decremented > when a VNIC is freed. Don't attempt VNIC allocation when the > maximum supported number of VNICs is currently allocated. > > Fixes: 49d0709b257f ("net/bnxt: delete and flus

Re: [dpdk-dev] L3fwd mode in testpmd

> > > > > > > > > In fact, l3fwd is also quite big and complex: > > > $ wc -l examples/l3fwd/*.[h,c] |grep total > > > 6969 total > > > > > > Plus it will introduce extra dependencies (fib, lpm, hash, might-be > > > acl?) I am not sure it is a good idea to pull all these complexities into > >

Re: [dpdk-dev] L3fwd mode in testpmd

On Wed, Apr 28, 2021 at 12:48 PM Bruce Richardson mailto:bruce.richard...@intel.com>> wrote: > I do not suggest pulling all these in. In our case, I see that the ask is > only on LPM. I am open to hearing what others see as the requirement. > I think fib is the planned long-term replacement fo

Re: [dpdk-dev] [PATCH v2 14/16] lib: remove librte_ prefix from directory names

On 4/20/21 3:22 AM, Bruce Richardson wrote: There is no reason for the DPDK libraries to all have 'librte_' prefix on the directory names. This prefix makes the directory names longer and also makes it awkward to add features referring to individual libraries in the build - should the lib name

[dpdk-dev] [PATCH] build: reduce max_lcores for ppc

When setting RTE_MAX_LCORES to the maximum value supported by ppc hardware (1536), the lcores_autotest may timeout after 30 seconds because the test takes nearly 60 seconds to complete. Set max_lcores to a lower value because the maximum value is unlikely to be seen in any production systems and to

Re: [dpdk-dev] [PATCH] autotest: disable lcores_autotest on ppc

On 4/20/21 4:45 AM, luca.bocca...@gmail.com wrote: From: Luca Boccassi This test consistently times out on ppc64 builds. Disable it. Cc: sta...@dpdk.org Signed-off-by: Luca Boccassi --- NAK. Will resolve with a different patch to reduce the max_lcore value used for PPC builds. Both x

Re: [dpdk-dev] [PATCH v3] build: optional NUMA and cpu counts detection

On 4/19/21 3:18 AM, Juraj Linkeš wrote: Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_

Re: [dpdk-dev] [PATCH] config/arm: restore support for Qualcomm servers

On 4/28/21 8:21 PM, Honnappa Nagarahalli wrote: Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers 28/04/2021 18:08, Thierry Herbelot: Like for other Arm chips, the 'soc' entry is also needed. Fixes: fddbe822c3eb ("config/arm: add Qualcomm") Signed-off-by: Thierry Herbel

Re: [dpdk-dev] [PATCH] config/arm: restore support for Qualcomm servers

> Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers > > 28/04/2021 18:08, Thierry Herbelot: > > Like for other Arm chips, the 'soc' entry is also needed. > > > > Fixes: fddbe822c3eb ("config/arm: add Qualcomm") > > > > Signed-off-by: Thierry Herbelot > > Is there any testin

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix integrity flow item

28/04/2021 19:59, Gregory Etelson: > Add integrity item definition to the rte_flow_desc_item array. > The new entry allows RTE conv API to work with the new flow item. What is RTE conv API? > Add bitmasks to the integrity item value. > The masks allow to query multiple integrity filters in a sing

[dpdk-dev] [PATCH 4/4] doc: add MLX5 PMD integrity item limitations

Add MLX5 PMD integrity item limitations. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index b27a9a69f6..12b45a69b5 100644 --- a/

[dpdk-dev] [PATCH 3/4] net/mlx5: support integrity flow item

MLX5 PMD supports the following integrity filters for outer and inner network headers: - l3_ok - l4_ok - ipv4_csum_ok - l4_csum_ok `level` values 0 and 1 reference outer headers. `level` > 1 reference inner headers. Flow rule items supplied by application must explicitly specify network headers r

[dpdk-dev] [PATCH 2/4] net/mlx5: update PRM definitions

Add integrity and IPv4 IHL bits to PRM file. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 31 drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 35 ++--

[dpdk-dev] [PATCH 1/4] ethdev: fix integrity flow item

Add integrity item definition to the rte_flow_desc_item array. The new entry allows RTE conv API to work with the new flow item. Add bitmasks to the integrity item value. The masks allow to query multiple integrity filters in a single compare operation. Fixes: b10a421a1f3b ("ethdev: add packet in

[dpdk-dev] [PATCH 0/4] net/mlx5: add integrity flow item support

Support integrity flow item in MLX5 PMD. Integrity flow item was described in commit b10a421a1f3b ("ethdev: add packet integrity check flow rules") Gregory Etelson (4): ethdev: fix integrity flow item net/mlx5: update PRM definitions net/mlx5: support integrity flow item doc: add MLX5 PMD

Re: [dpdk-dev] [PATCH] config/arm: restore support for Qualcomm servers

28/04/2021 18:08, Thierry Herbelot: > Like for other Arm chips, the 'soc' entry is also needed. > > Fixes: fddbe822c3eb ("config/arm: add Qualcomm") > > Signed-off-by: Thierry Herbelot Is there any testing of this platform?

Re: [dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tail update on aarch64

On Sun, 25 Apr 2021 05:56:53 + Ruifeng Wang wrote: > Instead of polling for tail to be updated, use wfe instruction. > > Signed-off-by: Gavin Hu > Signed-off-by: Ruifeng Wang > Reviewed-by: Steve Capper > Reviewed-by: Ola Liljedahl > Reviewed-by: Honnappa Nagarahalli > Acked-by: Konstan

[dpdk-dev] [PATCH] config/arm: restore support for Qualcomm servers

Like for other Arm chips, the 'soc' entry is also needed. Fixes: fddbe822c3eb ("config/arm: add Qualcomm") Signed-off-by: Thierry Herbelot --- config/arm/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 22cd81319c06..8

Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute

On 4/23/2021 6:22 AM, Kalesh A P wrote: > From: Kalesh AP > > Remove "__rte_unused" instances that are wrongly marked. > Can you please provide the fixes tags, so that patch can be backported to required stable versions? > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by:

Re: [dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor

> -Original Message- > From: dev On Behalf Of Anatoly Burakov > + /* Save the original governor */ > + rte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori)); > + Acked-by: Reshma Pattan

[dpdk-dev] [PATCH RFC V2 2/2] Allow the flow_classify example to add an ACL table for tcp.

Hi Sowmini, Could you rebase this patchset to the latest DPDK-21.05-rc1 code. Regards, Bernard

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

Hi Hemant, As mentioned earlier I have no problem adding such an option in the API, but that would still be a late API change (arguably too tight for 21.05 so that everyone has time to comment back). Based on description below this should not be an operation specific flag (again see my previo

Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check

> -Original Message- > From: dev On Behalf Of Min Hu (Connor) > > + if (lcore_id >= RTE_MAX_LCORE) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of range > 0...%d\n", > + lcore_id, RTE_MAX_LCORE-1); > + return -1; > +

Re: [dpdk-dev] [PATCH 2/2] compress/qat: enable compression on QAT GEN3

> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 28, 2021 3:42 PM > To: dev@dpdk.org; Zhang, Roy Fan ; Kusztal, > ArkadiuszX ; gak...@marvell.com > Cc: Dybkowski, AdamX > Subject: [PATCH 2/2] compress/qat: enable compression on QAT GEN3 > > This patch enables the co

Re: [dpdk-dev] [PATCH 1/2] common/qat: increase IM buffer size for QAT GEN3

> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 28, 2021 3:42 PM > To: dev@dpdk.org; Zhang, Roy Fan ; Kusztal, > ArkadiuszX ; gak...@marvell.com > Cc: Dybkowski, AdamX > Subject: [PATCH 1/2] common/qat: increase IM buffer size for QAT GEN3 > > This patch increases

[dpdk-dev] [PATCH 2/2] compress/qat: enable compression on QAT GEN3

This patch enables the compression on QAT GEN3 (on hardware versions that support it) and changes the error message shown on older hardware versions that don't support the compression. It also fixes the crash that happened on IM buffer allocation failure (not enough memory) during the PMD cleaning

[dpdk-dev] [PATCH 1/2] common/qat: increase IM buffer size for QAT GEN3

This patch increases the intermediate buffer size used for the compression on QAT GEN3 to accommodate new hardware versions. Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_device.h | 2 +- 1 file changed, 1 insertio

[dpdk-dev] [PATCH v2 2/2] test/distributor: fix burst flush on worker quit

While working on RISC-V port I have encountered a situation where worker threads get stuck in the rte_distributor_return_pkt() function in the burst test. Investigation showed some of the threads enter this function with flag RTE_DISTRIB_GET_BUF set in the d->retptr64[0]. At the same time the main

[dpdk-dev] [PATCH v2 1/2] test/distributor: fix worker notification in burst

Because a single worker can process more than one packet from the distributor, the final set of notifications in burst mode should be sent one-by-one to ensure that each worker has a chance to wake up. This fix mirrors the change done in the functional test by commit f72bff0ec272 ("test/distributo

[dpdk-dev] [PATCH v2 0/2] test/distributor: perf burst mode quit fixes

This series addresses two issues: 1. Worker threads hang when finishing the burst-mode distributor perf test. This was observed on a RISC-V platform as well as reproduced on x86. 2. Potential lack of fairness in final wakeup notification distribution in burst mode. Though this issue was n

[dpdk-dev] [PATCH] net/sfc: fix mark support in EF100 native Rx datapath

Decouple user mark from user flag. Usage of mark does not require to use flag as well. Flag is not actually supported yet. Fixes: 1aacc3d388d3 ("net/sfc: support user mark and flag Rx for EF100") Cc: stabledpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malo

[dpdk-dev] [PATCH] app/testpmd: support meter color action in policy

Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined. Add the CLI for this action in meter policy: color type (types) There are three types: green, yellow and red. Example for the new policy meter CLIs: add port meter policy 0 1 g_actions color type green / end y_actions color type

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

Hi,     My mail with photo snippets were rejected by dpdk mailing list. So, just sending the summary of it.     My understanding is that in ORAN, typically network order is used between CU-DU or DU-RU communication. In FAPI interface as well, both LE and BE are allowed types, however few pla

Re: [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: fix check of port and core

Hi Min, > -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 8:00 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Iremonger, Bernard > ; Kantecki, Tomasz > ; Richardson, Bruce > ; tho...@monjalon.net > Subject: [PATCH v2 1/3] examples/flow_classify: fix check of port

Re: [dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

On Wed, Apr 28, 2021 at 3:11 PM David Marchand wrote: > > Do we have two fixes in a single patch? > This is ok if both point at the same originating commit, but else, we > need two patches with proper Fixes: line. > Those touch different commits, I'll split them and send together. > > I see we

Re: [dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

On Mon, Apr 26, 2021 at 6:33 PM Stanislaw Kardach wrote: > > While working on RISC-V port I have encountered a situation where worker > threads get stuck in the rte_distributor_return_pkt() function in the > burst test. > After investigation some of the threads enter this function with > flag RTE_

Re: [dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

On 28/4/2021 1:53 PM, Stanisław Kardach wrote: On Wed, Apr 28, 2021 at 2:51 PM David Hunt > wrote: Thanks, Stanislaw, Lukasz. Acked-by: David Hunt mailto:david.h...@intel.com>> Just to be sure, may I send the non-RFC patch without the question part of t

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

Hi Dave, If we go back to the data providing source i.e. FAPI interface, it is implementation specific. As per SCF222: Our customers do use BE data in network and at FAPI interface. In LA12xx, at present, we use u8 Big-endian data for processing to FECA engine.  We do see that other drivers

Re: [dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

On Wed, Apr 28, 2021 at 2:51 PM David Hunt wrote: > Thanks, Stanislaw, Lukasz. > > Acked-by: David Hunt > > Just to be sure, may I send the non-RFC patch without the question part of the description or would you prefer the current version to be merged?

Re: [dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

On 28/4/2021 8:46 AM, Lukasz Wojciechowski wrote: Hi Stanislaw, W dniu 26.04.2021 o 18:33, Stanislaw Kardach pisze: While working on RISC-V port I have encountered a situation where worker threads get stuck in the rte_distributor_return_pkt() function in the burst test. After investigation so

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Wednesday, April 28, 2021 2:22 PM > > Hi Morten, > > Thank you for the review. > > <...> > > On Tue, Apr 27, 2021 at 05:07:04PM +0200, Morten Brørup wrote: > > > +static inline uint16_t > > > +rte_ipv4_udptcp_cksum(cons

Re: [dpdk-dev] [PATCH] mbuf: check mbuf dyn shared memory validity

Hi Chengwen, On Fri, Apr 23, 2021 at 04:11:04PM +0800, Min Hu (Connor) wrote: > From: Chengwen Feng > > Because mbuf dyn shared memory was allocated runtime, so it's > necessary to check validity when dump mbuf dyn info. > > Also this patch adds an error logging when init shared memory fail. >

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

Hi Morten, Thank you for the review. <...> On Tue, Apr 27, 2021 at 05:07:04PM +0200, Morten Brørup wrote: > > +static inline uint16_t > > +rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void > > *l4_hdr) > > +{ > > + uint16_t cksum = __rte_ipv4_udptcp_cksum(ipv4_hdr, l4_hdr);

Re: [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags

On Fri, Apr 9, 2021 at 3:30 PM Olivier Matz wrote: > > I see your point. Going back to improving the documentation as a > > first step, what would be the next steps? Are we going to wait few > > releases and then remove the flag tweaking code assuming that PMDs > > and apps are ok? > > After this

Re: [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags

On Thu, Apr 8, 2021 at 9:53 AM Olivier Matz wrote: > > On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote: > > Tx offload flags are of the application responsibility. > > Leave the mbuf alone and check for TSO where needed. > > > > Signed-off-by: David Marchand Self nack on this patc

Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process

This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4 --nu

Re: [dpdk-dev] [PATCH 0/3] mlx5 - support checksum offloads on Windows

Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Wednesday, April 21, 2021 7:35 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Raslan Darawsheh ; Asaf Penso > ; Odi Assli > Subject: [PATCH 0/3] mlx5 - support checksum offloads on Windows > > Support th

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 28, 2021 7:32 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > On 4/27/2021 3:57 AM, Zhang, Qi Z wrote: > > > > > >> -Original Message- > >

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

On 4/27/2021 3:57 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Lu, Wenzhuo >> Sent: 2021年4月27日 9:51 >> To: Zhang, Qi Z ; dev@dpdk.org >> Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix performance drop >> +use_sse = true; +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AV

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

On 4/26/2021 6:29 AM, Wenzhuo Lu wrote: > AVX2 and SSE don't have the offload path. > Not necessary doing any check. Or the scalar path > will be chosen. Hi Wenzhuo, The fix by not changing Rx implementation, but making sure correct Rx path selected, right? Can you please clarify this in the comm

Re: [dpdk-dev] [PATCH] net/mlx5: fix the size of tcp flags for modify actions

> -Original Message- > From: Wisam Monther > Sent: Wednesday, April 28, 2021 13:29 > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; Alexander Kozyrev > ; Raslan Darawsheh ; > dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the size of tc

  1   2   >