Hi Min,
> -----Original Message-----
> From: Min Hu (Connor) <[email protected]>
> Sent: Wednesday, April 21, 2021 8:00 AM
> To: [email protected]
> Cc: Yigit, Ferruh <[email protected]>; Iremonger, Bernard
> <[email protected]>; Kantecki, Tomasz
> <[email protected]>; Richardson, Bruce
> <[email protected]>; [email protected]
> Subject: [PATCH v2 1/3] examples/flow_classify: fix check of port and core
>
> According to the comments and logging, the author just hope user to use the
> core and device which are in the same numa node for optimal performance.
> If not, A warning gives out.
>
> For example in flow_classify:
> ./build/flow_classify -w 0000:7d:00.1 -l 93
The EAL option "-w" has been replaced by the "-a" option in dpdk-20.05
> Here:
> 0000:7d:00.1 is on numa node 0.
> core 93 is on numa node 3.
>
> The two are not in same numa node, but no warning gives out in old codes.
>
> This patch can fix it.
>
> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
> Cc: [email protected]
>
> Signed-off-by: Min Hu (Connor) <[email protected]>
> ---
> examples/flow_classify/flow_classify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/flow_classify/flow_classify.c
> b/examples/flow_classify/flow_classify.c
> index 335d7d2..277a2f5 100644
> --- a/examples/flow_classify/flow_classify.c
> +++ b/examples/flow_classify/flow_classify.c
> @@ -284,7 +284,7 @@ lcore_main(struct flow_classifier *cls_app)
> * for best performance.
> */
> RTE_ETH_FOREACH_DEV(port)
> - if (rte_eth_dev_socket_id(port) > 0 &&
> + if (rte_eth_dev_socket_id(port) >= 0 &&
> rte_eth_dev_socket_id(port) != (int)rte_socket_id())
> {
> printf("\n\n");
> printf("WARNING: port %u is on remote NUMA
> node\n",
> --
> 2.7.4
Tested-by: Bernard Iremonger <[email protected]>
