Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy

2021-04-26 Thread Tianyu Li
Hi Jakub, Any comments about the patch? -Original Message- From: Ferruh Yigit Sent: Wednesday, April 14, 2021 4:13 PM To: Tianyu Li ; Jakub Grajciar Cc: dev@dpdk.org; nd ; sta...@dpdk.org Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy On 4/12/2021 9:22 AM, Tian

Re: [dpdk-dev] [PATCH v8 2/4] vhost: add support for packed ring in async vhost

2021-04-26 Thread Jiang, Cheng1
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Tuesday, April 27, 2021 1:16 PM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com; > Xia, Chenbo > Cc: dev@dpdk.org; Yang, YvonneX ; Wang, Yinan > ; Liu, Yong > Subject: RE: [PATCH v8 2/4] vhost: add support for packed ring in asyn

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Monday, April 26, 2021 1:30 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > AVX2 and SSE don't have the offload path. > Not necessary doing any check. Or the scala

Re: [dpdk-dev] [PATCH v8 2/4] vhost: add support for packed ring in async vhost

2021-04-26 Thread Hu, Jiayu
Hi Cheng, Some comments are inline. > -Original Message- > From: Jiang, Cheng1 > Sent: Monday, April 19, 2021 4:51 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong ; Jiang, Cheng1 > Subject: [PATCH v8 2/4] vhos

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Lu, Wenzhuo
> > > > +use_sse = true; > > > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || > > > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && > > > > +rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) > > > > +use_avx2 = true; > > > > > > > > > Not sure if the right path w

[dpdk-dev] [PATCH v2] examples/vhost: fix potential overflow in args process

2021-04-26 Thread Cheng Jiang
Change the way passing args to fix potential overflow in args process. Coverity issue: 363741 Fixes: 965b06f0358 ("examples/vhost: enhance getopt_long usage") Signed-off-by: Cheng Jiang --- v2: * Change the way passing args * Change git log examples/vhost/main.c | 11 --- 1 file chan

Re: [dpdk-dev] [PATCH] net/iavf: fix l4 checksum error

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: 2021年4月27日 10:24 > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix l4 checksum error > > leverage the behavior of the scalar path, preparing packets is necessary for > the checksum offload.

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/vhost: fix potential overflow in args process

2021-04-26 Thread Jiang, Cheng1
Hi, > -Original Message- > From: David Marchand > Sent: Monday, April 26, 2021 4:25 PM > To: Jiang, Cheng1 > Cc: Maxime Coquelin ; Xia, Chenbo > ; dev ; dpdk stable > > Subject: Re: [dpdk-stable] [PATCH] examples/vhost: fix potential overflow in > args process > > On Mon, Apr 19, 2021

Re: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: 2021年4月27日 10:32 > To: Zhang, AlvinX ; Zhang, Qi Z > ; Yang, Qiming > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode > > > > -Original Message- > > From: d

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Lu, Wenzhuo > Sent: 2021年4月27日 9:51 > To: Zhang, Qi Z ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > > > +use_sse = true; > > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || > > > + rte_cpu_get_flag_enable

[dpdk-dev] [Bug 693] [dpdk-21.05] shutdown_api/change_linkspeed: port config speed is invalid

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=693 Bug ID: 693 Summary: [dpdk-21.05] shutdown_api/change_linkspeed: port config speed is invalid Product: DPDK Version: unspecified Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-26 Thread Chengchang Tang
On 2021/4/26 22:54, Ferruh Yigit wrote: > On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: >> From: Chengchang Tang >> >> The socket ID entered by user is cast to an unsigned integer. However, >> the value may be an illegal negative value, which may cause some >> problems. In this case, an error sh

Re: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode

2021-04-26 Thread Rong, Leyi
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: Sunday, April 25, 2021 5:27 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode > > In some cases, it seems that the txq

[dpdk-dev] [PATCH] net/iavf: fix l4 checksum error

2021-04-26 Thread Wenzhuo Lu
leverage the behavior of the scalar path, preparing packets is necessary for the checksum offload. Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512") Signed-off-by: Wenzhuo Lu --- drivers/net/iavf/iavf_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

Re: [dpdk-dev] [PATCH 2/3] net/kni: fix rewritten return value

2021-04-26 Thread Min Hu (Connor)
在 2021/4/26 21:18, Ferruh Yigit 写道: On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: Return value of function 'eth_kni_dev_stop' passed to 'ret' is rewritten later, and this is unreasonable. This patch fixes it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Cc: st

[dpdk-dev] [PATCH v2] net/kni: fix rewritten return value

2021-04-26 Thread Min Hu (Connor)
Return value of function 'eth_kni_dev_stop' passed to 'ret' is rewritten later, and this is unreasonable. This patch fixes it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- v2: * just log but not return. ---

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Lu, Wenzhuo
> > +use_sse = true; > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && > > +rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) > > +use_avx2 = true; > > > Not sure if the right path will be selected when avx512 is

Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

2021-04-26 Thread Wang, Haiyue
> -Original Message- > From: Hunt, David > Sent: Monday, April 26, 2021 22:20 > To: Burakov, Anatoly ; dev@dpdk.org; Guo, Jia > ; Wang, > Haiyue ; Ananyev, Konstantin > ; Liang Ma > > Subject: Re: [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver > > Hi Anatoly, > > On 26

Re: [dpdk-dev] [PATCH] bonding: fix overflow check

2021-04-26 Thread Min Hu (Connor)
在 2021/4/26 23:08, Ferruh Yigit 写道: On 4/22/2021 10:22 AM, Min Hu (Connor) wrote: Buffer 'test_params->slave_port_ids' of size 6 accessed may overflow, since its index 'i' can have value be is out of range. This patch fixed it. Fixes: 92073ef961ee ("bond: unit tests") Cc: sta...@dpdk.org S

[dpdk-dev] [PATCH v2] bonding: fix overflow check

2021-04-26 Thread Min Hu (Connor)
Buffer 'test_params->slave_port_ids' of size 6 accessed may overflow, since its index 'i' can have value be is out of range. This patch fixed it. Fixes: 92073ef961ee ("bond: unit tests") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- v2: * fix bonded_slave_count value. --- app/test/tes

Re: [dpdk-dev] [PATCH 4/4] examples/l3fwd: make data struct to be memory efficient

2021-04-26 Thread Ruifeng Wang
> -Original Message- > From: Walsh, Conor > Sent: Monday, April 26, 2021 6:55 PM > To: hemant.agra...@nxp.com; Jerin Jacob ; > Ruifeng Wang > Cc: jer...@marvell.com; Yigit, Ferruh ; > tho...@monjalon.net; David Marchand ; > dpdk-dev ; nd ; Honnappa Nagarahalli > > Subject: RE: [dpdk-dev]

Re: [dpdk-dev] [PATCH v8 1/4] vhost: abstract and reorganize async split ring code

2021-04-26 Thread Hu, Jiayu
Reviewed-by: Jiayu Hu > -Original Message- > From: Jiang, Cheng1 > Sent: Monday, April 19, 2021 4:51 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan ; Liu, > Yong ; Jiang, Cheng1 > Subject: [PATCH v8 1/4] vhost: abstract an

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix log loss when state fails to be restored

2021-04-26 Thread Min Hu (Connor)
在 2021/4/26 23:30, Ferruh Yigit 写道: On 4/22/2021 12:27 PM, Min Hu (Connor) wrote: From: Chengchang Tang After restoring the remote states, the return value of ioctl() is not checked. Therefore, users cannot know whether the remote state is restored successfully. This patch add log for rest

[dpdk-dev] [PATCH v2] net/tap: fix log loss when state fails to be restored

2021-04-26 Thread Min Hu (Connor)
From: Chengchang Tang After restoring the remote states, the return value of ioctl() is not checked. Therefore, users cannot know whether the remote state is restored successfully. This patch add log for restoring failure. Fixes: 4810d3af8343 ("net/tap: restore state of remote device when closi

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa > > > > > > > > > > > Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > Performance of L3fwd example application > > > > > > > > > > > > is one of the key > > > > > > > >

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Honnappa Nagarahalli
> > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > Performance of L3fwd example application is > > > > > > > > > > > one of the key > > > > > > > > > > benchmarks in

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-26 Thread Stephen Hemminger
On Mon, 26 Apr 2021 15:14:59 +0530 Jerin Jacob wrote: > On Sat, Apr 24, 2021 at 5:56 AM Honnappa Nagarahalli > wrote: > > > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > Hello, > > > >

[dpdk-dev] [PATCH v2 33/33] event/cnxk: add devargs to control timer adapters

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add devargs to control each event timer adapter i.e. TIM rings internal parameters uniquely. The following dict format is expected [ring-chnk_slots-disable_npa-stats_ena]. 0 represents default values. Example: --dev "0002:1e:00.0,tim_ring_ctl=[2-1023-1-0]" Signed-o

[dpdk-dev] [PATCH v2 32/33] event/cnxk: add timer adapter start and stop

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter start and stop functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 71 - 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cn

[dpdk-dev] [PATCH v2 28/33] event/cnxk: add timer arm routine

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm routine. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 18 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 23 ++ drivers/event/cnxk/cnxk_tim_worker.c | 95 + drivers/event/cnxk/cnxk_tim_

[dpdk-dev] [PATCH v2 31/33] event/cnxk: add timer stats get and reset

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter statistics get and reset functions. Stats are disabled by default and can be enabled through devargs. Example: --dev "0002:1e:00.0,tim_stats_ena=1" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnx

[dpdk-dev] [PATCH v2 30/33] event/cnxk: add timer cancel function

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add function to cancel event timer that has been armed. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 1 + drivers/event/cnxk/cnxk_tim_evdev.h | 5 drivers/event/cnxk/cnxk_tim_worker.c | 30 ++

[dpdk-dev] [PATCH v2 29/33] event/cnxk: add timer arm timeout burst

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm timeout burst function. All the timers requested to be armed have the same timeout. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 7 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 12 +++ driver

[dpdk-dev] [PATCH v2 27/33] event/cnxk: add TIM bucket operations

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add TIM bucket operations used for event timer arm and cancel. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.h | 30 +++ drivers/event/cnxk/cnxk_tim_worker.c | 6 ++ drivers/event/cnxk/cnxk_tim_worker.h | 123

[dpdk-dev] [PATCH v2 26/33] event/cnxk: add devargs for chunk size and rings

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add devargs to control default chunk size and max numbers of timer rings to attach to a given RVU PF. Example: --dev "0002:1e:00.0,tim_chnk_slots=1024" --dev "0002:1e:00.0,tim_rings_lmt=4" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton ---

[dpdk-dev] [PATCH v2 25/33] event/cnxk: add timer adapter info function

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add TIM event timer adapter info get function. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_evdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cn

[dpdk-dev] [PATCH v2 24/33] event/cnxk: allow adapters to resize inflights

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add internal SSO functions to allow event adapters to resize SSO buffers that are used to hold in-flight events in DRAM. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 33 drivers/event/cnxk/cnxk_

[dpdk-dev] [PATCH v2 23/33] event/cnxk: add devargs to disable NPA

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh If the chunks are allocated from NPA then TIM can automatically free them when traversing the list of chunks. Add devargs to disable NPA and use software mempool to manage chunks. Example: --dev "0002:0e:00.0,tim_disable_npa=1" Signed-off-by: Shijith Thotton Signe

[dpdk-dev] [PATCH v2 22/33] event/cnxk: create and free timer adapter

2021-04-26 Thread pbhagavatula
From: Shijith Thotton When the application calls timer adapter create the following is used: - Allocate a TIM LF based on number of LF's provisioned. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate

[dpdk-dev] [PATCH v2 21/33] event/cnxk: add timer adapter capabilities

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add function to retrieve event timer adapter capabilities. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_tim_evdev.c | 22 +++

[dpdk-dev] [PATCH v2 20/33] event/cnxk: support event timer

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter aka TIM initialization on SSO probe. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnxk.rst | 6 drivers/event/cnxk/cnxk_eventdev.c | 3 ++ drivers/event/cnxk/cnxk_eventdev.h | 2 ++ drivers

[dpdk-dev] [PATCH v2 19/33] event/cnxk: add event port and queue xstats

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving statistics from SSO HWS and HWGRP. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.c| 63 + drivers/common/cnxk/roc_sso.h| 19 ++ drivers/event/cnxk/cnxk_eventdev.h | 15 ++ drivers/event/cnxk/

[dpdk-dev] [PATCH v2 18/33] event/cnxk: add SSO selftest and dump

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add selftest to verify sanity of SSO and also add function to dump internal state of SSO. Signed-off-by: Pavan Nikhilesh --- app/test/test_eventdev.c| 14 + drivers/event/cnxk/cn10k_eventdev.c |8 + drivers/event/cnxk/cn9k_eventdev.c

[dpdk-dev] [PATCH v2 17/33] event/cnxk: add device stop and close functions

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add event device stop and close callback functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 15 + drivers/event/cnxk/cn9k_eventdev.c | 14 + drivers/event/cnxk/cnxk_eventdev.c | 48

[dpdk-dev] [PATCH v2 16/33] event/cnxk: add device start function

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add eventdev start function along with few cleanup API's to maintain sanity. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 127 drivers/event/cnxk/cn9k_eventdev.c | 113 ++

[dpdk-dev] [PATCH v2 15/33] event/cnxk: add SSO GWS dequeue fastpath functions

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS event dequeue fastpath functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 10 ++- drivers/event/cnxk/cn10k_worker.c | 54 + drivers/event/cnxk/cn10k_worker.h | 12 +++ drivers/event/cnxk/cn9k_eventdev.c | 1

[dpdk-dev] [PATCH v2 11/33] event/cnxk: add event port link and unlink

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add platform specific event port, queue link and unlink APIs. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 64 +- drivers/event/cnxk/cn9k_eventdev.c | 101 drivers/e

[dpdk-dev] [PATCH v2 14/33] event/cnxk: add SSO GWS fastpath enqueue functions

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS fastpath event device enqueue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 16 +++- drivers/event/cnxk/cn10k_worker.c | 54 ++ drivers/event/cnxk/cn10k_worker.h | 12 +++ drivers/event/cnxk/cn9k_eventde

[dpdk-dev] [PATCH v2 13/33] event/cnxk: add SSO HW device operations

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO HW device operations used for enqueue/dequeue. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_worker.c | 7 + drivers/event/cnxk/cn10k_worker.h | 151 + drivers/event/cnxk/cn9k_worker.c | 7 + drivers/event/cnxk/cn9k_worker.h

[dpdk-dev] [PATCH v2 12/33] event/cnxk: add devargs to configure getwork mode

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add devargs to configure the platform specific getwork mode. CN9K getwork mode by default is set to use dual workslot mode. Add option to force single workslot mode. Example: --dev "0002:0e:00.0,single_ws=1" CN10K supports multiple getwork prefetch modes, by defaul

[dpdk-dev] [PATCH v2 10/33] event/cnxk: add port config functions

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add SSO HWS aka event port setup and release functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 121 +++ drivers/event/cnxk/cn9k_eventdev.c | 147 drivers/ev

[dpdk-dev] [PATCH v2 08/33] event/cnxk: add devargs for inflight buffer count

2021-04-26 Thread pbhagavatula
From: Shijith Thotton The number of events for a *open system* event device is specified as -1 as per the eventdev specification. Since, SSO inflight events are only limited by DRAM size, the xae_cnt devargs parameter is introduced to provide upper limit for in-flight events. Example: --

[dpdk-dev] [PATCH v2 09/33] event/cnxk: add devargs to control SSO HWGRP QoS

2021-04-26 Thread pbhagavatula
From: Shijith Thotton SSO HWGRPs i.e. queue uses DRAM & SRAM buffers to hold in-flight events. By default the buffers are assigned to the SSO HWGRPs to satisfy minimum HW requirements. SSO is free to assign the remaining buffers to HWGRPs based on a preconfigured threshold. We can control the QoS

[dpdk-dev] [PATCH v2 07/33] event/cnxk: allocate event inflight buffers

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Allocate buffers in DRAM that hold inflight events. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 7 ++ drivers/event/cnxk/cn9k_eventdev.c | 7 ++ drivers/event/cnxk/cnxk_eventdev.c | 105 +++

[dpdk-dev] [PATCH v2 04/33] event/cnxk: add common configuration validation

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add configuration validation, port and queue configuration functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 70 ++ drivers/event/cnxk/cnxk_eventdev.h | 6 +++ 2 files changed, 7

[dpdk-dev] [PATCH v2 06/33] event/cnxk: add event queue config functions

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add setup and release functions for event queues i.e. SSO HWGRPs. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_eventdev.c | 19

[dpdk-dev] [PATCH v2 03/33] event/cnxk: add platform specific device probe

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add platform specific event device probe and remove, also add event device info get function. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 101 +++ drivers/event/cnxk/cn9k_eventdev.c | 10

[dpdk-dev] [PATCH v2 05/33] event/cnxk: add platform specific device config

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add platform specific event device configuration that attaches the requested number of SSO HWS(event ports) and HWGRP(event queues) LFs to the RVU PF/VF. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 35 ++

[dpdk-dev] [PATCH v2 02/33] event/cnxk: add device capabilities function

2021-04-26 Thread pbhagavatula
From: Shijith Thotton Add the info_get function to return details on the queues, flow, prioritization capabilities, etc. which this device has. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.c | 24 drivers/event/cnx

[dpdk-dev] [PATCH v2 01/33] event/cnxk: add build infra and device setup

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh Add meson build infra structure along with the event device SSO initialization and teardown functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- MAINTAINERS| 6 +++ doc/guides/eventdevs/cnxk.rst | 55 +

[dpdk-dev] [PATCH v2 00/33] Marvell CNXK Event device Driver

2021-04-26 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' driver. In future, CN9K a.k.a octeontx2 will also be supported by same driver when code is ready and 'event/octeontx2' will be deprecated. v2 Changes: - Split Rx/Tx adapter into seperate patch set to

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-26 Thread Dave Burley
Hi Hemant Can I ask what the usage case is for RTE_BBDEV_LDPC_ENC_NETWORK_ORDER/RTE_BBDEV_LDPC_DEC_NETWORK_ORDER ? Thanks Dave From: dev on behalf of Hemant Agrawal Sent: 24 April 2021 11:36 To: dev@dpdk.org ; gak...@marvell.com ; nicolas.chau...@intel.co

[dpdk-dev] [RFC PATCH] test/distributor: fix burst flush on worker quit

2021-04-26 Thread Stanislaw Kardach
While working on RISC-V port I have encountered a situation where worker threads get stuck in the rte_distributor_return_pkt() function in the burst test. After investigation some of the threads enter this function with flag RTE_DISTRIB_GET_BUF set in the d->retptr64[0]. At the same time main threa

Re: [dpdk-dev] [PATCH 0/2] bugfix for hns3 PMD

2021-04-26 Thread Ferruh Yigit
On 4/23/2021 10:27 AM, Min Hu (Connor) wrote: > This patch set contains two bugfixes for hns3 PMD. > > Min Hu (Connor) (2): > net/hns3: fix wrong word of comments > doc: fix runtime config options > Series applied to dpdk-next-net/main, thanks.

[dpdk-dev] [Bug 692] bnx2x build fail on Fedora 34 with gcc 11

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=692 Bug ID: 692 Summary: bnx2x build fail on Fedora 34 with gcc 11 Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW

2021-04-26 Thread Dmitry Kozlyuk
2021-04-21 19:09 (UTC+0300), Tal Shnaiderman: > the strncasecmp macro defined in rte_os_shim.h is already > defined in MinGW-w64, as a result the compiler prints out > the warning below on function redefinition whenever compiling > a file including the header in debug mode. > > ..\lib/librte_eal/w

Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Monday, April 26, 2021 6:31 PM > To: Ali Alnubani ; Konstantin Ananyev > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 > > On 26/04/2021 16:24, Ali Alnubani wrote: > >> -Original

[dpdk-dev] [Bug 691] test-pmd build failure on Fedora 35 with gcc 11

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=691 Bug ID: 691 Summary: test-pmd build failure on Fedora 35 with gcc 11 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 690] tap build failures on Fedora 35 with gcc 11

2021-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=690 Bug ID: 690 Summary: tap build failures on Fedora 35 with gcc 11 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v2 1/1] usertools/devbind: add dlb

2021-04-26 Thread Timothy McDaniel
Add dlb to usertools/dpdk-devbind.py so that it shows up as an eventdev, and is identified as Intel dlb. Signed-off-by: Timothy McDaniel --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py inde

Re: [dpdk-dev] [PATCH 2/2] net/tap: fix tap interrupt vector array size

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 12:27 PM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The size of the current interrupt vector array is fixed to an integer. > > This patch will create an interrupt vector array based on the number > of rxqs. > > Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt") > Cc: st

Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Kevin Traynor
On 26/04/2021 16:24, Ali Alnubani wrote: >> -Original Message- >> From: dev On Behalf Of Konstantin Ananyev >> Sent: Monday, April 26, 2021 4:35 PM >> To: dev@dpdk.org >> Cc: Konstantin Ananyev ; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 >> > > Thanks Ko

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix log loss when state fails to be restored

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 12:27 PM, Min Hu (Connor) wrote: > From: Chengchang Tang > > After restoring the remote states, the return value of ioctl() is not > checked. Therefore, users cannot know whether the remote state is > restored successfully. > > This patch add log for restoring failure. > > Fixes: 4

Re: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Ali Alnubani
> -Original Message- > From: dev On Behalf Of Konstantin Ananyev > Sent: Monday, April 26, 2021 4:35 PM > To: dev@dpdk.org > Cc: Konstantin Ananyev ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 > Thanks Konstantin, I don't see the acl build failures with t

Re: [dpdk-dev] [PATCH] bonding: fix overflow check

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 10:22 AM, Min Hu (Connor) wrote: > Buffer 'test_params->slave_port_ids' of size 6 accessed may > overflow, since its index 'i' can have value be is out of range. > > This patch fixed it. > > Fixes: 92073ef961ee ("bond: unit tests") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Co

Re: [dpdk-dev] [PATCH] net/bonding: fix socket id check

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 8:12 AM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The socket ID entered by user is cast to an unsigned integer. However, > the value may be an illegal negative value, which may cause some > problems. In this case, an error should be returned. > +1 to fix > In addition, t

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Burakov, Anatoly
On 26-Apr-21 3:05 PM, Bruce Richardson wrote: On Mon, Apr 26, 2021 at 02:40:25PM +0100, Burakov, Anatoly wrote: On 26-Apr-21 11:54 AM, Bruce Richardson wrote: This is a script to fix up minor formatting issues in meson files. It scans for, and can optionally fix, indentation issues and missing

Re: [dpdk-dev] [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair ops

2021-04-26 Thread Ankur Dwivedi
>-Original Message- >From: Shijith Thotton >Sent: Monday, April 26, 2021 5:51 PM >To: dev@dpdk.org >Cc: Shijith Thotton ; Jerin Jacob Kollanukkaran >; Anoob Joseph ; Ankur Dwivedi >; Pavan Nikhilesh Bhagavatula > >Subject: [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair op

Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

2021-04-26 Thread David Hunt
Hi Anatoly, On 26/4/2021 2:49 PM, Anatoly Burakov wrote: When .get_monitor_addr API was introduced, it was implemented in the i40e driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device stru

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix max queue number when configure Tx offloads

2021-04-26 Thread Ferruh Yigit
On 4/25/2021 3:08 AM, Li, Xiaoyun wrote: > >> -Original Message- >> From: Min Hu (Connor) >> Sent: Thursday, April 22, 2021 15:04 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> >> Subject: [PATCH 2/2] app/testpmd: fix max queue number when configure Tx >> offloads >> >> From:

Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

2021-04-26 Thread David Hunt
Hi Anatoly, On 26/4/2021 2:49 PM, Anatoly Burakov wrote: When .get_monitor_addr API was introduced, it was implemented in the ixgbe driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device str

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Bruce Richardson
On Mon, Apr 26, 2021 at 02:40:25PM +0100, Burakov, Anatoly wrote: > On 26-Apr-21 11:54 AM, Bruce Richardson wrote: > > This is a script to fix up minor formatting issues in meson files. > > It scans for, and can optionally fix, indentation issues and missing > > trailing commas in the lists in meso

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax

2021-04-26 Thread Thomas Monjalon
Lun 26 avr 2021, à 11:48, Ferruh Yigit a écrit : > Hi Thomas, David, Akhil, Jerin, Maxime, Qi, Raslan, Ajit, > > For the doc patches, the subsystem prefix 'doc:' is too wide, what do you > think > to extend it to include the component, like for this patch: > "doc/nics/nfp: fix multiport syntax"

[dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

2021-04-26 Thread Anatoly Burakov
When .get_monitor_addr API was introduced, it was implemented in the ixgbe driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device structure. Fixes: 3982b7967bb7 ("net/ixgbe: implement power ma

[dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

2021-04-26 Thread Anatoly Burakov
When .get_monitor_addr API was introduced, it was implemented in the i40e driver, but only for the physical function; the virtual function portion of the driver does not support that API. Add the missing function pointer to VF device structure. The i40e driver is not meant to use the VF portion a

[dpdk-dev] [PATCH v2] net/hns3: fix parse link fails code fail

2021-04-26 Thread Min Hu (Connor)
From: Chengwen Feng The link fails code should be parsed using the structure hns3_mbx_vf_to_pf_cmd, else it will parse fail. Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- v2: * kept o

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-04-26 Thread Burakov, Anatoly
On 26-Apr-21 11:54 AM, Bruce Richardson wrote: This is a script to fix up minor formatting issues in meson files. It scans for, and can optionally fix, indentation issues and missing trailing commas in the lists in meson.build files. It also detects, and can fix, multi-line lists where more than

Re: [dpdk-dev] [PATCH 0/3] bugfix for kni

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > This patchset contains three bugfixes for kni. > > Min Hu (Connor) (3): > kni: fix wrong comments > net/kni: fix rewritten return value > kni: fix unchecked return value > Except from 2/3, Series applied to dpdk-next-net/main, thanks.

[dpdk-dev] [PATCH v2] acl: fix build with gcc 11

2021-04-26 Thread Konstantin Ananyev
gcc 11 with '-O2' complains about some variables being used without being initialized: In file included from ../lib/librte_acl/acl_run_avx512x8.h:201, from ../lib/librte_acl/acl_run_avx512.c:110: In function ‘start_flow_avx512x8’, inlined from ‘search_trie_avx512x8.constprop’

Re: [dpdk-dev] [PATCH 3/3] kni: fix unchecked return value

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > Return value 'rte_kni_init' of a function is not checked. If > it fails, error handling (logging and return) should be done. > > This patch fixed it. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") > Cc: sta...@dpdk.org > > Signe

Re: [dpdk-dev] [PATCH 1/3] kni: fix wrong comments

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > This patch changed 'subsytem' to 'subsystem'. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Connor) This is not on the "kni:", which implies the kni library, but the kni unit te

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-26 Thread fengchengwen
On 2021/4/26 20:50, Ferruh Yigit wrote: > On 4/26/2021 1:41 PM, fengchengwen wrote: >> >> >> On 2021/4/26 20:26, Ferruh Yigit wrote: >>> On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: From: Chengwen Feng The link fails code should be parsed using the structure hns3_mbx_vf_to_p

Re: [dpdk-dev] [PATCH 2/3] net/kni: fix rewritten return value

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > Return value of function 'eth_kni_dev_stop' passed to 'ret' is > rewritten later, and this is unreasonable. > > This patch fixes it. > > Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") > Cc: sta...@dpdk.org > > Signed-of

Re: [dpdk-dev] [PATCH] net/bonding: fix kvlist memory leakage

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 3:05 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > If the bond device was created by vdev mode, the kvlist was not free > when the bond device removed. > > Fixes: 8d30fe7fa737 ("bonding: support port hotplug") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-

Re: [dpdk-dev] [PATCH] usertools/devbind: add dlb

2021-04-26 Thread McDaniel, Timothy
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, April 25, 2021 10:53 AM > To: McDaniel, Timothy > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Van > Haaren, Harry ; Ray Kinsella ; > Neil Horman ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; pbhagavat...@mar

Re: [dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD

2021-04-26 Thread Ferruh Yigit
On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: > This patchset contains four bugfixes for hns3 PMD. > > Chengwen Feng (4): > net/hns3: fix error mbx messages prompt errors > net/hns3: fix PF miss link status notify message > net/hns3: fix parse link fails code fail > net/hns3: delete unused

[dpdk-dev] [PATCH v2] log: register with standardized names

2021-04-26 Thread David Marchand
Let's try to enforce the convention where drivers use a pmd. logtype with their class reflected in it and libraries use a lib. logtype. Introduce two new macros: - RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is used in a component. It is associated to the default name provided b

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

2021-04-26 Thread Ferruh Yigit
On 4/26/2021 1:41 PM, fengchengwen wrote: > > > On 2021/4/26 20:26, Ferruh Yigit wrote: >> On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: >>> From: Chengwen Feng >>> >>> The link fails code should be parsed using the structure >>> hns3_mbx_vf_to_pf_cmd, else it will parse fail. >>> >>> Fixes: 109e

[dpdk-dev] [PATCH v2] net/mlx5: workaround ASO memory region creation

2021-04-26 Thread Michael Baum
Due to kernel issue in direct MKEY creation using the DevX API for physical memory, this patch replaces the ASO MR creation to use Verbs API. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- v2: The sec

[dpdk-dev] [PATCH 4/5] net/mlx5: fix flow age event triggering

2021-04-26 Thread Michael Baum
A FLOW_AGE event should be invoked when a new aged-out flow is detected by the PMD after the last user get-aged query calling. The PMD manages 2 flags for this information and check them in order to decide if an event should be invoked: MLX5_AGE_EVENT_NEW - a new aged-out flow was detected. after t

  1   2   >