Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

2021-01-19 Thread Dmitry Kozlyuk
On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > This is now the right timeframe to introduce this change > with the new Python module dependency. > Unfortunately, the ABI check is returning an issue: > > 'const char mlx5_common_pci_pmd_info[62]' was changed > to 'const char mlx5_commo

Re: [dpdk-dev] [PATCH v2 10/10] compress/mlx5: add the supported capabilities

2021-01-19 Thread Matan Azrad
Hi Akhil Thanks for the review. PSB From: Akhil Goyal > > Add all the capabilities supported by the device. > > > > Add the driver documentations. > > > > Signed-off-by: Matan Azrad > > --- > > doc/guides/compressdevs/features/mlx5.ini | 13 + > > doc/guides/compressdevs/index.rst

Re: [dpdk-dev] [PATCH v1] net/e1000: fix the invalid flow control mode setting

2021-01-19 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Wu, Wenjun1 > Sent: Wednesday, January 20, 2021 2:54 PM > To: dev@dpdk.org; Guo, Jia > Cc: Wu, Wenjun1 ; sta...@dpdk.org > Subject: [PATCH v1] net/e1000: fix the invalid flow control mode setting > > E1000_CTRL register should be updated

[dpdk-dev] [PATCH v1] net/e1000: fix the invalid flow control mode setting

2021-01-19 Thread Wenjun Wu
E1000_CTRL register should be updated according to fc_conf->mode's value. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/e1000/igb_ethdev.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/

[dpdk-dev] [PATCH v7] app/testpmd: fix testpmd packets dump overlapping

2021-01-19 Thread Jiawei Wang
When testpmd enabled the verbosity for the received packets, if two packets were received at the same time, for example, sampling packet and normal packet, the dump output of these packets may be overlapping due to multiple core handling the multiple queues simultaneously. The patch uses one strin

Re: [dpdk-dev] [PATCH v3 2/2] net/iavf: align to the new VLAN offload name

2021-01-19 Thread Xing, Beilei
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, January 20, 2021 12:18 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Fu, Qi ; Wang, Haiyue > ; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH v3 2/2] net/iavf: align to the new VLAN offload name > > Since the V

Re: [dpdk-dev] [PATCH v3 1/2] common/iavf: support VLAN filtering

2021-01-19 Thread Xing, Beilei
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, January 20, 2021 12:18 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Fu, Qi ; Wang, Haiyue > ; Creeley, Brett ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH v3 1/2] common/iavf: support VLAN filtering > > In

[dpdk-dev] [PATCH 2/2] net/dpaa2: support MPLS distribution

2021-01-19 Thread Hemant Agrawal
From: Apeksha Gupta add support for MPLS based distribution is supported. Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 45 -- drivers/net/dpaa2/dpaa2_ethdev.h | 3 +- drivers/net/dpaa2/dpaa2_rxtx.c | 4 +++ drivers/net/dpaa2/

[dpdk-dev] [PATCH 1/2] ethdev: add MPLS RSS offload type

2021-01-19 Thread Hemant Agrawal
This patch defines new RSS offload types for MPLS. The distribution will on the basis of MPLS tag. Signed-off-by: Hemant Agrawal --- app/test-pmd/cmdline.c | 4 +++- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- lib/librte_ethdev/rte_ethdev.h | 4 +++- 3 f

Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

2021-01-19 Thread Tal Shnaiderman
> Subject: RE: [PATCH v3 0/3] AVX512 vPMD on i40e > > Hi, > > > > Hi Guys, > > > > > > I tested it in my side and it works > > > > Thanks Assli, Leyi, I will proceed with the patch. > > > > > Can you please the Bugzilla bug 619? > > > > > The patch "add AVX512 vector path" also caused a build fa

Re: [dpdk-dev] [PATCH v1] net/e1000: fix the invalid flow control mode setting

2021-01-19 Thread Guo, Jia
Hi, wenjun > -Original Message- > From: Wu, Wenjun1 > Sent: Wednesday, January 20, 2021 12:59 PM > To: dev@dpdk.org; Guo, Jia > Cc: Wu, Wenjun1 ; sta...@dpdk.org > Subject: [PATCH v1] net/e1000: fix the invalid flow control mode setting > > E1000_CTRL register should be updated accordin

Re: [dpdk-dev] [PATCH v4 7/9] devarg: change representor ID to bitmap

2021-01-19 Thread Xueming(Steven) Li
>-Original Message- >From: Ajit Khaparde >Sent: Tuesday, January 19, 2021 3:02 AM >To: Xueming(Steven) Li >Cc: NBU-Contact-Thomas Monjalon ; Ferruh Yigit >; Andrew Rybchenko >; Olivier Matz ; >dpdk-dev ; Slava Ovsiienko ; Asaf >Penso >Subject: Re: [dpdk-dev] [PATCH v4 7/9] devarg: chan

Re: [dpdk-dev] [PATCH v3 0/2] iavf: update the VLAN offload message

2021-01-19 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Haiyue Wang > Sent: Wednesday, January 20, 2021 12:18 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Fu, Qi ; Wang, Haiyue > > Subject: [dpdk-dev] [PATCH v3 0/2] iavf: update the VLAN offload message > > Haiyue Wang (2): > co

[dpdk-dev] [PATCH v2] app/proc-info: fix security context info

2021-01-19 Thread Hemant Agrawal
We need to differentiate between crypto and ethernet security context as they belong to different devices. Fixes: d82d6ac64338 ("app/procinfo: add crypto security context info") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- app/proc-info/main.c | 13 + 1 file changed, 9 inse

[dpdk-dev] [PATCH v3 2/2] net/iavf: align to the new VLAN offload name

2021-01-19 Thread Haiyue Wang
Since the VLAN offload virtchnl message name has been renamed to setting style, the internal Ethernet type setting name needs be changed to avoid confusing. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_vchnl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff -

[dpdk-dev] [PATCH v3 1/2] common/iavf: support VLAN filtering

2021-01-19 Thread Haiyue Wang
In order to support enable/disable VLAN filtering the VF has to negotiate the capability via VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2. If VIRTCHNL_VLAN_TOGGLE is allowed for the VLAN fitlering capabilities, then there needs to be a method to allow this. Make the necessary changes to support this. Also, sin

[dpdk-dev] [PATCH v3 0/2] iavf: update the VLAN offload message

2021-01-19 Thread Haiyue Wang
Haiyue Wang (2): common/iavf: support VLAN filtering net/iavf: align to the new VLAN offload name drivers/common/iavf/virtchnl.h | 67 -- drivers/net/iavf/iavf_vchnl.c | 20 +- 2 files changed, 66 insertions(+), 21 deletions(-) -- 2.30.0

[dpdk-dev] [PATCH v2] common/iavf: support VLAN filtering

2021-01-19 Thread Haiyue Wang
In order to support enable/disable VLAN filtering the VF has to negotiate the capability via VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2. If VIRTCHNL_VLAN_TOGGLE is allowed for the VLAN fitlering capabilities, then there needs to be a method to allow this. Make the necessary changes to support this. Also, sin

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-19 Thread Honnappa Nagarahalli
> > 20/01/2021 02:04, Honnappa Nagarahalli: > > > On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote: > > > > 19/01/2021 15:56, Juraj Linkeš: > > > > > From: Thomas Monjalon > > > > > > 15/01/2021 14:26, Juraj Linkeš: > > > > > > > --- a/meson_options.txt > > > > > > > +++ b/meson_o

[dpdk-dev] [PATCH v2] doc: update release notes for iavf

2021-01-19 Thread Yuying Zhang
Add iavf PMD new feature in release notes. Fixes: 61abc5f611a0 ("net/iavf: support TCP/UDP flow item without input set") Signed-off-by: Yuying Zhang --- doc/guides/rel_notes/release_21_02.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/gu

[dpdk-dev] [dpdk-announce] release candidate 21.02-rc1

2021-01-19 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v21.02-rc1 There are 544 new patches in this snapshot, which is reasonnable for starting a new year. Release notes: https://doc.dpdk.org/guides/rel_notes/release_21_02.html Highlights of 21.02-rc

Re: [dpdk-dev] [PATCH v2] doc: fix testpmd sample qinq flow rules

2021-01-19 Thread Li, Xiaoyun
Acked-by: Xiaoyun Li > -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, January 19, 2021 21:01 > To: dev@dpdk.org; Li, Xiaoyun > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: [PATCH v2] doc: fix testpmd sample qinq flow rules > > In the Testpmd Flow rules management

[dpdk-dev] [PATCH v1] doc: update release notes for iavf

2021-01-19 Thread Yuying Zhang
Add iavf PMD new feature in release notes. Signed-off-by: Yuying Zhang --- doc/guides/rel_notes/release_21_02.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index 78ec2758e..ecd7cd206 100644 --- a/doc/gu

[dpdk-dev] [PATCH v1] net/iavf: rename the VLAN offload virtchnl message

2021-01-19 Thread Haiyue Wang
Rename the VLAN offload message to make the virtchnl support one more filtering offload, the name is straightforward. Signed-off-by: Haiyue Wang --- drivers/common/iavf/virtchnl.h | 67 -- drivers/net/iavf/iavf_vchnl.c | 36 +- 2 files changed, 74

Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds

2021-01-19 Thread Honnappa Nagarahalli
> > 15/01/2021 14:26, Juraj Linkeš: > > > A few options that disabled drivers in the old makefiles were > > > improperly ported to the meson build system. Fix this by adding a to > > > the list of > > > > "by adding a" what? > > This is a typo, the "a" should not be there. Would that be ok wordi

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-19 Thread Thomas Monjalon
20/01/2021 02:04, Honnappa Nagarahalli: > > On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote: > > > 19/01/2021 15:56, Juraj Linkeš: > > > > From: Thomas Monjalon > > > > > 15/01/2021 14:26, Juraj Linkeš: > > > > > > --- a/meson_options.txt > > > > > > +++ b/meson_options.txt > > > >

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-19 Thread Honnappa Nagarahalli
> > On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote: > > 19/01/2021 15:56, Juraj Linkeš: > > > From: Thomas Monjalon > > > > 15/01/2021 14:26, Juraj Linkeš: > > > > > Add Arm SoC configuration to Arm meson.build and add a meson > > > > > option to enable those options for native

Re: [dpdk-dev] [PATCH v2 01/44] bus/vdev: add helper to get vdev from eth dev

2021-01-19 Thread Thomas Monjalon
19/01/2021 22:24, Maxime Coquelin: > This patch adds an helper macro to get the rte_vdev_device > pointer from a rte_eth_dev pointer. > > This is similar to RTE_ETH_DEV_TO_PCI(). [...] > --- a/drivers/bus/vdev/rte_bus_vdev.h > +++ b/drivers/bus/vdev/rte_bus_vdev.h > @@ -34,6 +34,8 @@ struct rte_vd

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: provide suitable error for "both" libraries option

2021-01-19 Thread Thomas Monjalon
11/01/2021 17:19, Andrew Boyer: > > On Jan 11, 2021, at 8:55 AM, Bruce Richardson > > wrote: > > > > Rather than having the DPDK configuration error out when linking apps > > and examples when "both" is select for "default_library" option, we can > > detect that setting earlier in the build conf

Re: [dpdk-dev] [PATCH] build: remove compatibility build defines

2021-01-19 Thread Thomas Monjalon
09/12/2020 18:14, Bruce Richardson: > As announced in the deprecation note, remove all compatibility build > defines from previous make/meson versions and use only the standardized > ones - RTE_LIB_ for libraries, and RTE__ for drivers. > > Signed-off-by: Bruce Richardson Applied with a note in

Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen

2021-01-19 Thread Thomas Monjalon
This is now the right timeframe to introduce this change with the new Python module dependency. Unfortunately, the ABI check is returning an issue: 'const char mlx5_common_pci_pmd_info[62]' was changed to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c Few more comments below:

Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug

2021-01-19 Thread Thomas Monjalon
18/01/2021 16:41, Anatoly Burakov: > + /* now that we've validated the request, time for a PSA */ What is PSA? > + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, > + m->free_req.addr, m->free_req.len); [...] > + /* this is checked by the API, but we need to pre

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-19 Thread Thomas Monjalon
19/01/2021 22:31, Tyler Retzlaff: > On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > > > Not sure it makes sense without the new telemetry feature. > > Please focus on telemetry lib instead of half-enabling > > the old metrics lib. > > > > can you elaborate? (or reference a m

Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-19 Thread Tyler Retzlaff
On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > Not sure it makes sense without the new telemetry feature. > Please focus on telemetry lib instead of half-enabling > the old metrics lib. > can you elaborate? (or reference a mailing list discussion) that gives some guidance?

[dpdk-dev] [PATCH v2 44/44] net/virtio: handle Virtio-user setup failure properly

2021-01-19 Thread Maxime Coquelin
This patch fixes virtio_user_dev_setup() error path, by cleaning all resources it allocates. Suggested-by: Adrian Moreno Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 43/44] net/virtio: improve Vhost-user error logging

2021-01-19 Thread Maxime Coquelin
This patch improves error logging in vhost_user_read, especially printing errno when recv() fails. Suggested-by: Adrian Moreno Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_user.c | 29 - 1 file changed, 17 insertions(+), 12 deletions(-) diff --git

[dpdk-dev] [PATCH v2 42/44] net/virtio: move Vhost-vDPA data to its backend

2021-01-19 Thread Maxime Coquelin
As done earlier for Vhost-user and Vhost-kernel, this patch moves the Vhost-vDPA specific data to its backend file. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_vdpa.c | 120 +- .../net/virtio/virtio_user/virtio_user_dev.h | 4 - 2 files changed, 8

[dpdk-dev] [PATCH v2 41/44] net/virtio: move Vhost-kernel data to its backend

2021-01-19 Thread Maxime Coquelin
As done earlier for Vhost-user, this patch moves the Vhost-Kernel specific data to its backend file. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_kernel.c | 106 +++--- .../net/virtio/virtio_user/virtio_user_dev.c | 43 ++- .../net/virtio/virtio_user/

[dpdk-dev] [PATCH v2 40/44] net/virtio: move Vhost-user specifics to its backend

2021-01-19 Thread Maxime Coquelin
This patch moves all the Vhost-user backend specific logic like Vhost FD, listen FD and interrupt handling to the vhost-user backend implementation. In order to achieve that, new ops are created to update the link status, disconnect and reconnect the server, and fetch the link state interrupt FD.

[dpdk-dev] [PATCH v2 39/44] net/virtio: introduce backend data

2021-01-19 Thread Maxime Coquelin
The goal of this patch is to introduce backend-specific data in order to better isolate what is backend-specific from what is generic to Virtio-user. For now, only Vhost-user protocol features are moved to Vhost-user backend data. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_use

[dpdk-dev] [PATCH v2 38/44] net/virtio: move protocol features to Vhost-user

2021-01-19 Thread Maxime Coquelin
Since only protocol features are specific to Vhost-user backend, this patch moves all related code to Vhost-user file. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 20 + drivers/net/virtio/virtio_user/vhost_kernel.c | 9 ++ drivers/net/virtio/virtio_use

[dpdk-dev] [PATCH v2 37/44] net/virtio: make server mode blocking

2021-01-19 Thread Maxime Coquelin
This patch makes the Vhost-user backend server mode blocking at init, waiting for the client connection. The goal is to make the driver more reliable, as without waiting for client connection, the Virtio driver has to assume the Vhost-user backend will support all the features it has advertized, w

[dpdk-dev] [PATCH v2 36/44] net/virtio: move Vhost-user reqs to Vhost-user backend

2021-01-19 Thread Maxime Coquelin
Now that we have a proper isolation of the backends, we can move Vhost-user requests declaration to the Vhost-user backend file. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 25 - drivers/net/virtio/virtio_user/vhost_user.c | 25 +++

[dpdk-dev] [PATCH v2 35/44] net/virtio: improve Virtio-user errors handling

2021-01-19 Thread Maxime Coquelin
This patch adds error logs and propagates errors reported by the backend. It also adds the device path in error logs to make it easier to distinguish which device is facing the issue. Signed-off-by: Maxime Coquelin --- .../net/virtio/virtio_user/virtio_user_dev.c | 154 -- 1 fil

[dpdk-dev] [PATCH v2 34/44] net/virtio: remove useless request ops

2021-01-19 Thread Maxime Coquelin
Now that all the ops have been implemented, we can remove the send_request ops for all backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 15 +-- drivers/net/virtio/virtio_user/vhost_kernel.c | 43 drivers/net/virtio/virtio_user/vhost_user.c

[dpdk-dev] [PATCH v2 33/44] net/virtio: add Virtio-user status ops

2021-01-19 Thread Maxime Coquelin
This patch introduces new callbacks to get and set the device status. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_kernel.c | 14 ++ drivers/net/virtio/virtio_user/vhost_user.c | 121 +- drivers/

[dpdk-dev] [PATCH v2 32/44] net/virtio: add Virtio-user vring address ops

2021-01-19 Thread Maxime Coquelin
This patch introduces a new callback for setting vrings addresses. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 1 + drivers/net/virtio/virtio_user/vhost_kernel.c | 32 +-- drivers/net/virtio/virtio_user/vhost_user.c | 29 +

Re: [dpdk-dev] [PATCH v2 1/6] net/hns3: fix incorrect interception with filter director

2021-01-19 Thread Thomas Monjalon
06/01/2021 04:46, Lijun Ou: > The rte_fdir_conf structure has deprecated and users need > to use the specified rule parameters of rte_flow structure > when configure a flow rule. As a result, it is incorrectly > used in the rte_flow API. Note: it should be "flow director" in the title. I really d

[dpdk-dev] [PATCH v2 31/44] net/virtio: add Virtio-user vring file ops

2021-01-19 Thread Maxime Coquelin
This patch introduces new callbacks for setting vring files (kick and call). Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_kernel.c | 41 +++-- drivers/net/virtio/virtio_user/vhost_user.c | 46 +

[dpdk-dev] [PATCH v2 30/44] net/virtio: add Virtio-user vring setting ops

2021-01-19 Thread Maxime Coquelin
This patch introduces new callbacks for setting and getting vring state. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 3 + drivers/net/virtio/virtio_user/vhost_kernel.c | 49 +++- drivers/net/virtio/virtio_user/vhost_user.c | 113 +-

[dpdk-dev] [PATCH v2 29/44] net/virtio: add Virtio-user memory tables ops

2021-01-19 Thread Maxime Coquelin
This patch implements a dedicated callback for preparing and sending memory table to the backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 1 + drivers/net/virtio/virtio_user/vhost_kernel.c | 60 ++--- drivers/net/virtio/virtio_user/vhost_user.

[dpdk-dev] [PATCH v2 28/44] net/virtio: add Virtio-user protocol features ops

2021-01-19 Thread Maxime Coquelin
This patch introduces new callbacks for getting and setting Vhost-user protocol features. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_user.c | 64 +-- drivers/net/virtio/virtio_user/vhost_vdpa.c

[dpdk-dev] [PATCH v2 27/44] net/virtio: add Virtio-user features ops

2021-01-19 Thread Maxime Coquelin
This patch introduces new callbacks for getting and setting Virtio features, and implements them for the different backend types. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 2 + drivers/net/virtio/virtio_user/vhost_kernel.c | 150 +- .../

[dpdk-dev] [PATCH v2 26/44] net/virtio: add Virtio-user ops to set owner

2021-01-19 Thread Maxime Coquelin
This patch implements a dedicated callback for sending owner request. All the requests will be converted that way so that backends other than Vhost-user don't have to work around being it. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h| 1 + drivers/net/virtio

[dpdk-dev] [PATCH v2 25/44] net/virtio: make Vhost-user req sender consistent

2021-01-19 Thread Maxime Coquelin
This patch makes vhost_user_write() consistent with vhost_user_read(), by passing a Vhost-user message pointer instead of a buffer pointer and its length, which is now calculated in the function. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_user.c | 10 -- 1 fi

[dpdk-dev] [PATCH v2 24/44] net/virtio: remove last PCI refs in non-PCI code

2021-01-19 Thread Maxime Coquelin
This patch finalizes the bus isolation part of this refactoring. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 21 +--- drivers/net/virtio/virtio_rxtx.c | 18 - d

[dpdk-dev] [PATCH v2 23/44] net/virtio: move vring alignment to generic header

2021-01-19 Thread Maxime Coquelin
This patch moves vring alignment define to the generic Virtio header. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio.h | 3 +++ drivers/net/virtio/virtio_ethdev.c | 10 +- drivers/net/virtio/virtio_pci.

[dpdk-dev] [PATCH v2 21/44] net/virtio: move config definitions to generic header

2021-01-19 Thread Maxime Coquelin
This patch moves config and status definitions from the PCI header to the generic one. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio.c | 43 +++ drivers/net/virtio/virtio.h | 50 ++ drivers/net/vi

[dpdk-dev] [PATCH v2 22/44] net/virtio: make interrupt handling more generic

2021-01-19 Thread Maxime Coquelin
This patch aims at isolating MSIX notion into PCI layer. Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- drivers/net/virtio/virtio.c | 6 drivers/net/virtio/virtio.h | 11 +-- drivers/net/virtio/virtio_ethdev.c | 7 ++--- drivers/net/virtio

[dpdk-dev] [PATCH v2 20/44] net/virtio: move virtqueue defines in generic header

2021-01-19 Thread Maxime Coquelin
This patch moves the virtqueues defines from PCI header to the generic one. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio.h| 18 ++ drivers/net/virtio/virtio_ethdev.h | 4 +++- drivers/net/virtio/virtio_pci.

[dpdk-dev] [PATCH v2 19/44] net/virtio: move features definition to generic header

2021-01-19 Thread Maxime Coquelin
This patch moves all the Virtio definition to the generic header. It also renames some helpers to no more reference PCI. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/meson.build| 3 +- drivers/net/virtio/virtio.c | 22 drivers/net/virtio/virtio.

[dpdk-dev] [PATCH v2 18/44] net/virtio: introduce generic virtio header

2021-01-19 Thread Maxime Coquelin
This patch moves virtio_hw and virtio callbacks into a generic virtio header, now that they have been curated from PCI references. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio.h | 74 ++ drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v2 17/44] net/virtio: move legacy IO to Virtio PCI

2021-01-19 Thread Maxime Coquelin
This patch moves Virtio PCI legacy IO handling to virtio_pci.c. Two functions are created so that virtio_pci_ethdev does not have to care about it. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_pci.c| 28 +++

[dpdk-dev] [PATCH v2 16/44] net/virtio: pack virtio HW struct

2021-01-19 Thread Maxime Coquelin
This patch improves the virtio_hw struct packing, going from 88 down to 80 bytes with a 6 bytes hole in the end of the first cacheline. Fields only used in the slow path are placed in the end, so that hot path only uses the first cacheline. The patch also changes booleans fields to uint8_t type, a

[dpdk-dev] [PATCH v2 15/44] net/virtio: move PCI-specific fields to PCI device

2021-01-19 Thread Maxime Coquelin
This patch moves the fields from virtio_hw structure that are PCI-specific to virtio_pci_dev_struct. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_pci.c | 139 ++-- drivers/net/virtio/virtio_pci.h |

[dpdk-dev] [PATCH v2 14/44] net/virtio: remove bus type enum

2021-01-19 Thread Maxime Coquelin
Bus type awareness at the generic ethdev level is no more needed as previous patches have made it bus-agnostic. This patch removes it from struct virtio_hw. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 18

[dpdk-dev] [PATCH v2 13/44] net/virtio: validate features at bus level

2021-01-19 Thread Maxime Coquelin
This patch provides a new callback for the bus type to validate negotiated features are compatible with it. Only user for now is PCI modern bus type, which implies that the device supports Virtio 1.0+. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.

[dpdk-dev] [PATCH v2 12/44] net/virtio: add callback for device closing

2021-01-19 Thread Maxime Coquelin
This patch introduces a new callback for device closing, making virtio_dev_close() bus-agnostic. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/meson.build | 2 -- drivers/net/virtio/virtio_ethdev.c | 13 + d

[dpdk-dev] [PATCH v2 11/44] net/virtio: store PCI type in Virtio device metadata

2021-01-19 Thread Maxime Coquelin
Going further in making the Virtio ethdev layer bus agnostic, this patch adds a boolean in the Virtio PCI device metadata. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_pci.c| 20 drivers/net/virtio

[dpdk-dev] [PATCH v2 10/44] net/virtio: force IOVA as VA mode for Virtio-user

2021-01-19 Thread Maxime Coquelin
At least Vhost-user backend of Virtio-user PMD requires IOVA as VA mode. Until now, it was implemented as a hack by forcing to use mbuf's buf_addr field instead of buf_iova. This patch removes all this logic and just fails probing if IOVA as VA mode is not selected. It simplifies the code overall,

[dpdk-dev] [PATCH v2 09/44] net/virtio: move MSIX detection to PCI ethdev

2021-01-19 Thread Maxime Coquelin
This patch introduces a new callback to notify the bus driver some interrupt related operation was done. This is used by Virtio PCI driver to check msix status. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 12 +-- drivers/net/virtio/virtio_pci.c| 120

[dpdk-dev] [PATCH v2 07/44] net/virtio: move PCI device init in dedicated file

2021-01-19 Thread Maxime Coquelin
This patch moves the PCI Ethernet device registration bits in a dedicated patch. In following patches, more code will be moved there, with the goal of making virtio_ethdev.c truly bus-agnostic. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/meson.build |

[dpdk-dev] [PATCH v2 08/44] net/virtio: move PCI specific dev init to PCI ethdev init

2021-01-19 Thread Maxime Coquelin
This patch moves the PCI specific initialization from eth_virtio_dev_init() to eth_virtio_pci_init(). Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 63 +-- drivers/net/virtio/virtio_pci_ethdev

[dpdk-dev] [PATCH v2 06/44] net/virtio: introduce PCI device metadata

2021-01-19 Thread Maxime Coquelin
This patch initiate refactoring of Virtio PCI, by introducing a new device structure for PCI-specific metadata. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c | 2 +- drivers/net/virtio/virtio_pci.c| 2 ++ drivers/net/virtio/virtio_pci.h| 5

[dpdk-dev] [PATCH v2 05/44] net/virtio: refactor virtio-user device

2021-01-19 Thread Maxime Coquelin
This patch moves the virtio_hw structure into the virtio_user_dev structure, with the goal of making virtio_hw bus-agnostic. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c| 2 +- drivers/net/virtio/virtio_pci.h | 1 - ..

[dpdk-dev] [PATCH v2 04/44] net/virtio: introduce Virtio bus type

2021-01-19 Thread Maxime Coquelin
This patch is preliminary work for introducing a bus layer in Virtio PMD, in order to improve Virtio-user integration. A new bus type is added to provide a unified way to distinguish which bus type is used (PCI modern, PCI legacy or Virtio-user). Signed-off-by: Maxime Coquelin Reviewed-by: Chenb

[dpdk-dev] [PATCH v2 03/44] net/virtio: fix getting old status on reconnect

2021-01-19 Thread Maxime Coquelin
This patch fixes getting reset status from the restarted vhost-user backend in case of reconnection, instead of the status at the time of the disconnection. This issue was not spotted earlier because Vhost-user protocol status feature was disabled in server mode. Fixes: 47235f16505f ("net/virtio-

[dpdk-dev] [PATCH v2 02/44] bus/vdev: add driver IOVA VA mode requirement

2021-01-19 Thread Maxime Coquelin
This patch adds driver flag in vdev bus driver so that vdev drivers can require VA IOVA mode to be used, which for example the case of Virtio-user PMD. The patch implements the .get_iommu_class() callback, that is called before devices probing to determine the IOVA mode to be used. It also adds a

[dpdk-dev] [PATCH v2 01/44] bus/vdev: add helper to get vdev from eth dev

2021-01-19 Thread Maxime Coquelin
This patch adds an helper macro to get the rte_vdev_device pointer from a rte_eth_dev pointer. This is similar to RTE_ETH_DEV_TO_PCI(). Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Reviewed-by: David Marchand --- drivers/bus/vdev/rte_bus_vdev.h | 2 ++ 1 file changed, 2 insertions(+

[dpdk-dev] [PATCH v2 00/44] net/virtio: Virtio PMD rework

2021-01-19 Thread Maxime Coquelin
Thanks Chenbo, David & Adrian for your review contribution to the V1. This V2 should implement all the changes you requested, and fix a few regressions caught while testing. This series significantly rework Virtio PMD to improve the Virtio-user PMD and its backends integration. First part of the

Re: [dpdk-dev] [PATCH v1 2/2] linux/kni: Added support for KNI multiple fifos

2021-01-19 Thread Dheemanth Mallikarjun
No, this is the only patch. Regards, Dheemanth On 1/17/21, 2:02 PM, "Thomas Monjalon" wrote: 11/12/2020 00:15, dheemanth: > In order to improve performance, the KNI is made to > support multiple fifos, So that multiple threads pinned > to multiple cores can process packets in p

Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS key

2021-01-19 Thread Ferruh Yigit
On 1/18/2021 8:59 AM, Zhang,Alvin wrote: From: Alvin Zhang Since the patch '1848b117' has set the value of key in 'struct rte_flow_action_rss' to NULL, the PMD cannot get the RSS key now. This patch sets offset and size of the key pointer as the first parameter of the token 'key' and copies th

Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions

2021-01-19 Thread Thomas Monjalon
15/01/2021 17:01, Akhil Goyal: > > This patch adds APIs to add/remove callback functions on crypto > > enqueue/dequeue burst. The callback function will be called for > > each burst of crypto ops received/sent on a given crypto device > > queue pair. > > > > Signed-off-by: Abhinandan Gujjar > > A

Re: [dpdk-dev] [PATCH v2 8/9] test/vfio_user: introduce functional test

2021-01-19 Thread David Christensen
On 1/18/21 7:27 PM, Xia, Chenbo wrote: Also, when running vfio_user_autotest_server, I'm unable to exit the application with CTRL-C directly. If a run a second test with vfio_user_autotest_client then the server test runs to completion without an error and I'm able to exit the test app normal

Re: [dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations

2021-01-19 Thread Doherty, Declan
On 19/01/2021 5:00 PM, Akhil Goyal wrote: Hi Tejasree, Subject: [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations Adding support for SSL/TLS way of cipher-auth operations order - auth generation followed by encryption - decryption followed by auth verify Sign

Re: [dpdk-dev] [PATCH v2 10/10] compress/mlx5: add the supported capabilities

2021-01-19 Thread Akhil Goyal
> Subject: [PATCH v2 10/10] compress/mlx5: add the supported capabilities > > Add all the capabilities supported by the device. > > Add the driver documentations. > > Signed-off-by: Matan Azrad > --- > doc/guides/compressdevs/features/mlx5.ini | 13 + > doc/guides/compressdevs/index.rst

Re: [dpdk-dev] [PATCH] test/cryptodev: fix spelling in app output

2021-01-19 Thread Akhil Goyal
> Fixes some spelling errors in app logs and help text. > > Fixes: 7da018731c56 ("app/crypto-perf: add help option") > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > application") > Cc: pablo.de.lara.gua...@intel.com > Cc: slawomirx.mrozow...@intel.com > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script

2021-01-19 Thread Akhil Goyal
> 15/01/2021 16:54, Akhil Goyal: > > > On 14/01/2021 10:41 AM, Ciara Power wrote: > > > > Ciara Power (4): > > > >test/cryptodev: fix latency test csv output > > > >test/cryptodev: fix csv output format > > > >usertools: add script to graph crypto perf results > > > >maintainers: up

Re: [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script

2021-01-19 Thread Thomas Monjalon
15/01/2021 16:54, Akhil Goyal: > > On 14/01/2021 10:41 AM, Ciara Power wrote: > > > Ciara Power (4): > > >test/cryptodev: fix latency test csv output > > >test/cryptodev: fix csv output format > > >usertools: add script to graph crypto perf results > > >maintainers: update crypto pe

Re: [dpdk-dev] [PATCH v2 0/5] regex/mlx5: pmd improvements

2021-01-19 Thread Thomas Monjalon
> Ori Kam (5): > regex/mlx5: fix memory rule alignment > regex/mlx5: add support for combined rule file > regex/mlx5: fix support for group id > regex/mlx5: add support for priority match > regex/mlx5: fix num of supported queues Applied, thanks

[dpdk-dev] [PATCH] net/mlx5: fix refuse empty VLAN validation

2021-01-19 Thread Shiri Kuzin
In verbs, an empty VLAN is equivalent to a packet without VLAN layer, hence, the VLAN item should not be empty and this case is rejected. However, the case for ether type of VLAN without following VLAN item was not validated, allowing the creation of a flow with empty VLAN item. To fix this issue

Re: [dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations

2021-01-19 Thread Akhil Goyal
Hi Tejasree, > Subject: [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth > operations > > Adding support for SSL/TLS way of cipher-auth operations order > - auth generation followed by encryption > - decryption followed by auth verify > > Signed-off-by: Tejasree Kondoj > ---

[dpdk-dev] [PATCH v18 2/2] examples/l3fwd-power: enable PMD power mgmt

2021-01-19 Thread Anatoly Burakov
From: Liang Ma Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v12: - Allow selecting PMD power management scheme from command-line - Enforce 1 core 1 queue rule .../sampl

[dpdk-dev] [PATCH v18 1/2] power: add PMD power management API and callback

2021-01-19 Thread Anatoly Burakov
From: Liang Ma Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timest

[dpdk-dev] [PATCH v18 0/2] Add PMD power management

2021-01-19 Thread Anatoly Burakov
This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive. There are multiple proposed mechanisms to achieve said power savings: simple frequency scaling, idle loop, and monitoring the Rx queue for incoming pac

Re: [dpdk-dev] [PATCH v2] maintainers: update for testpmd

2021-01-19 Thread Thomas Monjalon
18/01/2021 08:16, Li, Xiaoyun: > From: Thomas Monjalon > > 07/12/2020 21:59, Thomas Monjalon: > > > 02/12/2020 07:33, beilei.x...@intel.com: > > > > From: Beilei Xing > > > > > > > > Replace Beilei Xing with Xiaoyun Li. > > > > > > > > Signed-off-by: Beilei Xing > > > > --- > > > > Driver testi

Re: [dpdk-dev] [PATCH v4 1/3] build: add aarch64 clang to meson cross-compile

2021-01-19 Thread Thomas Monjalon
19/01/2021 09:33, Juraj Linkeš: > Create meson cross-file arm64_armv8_linux_clang_ubuntu1804. Why is it specific to Ubuntu 18.04? I don't want to add specifc cross files per distributions. > Use clang/LLVM toolchain with sysroot pointing to gcc cross stdlib. > > The sysroot path must be in the c

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-19 Thread Bruce Richardson
On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote: > 19/01/2021 15:56, Juraj Linkeš: > > From: Thomas Monjalon > > > 15/01/2021 14:26, Juraj Linkeš: > > > > Add Arm SoC configuration to Arm meson.build and add a meson option to > > > > enable those options for native builds. This is

Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds

2021-01-19 Thread Liron Himi
-Original Message- From: Juraj Linkeš Sent: Tuesday, 19 January 2021 17:36 To: Thomas Monjalon Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; hemant.agra...@nxp

Re: [dpdk-dev] [PATCH v15 00/12] Arm build options rework

2021-01-19 Thread Thomas Monjalon
19/01/2021 16:10, Juraj Linkeš: > From: Thomas Monjalon > > I consider these patches (9, 11, 12) need more review or rework: > > > > > build: disable drivers in Arm builds > > > build: add Arm SoC meson option > > > config: fix Arm implementer and its SoCs > > > > I've decided to partially

  1   2   >