11/01/2021 17:19, Andrew Boyer:
> > On Jan 11, 2021, at 8:55 AM, Bruce Richardson <bruce.richard...@intel.com>
> > wrote:
> >
> > Rather than having the DPDK configuration error out when linking apps
> > and examples when "both" is select for "default_library" option, we can
> > detect that setting earlier in the build config and provide a suitable
> > error message to the user.
> >
> > CC: sta...@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> > ---
> > +if get_option('default_library') == 'both'
> > + error( '''
> > + Unsupported value "both" for "default_library" option.
> > +
> > + NOTE: DPDK always builds both shared and static libraries. Please set
> > + "default_library" to either "static" or "shared" to select default
> > linkage
> > + for apps and any examples''')
>
> Should there be a period after ‘examples’?
>
> Reviewed-by: Andrew Boyer <abo...@pensando.io>
Applied with above fixup, thanks
